RecentBlogPostsBlock::canCreate() - Code Metrics - Inspection of "Test Clean Up" - dynamic/dynamic-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#34)

by Jason

created 2017-02-05 15:49 UTC

RecentBlogPostsBlock::canCreate() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.0625

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	3
cts	4
cp	0.75
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	1
crap	2.0625

<?php

if (class_exists('Blog')) {

    /**
     * Class RecentBlogPostsBlock
     */
    class RecentBlogPostsBlock extends Block
    {
        /**
         * @var string
         */
        private static $singular_name = 'Recent Blog Posts Block';

        /**
         * @var string
         */
        private static $plural_name = 'Recent Blog Posts Blocks';

        /**
         * @var array
         */
        private static $db = array(
            'Limit' => 'Int',
        );

        /**
         * @var array
         */
        private static $has_one = array(
            'Blog' => 'Blog',
        );

        /**
         * @var array
         */
        private static $defaults = array(
            'Limit' => 3,
        );

        /**
         * @return FieldList
         */
        public function getCMSFields()

        {
            $fields = singleton('Block')->getCMSFields();

            $fields->addFieldsToTab('Root.Main', array(
                NumericField::create('Limit'),
            ));

            if (class_exists('Blog')) {
                $fields->addFieldToTab(
                    'Root.Main',
                    DropdownField::create('BlogID', 'Featured Blog', Blog::get()->map())
                        ->setEmptyString('')
                );
            }

            return $fields;
        }
    }

}



1			<?php
2
3	1		if (class_exists('Blog')) {
4
5			/**
6			* Class RecentBlogPostsBlock
7			*/
8			class RecentBlogPostsBlock extends Block
9			{
10			/**
11			* @var string
12			*/
13			private static $singular_name = 'Recent Blog Posts Block';
14
15			/**
16			* @var string
17			*/
18			private static $plural_name = 'Recent Blog Posts Blocks';
19
20			/**
21			* @var array
22			*/
23			private static $db = array(
24			'Limit' => 'Int',
25			);
26
27			/**
28			* @var array
29			*/
30			private static $has_one = array(
31			'Blog' => 'Blog',
32			);
33
34			/**
35			* @var array
36			*/
37			private static $defaults = array(
38			'Limit' => 3,
39			);
40
41			/**
42			* @return FieldList
43			*/
44		View Code Duplication	public function getCMSFields()
			0 ignored issues – show Duplication introduced 2016-10-11 20:37 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45			{
46			$fields = singleton('Block')->getCMSFields();
47
48			$fields->addFieldsToTab('Root.Main', array(
49			NumericField::create('Limit'),
50			));
51
52			if (class_exists('Blog')) {
53			$fields->addFieldToTab(
54			'Root.Main',
55			DropdownField::create('BlogID', 'Featured Blog', Blog::get()->map())
56			->setEmptyString('')
57			);
58			}
59
60			return $fields;
61			}
62			}
63
64			}
65
66

dynamic / dynamic-blocks

Pull Request — master (#34)

RecentBlogPostsBlock::canCreate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like