CallToActionBlock::getCMSFields() - Code Metrics - Inspection of "Test Clean Up" - dynamic/dynamic-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#34)

by Jason

created 2017-02-05 15:49 UTC

CallToActionBlock::getCMSFields() A

↳ Parent: CallToActionBlock

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1.2963

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	4
cts	12
cp	0.3333
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	9
nc	1
nop	0
crap	1.2963

<?php

class CallToActionBlock extends Block
{
    /**
     * @return string
     */
    public function singular_name()
    {
        return _t('CallToActionBlock.SINGULARNAME', 'Call To Action Block');
    }

    /**
     * @return string
     */
    public function plural_name()
    {
        return _t('CallToActionBlock.PLURALNAME', 'Call To Action Blocks');
    }

    /**
     * @var array
     */
    private static $has_one = [
        'BlockLink' => 'Link',
    ];

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $this->beforeUpdateCMSFields(function ($fields) {
            $fields->addFieldToTab(
                'Root.Main',
                LinkField::create('BlockLinkID', 'Link')
            );
        });

        $fields = parent::getCMSFields();

        $fields->removeByName([
            'Title',
        ]);

        return $fields;
    }

    public function getTitle()
    {
        if ($this->BlockLink()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return $this->BlockLink()->Title;
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }
    }
}

1		<?php
2
3		class CallToActionBlock extends Block
4		{
5		/**
6		* @return string
7		*/
8	8	public function singular_name()
9		{
10	8	return _t('CallToActionBlock.SINGULARNAME', 'Call To Action Block');
11		}
12
13		/**
14		* @return string
15		*/
16		public function plural_name()
17		{
18		return _t('CallToActionBlock.PLURALNAME', 'Call To Action Blocks');
19		}
20
21		/**
22		* @var array
23		*/
24		private static $has_one = [
25		'BlockLink' => 'Link',
26		];
27
28		/**
29		* @return FieldList
30		*/
31	1	public function getCMSFields()
32		{
33	1	$this->beforeUpdateCMSFields(function ($fields) {
34		$fields->addFieldToTab(
35		'Root.Main',
36		LinkField::create('BlockLinkID', 'Link')
37		);
38	1	});
39
40	1	$fields = parent::getCMSFields();
41
42		$fields->removeByName([
43		'Title',
44		]);
45
46		return $fields;
47		}
48
49	1	public function getTitle()
50		{
51	1	if ($this->BlockLink()) {
		0 ignored issues – show Documentation Bug introduced 2017-02-04 20:47 UTC by Report Bug Copy Issue Report The method `BlockLink` does not exist on `object<CallToActionBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
52	1	return $this->BlockLink()->Title;
		0 ignored issues – show Documentation Bug introduced 2017-02-04 20:47 UTC by Report Bug Copy Issue Report The method `BlockLink` does not exist on `object<CallToActionBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
53		}
54		}
55		}

dynamic / dynamic-blocks

Pull Request — master (#34)

CallToActionBlock::getCMSFields() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like