AccordionBlock - Code Metrics - Inspection of "Test Clean Up" - dynamic/dynamic-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#34)

by Jason

created 2017-02-05 15:49 UTC

AccordionBlock A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

25.92%

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	6
dl	0
loc	73
ccs	7
cts	27
cp	0.2592
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	plural_name()	4	1
A	singular_name()	4	1
A	getPanelList()	7	2
B	getCMSFields()	25	3

<?php

class AccordionBlock extends Block
{
    /**
     * @return string
     */
    public function singular_name()
    {
        return _t('AccordionBlock.SINGULARNAME', 'Accordion Block');
    }

    /**
     * @return string
     */
    public function plural_name()
    {
        return _t('AccordionBlock.PLURALNAME', 'Accordion Blocks');
    }

    /**
     * @var array
     */
    private static $db = array(
        'Content' => 'HTMLText',
        'SortOrder' => 'Int',
    );

    /**
     * @var array
     */
    private static $has_many = array(
        'Panels' => 'AccordionPanel',
    );

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $fields->removeByName(array(
            'SortOrder',
            'Panels',
        ));

        $config = GridFieldConfig_RecordEditor::create();
        if (class_exists('GridFieldOrderableRows')) {
            $config->addComponent(new GridFieldOrderableRows());
        }
        $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
        $config->removeComponentsByType('GridFieldDeleteAction');
        $config->addComponent(new GridFieldDeleteAction(false));

        if ($this->ID) {
            $fields->addFieldsToTab('Root.Panels', array(
                GridField::create('Panels', 'Accordion Panels', $this->Panels()->sort('Sort'), $config),
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            ));
        }

        return $fields;
    }

    /**
     * @return DataList
     */
    public function getPanelList()
    {
        if ($this->Panels()->exists()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return $this->Panels()->sort('Sort');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }
        return $this->Panels();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }
}

class AccordionBlock_Controller extends Block_Controller

{
    /**
     * @var string
     */
    private static $accordion_class = 'accordion-block';


    /**
     *
     */
    public function init()
    {
        $class = $this->AccordionClass();
        Requirements::javascript(THIRDPARTY_DIR . '/jquery-ui/jquery-ui.js');
        Requirements::customScript('
            $(function() {
                $( ".' . $class . '" ).accordion({
                    header: ".accord-header",
                    collapsible: true, heightStyle: "content"
                });
            });
        ');
    }

    /**
     * @return array
     */
    public function AccordionClass()
    {
        return Config::inst()->get('AccordionBlock_Controller', 'accordion_class');
    }
}

1		<?php
2
3		class AccordionBlock extends Block
4		{
5		/**
6		* @return string
7		*/
8	8	public function singular_name()
9		{
10	8	return _t('AccordionBlock.SINGULARNAME', 'Accordion Block');
11		}
12
13		/**
14		* @return string
15		*/
16		public function plural_name()
17		{
18		return _t('AccordionBlock.PLURALNAME', 'Accordion Blocks');
19		}
20
21		/**
22		* @var array
23		*/
24		private static $db = array(
25		'Content' => 'HTMLText',
26		'SortOrder' => 'Int',
27		);
28
29		/**
30		* @var array
31		*/
32		private static $has_many = array(
33		'Panels' => 'AccordionPanel',
34		);
35
36		/**
37		* @return FieldList
38		*/
39	1	public function getCMSFields()
40		{
41	1	$fields = parent::getCMSFields();
42
43		$fields->removeByName(array(
44		'SortOrder',
45		'Panels',
46		));
47
48		$config = GridFieldConfig_RecordEditor::create();
49		if (class_exists('GridFieldOrderableRows')) {
50		$config->addComponent(new GridFieldOrderableRows());
51		}
52		$config->removeComponentsByType('GridFieldAddExistingAutocompleter');
53		$config->removeComponentsByType('GridFieldDeleteAction');
54		$config->addComponent(new GridFieldDeleteAction(false));
55
56		if ($this->ID) {
57		$fields->addFieldsToTab('Root.Panels', array(
58		GridField::create('Panels', 'Accordion Panels', $this->Panels()->sort('Sort'), $config),
		0 ignored issues – show Documentation Bug introduced 2016-09-27 04:58 UTC by Report Bug Copy Issue Report The method `Panels` does not exist on `object<AccordionBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
59		));
60		}
61
62		return $fields;
63		}
64
65		/**
66		* @return DataList
67		*/
68	1	public function getPanelList()
69		{
70	1	if ($this->Panels()->exists()) {
		0 ignored issues – show Documentation Bug introduced 2017-02-05 01:47 UTC by Report Bug Copy Issue Report The method `Panels` does not exist on `object<AccordionBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
71	1	return $this->Panels()->sort('Sort');
		0 ignored issues – show Documentation Bug introduced 2017-02-05 01:47 UTC by Report Bug Copy Issue Report The method `Panels` does not exist on `object<AccordionBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
72		}
73		return $this->Panels();
		0 ignored issues – show Documentation Bug introduced 2017-02-05 01:47 UTC by Report Bug Copy Issue Report The method `Panels` does not exist on `object<AccordionBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
74		}
75		}
76
77		class AccordionBlock_Controller extends Block_Controller
		0 ignored issues – show Coding Style Compatibility introduced 2017-02-04 21:43 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
78		{
79		/**
80		* @var string
81		*/
82		private static $accordion_class = 'accordion-block';
		0 ignored issues – show Unused Code introduced 2017-02-05 02:03 UTC by Report Bug Copy Issue Report The property `$accordion_class` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
83
84		/**
85		*
86		*/
87		public function init()
88		{
89		$class = $this->AccordionClass();
90		Requirements::javascript(THIRDPARTY_DIR . '/jquery-ui/jquery-ui.js');
91		Requirements::customScript('
92		$(function() {
93		$( ".' . $class . '" ).accordion({
94		header: ".accord-header",
95		collapsible: true, heightStyle: "content"
96		});
97		});
98		');
99		}
100
101		/**
102		* @return array
103		*/
104		public function AccordionClass()
105		{
106		return Config::inst()->get('AccordionBlock_Controller', 'accordion_class');
107		}
108		}

dynamic / dynamic-blocks

Pull Request — master (#34)

AccordionBlock A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like