FormBlock::BlockForm() - Code Metrics - dynamic/dynamic-blocks - Measure and Improve Code Quality continuously with Scrutinizer

FormBlock::BlockForm() A
last analyzed 2017-05-05 21:32 UTC

↳ Parent: FormBlock

Complexity

Conditions	4
Paths	3

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	0
cts	9
cp	0
rs	9.2
c	0
b	0
f	0
cc	4
eloc	8
nc	3
nop	0
crap	20

<?php


if (!class_exists('UserDefinedForm')) {
    return;
}

class FormBlock extends Block
{
    /**
     * @var string
     */
    private static $singular_name = 'Form Block';

    /**
     * @var string
     */
    private static $plural_name = 'Form Blocks';

    /**
     * @var array
     */
    private static $db = array(
        'Content' => 'HTMLText',
    );

    /**
     * @var array
     */
    private static $has_one = array(
        'Form' => 'UserDefinedForm',
    );

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = singleton('Block')->getCMSFields();

        if (class_exists('UserDefinedForm')) {
            $fields->addFieldToTab('Root.Main', DropdownField::create(
                'FormID',
                'Form',
                UserDefinedForm::get()->map()
                )->setEmptyString('')
                ->setDescription('select an existing User Defined Form to display')
            );
        }

        $fields->addFieldToTab('Root.Main', HtmlEditorField::create('Content'));

        return $fields;
    }

    /**
     * @return Forms|HTMLText
     */
    public function BlockForm()
    {
        if ($this->Form()->exists()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $controller = new UserDefinedForm_Controller($this->Form());
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $current = Controller::curr();
            if ($current && $current->getAction() == 'finished') {
                return $controller->renderWith('ReceivedFormSubmission');
            }
            $form = $controller->Form();
            return $form;
        }
    }

    /**
     * @param null $member
     * @return bool
     */
    public function canCreate($member = null)
    {
        if (!class_exists('UserDefinedForm')) {
            return false;
        }
        return parent::canCreate();
    }

    /**
     * @param null $member
     * @return bool
     */
    public function canView($member = null)
    {
        if (!class_exists('UserDefinedForm')) {
            return false;
        }
        return parent::canView();
    }
}

1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2017-02-05 19:49 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 7 and the first side effect is on line 4. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3	1	if (!class_exists('UserDefinedForm')) {
4	1	return;
5		}
6
7		class FormBlock extends Block
8		{
9		/**
10		* @var string
11		*/
12		private static $singular_name = 'Form Block';
13
14		/**
15		* @var string
16		*/
17		private static $plural_name = 'Form Blocks';
18
19		/**
20		* @var array
21		*/
22		private static $db = array(
23		'Content' => 'HTMLText',
24		);
25
26		/**
27		* @var array
28		*/
29		private static $has_one = array(
30		'Form' => 'UserDefinedForm',
31		);
32
33		/**
34		* @return FieldList
35		*/
36	1	public function getCMSFields()
37		{
38	1	$fields = singleton('Block')->getCMSFields();
39
40	1	if (class_exists('UserDefinedForm')) {
41		$fields->addFieldToTab('Root.Main', DropdownField::create(
42		'FormID',
43		'Form',
44		UserDefinedForm::get()->map()
45		)->setEmptyString('')
46		->setDescription('select an existing User Defined Form to display')
47		);
48		}
49
50	1	$fields->addFieldToTab('Root.Main', HtmlEditorField::create('Content'));
51
52	1	return $fields;
53		}
54
55		/**
56		* @return Forms\|HTMLText
57		*/
58		public function BlockForm()
59		{
60		if ($this->Form()->exists()) {
		0 ignored issues – show Documentation Bug introduced 2016-10-11 20:37 UTC by Report Bug Copy Issue Report The method `Form` does not exist on `object<FormBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
61		$controller = new UserDefinedForm_Controller($this->Form());
		0 ignored issues – show Documentation Bug introduced 2016-10-11 20:37 UTC by Report Bug Copy Issue Report The method `Form` does not exist on `object<FormBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
62		$current = Controller::curr();
63		if ($current && $current->getAction() == 'finished') {
64		return $controller->renderWith('ReceivedFormSubmission');
65		}
66		$form = $controller->Form();
67		return $form;
68		}
69		}
70
71		/**
72		* @param null $member
73		* @return bool
74		*/
75	1	public function canCreate($member = null)
76		{
77	1	if (!class_exists('UserDefinedForm')) {
78	1	return false;
79		}
80		return parent::canCreate();
81		}
82
83		/**
84		* @param null $member
85		* @return bool
86		*/
87	1	public function canView($member = null)
88		{
89	1	if (!class_exists('UserDefinedForm')) {
90	1	return false;
91		}
92		return parent::canView();
93		}
94		}

dynamic / dynamic-blocks

FormBlock::BlockForm() A last analyzed 2017-05-05 21:32 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

FormBlock::BlockForm() A
last analyzed 2017-05-05 21:32 UTC