vote-card.ts ➔ buildVoteCard - Code Metrics - Inspection of "migrate from javascript to TypeScript" - dyaskur/google-chat-poll - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1)

by Muhammad Dyas

created 2023-08-05 22:06 UTC

vote-card.ts ➔ buildVoteCard B

↳ Parent: src/vote-card.ts

Complexity

Conditions

Size

Total Lines	61
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	35
dl	0
loc	61
c	0
b	0
f	0
rs	8.5733
cc	5

How to fix Long Method

import {choiceSection} from './helpers/vote';
import {ICON_URL_48X48} from './config/default';
import {chat_v1 as chatV1} from 'googleapis/build/src/apis/chat/v1';

/**
 * Builds the card header including the question and author details.
 *
 * @param {string} topic - Topic of the poll
 * @param {string} author - Display name of user that created the poll
 * @returns {object} card widget
 */
function cardHeader(topic, author) {
  return {
    title: topic,
    subtitle: `Posted by ${author}`,
    imageUrl: ICON_URL_48X48,
    imageType: 'CIRCLE',
  };
}

/**
 * Builds the section header if the topic is too long
 *
 * @param {string} topic - Topic of the poll
 * @param {string} author - Display name of user that created the poll
 * @returns {object} card section
 */
function sectionHeader(topic, author) {
  return {
    widgets: [
      {
        'decoratedText': {
          'text': topic,
          'wrapText': true,
          'bottomLabel': `Posted by ${author}`,
          'startIcon': {
            'altText': 'Absolute Poll',
            'iconUrl': ICON_URL_48X48,
            'imageType': 'SQUARE',
          },
        },
      },
    ],
  };
}

/**
 * Builds the configuration form.
 *
 * @param {object} poll - Current state of poll
 * @param {object} poll.author - User that submitted the poll
 * @param {string} poll.topic - Topic of poll
 * @param {string[]} poll.choices - Text of choices to display to users
 * @param {object} poll.votes - Map of cast votes keyed by choice index
 * @param {object} poll.choiceCreator - Map of cast votes keyed by choice index
 * @param {boolean} poll.anon - Is anonymous?(will save voter name or not)
 * @param {boolean} poll.optionable - Can other user add other option?
 * @returns {object} card
 */
export function buildVoteCard(poll) {
  const sections = [];
  const state = JSON.stringify(poll);

  const votes: Array<Array<object>> = Object.values(poll.votes);
  const totalVotes: number = votes.reduce((sum, vote) => sum + vote.length, 0);
  for (let i = 0; i < poll.choices.length; ++i) {
    const creator = poll.choiceCreator?.[i];
    const section = choiceSection(i, poll, totalVotes, state, creator);
    sections.push(section);
  }
  if (poll.optionable) {
    sections.push(
        {
          'widgets': [
            {
              'buttonList': {
                'buttons': [
                  {
                    'text': 'Add Option',
                    'onClick': {
                      'action': {
                        'function': 'add_option_form',
                        'interaction': 'OPEN_DIALOG',
                        'parameters': [],
                      },
                    },
                  },
                ],
              },
            },
          ],
        });
  }
  const card: chatV1.Schema$CardWithId = {
    'cardId': 'unique-card-id',
    'card': {
      sections,
    },
  };
  if (poll.topic.length > 40) {
    const widgetHeader = sectionHeader(poll.topic, poll.author.displayName);
    card.card.sections = [widgetHeader, ...sections];
  } else {
    card.card.header = cardHeader(poll.topic, poll.author.displayName);
  }
  return card;
}


1			import {choiceSection} from './helpers/vote';
2			import {ICON_URL_48X48} from './config/default';
3			import {chat_v1 as chatV1} from 'googleapis/build/src/apis/chat/v1';
4
5			/**
6			* Builds the card header including the question and author details.
7			*
8			* @param {string} topic - Topic of the poll
9			* @param {string} author - Display name of user that created the poll
10			* @returns {object} card widget
11			*/
12			function cardHeader(topic, author) {
13			return {
14			title: topic,
15			subtitle: `Posted by ${author}`,
16			imageUrl: ICON_URL_48X48,
17			imageType: 'CIRCLE',
18			};
19			}
20
21			/**
22			* Builds the section header if the topic is too long
23			*
24			* @param {string} topic - Topic of the poll
25			* @param {string} author - Display name of user that created the poll
26			* @returns {object} card section
27			*/
28			function sectionHeader(topic, author) {
29			return {
30			widgets: [
31			{
32			'decoratedText': {
33			'text': topic,
34			'wrapText': true,
35			'bottomLabel': `Posted by ${author}`,
36			'startIcon': {
37			'altText': 'Absolute Poll',
38			'iconUrl': ICON_URL_48X48,
39			'imageType': 'SQUARE',
40			},
41			},
42			},
43			],
44			};
45			}
46
47			/**
48			* Builds the configuration form.
49			*
50			* @param {object} poll - Current state of poll
51			* @param {object} poll.author - User that submitted the poll
52			* @param {string} poll.topic - Topic of poll
53			* @param {string[]} poll.choices - Text of choices to display to users
54			* @param {object} poll.votes - Map of cast votes keyed by choice index
55			* @param {object} poll.choiceCreator - Map of cast votes keyed by choice index
56			* @param {boolean} poll.anon - Is anonymous?(will save voter name or not)
57			* @param {boolean} poll.optionable - Can other user add other option?
58			* @returns {object} card
59			*/
60			export function buildVoteCard(poll) {
61			const sections = [];
62			const state = JSON.stringify(poll);
63
64			const votes: Array<Array<object>> = Object.values(poll.votes);
65			const totalVotes: number = votes.reduce((sum, vote) => sum + vote.length, 0);
66			for (let i = 0; i < poll.choices.length; ++i) {
67			const creator = poll.choiceCreator?.[i];
68			const section = choiceSection(i, poll, totalVotes, state, creator);
69			sections.push(section);
70			}
71			if (poll.optionable) {
72			sections.push(
73			{
74			'widgets': [
75			{
76			'buttonList': {
77			'buttons': [
78			{
79			'text': 'Add Option',
80			'onClick': {
81			'action': {
82			'function': 'add_option_form',
83			'interaction': 'OPEN_DIALOG',
84			'parameters': [],
85			},
86			},
87			},
88			],
89			},
90			},
91			],
92			});
93			}
94			const card: chatV1.Schema$CardWithId = {
95			'cardId': 'unique-card-id',
96			'card': {
97			sections,
98			},
99			};
100			if (poll.topic.length > 40) {
101			const widgetHeader = sectionHeader(poll.topic, poll.author.displayName);
102			card.card.sections = [widgetHeader, ...sections];
103			} else {
104			card.card.header = cardHeader(poll.topic, poll.author.displayName);
105			}
106			return card;
107			}
108

dyaskur / google-chat-poll

Pull Request — master (#1)

vote-card.ts ➔ buildVoteCard B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like