config-form.ts ➔ buildConfigurationForm - Code Metrics - Inspection of "migrate from javascript to TypeScript" - dyaskur/google-chat-poll - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1)

by Muhammad Dyas

created 2023-08-05 22:06 UTC

config-form.ts ➔ buildConfigurationForm B

↳ Parent: src/config-form.ts

Complexity

Conditions

Size

Total Lines	58
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	38
dl	0
loc	58
c	0
b	0
f	0
rs	8.968
cc	4

How to fix Long Method

import {splitMessage} from './helpers/utils';
import {MAX_NUM_OF_OPTIONS} from './config/default';

/** Upper bounds on number of choices to present. */

/**
 * Build widget with instructions on how to use form.
 *
 * @returns {object} card widget
 */
function helpText() {
  return {
    textParagraph: {
      text: 'Enter the poll topic and up to 10 choices in the poll. Blank options will be omitted.',
    },
  };
}

/**
 * Build the text input for a choice.
 *
 * @param {number} index - Index to identify the choice
 * @param {string|undefined} value - Initial value to render (optional)
 * @returns {object} card widget
 */
function optionInput(index, value) {
  return {
    textInput: {
      label: `Option ${index + 1}`,
      type: 'SINGLE_LINE',
      name: `option${index}`,
      value: value || '',
    },
  };
}

/**
 * Build the text input for the poll topic.
 *
 * @param {string|undefined} topic - Initial value to render (optional)
 * @returns {object} card widget
 */
function topicInput(topic) {
  return {
    textInput: {
      label: 'Topic',
      type: 'MULTIPLE_LINE',
      name: 'topic',
      value: topic || '',
    },
  };
}

/**
 * Build the buttons/actions for the form.
 *
 * @returns {object} card widget
 */
function fixedFooter() {
  return {
    'primaryButton': {
      'text': 'Submit',
      'onClick': {
        'action': {
          'function': 'start_poll',
        },
      },
    },
  };
}

/**
 * Build the configuration form.
 *
 * @param {object} options - Initial state to render with form
 * @param {string|undefined} options.topic - Topic of poll (optional)
 * @param {string[]|undefined} options.choices - Text of choices to display to users (optional)
 * @returns {object} card
 */
export function buildConfigurationForm(options) {
  const widgets = [];
  widgets.push(helpText());
  widgets.push(topicInput(options.topic));
  for (let i = 0; i < MAX_NUM_OF_OPTIONS; ++i) {
    const choice = options?.choices?.[i];
    widgets.push(optionInput(i, choice));
  }

  // Assemble the card
  return {
    'sections': [
      {
        'collapsible': true,
        'uncollapsibleWidgetsCount': 6,
        widgets,
      },
      {
        'widgets': [
          {
            'decoratedText': {
              'bottomLabel': 'If this checked the voters name will be not shown',
              'text': 'Anonymous voter',
              'switchControl': {
                'controlType': 'SWITCH',
                'name': 'is_anonymous',
                'value': '1',
                'selected': false,
              },
            },
            'horizontalAlignment': 'CENTER',
          },
          {
            'decoratedText': {
              'bottomLabel': 'After the poll is created, other member can add more option',
              'text': 'Allow to add more option(s)',
              'switchControl': {
                'controlType': 'SWITCH',
                'name': 'allow_add_option',
                'value': '1',
                'selected': true,
              },
            },
            'horizontalAlignment': 'CENTER',
          },
        ],
      },
    ],
    'fixedFooter': fixedFooter(),
  };
}

/**
 * Build poll options from message sent by user.
 *
 * @param {string} message - message or text after poll command
 * @returns {object} option
 */
export function buildOptionsFromMessage(message) {
  const explodedMesage = splitMessage(message);
  const topic = explodedMesage[0] !== 'undefined' && explodedMesage[0] ? explodedMesage[0] : '';
  if (explodedMesage.length > 0) {
    explodedMesage.shift();
  }
  return {
    topic,
    choices: explodedMesage,
  };
}


1			import {splitMessage} from './helpers/utils';
2			import {MAX_NUM_OF_OPTIONS} from './config/default';
3
4			/** Upper bounds on number of choices to present. */
5
6			/**
7			* Build widget with instructions on how to use form.
8			*
9			* @returns {object} card widget
10			*/
11			function helpText() {
12			return {
13			textParagraph: {
14			text: 'Enter the poll topic and up to 10 choices in the poll. Blank options will be omitted.',
15			},
16			};
17			}
18
19			/**
20			* Build the text input for a choice.
21			*
22			* @param {number} index - Index to identify the choice
23			* @param {string\|undefined} value - Initial value to render (optional)
24			* @returns {object} card widget
25			*/
26			function optionInput(index, value) {
27			return {
28			textInput: {
29			label: `Option ${index + 1}`,
30			type: 'SINGLE_LINE',
31			name: `option${index}`,
32			value: value \|\| '',
33			},
34			};
35			}
36
37			/**
38			* Build the text input for the poll topic.
39			*
40			* @param {string\|undefined} topic - Initial value to render (optional)
41			* @returns {object} card widget
42			*/
43			function topicInput(topic) {
44			return {
45			textInput: {
46			label: 'Topic',
47			type: 'MULTIPLE_LINE',
48			name: 'topic',
49			value: topic \|\| '',
50			},
51			};
52			}
53
54			/**
55			* Build the buttons/actions for the form.
56			*
57			* @returns {object} card widget
58			*/
59			function fixedFooter() {
60			return {
61			'primaryButton': {
62			'text': 'Submit',
63			'onClick': {
64			'action': {
65			'function': 'start_poll',
66			},
67			},
68			},
69			};
70			}
71
72			/**
73			* Build the configuration form.
74			*
75			* @param {object} options - Initial state to render with form
76			* @param {string\|undefined} options.topic - Topic of poll (optional)
77			* @param {string[]\|undefined} options.choices - Text of choices to display to users (optional)
78			* @returns {object} card
79			*/
80			export function buildConfigurationForm(options) {
81			const widgets = [];
82			widgets.push(helpText());
83			widgets.push(topicInput(options.topic));
84			for (let i = 0; i < MAX_NUM_OF_OPTIONS; ++i) {
85			const choice = options?.choices?.[i];
86			widgets.push(optionInput(i, choice));
87			}
88
89			// Assemble the card
90			return {
91			'sections': [
92			{
93			'collapsible': true,
94			'uncollapsibleWidgetsCount': 6,
95			widgets,
96			},
97			{
98			'widgets': [
99			{
100			'decoratedText': {
101			'bottomLabel': 'If this checked the voters name will be not shown',
102			'text': 'Anonymous voter',
103			'switchControl': {
104			'controlType': 'SWITCH',
105			'name': 'is_anonymous',
106			'value': '1',
107			'selected': false,
108			},
109			},
110			'horizontalAlignment': 'CENTER',
111			},
112			{
113			'decoratedText': {
114			'bottomLabel': 'After the poll is created, other member can add more option',
115			'text': 'Allow to add more option(s)',
116			'switchControl': {
117			'controlType': 'SWITCH',
118			'name': 'allow_add_option',
119			'value': '1',
120			'selected': true,
121			},
122			},
123			'horizontalAlignment': 'CENTER',
124			},
125			],
126			},
127			],
128			'fixedFooter': fixedFooter(),
129			};
130			}
131
132			/**
133			* Build poll options from message sent by user.
134			*
135			* @param {string} message - message or text after poll command
136			* @returns {object} option
137			*/
138			export function buildOptionsFromMessage(message) {
139			const explodedMesage = splitMessage(message);
140			const topic = explodedMesage[0] !== 'undefined' && explodedMesage[0] ? explodedMesage[0] : '';
141			if (explodedMesage.length > 0) {
142			explodedMesage.shift();
143			}
144			return {
145			topic,
146			choices: explodedMesage,
147			};
148			}
149

dyaskur / google-chat-poll

Pull Request — master (#1)

config-form.ts ➔ buildConfigurationForm B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like