Application::setCatcher() - Code Metrics - Inspection of "添加：多Logger支持" - dxkite/suda - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — dev ( e79643...3785bc )

by 世昌

created 2020-02-29 08:45 UTC

Application::setCatcher() A

↳ Parent: Application

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace suda\application;

use Exception;
use Throwable;
use suda\framework\Request;
use suda\framework\Response;
use suda\framework\http\Status;
use suda\framework\loader\Loader;
use suda\framework\route\MatchResult;
use suda\application\template\Template;
use suda\application\debug\RequestDumper;
use suda\application\loader\ModuleLoader;
use suda\database\exception\SQLException;
use suda\application\template\RawTemplate;
use suda\application\debug\ExceptionCatcher;
use suda\application\wrapper\TemplateWrapper;
use suda\application\loader\ApplicationLoader;
use suda\application\processor\FileRequestProcessor;
use suda\framework\http\Request as RequestInterface;
use suda\application\wrapper\ExceptionContentWrapper;
use suda\application\exception\ConfigurationException;
use suda\framework\http\Response as ResponseInterface;
use suda\application\processor\TemplateAssetProcessor;
use suda\application\processor\TemplateRequestProcessor;
use suda\application\processor\RunnableRequestProcessor;

/**
 * 应用程序
 */
class Application extends ApplicationRoute
{
    /**
     * @var RequestDumper
     */
    protected $catcher;

    /**
     * 准备运行环境
     *
     * @return void
     * @throws SQLException
     */
    public function load()
    {
        $this->debug->info('===============================');
        parent::load();
        $appLoader = new ApplicationLoader($this);
        $this->debug->time('loading route');
        $appLoader->loadRoute();
        $this->event->exec('application:load-route', [$this->route, $this]);
        $route = $this->debug->timeEnd('loading route');
        $this->debug->recordTiming('route', $route);
        $this->debug->info('-------------------------------');
    }

    /**
     * 准备环境
     *
     * @param Request $request
     * @param Response $response
     * @throws SQLException
     */
    protected function prepare(Request $request, Response $response)
    {
        $response->setHeader('x-powered-by', 'suda/' . SUDA_VERSION, true);
        $response->getWrapper()->register(ExceptionContentWrapper::class, [Throwable::class]);
        $response->getWrapper()->register(TemplateWrapper::class, [RawTemplate::class]);
        $this->setCatcher(new RequestDumper($this, $request, $response));

        $this->debug->info('{request-time} {remote-ip} {request-method} {request-uri} debug={debug}', [
            'remote-ip' => $request->getRemoteAddr(),
            'debug' => SUDA_DEBUG,
            'request-uri' => $request->getUrl(),
            'request-method' => $request->getMethod(),
            'request-time' => date('Y-m-d H:i:s', constant('SUDA_START_TIME')),
        ]);

        $this->load();
    }

    /**
     * @param ExceptionCatcher $catcher
     */
    public function setCatcher(ExceptionCatcher $catcher) {
        ExceptionCatcher::restore();
        $this->catcher = $catcher;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->catcher->register();
    }

    /**
     * @param Throwable $throwable
     */
    public function dumpException($throwable)
    {
        $this->catcher->dumpThrowable($throwable);
    }

    /**
     * 运行程序
     *
     * @param RequestInterface $request
     * @param ResponseInterface $response
     */
    public function run(RequestInterface $request, ResponseInterface $response)
    {
        $appRequest = new Request($request);
        $appResponse = new Response($response, $this);

        try {
            $this->debug->time('init');
            $this->prepare($appRequest, $appResponse);
            $init = $this->debug->timeEnd('init');
            $this->debug->recordTiming('init', $init, 'init total');
            $this->debug->time('match route');
            $result = $this->route->match($appRequest->getMethod(), $appRequest->getUri());
            $match = $this->debug->timeEnd('match route');
            $this->debug->recordTiming('dispatch', $match);
            if ($result !== null) {
                $this->event->exec('application:route:match::after', [$result, $appRequest]);
            }
            $this->debug->time('sending response');
            $appResponse = $this->createResponse($result, $appRequest, $appResponse);
            if (!$appResponse->isSend()) {
                $appResponse->end();
            }
            $this->debug->info('responded with code ' . $appResponse->getStatus());
            $this->debug->timeEnd('sending response');
        } catch (Throwable $e) {
            $this->debug->uncaughtException($e);
            $this->catcher->dumpThrowable($e);
            $appResponse->sendContent($e);
            $this->debug->timeEnd('sending response');
        }
        $this->debug->info('system shutdown');
    }

    /**
     * 添加请求
     *
     * @param array $method
     * @param string $name
     * @param string $url
     * @param array $attributes
     * @return void
     */
    public function request(array $method, string $name, string $url, array $attributes = [])
    {
        $route = $attributes['config'] ?? [];
        $runnable = RunnableRequestProcessor::class . '->onRequest';
        if (array_key_exists('class', $route)) {
            $attributes['class'] = $route['class'];
        } elseif (array_key_exists('source', $route)) {
            $attributes['class'] = FileRequestProcessor::class;
            $attributes['source'] = $route['source'];
        } elseif (array_key_exists('template', $route)) {
            $attributes['class'] = TemplateRequestProcessor::class;
            $attributes['template'] = $route['template'];
        } elseif (array_key_exists('runnable', $route)) {
            $attributes['runnable'] = $route['runnable'];
        } else {
            throw new ConfigurationException('request config error', ConfigurationException::ERR_CONFIG_SET);
        }
        $this->route->request($method, $name, $url, $runnable, $attributes);
    }

    /**
     * 运行默认请求
     * @param Application $application
     * @param Request $request
     * @param Response $response
     * @return mixed
     * @throws Exception
     */
    protected function defaultResponse(Application $application, Request $request, Response $response)
    {
        (new TemplateAssetProcessor)->onRequest($application, $request, $response);
        if ($response->getStatus() === Status::HTTP_NOT_FOUND) {
            return $this->route->getDefaultRunnable()->run($request, $response);
        }
        return null;
    }

    /**
     * 运行请求
     * @param MatchResult|null $result
     * @param Request $request
     * @param Response $response
     * @return Response
     * @throws Exception
     */
    protected function createResponse(?MatchResult $result, Request $request, Response $response)
    {
        if (SUDA_DEBUG) {
            $response->setHeader('x-route', $result === null ? 'default' : $result->getName());
        }
        if ($result === null) {
            $response->status(Status::HTTP_NOT_FOUND);
            $content = $this->defaultResponse($this, $request, $response);
        } else {
            $response->status(Status::HTTP_OK);
            $content = $this->runResult($result, $request, $response);
        }
        if ($content instanceof  Response) {
            return $response;
        }
        if ($content !== null && !$response->isSend()) {
            $response->setContent($content);
        }
        return $response;
    }

    /**
     * 运行结果
     *
     * @param MatchResult $result
     * @param Request $request
     * @param Response $response
     * @return mixed
     */
    protected function runResult(MatchResult $result, Request $request, Response $response)
    {
        $request
            ->setParameter($request->getParameter())
            ->mergeQueries($result->getParameter())
            ->setAttributes($result->getMatcher()->getAttribute());
        $request->setAttribute('result', $result);
        $module = $request->getAttribute('module');
        if ($module && ($running = $this->find($module))) {
            $moduleLoader = new ModuleLoader($this, $running);
            $moduleLoader->toRunning();
        }
        return ($result->getRunnable())($this, $request, $response);
    }

    /**
     * 获取模板页面
     *
     * @param string $name
     * @param Request $request
     * @param string|null $default
     * @return Template
     */
    public function getTemplate(string $name, Request $request, ?string $default = null): Template
    {
        if ($default === null && $this->running !== null) {
            $default = $this->running->getFullName();
        } else {
            $default = $default ?? $request->getAttribute('module');
        }
        return new Template($this->getModuleSourceName($name, $default), $this, $request, $default);
    }

    /**
     * @inheritDoc
     */
    public function __clone()
    {
        $this->config = clone $this->config;
        $this->event = clone $this->event;
        $this->loader = clone $this->loader;
    }
}


1			<?php
2
3			namespace suda\application;
4
5			use Exception;
6			use Throwable;
7			use suda\framework\Request;
8			use suda\framework\Response;
9			use suda\framework\http\Status;
10			use suda\framework\loader\Loader;
11			use suda\framework\route\MatchResult;
12			use suda\application\template\Template;
13			use suda\application\debug\RequestDumper;
14			use suda\application\loader\ModuleLoader;
15			use suda\database\exception\SQLException;
16			use suda\application\template\RawTemplate;
17			use suda\application\debug\ExceptionCatcher;
18			use suda\application\wrapper\TemplateWrapper;
19			use suda\application\loader\ApplicationLoader;
20			use suda\application\processor\FileRequestProcessor;
21			use suda\framework\http\Request as RequestInterface;
22			use suda\application\wrapper\ExceptionContentWrapper;
23			use suda\application\exception\ConfigurationException;
24			use suda\framework\http\Response as ResponseInterface;
25			use suda\application\processor\TemplateAssetProcessor;
26			use suda\application\processor\TemplateRequestProcessor;
27			use suda\application\processor\RunnableRequestProcessor;
28
29			/**
30			* 应用程序
31			*/
32			class Application extends ApplicationRoute
33			{
34			/**
35			* @var RequestDumper
36			*/
37			protected $catcher;
38
39			/**
40			* 准备运行环境
41			*
42			* @return void
43			* @throws SQLException
44			*/
45			public function load()
46			{
47			$this->debug->info('===============================');
48			parent::load();
49			$appLoader = new ApplicationLoader($this);
50			$this->debug->time('loading route');
51			$appLoader->loadRoute();
52			$this->event->exec('application:load-route', [$this->route, $this]);
53			$route = $this->debug->timeEnd('loading route');
54			$this->debug->recordTiming('route', $route);
55			$this->debug->info('-------------------------------');
56			}
57
58			/**
59			* 准备环境
60			*
61			* @param Request $request
62			* @param Response $response
63			* @throws SQLException
64			*/
65			protected function prepare(Request $request, Response $response)
66			{
67			$response->setHeader('x-powered-by', 'suda/' . SUDA_VERSION, true);
68			$response->getWrapper()->register(ExceptionContentWrapper::class, [Throwable::class]);
69			$response->getWrapper()->register(TemplateWrapper::class, [RawTemplate::class]);
70			$this->setCatcher(new RequestDumper($this, $request, $response));
71
72			$this->debug->info('{request-time} {remote-ip} {request-method} {request-uri} debug={debug}', [
73			'remote-ip' => $request->getRemoteAddr(),
74			'debug' => SUDA_DEBUG,
75			'request-uri' => $request->getUrl(),
76			'request-method' => $request->getMethod(),
77			'request-time' => date('Y-m-d H:i:s', constant('SUDA_START_TIME')),
78			]);
79
80			$this->load();
81			}
82
83			/**
84			* @param ExceptionCatcher $catcher
85			*/
86			public function setCatcher(ExceptionCatcher $catcher) {
87			ExceptionCatcher::restore();
88			$this->catcher = $catcher;
			0 ignored issues – show Documentation Bug introduced 2020-02-29 08:50 UTC by Report Bug Copy Issue Report `$catcher` is of type `suda\application\debug\ExceptionCatcher`, but the property `$catcher` was declared to be of type `suda\application\debug\RequestDumper`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
89			$this->catcher->register();
90			}
91
92			/**
93			* @param Throwable $throwable
94			*/
95			public function dumpException($throwable)
96			{
97			$this->catcher->dumpThrowable($throwable);
98			}
99
100			/**
101			* 运行程序
102			*
103			* @param RequestInterface $request
104			* @param ResponseInterface $response
105			*/
106			public function run(RequestInterface $request, ResponseInterface $response)
107			{
108			$appRequest = new Request($request);
109			$appResponse = new Response($response, $this);
110
111			try {
112			$this->debug->time('init');
113			$this->prepare($appRequest, $appResponse);
114			$init = $this->debug->timeEnd('init');
115			$this->debug->recordTiming('init', $init, 'init total');
116			$this->debug->time('match route');
117			$result = $this->route->match($appRequest->getMethod(), $appRequest->getUri());
118			$match = $this->debug->timeEnd('match route');
119			$this->debug->recordTiming('dispatch', $match);
120			if ($result !== null) {
121			$this->event->exec('application:route:match::after', [$result, $appRequest]);
122			}
123			$this->debug->time('sending response');
124			$appResponse = $this->createResponse($result, $appRequest, $appResponse);
125			if (!$appResponse->isSend()) {
126			$appResponse->end();
127			}
128			$this->debug->info('responded with code ' . $appResponse->getStatus());
129			$this->debug->timeEnd('sending response');
130			} catch (Throwable $e) {
131			$this->debug->uncaughtException($e);
132			$this->catcher->dumpThrowable($e);
133			$appResponse->sendContent($e);
134			$this->debug->timeEnd('sending response');
135			}
136			$this->debug->info('system shutdown');
137			}
138
139			/**
140			* 添加请求
141			*
142			* @param array $method
143			* @param string $name
144			* @param string $url
145			* @param array $attributes
146			* @return void
147			*/
148			public function request(array $method, string $name, string $url, array $attributes = [])
149			{
150			$route = $attributes['config'] ?? [];
151			$runnable = RunnableRequestProcessor::class . '->onRequest';
152			if (array_key_exists('class', $route)) {
153			$attributes['class'] = $route['class'];
154			} elseif (array_key_exists('source', $route)) {
155			$attributes['class'] = FileRequestProcessor::class;
156			$attributes['source'] = $route['source'];
157			} elseif (array_key_exists('template', $route)) {
158			$attributes['class'] = TemplateRequestProcessor::class;
159			$attributes['template'] = $route['template'];
160			} elseif (array_key_exists('runnable', $route)) {
161			$attributes['runnable'] = $route['runnable'];
162			} else {
163			throw new ConfigurationException('request config error', ConfigurationException::ERR_CONFIG_SET);
164			}
165			$this->route->request($method, $name, $url, $runnable, $attributes);
166			}
167
168			/**
169			* 运行默认请求
170			* @param Application $application
171			* @param Request $request
172			* @param Response $response
173			* @return mixed
174			* @throws Exception
175			*/
176			protected function defaultResponse(Application $application, Request $request, Response $response)
177			{
178			(new TemplateAssetProcessor)->onRequest($application, $request, $response);
179			if ($response->getStatus() === Status::HTTP_NOT_FOUND) {
180			return $this->route->getDefaultRunnable()->run($request, $response);
181			}
182			return null;
183			}
184
185			/**
186			* 运行请求
187			* @param MatchResult\|null $result
188			* @param Request $request
189			* @param Response $response
190			* @return Response
191			* @throws Exception
192			*/
193			protected function createResponse(?MatchResult $result, Request $request, Response $response)
194			{
195			if (SUDA_DEBUG) {
196			$response->setHeader('x-route', $result === null ? 'default' : $result->getName());
197			}
198			if ($result === null) {
199			$response->status(Status::HTTP_NOT_FOUND);
200			$content = $this->defaultResponse($this, $request, $response);
201			} else {
202			$response->status(Status::HTTP_OK);
203			$content = $this->runResult($result, $request, $response);
204			}
205			if ($content instanceof Response) {
206			return $response;
207			}
208			if ($content !== null && !$response->isSend()) {
209			$response->setContent($content);
210			}
211			return $response;
212			}
213
214			/**
215			* 运行结果
216			*
217			* @param MatchResult $result
218			* @param Request $request
219			* @param Response $response
220			* @return mixed
221			*/
222			protected function runResult(MatchResult $result, Request $request, Response $response)
223			{
224			$request
225			->setParameter($request->getParameter())
226			->mergeQueries($result->getParameter())
227			->setAttributes($result->getMatcher()->getAttribute());
228			$request->setAttribute('result', $result);
229			$module = $request->getAttribute('module');
230			if ($module && ($running = $this->find($module))) {
231			$moduleLoader = new ModuleLoader($this, $running);
232			$moduleLoader->toRunning();
233			}
234			return ($result->getRunnable())($this, $request, $response);
235			}
236
237			/**
238			* 获取模板页面
239			*
240			* @param string $name
241			* @param Request $request
242			* @param string\|null $default
243			* @return Template
244			*/
245			public function getTemplate(string $name, Request $request, ?string $default = null): Template
246			{
247			if ($default === null && $this->running !== null) {
248			$default = $this->running->getFullName();
249			} else {
250			$default = $default ?? $request->getAttribute('module');
251			}
252			return new Template($this->getModuleSourceName($name, $default), $this, $request, $default);
253			}
254
255			/**
256			* @inheritDoc
257			*/
258			public function __clone()
259			{
260			$this->config = clone $this->config;
261			$this->event = clone $this->event;
262			$this->loader = clone $this->loader;
263			}
264			}
265

dxkite / suda

Push — dev ( e79643...3785bc )

Application::setCatcher() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like