RouteCollection::getIterator() - Code Metrics - Inspection of "调整：路由集合" - dxkite/suda - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bd0f24...ab8bab )

by 世昌

created 2019-01-23 05:32 UTC

RouteCollection::getIterator() A

↳ Parent: RouteCollection

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php
namespace nebula\route;

use Iterator;
use ArrayIterator;
use IteratorAggregate;

/**
 * 路由集合
 *
 */
class RouteCollection implements IteratorAggregate
{
    /**
     * 属性
     *
     * @var RouteMatcher[]
     */
    protected $collection = [];

    /**
     * 创建集合
     *
     * @param RouteMatcher[] $collection
     */
    public function __construct(array $collection=[])
    {
        $this->merge($collection);
    }

    /**
     * 合并集合
     *
     * @param array $collection
     * @return void
     */
    public function merge(array $collection=[])
    {
        $this->collection = array_merge($this->collection, $collection);
    }

    /**
     * 添加集合
     *
     * @param string $name
     * @param RouteMatcher $collection
     * @return void
     */
    public function add(string $name, RouteMatcher $collection)
    {
        $this->collection[$name] = $collection;
    }

    /**
     * 获取集合
     *
     * @param string $name
     * @return RouteMatcher|null
     */
    public function get(string $name):?RouteMatcher
    {
        return $this->collection[$name] ?? null;
    }

    /**
     * 获取迭代器
     *
     * @return RouteMatcher[]
     */
    public function getCollection():array
    {
        return $this->collection;
    }

    /**
     * 从文件创建
     *
     * @param string $path
     * @return void
     */
    public static function fromFile(string $path)
    {
        $collection = \unserialize(\file_get_contents($path));
        return new static($collection);

    }

    /**
     * 保存到文件
     *
     * @param string $path
     * @return boolean
     */
    public function save(string $path):bool
    {
        return \file_put_contents($path, \serialize($this->collection));

    }

    public function getIterator():Iterator
    {
        return new ArrayIterator($this->collection);
    }
}


1			<?php
2			namespace nebula\route;
3
4			use Iterator;
5			use ArrayIterator;
6			use IteratorAggregate;
7
8			/**
9			* 路由集合
10			*
11			*/
12			class RouteCollection implements IteratorAggregate
13			{
14			/**
15			* 属性
16			*
17			* @var RouteMatcher[]
18			*/
19			protected $collection = [];
20
21			/**
22			* 创建集合
23			*
24			* @param RouteMatcher[] $collection
25			*/
26			public function __construct(array $collection=[])
27			{
28			$this->merge($collection);
29			}
30
31			/**
32			* 合并集合
33			*
34			* @param array $collection
35			* @return void
36			*/
37			public function merge(array $collection=[])
38			{
39			$this->collection = array_merge($this->collection, $collection);
40			}
41
42			/**
43			* 添加集合
44			*
45			* @param string $name
46			* @param RouteMatcher $collection
47			* @return void
48			*/
49			public function add(string $name, RouteMatcher $collection)
50			{
51			$this->collection[$name] = $collection;
52			}
53
54			/**
55			* 获取集合
56			*
57			* @param string $name
58			* @return RouteMatcher\|null
59			*/
60			public function get(string $name):?RouteMatcher
61			{
62			return $this->collection[$name] ?? null;
63			}
64
65			/**
66			* 获取迭代器
67			*
68			* @return RouteMatcher[]
69			*/
70			public function getCollection():array
71			{
72			return $this->collection;
73			}
74
75			/**
76			* 从文件创建
77			*
78			* @param string $path
79			* @return void
80			*/
81			public static function fromFile(string $path)
82			{
83			$collection = \unserialize(\file_get_contents($path));
84			return new static($collection);
			0 ignored issues – show Bug Best Practice introduced 2019-01-23 05:34 UTC by Report Bug Copy Issue Report The expression `return new static($collection)` returns the type `nebula\route\RouteCollection` which is incompatible with the documented return type `void`. Loading history...
85			}
86
87			/**
88			* 保存到文件
89			*
90			* @param string $path
91			* @return boolean
92			*/
93			public function save(string $path):bool
94			{
95			return \file_put_contents($path, \serialize($this->collection));
			0 ignored issues – show Bug Best Practice introduced 2019-01-23 05:34 UTC by Report Bug Copy Issue Report The expression `return file_put_contents...ize($this->collection))` returns the type `integer` which is incompatible with the type-hinted return `boolean`. Loading history...
96			}
97
98			public function getIterator():Iterator
99			{
100			return new ArrayIterator($this->collection);
101			}
102			}
103

dxkite / suda

Push — master ( bd0f24...ab8bab )

RouteCollection::getIterator() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like