ZfMailer\Service\MailerFactory::createService()

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	1

Importance

Changes

0

<?php

  public function createService(ServiceLocatorInterface $serviceLocator)

  {


    $options = $serviceLocator->get('ZfMailerOptions');

    $renderer = $serviceLocator->get('ZfMailer\View\MailRenderer');

    $message = $serviceLocator->get('ZfMailer\Service\MailMessage');

    $transport = $serviceLocator->get('ZfMailer\Service\Transport');

    

    $service = new Mailer();

    $service->setOptions($options);

It seems like $options can also be of type array; however, parameter $options of ZfMailer\Service\AbstractMailer::setOptions() does only seem to accept ZfMailer\Options\ModuleOptions, maybe add an additional type check?

    $service->setRenderer($renderer);

It seems like $renderer can also be of type array; however, parameter $renderer of ZfMailer\Service\AbstractMailer::setRenderer() does only seem to accept Zend\View\Renderer\RendererInterface, maybe add an additional type check?

    $service->setMailMessage($message);

It seems like $message can also be of type array; however, parameter $mailMessage of ZfMailer\Service\AbstractMailer::setMailMessage() does only seem to accept Zend\Mail\Message, maybe add an additional type check?

    $service->setTransport($transport);

It seems like $transport can also be of type array; however, parameter $transport of ZfMailer\Service\AbstractMailer::setTransport() does only seem to accept Zend\Mail\Transport, maybe add an additional type check?

    return $service;