dvdoug /
PHPCoord
| Conditions | 35 |
| Paths | 34 |
| Total Lines | 102 |
| Code Lines | 77 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 42 |
| CRAP Score | 35 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 36 | 164 | public static function makeUnit($measurement, int $epsgUnitCode): UnitOfMeasure |
|
| 37 | { |
||
| 38 | 164 | $repository = self::$repository ?? new Repository(); |
|
| 39 | 164 | $allData = $repository->getUnitsOfMeasure(); |
|
| 40 | |||
| 41 | 164 | if (!isset($allData[$epsgUnitCode])) { |
|
| 42 | 1 | throw new UnknownUnitOfMeasureException($epsgUnitCode); |
|
| 43 | } |
||
| 44 | |||
| 45 | 163 | $unitData = $allData[$epsgUnitCode]; |
|
| 46 | |||
| 47 | /* |
||
| 48 | * Common units (and those that require special handling) having discrete implementations, |
||
| 49 | * try those first. |
||
| 50 | */ |
||
| 51 | 163 | switch ($epsgUnitCode) { |
|
| 52 | case UnitOfMeasure::EPSG_ANGLE_RADIAN_PER_SECOND: |
||
| 53 | 1 | return new Rate(new Radian($measurement), new Second(1)); |
|
|
Bug
introduced
by
|
|||
| 54 | case UnitOfMeasure::EPSG_ANGLE_ARC_SECONDS_PER_YEAR: |
||
| 55 | 1 | return new Rate(new ArcSecond($measurement), new Year(1)); |
|
| 56 | case UnitOfMeasure::EPSG_ANGLE_MILLIARC_SECONDS_PER_YEAR: |
||
| 57 | 1 | return new Rate(self::makeUnit($measurement, UnitOfMeasure::EPSG_ANGLE_MILLIARC_SECOND), new Year(1)); |
|
| 58 | case UnitOfMeasure::EPSG_LENGTH_METRE_PER_SECOND: |
||
| 59 | 1 | return new Rate(new Metre($measurement), new Second(1)); |
|
| 60 | case UnitOfMeasure::EPSG_LENGTH_METRES_PER_YEAR: |
||
| 61 | 1 | return new Rate(new Metre($measurement), new Year(1)); |
|
| 62 | case UnitOfMeasure::EPSG_LENGTH_MILLIMETRES_PER_YEAR: |
||
| 63 | 1 | return new Rate(self::makeUnit($measurement, UnitOfMeasure::EPSG_LENGTH_MILLIMETRE), new Year(1)); |
|
| 64 | case UnitOfMeasure::EPSG_LENGTH_CENTIMETRES_PER_YEAR: |
||
| 65 | 1 | return new Rate(self::makeUnit($measurement, UnitOfMeasure::EPSG_LENGTH_CENTIMETRE), new Year(1)); |
|
| 66 | case UnitOfMeasure::EPSG_SCALE_UNITY_PER_SECOND: |
||
| 67 | 1 | return new Rate(new Unity($measurement), new Second(1)); |
|
| 68 | case UnitOfMeasure::EPSG_SCALE_PARTS_PER_BILLION_PER_YEAR: |
||
| 69 | 1 | return new Rate(self::makeUnit($measurement, UnitOfMeasure::EPSG_SCALE_PARTS_PER_BILLION), new Year(1)); |
|
| 70 | case UnitOfMeasure::EPSG_SCALE_PARTS_PER_MILLION_PER_YEAR: |
||
| 71 | 1 | return new Rate(self::makeUnit($measurement, UnitOfMeasure::EPSG_SCALE_PARTS_PER_MILLION), new Year(1)); |
|
| 72 | case UnitOfMeasure::EPSG_ANGLE_RADIAN: |
||
| 73 | 1 | return new Radian($measurement); |
|
| 74 | case UnitOfMeasure::EPSG_ANGLE_DEGREE: |
||
| 75 | 50 | return new Degree($measurement); |
|
| 76 | case UnitOfMeasure::EPSG_ANGLE_ARC_SECOND: |
||
| 77 | 1 | return new ArcSecond($measurement); |
|
| 78 | case UnitOfMeasure::EPSG_ANGLE_DEGREE_MINUTE_SECOND: |
||
| 79 | 1 | return Degree::fromDegreeMinuteSecond((string) $measurement); |
|
| 80 | case UnitOfMeasure::EPSG_ANGLE_DEGREE_MINUTE_SECOND_HEMISPHERE: |
||
| 81 | 1 | return Degree::fromDegreeMinuteSecondHemisphere((string) $measurement); |
|
| 82 | case UnitOfMeasure::EPSG_ANGLE_HEMISPHERE_DEGREE_MINUTE_SECOND: |
||
| 83 | 1 | return Degree::fromHemisphereDegreeMinuteSecond((string) $measurement); |
|
| 84 | case UnitOfMeasure::EPSG_ANGLE_DEGREE_MINUTE: |
||
| 85 | 1 | return Degree::fromDegreeMinute((string) $measurement); |
|
| 86 | case UnitOfMeasure::EPSG_ANGLE_DEGREE_MINUTE_HEMISPHERE: |
||
| 87 | 1 | return Degree::fromDegreeMinuteHemisphere((string) $measurement); |
|
| 88 | case UnitOfMeasure::EPSG_ANGLE_HEMISPHERE_DEGREE_MINUTE: |
||
| 89 | 1 | return Degree::fromHemisphereDegreeMinute((string) $measurement); |
|
| 90 | case UnitOfMeasure::EPSG_ANGLE_DEGREE_HEMISPHERE: |
||
| 91 | 1 | return Degree::fromDegreeHemisphere((string) $measurement); |
|
| 92 | case UnitOfMeasure::EPSG_ANGLE_HEMISPHERE_DEGREE: |
||
| 93 | 1 | return Degree::fromHemisphereDegree((string) $measurement); |
|
| 94 | case UnitOfMeasure::EPSG_ANGLE_SEXAGESIMAL_DMS_S: |
||
| 95 | 1 | return Degree::fromSexagesimalDMSS((string) $measurement); |
|
| 96 | case UnitOfMeasure::EPSG_ANGLE_SEXAGESIMAL_DMS: |
||
| 97 | 5 | return Degree::fromSexagesimalDMS((string) $measurement); |
|
| 98 | case UnitOfMeasure::EPSG_ANGLE_SEXAGESIMAL_DM: |
||
| 99 | 1 | return Degree::fromSexagesimalDM((string) $measurement); |
|
| 100 | case UnitOfMeasure::EPSG_LENGTH_METRE: |
||
| 101 | 56 | return new Metre($measurement); |
|
| 102 | case UnitOfMeasure::EPSG_SCALE_UNITY: |
||
| 103 | 1 | return new Unity($measurement); |
|
| 104 | case UnitOfMeasure::EPSG_TIME_SECOND: |
||
| 105 | 1 | return new Second($measurement); |
|
| 106 | case UnitOfMeasure::EPSG_TIME_YEAR: |
||
| 107 | 1 | return new Year($measurement); |
|
| 108 | } |
||
| 109 | |||
| 110 | /* |
||
| 111 | * Check that the unit can be defined by reference to SI, if it can't it needs special handling and needs to be |
||
| 112 | * in the list above |
||
| 113 | */ |
||
| 114 | // @codeCoverageIgnoreStart |
||
| 115 | if ($unitData['factor_b'] === null || |
||
| 116 | !in_array( |
||
| 117 | $unitData['target_uom_code'], |
||
| 118 | [ |
||
| 119 | UnitOfMeasure::EPSG_ANGLE_RADIAN, |
||
| 120 | UnitOfMeasure::EPSG_LENGTH_METRE, |
||
| 121 | UnitOfMeasure::EPSG_SCALE_UNITY, |
||
| 122 | //UnitOfMeasure::EPSG_TIME_SECOND, all time units in the DB are currently handled above |
||
| 123 | ], |
||
| 124 | true |
||
| 125 | ) |
||
| 126 | ) { |
||
| 127 | throw new UnknownUnitOfMeasureException($epsgUnitCode); |
||
| 128 | } |
||
| 129 | // @codeCoverageIgnoreEnd |
||
| 130 | |||
| 131 | 110 | switch ($unitData['unit_of_meas_type']) { |
|
| 132 | 110 | case 'angle': |
|
| 133 | 31 | return new ExoticAngle($measurement, $unitData['unit_of_meas_name'], $unitData['factor_b'], $unitData['factor_c']); |
|
| 134 | 88 | case 'length': |
|
| 135 | 66 | return new ExoticLength($measurement, $unitData['unit_of_meas_name'], $unitData['factor_b'], $unitData['factor_c']); |
|
| 136 | 22 | case 'scale': |
|
| 137 | 22 | return new ExoticScale($measurement, $unitData['unit_of_meas_name'], $unitData['factor_b'], $unitData['factor_c']); |
|
| 138 | } |
||
| 169 |
Loading history...