PHPCoord\UnitOfMeasure\UnitOfMeasureFactory

Complexity

Total Complexity

7

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getSupportedSRIDs()	0	3	1
A	makeUnit()	0	23	6

<?php
/**
 * PHPCoord.
 *
 * @author Doug Wright
 */
declare(strict_types=1);

namespace PHPCoord\UnitOfMeasure;

use PHPCoord\Exception\UnknownUnitOfMeasureException;
use PHPCoord\UnitOfMeasure\Angle\Angle;
use PHPCoord\UnitOfMeasure\Length\Length;
use PHPCoord\UnitOfMeasure\Scale\Scale;
use PHPCoord\UnitOfMeasure\Time\Time;

class UnitOfMeasureFactory
{
    /**
     * @param float|string $measurement
     */
    public static function makeUnit($measurement, string $srid): UnitOfMeasure
    {
        if (isset(Angle::getSupportedSRIDs()[$srid])) {
            return Angle::makeUnit($measurement, $srid);
        }

        if (isset(Length::getSupportedSRIDs()[$srid])) {
            return Length::makeUnit($measurement, $srid);

It seems like $measurement can also be of type string; however, parameter $measurement of PHPCoord\UnitOfMeasure\Length\Length::makeUnit() does only seem to accept double, maybe add an additional type check?

        }

        if (isset(Scale::getSupportedSRIDs()[$srid])) {
            return Scale::makeUnit($measurement, $srid);

It seems like $measurement can also be of type string; however, parameter $measurement of PHPCoord\UnitOfMeasure\Scale\Scale::makeUnit() does only seem to accept double, maybe add an additional type check?

        }

        if (isset(Time::getSupportedSRIDs()[$srid])) {
            return Time::makeUnit($measurement, $srid);

It seems like $measurement can also be of type string; however, parameter $measurement of PHPCoord\UnitOfMeasure\Time\Time::makeUnit() does only seem to accept double, maybe add an additional type check?

        }

        if (isset(Rate::getSupportedSRIDs()[$srid])) {
            return Rate::makeUnit($measurement, $srid);

It seems like $measurement can also be of type string; however, parameter $measurement of PHPCoord\UnitOfMeasure\Rate::makeUnit() does only seem to accept double, maybe add an additional type check?

        }

        throw new UnknownUnitOfMeasureException($srid);
    }

    public static function getSupportedSRIDs(): array
    {
        return array_merge(Angle::getSupportedSRIDs(), Length::getSupportedSRIDs(), Scale::getSupportedSRIDs(), Time::getSupportedSRIDs(), Rate::getSupportedSRIDs());
    }
}