PHPCoord\CoordinateReferenceSystem\Geographic

Complexity

Total Complexity

5

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Test Coverage

Coverage

90%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getSupportedSRIDs()	0	7	2
A	fromSRID()	0	11	3

<?php
/**
 * PHPCoord.
 *
 * @author Doug Wright
 */
declare(strict_types=1);

namespace PHPCoord\CoordinateReferenceSystem;

use function array_merge;
use PHPCoord\Exception\UnknownCoordinateReferenceSystemException;

abstract class Geographic extends CoordinateReferenceSystem
{
    private static $supportedCache = [];

    public static function fromSRID(string $srid)
    {
        if (isset(Geographic2D::getSupportedSRIDs()[$srid])) {
            return Geographic2D::fromSRID($srid);
        }

        if (isset(Geographic3D::getSupportedSRIDs()[$srid])) {
            return Geographic3D::fromSRID($srid);
        }

        throw new UnknownCoordinateReferenceSystemException($srid);
    }

    public static function getSupportedSRIDs(): array
    {
        if (!self::$supportedCache) {

The expression self::supportedCache of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            self::$supportedCache = array_merge(Geographic2D::getSupportedSRIDs(), Geographic3D::getSupportedSRIDs());
        }

        return self::$supportedCache;
    }
}