ItemList::compare() - Code Metrics - Inspection of "Cap lookahead recursion" - dvdoug/BoxPacker - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 1.x-dev ( afef98...3b2513 )

by Doug

created 2018-11-12 23:25 UTC

ItemList::compare() A

↳ Parent: ItemList

Complexity

Conditions	5
Paths	5

Size

Total Lines	12
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	5

Importance

Changes

Metric	Value
cc	5
eloc	10
nc	5
nop	2
dl	0
loc	12
ccs	10
cts	10
cp	1
crap	5
rs	9.6111
c	0
b	0
f	0

<?php
/**
 * Box packing (3D bin packing, knapsack problem).
 *
 * @author Doug Wright
 */

namespace DVDoug\BoxPacker;

/**
 * List of items to be packed, ordered by volume.
 *
 * @author Doug Wright
 */
class ItemList extends \SplMaxHeap
{
    /**
     * Compare elements in order to place them correctly in the heap while sifting up.
     *
     * @see \SplMaxHeap::compare()
     *
     * @param mixed $itemA
     * @param mixed $itemB
     *
     * @return int
     */
    public function compare($itemA, $itemB)
    {
        if ($itemA->getVolume() > $itemB->getVolume()) {
            return 1;
        } elseif ($itemA->getVolume() < $itemB->getVolume()) {
            return -1;
        } elseif ($itemA->getWeight() !== $itemB->getWeight()) {
            return $itemA->getWeight() - $itemB->getWeight();
        } elseif ($itemA->getDescription() < $itemB->getDescription()) {
            return 1;
        } else {
            return -1;
        }
    }

    /**
     * Get copy of this list as a standard PHP array.
     *
     * @return Item[]
     */
    public function asArray()
    {
        $return = [];
        foreach (clone $this as $item) {
            $return[] = $item;
        }

        return $return;
    }

    /**
     * @internal
     *
     * @param  int      $n
     * @return ItemList
     */
    public function topN($n)
    {
        $workingList = clone $this;
        $topNList = new self();
        $i = 0;
        while(!$workingList->isEmpty() && $i < $n) {
            $topNList->insert($workingList->extract());
        }

        return $topNList;
    }

}


1		<?php
2		/**
3		* Box packing (3D bin packing, knapsack problem).
4		*
5		* @author Doug Wright
6		*/
7
8		namespace DVDoug\BoxPacker;
9
10		/**
11		* List of items to be packed, ordered by volume.
12		*
13		* @author Doug Wright
14		*/
15		class ItemList extends \SplMaxHeap
16		{
17		/**
18		* Compare elements in order to place them correctly in the heap while sifting up.
19		*
20		* @see \SplMaxHeap::compare()
21		*
22		* @param mixed $itemA
23		* @param mixed $itemB
24		*
25		* @return int
26		*/
27	22	public function compare($itemA, $itemB)
28		{
29	22	if ($itemA->getVolume() > $itemB->getVolume()) {
30	11	return 1;
31	22	} elseif ($itemA->getVolume() < $itemB->getVolume()) {
32	10	return -1;
33	20	} elseif ($itemA->getWeight() !== $itemB->getWeight()) {
34	3	return $itemA->getWeight() - $itemB->getWeight();
35	20	} elseif ($itemA->getDescription() < $itemB->getDescription()) {
36	4	return 1;
37		} else {
38	18	return -1;
39		}
40		}
41
42		/**
43		* Get copy of this list as a standard PHP array.
44		*
45		* @return Item[]
46		*/
47	5	public function asArray()
48		{
49	5	$return = [];
50	5	foreach (clone $this as $item) {
51	5	$return[] = $item;
52		}
53
54	5	return $return;
55		}
56
57		/**
58		* @internal
59		*
60		* @param int $n
61		* @return ItemList
62		*/
63	12	public function topN($n)
64		{
65	12	$workingList = clone $this;
66	12	$topNList = new self();
67	12	$i = 0;
68	12	while(!$workingList->isEmpty() && $i < $n) {
69	12	$topNList->insert($workingList->extract());
70		}
71
72	12	return $topNList;
73		}
74
75		}
76

dvdoug / BoxPacker

Push — 1.x-dev ( afef98...3b2513 )

ItemList::compare() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like