Completed
Push — 1.x-dev ( 423a53...2f7d84 )
by Doug
48:23 queued 46:55
created

PackedBoxListTest   A

Complexity

Total Complexity 2

Size/Duplication

Total Lines 34
Duplicated Lines 88.24 %

Coupling/Cohesion

Components 0
Dependencies 6

Importance

Changes 1
Bugs 0 Features 0
Metric Value
wmc 2
lcom 0
cbo 6
dl 30
loc 34
rs 10
c 1
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
A testVolumeUtilisation() 15 15 1
A testWeightVariance() 15 15 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * Box packing (3D bin packing, knapsack problem)
4
 * @package BoxPacker
5
 * @author Doug Wright
6
 */
7
8
namespace DVDoug\BoxPacker;
9
10
use DVDoug\BoxPacker\Test\TestBox;
11
use DVDoug\BoxPacker\Test\TestItem;
12
use PHPUnit\Framework\TestCase;
13
14
class PackedBoxListTest extends TestCase
15
{
16 View Code Duplication
    function testVolumeUtilisation()
0 ignored issues
show
Best Practice introduced by
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
17
    {
18
        $box = new TestBox('Box', 10, 10, 10, 10, 10, 10, 10, 10);
19
        $item = new TestItem('Item', 5, 10, 10, 10);
20
21
        $boxItems = new ItemList();
22
        $boxItems->insert($item);
23
24
        $packedBox = new PackedBox($box, $boxItems, 1, 2, 3, 4, 0, 0, 0);
25
26
        $packedBoxList = new PackedBoxList();
27
        $packedBoxList->insert($packedBox);
28
29
        self::assertEquals(50, $packedBoxList->getVolumeUtilisation());
30
    }
31
32 View Code Duplication
    function testWeightVariance()
0 ignored issues
show
Best Practice introduced by
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
33
    {
34
        $box = new TestBox('Box', 10, 10, 10, 10, 10, 10, 10, 10);
35
        $item = new TestItem('Item', 5, 10, 10, 10);
36
37
        $boxItems = new ItemList();
38
        $boxItems->insert($item);
39
40
        $packedBox = new PackedBox($box, $boxItems, 1, 2, 3, 4, 0, 0, 0);
41
42
        $packedBoxList = new PackedBoxList();
43
        $packedBoxList->insert($packedBox);
44
45
        self::assertEquals(0, $packedBoxList->getWeightVariance());
46
    }
47
}
48