DVDoug\BoxPacker\BoxListTest

Complexity

Total Complexity

7

Size/Duplication

Total Lines	63
Duplicated Lines	52.38 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testCompare()	18	18	2
A	testIssue14A()	15	15	2
B	testIssue14B()	0	24	3

<?php
/**
 * Box packing (3D bin packing, knapsack problem)
 * @package BoxPacker
 * @author Doug Wright
 */

namespace DVDoug\BoxPacker;

use DVDoug\BoxPacker\Test\TestBox;
use PHPUnit\Framework\TestCase;

class BoxListTest extends TestCase
{

    function testCompare()

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {

        $box1 = new TestBox('Small', 21, 21, 3, 1, 20, 20, 2, 100);
        $box2 = new TestBox('Large', 201, 201, 21, 1, 200, 200, 20, 1000);
        $box3 = new TestBox('Medium', 101, 101, 11, 5, 100, 100, 10, 500);

        $list = new BoxList;
        $list->insert($box1);
        $list->insert($box2);
        $list->insert($box3);

        $sorted = [];
        while (!$list->isEmpty()) {
            $sorted[] = $list->extract();
        }
        self::assertEquals(array($box1, $box3, $box2), $sorted);
    }

    function testIssue14A()

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        $box1 = new TestBox('Small', 21, 21, 3, 1, 20, 20, 2, 100);
        $box2 = new TestBox('Large', 1301, 1301, 1301, 1, 1300, 1300, 1300, 1000);
        $box3 = new TestBox('Medium', 101, 101, 11, 5, 100, 100, 10, 500);
        $list = new BoxList;
        $list->insert($box1);
        $list->insert($box2);
        $list->insert($box3);
        $sorted = [];
        while (!$list->isEmpty()) {
            $sorted[] = $list->extract();
        }
        self::assertEquals(array($box1, $box3, $box2), $sorted);
    }

    function testIssue14B()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $box1 = new TestBox('Small', 21, 21, 3, 1, 20, 20, 2, 100);
        $box2 = new TestBox('Large', 1301, 1301, 1301, 1, 1300, 1300, 1300, 1000);
        $box3 = new TestBox('Medium', 101, 101, 11, 5, 100, 100, 10, 500);
        $list = new BoxList;
        $list->insert($box3);
        $list->insert($box2);
        $list->insert($box1);
        $sorted = [];
        while (!$list->isEmpty()) {
            $sorted[] = $list->extract();
        }
        self::assertEquals(array($box1, $box3, $box2), $sorted);
        $list = new BoxList;
        $list->insert($box2);
        $list->insert($box1);
        $list->insert($box3);
        $sorted = [];
        while (!$list->isEmpty()) {
            $sorted[] = $list->extract();
        }
        self::assertEquals(array($box1, $box3, $box2), $sorted);
    }
}