DVDoug\BoxPacker\BoxList

Complexity

Total Complexity

4

Size/Duplication

Total Lines	48
Duplicated Lines	16.67 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getIterator()	8	8	2
A	insert()	0	4	1
A	compare()	0	7	1

<?php
/**
 * Box packing (3D bin packing, knapsack problem)
 * @package BoxPacker
 * @author Doug Wright
 */
declare(strict_types=1);
namespace DVDoug\BoxPacker;

use ArrayIterator, IteratorAggregate, Traversable;

/**
 * List of boxes available to put items into, ordered by volume
 * @author Doug Wright
 * @package BoxPacker
 */
class BoxList implements IteratorAggregate
{
    /**
     * List containing boxes
     * @var Box[]
     */
    private $list = [];

    /**
     * Has this list already been sorted?
     * @var bool
     */
    private $isSorted = false;

    /**
     * @return Traversable
     */
    public function getIterator(): Traversable

This method seems to be duplicated in your project.

    {
        if (!$this->isSorted) {
            usort($this->list, [$this, 'compare']);
            $this->isSorted = true;
        }
        return new ArrayIterator($this->list);
    }

    /**
     * @param Box $item
     */
    public function insert(Box $item)
    {
        $this->list[] = $item;
    }

    /**
     * @param Box $boxA
     * @param Box $boxB
     *
     * @return int
     */
    public function compare($boxA, $boxB): int
    {
        $boxAVolume = $boxA->getInnerWidth() * $boxA->getInnerLength() * $boxA->getInnerDepth();
        $boxBVolume = $boxB->getInnerWidth() * $boxB->getInnerLength() * $boxB->getInnerDepth();

        return $boxAVolume <=> $boxBVolume;
    }
}