InfalliblePacker::pack() - Code Metrics - Inspection of "Move multiple item helper into ItemList" - dvdoug/BoxPacker - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 3.x ( 539084...e58d28 )

by Doug

created 2021-07-01 22:22 UTC

InfalliblePacker::pack() A

↳ Parent: InfalliblePacker

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	8
c	1
b	0
f	0
nc	3
nop	0
dl	0
loc	11
ccs	8
cts	8
cp	1
crap	3
rs	10

<?php
/**
 * Box packing (3D bin packing, knapsack problem).
 *
 * @author Doug Wright
 */
declare(strict_types=1);

namespace DVDoug\BoxPacker;

/**
 * A version of the packer that swallows internal exceptions.
 *
 * @author Doug Wright
 */
class InfalliblePacker extends Packer
{
    /**
     * @var ItemList
     */
    protected $unpackedItems;

    /**
     * InfalliblePacker constructor.
     */
    public function __construct()
    {
        $this->unpackedItems = new ItemList();
        parent::__construct();
    }

    /**
     * Return the items that couldn't be packed.
     */
    public function getUnpackedItems(): ItemList
    {
        return $this->unpackedItems;
    }

    /**
     * {@inheritdoc}
     */
    public function pack(): PackedBoxList
    {
        $itemList = clone $this->items;

        while (true) {
            try {
                return parent::pack();
            } catch (ItemTooLargeException $e) {
                $this->unpackedItems->insert($e->getItem());
                $itemList->remove($e->getItem());
                $this->setItems($itemList);
            }
        }
    }
}


1		<?php
2		/**
3		* Box packing (3D bin packing, knapsack problem).
4		*
5		* @author Doug Wright
6		*/
7		declare(strict_types=1);
8
9		namespace DVDoug\BoxPacker;
10
11		/**
12		* A version of the packer that swallows internal exceptions.
13		*
14		* @author Doug Wright
15		*/
16		class InfalliblePacker extends Packer
17		{
18		/**
19		* @var ItemList
20		*/
21		protected $unpackedItems;
22
23		/**
24		* InfalliblePacker constructor.
25		*/
26	7	public function __construct()
27		{
28	7	$this->unpackedItems = new ItemList();
29	7	parent::__construct();
30	7	}
31
32		/**
33		* Return the items that couldn't be packed.
34		*/
35	2	public function getUnpackedItems(): ItemList
36		{
37	2	return $this->unpackedItems;
38		}
39
40		/**
41		* {@inheritdoc}
42		*/
43	7	public function pack(): PackedBoxList
44		{
45	7	$itemList = clone $this->items;
46
47	7	while (true) {
48		try {
49	7	return parent::pack();
50	2	} catch (ItemTooLargeException $e) {
51	2	$this->unpackedItems->insert($e->getItem());
52	2	$itemList->remove($e->getItem());
53	2	$this->setItems($itemList);
54		}
55		}
56		}
57		}
58

dvdoug / BoxPacker

Push — 3.x ( 539084...e58d28 )

InfalliblePacker::pack() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like