BoxList::sort() - Code Metrics - Inspection of "Switch BoxList to a datastructure that implements..." - dvdoug/BoxPacker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — new_data_structures_2 ( 960830 )

by Doug

created 2017-01-21 16:23 UTC

BoxList::sort() A

↳ Parent: BoxList

Complexity

Conditions	3
Paths	1

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3.0067

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	10
cts	11
cp	0.9091
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	10
nc	1
nop	0
crap	3.0067

<?php
/**
 * Box packing (3D bin packing, knapsack problem)
 *
 * @package BoxPacker
 * @author  Doug Wright
 */
namespace DVDoug\BoxPacker;

/**
 * List of boxes available to put items into, ordered by volume
 *
 * @author  Doug Wright
 * @package BoxPacker
 */
class BoxList implements \Countable, \IteratorAggregate
{
    /**
     * @var array
     */
    protected $list = [];

    /**
     * @return int
     */
    public function count()
    {
        return count($this->list);
    }

    /**
     * @return \ArrayIterator
     */
    public function getIterator()
    {
        $this->sort();
        return new \ArrayIterator($this->list);
    }

    /**
     * Insert a box choice into the list
     *
     * @param Box $box
     */
    public function insert(Box $box)
    {
        $this->list[spl_object_hash($box)] = $box;
    }

    /**
     * Sort the boxes into order (smallest volume first)
     */
    protected function sort()
    {
        uasort(
            $this->list,
            function (Box $boxA, Box $boxB) {
                if ($boxB->getInnerVolume() > $boxA->getInnerVolume()) {
                    return -1;
                } elseif ($boxB->getInnerVolume() < $boxA->getInnerVolume()) {
                    return 1;
                } else {
                    return 0;
                }
            }
        );
    }


}


1		<?php
2		/**
3		* Box packing (3D bin packing, knapsack problem)
4		*
5		* @package BoxPacker
6		* @author Doug Wright
7		*/
8		namespace DVDoug\BoxPacker;
9
10		/**
11		* List of boxes available to put items into, ordered by volume
12		*
13		* @author Doug Wright
14		* @package BoxPacker
15		*/
16		class BoxList implements \Countable, \IteratorAggregate
17		{
18		/**
19		* @var array
20		*/
21		protected $list = [];
22
23		/**
24		* @return int
25		*/
26		public function count()
27		{
28		return count($this->list);
29		}
30
31		/**
32		* @return \ArrayIterator
33		*/
34	21	public function getIterator()
35		{
36	21	$this->sort();
37	21	return new \ArrayIterator($this->list);
38		}
39
40		/**
41		* Insert a box choice into the list
42		*
43		* @param Box $box
44		*/
45	20	public function insert(Box $box)
46		{
47	20	$this->list[spl_object_hash($box)] = $box;
48	20	}
49
50		/**
51		* Sort the boxes into order (smallest volume first)
52		*/
53	21	protected function sort()
54		{
55	21	uasort(
56	21	$this->list,
57	11	function (Box $boxA, Box $boxB) {
58	11	if ($boxB->getInnerVolume() > $boxA->getInnerVolume()) {
59	4	return -1;
60	10	} elseif ($boxB->getInnerVolume() < $boxA->getInnerVolume()) {
61	10	return 1;
62		} else {
63		return 0;
64		}
65		}
66	21	);
67	21	}
68
69
70		}
71

dvdoug / BoxPacker

Push — new_data_structures_2 ( 960830 )

BoxList::sort() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like