ItemList::hasNoRotationItems() - Code Metrics - Inspection of "Fix #538" - dvdoug/BoxPacker - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( fe7a30...3bafcc )

by Doug

created 2023-07-23 22:00 UTC

ItemList::hasNoRotationItems() A

↳ Parent: ItemList

Complexity

Conditions	4
Paths	4

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	4.25

Importance

Changes

Metric	Value
eloc	7
dl	0
loc	13
ccs	6
cts	8
cp	0.75
c	0
b	0
f	0
rs	10
cc	4
nc	4
nop	0
crap	4.25

<?php
/**
 * Box packing (3D bin packing, knapsack problem).
 *
 * @author Doug Wright
 */
declare(strict_types=1);

namespace DVDoug\BoxPacker;

use ArrayIterator;
use Countable;
use IteratorAggregate;
use Traversable;

use function array_key_last;
use function array_pop;
use function array_reverse;
use function array_slice;
use function count;
use function current;
use function end;
use function key;
use function prev;
use function usort;

/**
 * List of items to be packed, ordered by volume.
 */
class ItemList implements Countable, IteratorAggregate
{
    /**
     * @var Item[]
     */
    private array $list = [];

    private bool $isSorted = false;

    private ?bool $hasConstrainedItems = null;

    private ?bool $hasNoRotationItems = null;

    public function __construct(private readonly ItemSorter $sorter = new DefaultItemSorter())
    {
    }

    /**
     * Do a bulk create.
     *
     * @param Item[] $items
     */
    public static function fromArray(array $items, bool $preSorted = false): self
    {
        $list = new self();
        $list->list = array_reverse($items); // internal sort is largest at the end
        $list->isSorted = $preSorted;

        return $list;
    }

    public function insert(Item $item, int $qty = 1): void
    {
        for ($i = 0; $i < $qty; ++$i) {
            $this->list[] = $item;
        }
        $this->isSorted = false;

        if (isset($this->hasConstrainedItems)) { // normally lazy evaluated, override if that's already been done
            $this->hasConstrainedItems = $this->hasConstrainedItems || $item instanceof ConstrainedPlacementItem;
        }

        if (isset($this->hasNoRotationItems)) { // normally lazy evaluated, override if that's already been done
            $this->hasNoRotationItems = $this->hasNoRotationItems || $item->getAllowedRotation() === Rotation::Never;
        }
    }

    /**
     * Remove item from list.
     */
    public function remove(Item $item): void
    {
        if (!$this->isSorted) {
            usort($this->list, $this->sorter->compare(...));
            $this->list = array_reverse($this->list); // internal sort is largest at the end
            $this->isSorted = true;
        }

        end($this->list);
        do {
            if (current($this->list) === $item) {
                unset($this->list[key($this->list)]);

                return;
            }
        } while (prev($this->list) !== false);
    }

    public function removePackedItems(PackedItemList $packedItemList): void
    {
        foreach ($packedItemList as $packedItem) {
            end($this->list);
            do {
                if (current($this->list) === $packedItem->getItem()) {
                    unset($this->list[key($this->list)]);

                    break;
                }
            } while (prev($this->list) !== false);
        }
    }

    /**
     * @internal
     */
    public function extract(): Item
    {
        if (!$this->isSorted) {
            usort($this->list, $this->sorter->compare(...));
            $this->list = array_reverse($this->list); // internal sort is largest at the end
            $this->isSorted = true;
        }

        return array_pop($this->list);
    }

    /**
     * @internal
     */
    public function top(): Item
    {
        if (!$this->isSorted) {
            usort($this->list, $this->sorter->compare(...));
            $this->list = array_reverse($this->list); // internal sort is largest at the end
            $this->isSorted = true;
        }

        return $this->list[array_key_last($this->list)];
    }

    /**
     * @internal
     */
    public function topN(int $n): self
    {
        if (!$this->isSorted) {
            usort($this->list, $this->sorter->compare(...));
            $this->list = array_reverse($this->list); // internal sort is largest at the end
            $this->isSorted = true;
        }

        $topNList = new self();
        $topNList->list = array_slice($this->list, -$n, $n);
        $topNList->isSorted = true;

        return $topNList;
    }

    /**
     * @return Traversable<Item>
     */
    public function getIterator(): Traversable
    {
        if (!$this->isSorted) {
            usort($this->list, $this->sorter->compare(...));
            $this->list = array_reverse($this->list); // internal sort is largest at the end
            $this->isSorted = true;
        }

        return new ArrayIterator(array_reverse($this->list));
    }

    /**
     * Number of items in list.
     */
    public function count(): int
    {
        return count($this->list);
    }

    /**
     * Does this list contain items with constrained placement criteria.
     */
    public function hasConstrainedItems(): bool
    {
        if (!isset($this->hasConstrainedItems)) {
            $this->hasConstrainedItems = false;
            foreach ($this->list as $item) {
                if ($item instanceof ConstrainedPlacementItem) {
                    $this->hasConstrainedItems = true;
                    break;
                }
            }
        }

        return $this->hasConstrainedItems;

    }

    /**
     * Does this list contain items which cannot be rotated.
     */
    public function hasNoRotationItems(): bool
    {
        if (!isset($this->hasNoRotationItems)) {
            $this->hasNoRotationItems = false;
            foreach ($this->list as $item) {
                if ($item->getAllowedRotation() === Rotation::Never) {
                    $this->hasNoRotationItems = true;
                    break;
                }
            }
        }

        return $this->hasNoRotationItems;

    }
}


1		<?php
2		/**
3		* Box packing (3D bin packing, knapsack problem).
4		*
5		* @author Doug Wright
6		*/
7		declare(strict_types=1);
8
9		namespace DVDoug\BoxPacker;
10
11		use ArrayIterator;
12		use Countable;
13		use IteratorAggregate;
14		use Traversable;
15
16		use function array_key_last;
17		use function array_pop;
18		use function array_reverse;
19		use function array_slice;
20		use function count;
21		use function current;
22		use function end;
23		use function key;
24		use function prev;
25		use function usort;
26
27		/**
28		* List of items to be packed, ordered by volume.
29		*/
30		class ItemList implements Countable, IteratorAggregate
31		{
32		/**
33		* @var Item[]
34		*/
35		private array $list = [];
36
37		private bool $isSorted = false;
38
39		private ?bool $hasConstrainedItems = null;
40
41		private ?bool $hasNoRotationItems = null;
42
43	104	public function __construct(private readonly ItemSorter $sorter = new DefaultItemSorter())
44		{
45	104	}
46
47		/**
48		* Do a bulk create.
49		*
50		* @param Item[] $items
51		*/
52	90	public static function fromArray(array $items, bool $preSorted = false): self
53		{
54	90	$list = new self();
55	90	$list->list = array_reverse($items); // internal sort is largest at the end
56	90	$list->isSorted = $preSorted;
57
58	90	return $list;
59		}
60
61	105	public function insert(Item $item, int $qty = 1): void
62		{
63	105	for ($i = 0; $i < $qty; ++$i) {
64	105	$this->list[] = $item;
65		}
66	105	$this->isSorted = false;
67
68	105	if (isset($this->hasConstrainedItems)) { // normally lazy evaluated, override if that's already been done
69		$this->hasConstrainedItems = $this->hasConstrainedItems \|\| $item instanceof ConstrainedPlacementItem;
70		}
71
72	105	if (isset($this->hasNoRotationItems)) { // normally lazy evaluated, override if that's already been done
73		$this->hasNoRotationItems = $this->hasNoRotationItems \|\| $item->getAllowedRotation() === Rotation::Never;
74		}
75		}
76
77		/**
78		* Remove item from list.
79		*/
80	1	public function remove(Item $item): void
81		{
82	1	if (!$this->isSorted) {
83	1	usort($this->list, $this->sorter->compare(...));
84	1	$this->list = array_reverse($this->list); // internal sort is largest at the end
85	1	$this->isSorted = true;
86		}
87
88	1	end($this->list);
89		do {
90	1	if (current($this->list) === $item) {
91	1	unset($this->list[key($this->list)]);
92
93	1	return;
94		}
95	1	} while (prev($this->list) !== false);
96		}
97
98	57	public function removePackedItems(PackedItemList $packedItemList): void
99		{
100	57	foreach ($packedItemList as $packedItem) {
101	56	end($this->list);
102		do {
103	56	if (current($this->list) === $packedItem->getItem()) {
104	56	unset($this->list[key($this->list)]);
105
106	56	break;
107		}
108	18	} while (prev($this->list) !== false);
109		}
110		}
111
112		/**
113		* @internal
114		*/
115	100	public function extract(): Item
116		{
117	100	if (!$this->isSorted) {
118	59	usort($this->list, $this->sorter->compare(...));
119	59	$this->list = array_reverse($this->list); // internal sort is largest at the end
120	59	$this->isSorted = true;
121		}
122
123	100	return array_pop($this->list);
124		}
125
126		/**
127		* @internal
128		*/
129	62	public function top(): Item
130		{
131	62	if (!$this->isSorted) {
132	2	usort($this->list, $this->sorter->compare(...));
133	2	$this->list = array_reverse($this->list); // internal sort is largest at the end
134	2	$this->isSorted = true;
135		}
136
137	62	return $this->list[array_key_last($this->list)];
138		}
139
140		/**
141		* @internal
142		*/
143	29	public function topN(int $n): self
144		{
145	29	if (!$this->isSorted) {
146	1	usort($this->list, $this->sorter->compare(...));
147	1	$this->list = array_reverse($this->list); // internal sort is largest at the end
148	1	$this->isSorted = true;
149		}
150
151	29	$topNList = new self();
152	29	$topNList->list = array_slice($this->list, -$n, $n);
153	29	$topNList->isSorted = true;
154
155	29	return $topNList;
156		}
157
158		/**
159		* @return Traversable<Item>
160		*/
161	96	public function getIterator(): Traversable
162		{
163	96	if (!$this->isSorted) {
164	43	usort($this->list, $this->sorter->compare(...));
165	43	$this->list = array_reverse($this->list); // internal sort is largest at the end
166	43	$this->isSorted = true;
167		}
168
169	96	return new ArrayIterator(array_reverse($this->list));
170		}
171
172		/**
173		* Number of items in list.
174		*/
175	103	public function count(): int
176		{
177	103	return count($this->list);
178		}
179
180		/**
181		* Does this list contain items with constrained placement criteria.
182		*/
183	97	public function hasConstrainedItems(): bool
184		{
185	97	if (!isset($this->hasConstrainedItems)) {
186	97	$this->hasConstrainedItems = false;
187	97	foreach ($this->list as $item) {
188	97	if ($item instanceof ConstrainedPlacementItem) {
189	3	$this->hasConstrainedItems = true;
190	3	break;
191		}
192		}
193		}
194
195	97	return $this->hasConstrainedItems;
		0 ignored issues – show Bug Best Practice introduced 2020-08-15 18:52 UTC by Report Bug Copy Issue Report The expression `return $this->hasConstrainedItems` could return the type `null` which is incompatible with the type-hinted return `boolean`. Consider adding an additional type-check to rule them out. Loading history...
196		}
197
198		/**
199		* Does this list contain items which cannot be rotated.
200		*/
201	97	public function hasNoRotationItems(): bool
202		{
203	97	if (!isset($this->hasNoRotationItems)) {
204	97	$this->hasNoRotationItems = false;
205	97	foreach ($this->list as $item) {
206	97	if ($item->getAllowedRotation() === Rotation::Never) {
207		$this->hasNoRotationItems = true;
208		break;
209		}
210		}
211		}
212
213	97	return $this->hasNoRotationItems;
		0 ignored issues – show Bug Best Practice introduced 2020-08-15 18:52 UTC by Report Bug Copy Issue Report The expression `return $this->hasNoRotationItems` could return the type `null` which is incompatible with the type-hinted return `boolean`. Consider adding an additional type-check to rule them out. Loading history...
214		}
215		}
216

dvdoug / BoxPacker

Push — master ( fe7a30...3bafcc )

ItemList::hasNoRotationItems() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like