Completed
Push — refactor_best_orientation ( 9fb66e )
by Doug
08:18
created
src/BoxList.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@
 block discarded – undo
4 4
  * @package BoxPacker
5 5
  * @author Doug Wright
6 6
  */
7
-declare(strict_types=1);
7
+declare(strict_types = 1);
8 8
 namespace DVDoug\BoxPacker;
9 9
 
10 10
 use ArrayIterator, IteratorAggregate, Traversable;
Please login to merge, or discard this patch.
src/WeightRedistributor.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
  * @package BoxPacker
5 5
  * @author Doug Wright
6 6
  */
7
-declare(strict_types=1);
7
+declare(strict_types = 1);
8 8
 namespace DVDoug\BoxPacker;
9 9
 
10 10
 use Psr\Log\LoggerAwareInterface;
@@ -68,21 +68,21 @@  discard block
 block discarded – undo
68 68
 
69 69
         do { //Keep moving items from most overweight box to most underweight box
70 70
             $tryRepack = false;
71
-            $this->logger->log(LogLevel::DEBUG, 'boxes under/over target: ' . count($underWeightBoxes) . '/' . count($overWeightBoxes));
71
+            $this->logger->log(LogLevel::DEBUG, 'boxes under/over target: '.count($underWeightBoxes).'/'.count($overWeightBoxes));
72 72
 
73 73
             usort($overWeightBoxes, [$this, 'sortMoreSpaceFirst']);
74 74
             usort($underWeightBoxes, [$this, 'sortMoreSpaceFirst']);
75 75
 
76 76
             foreach ($underWeightBoxes as $u => $underWeightBox) {
77
-                $this->logger->log(LogLevel::DEBUG, 'Underweight Box ' . $u);
77
+                $this->logger->log(LogLevel::DEBUG, 'Underweight Box '.$u);
78 78
                 foreach ($overWeightBoxes as $o => $overWeightBox) {
79
-                    $this->logger->log(LogLevel::DEBUG, 'Overweight Box ' . $o);
79
+                    $this->logger->log(LogLevel::DEBUG, 'Overweight Box '.$o);
80 80
                     $overWeightBoxItems = $overWeightBox->getItems()->asItemArray();
81 81
 
82 82
                     //For each item in the heavier box, try and move it to the lighter one
83 83
                     /** @var Item $overWeightBoxItem */
84 84
                     foreach ($overWeightBoxItems as $oi => $overWeightBoxItem) {
85
-                        $this->logger->log(LogLevel::DEBUG, 'Overweight Item ' . $oi);
85
+                        $this->logger->log(LogLevel::DEBUG, 'Overweight Item '.$oi);
86 86
                         if ($underWeightBox->getWeight() + $overWeightBoxItem->getWeight() > $targetWeight) {
87 87
                             $this->logger->log(LogLevel::DEBUG, 'Skipping item for hindering weight distribution');
88 88
                             continue; //skip if moving this item would hinder rather than help weight distribution
Please login to merge, or discard this patch.
src/ItemList.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@
 block discarded – undo
4 4
  * @package BoxPacker
5 5
  * @author Doug Wright
6 6
  */
7
-declare(strict_types=1);
7
+declare(strict_types = 1);
8 8
 namespace DVDoug\BoxPacker;
9 9
 
10 10
 use ArrayIterator, Countable, IteratorAggregate, Traversable;
Please login to merge, or discard this patch.
src/PackedItemList.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@
 block discarded – undo
4 4
  * @package BoxPacker
5 5
  * @author Doug Wright
6 6
  */
7
-declare(strict_types=1);
7
+declare(strict_types = 1);
8 8
 namespace DVDoug\BoxPacker;
9 9
 
10 10
 use ArrayIterator, Countable, IteratorAggregate, Traversable;
Please login to merge, or discard this patch.
src/OrientatedItemFactory.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
  * @package BoxPacker
5 5
  * @author Doug Wright
6 6
  */
7
-declare(strict_types=1);
7
+declare(strict_types = 1);
8 8
 namespace DVDoug\BoxPacker;
9 9
 
10 10
 use Psr\Log\LoggerAwareInterface;
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
         int $widthLeft,
44 44
         int $lengthLeft,
45 45
         int $depthLeft
46
-    ): ?OrientatedItem {
46
+    ) : ?OrientatedItem {
47 47
 
48 48
         $possibleOrientations = $this->getPossibleOrientations($item, $prevItem, $widthLeft, $lengthLeft, $depthLeft);
49 49
         $usableOrientations = $this->getUsableOrientations($possibleOrientations, $box, $item, $isLastItem);
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
             return null;
53 53
         }
54 54
 
55
-        usort($usableOrientations, function (OrientatedItem $a, OrientatedItem $b) use ($widthLeft, $lengthLeft) {
55
+        usort($usableOrientations, function(OrientatedItem $a, OrientatedItem $b) use ($widthLeft, $lengthLeft) {
56 56
             $orientationAWidthLeft = $widthLeft - $a->getWidth();
57 57
             $orientationALengthLeft = $lengthLeft - $a->getLength();
58 58
             $orientationBWidthLeft = $widthLeft - $b->getWidth();
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         int $widthLeft,
91 91
         int $lengthLeft,
92 92
         int $depthLeft
93
-    ): array {
93
+    ) : array {
94 94
 
95 95
         $orientations = [];
96 96
 
@@ -126,18 +126,18 @@  discard block
 block discarded – undo
126 126
      */
127 127
     public function getPossibleOrientationsInEmptyBox(Item $item, Box $box): array
128 128
     {
129
-        $cacheKey = $item->getWidth() .
130
-            '|' .
131
-            $item->getLength() .
132
-            '|' .
133
-            $item->getDepth() .
134
-            '|' .
135
-            ($item->getKeepFlat() ? '2D' : '3D') .
136
-            '|' .
137
-            $box->getInnerWidth() .
138
-            '|' .
139
-            $box->getInnerLength() .
140
-            '|' .
129
+        $cacheKey = $item->getWidth().
130
+            '|'.
131
+            $item->getLength().
132
+            '|'.
133
+            $item->getDepth().
134
+            '|'.
135
+            ($item->getKeepFlat() ? '2D' : '3D').
136
+            '|'.
137
+            $box->getInnerWidth().
138
+            '|'.
139
+            $box->getInnerLength().
140
+            '|'.
141 141
             $box->getInnerDepth();
142 142
 
143 143
         if (isset(static::$emptyBoxCache[$cacheKey])) {
Please login to merge, or discard this patch.