PackedBox::__construct() - Code Metrics - Inspection of "Fix Travis conditionals to correctly check against..." - dvdoug/BoxPacker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 349d65...0b9f3a )

by Doug

created 2017-01-07 19:49 UTC

PackedBox::__construct() A

↳ Parent: PackedBox

Complexity

Conditions	1
Paths	1

Size

Total Lines	22
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	22
ccs	11
cts	11
cp	1
rs	9.2
c	0
b	0
f	0
cc	1
eloc	19
nc	1
nop	9
crap	1

How to fix Many Parameters

<?php
/**
 * Box packing (3D bin packing, knapsack problem)
 * @package BoxPacker
 * @author Doug Wright
 */
namespace DVDoug\BoxPacker;

/**
 * A "box" with items
 * @author Doug Wright
 * @package BoxPacker
 */
class PackedBox
{

    /**
     * Box used
     * @var Box
     */
    protected $box;

    /**
     * Items in the box
     * @var ItemList
     */
    protected $items;

    /**
     * Total weight of box
     * @var int
     */
    protected $weight;

    /**
     * Remaining width inside box for another item
     * @var int
     */
    protected $remainingWidth;

    /**
     * Remaining length inside box for another item
     * @var int
     */
    protected $remainingLength;

    /**
     * Remaining depth inside box for another item
     * @var int
     */
    protected $remainingDepth;

    /**
     * Remaining weight inside box for another item
     * @var int
     */
    protected $remainingWeight;

    /**
     * Used width inside box for packing items
     * @var int
     */
    protected $usedWidth;

    /**
     * Used length inside box for packing items
     * @var int
     */
    protected $usedLength;

    /**
     * Used depth inside box for packing items
     * @var int
     */
    protected $usedDepth;

    /**
     * Get box used
     * @return Box
     */
    public function getBox()
    {
        return $this->box;
    }

    /**
     * Get items packed
     * @return ItemList
     */
    public function getItems()
    {
        return $this->items;
    }

    /**
     * Get packed weight
     * @return int weight in grams
     */
    public function getWeight()
    {

        if (!is_null($this->weight)) {
            return $this->weight;
        }

        $this->weight = $this->box->getEmptyWeight();
        $items = clone $this->items;
        foreach ($items as $item) {
            $this->weight += $item->getWeight();
        }
        return $this->weight;
    }

    /**
     * Get remaining width inside box for another item
     * @return int
     */
    public function getRemainingWidth()
    {
        return $this->remainingWidth;
    }

    /**
     * Get remaining length inside box for another item
     * @return int
     */
    public function getRemainingLength()
    {
        return $this->remainingLength;
    }

    /**
     * Get remaining depth inside box for another item
     * @return int
     */
    public function getRemainingDepth()
    {
        return $this->remainingDepth;
    }

    /**
     * Used width inside box for packing items
     * @return int
     */
    public function getUsedWidth()
    {
        return $this->usedWidth;
    }

    /**
     * Used length inside box for packing items
     * @return int
     */
    public function getUsedLength()
    {
        return $this->usedLength;
    }

    /**
     * Used depth inside box for packing items
     * @return int
     */
    public function getUsedDepth()
    {
        return $this->usedDepth;
    }

    /**
     * Get remaining weight inside box for another item
     * @return int
     */
    public function getRemainingWeight()
    {
        return $this->remainingWeight;
    }

    /**
     * Get volume utilisation of the packed box
     * @return float
     */
    public function getVolumeUtilisation()
    {
        $itemVolume = 0;

        /** @var Item $item */
        foreach (clone $this->items as $item) {
            $itemVolume += $item->getVolume();
        }

        return round($itemVolume / $this->box->getInnerVolume() * 100, 1);
    }


    /**
     * Constructor
     *
     * @param Box      $box
     * @param ItemList $itemList
     * @param int      $remainingWidth
     * @param int      $remainingLength
     * @param int      $remainingDepth
     * @param int      $remainingWeight
     * @param int      $usedWidth
     * @param int      $usedLength
     * @param int      $usedDepth
     */
    public function __construct(
        Box $box,
        ItemList $itemList,
        $remainingWidth,
        $remainingLength,
        $remainingDepth,
        $remainingWeight,
        $usedWidth,
        $usedLength,
        $usedDepth
    )
    {
        $this->box = $box;
        $this->items = $itemList;
        $this->remainingWidth = $remainingWidth;
        $this->remainingLength = $remainingLength;
        $this->remainingDepth = $remainingDepth;
        $this->remainingWeight = $remainingWeight;
        $this->usedWidth = $usedWidth;
        $this->usedLength = $usedLength;
        $this->usedDepth = $usedDepth;
    }
}


1		<?php
2		/**
3		* Box packing (3D bin packing, knapsack problem)
4		* @package BoxPacker
5		* @author Doug Wright
6		*/
7		namespace DVDoug\BoxPacker;
8
9		/**
10		* A "box" with items
11		* @author Doug Wright
12		* @package BoxPacker
13		*/
14		class PackedBox
15		{
16
17		/**
18		* Box used
19		* @var Box
20		*/
21		protected $box;
22
23		/**
24		* Items in the box
25		* @var ItemList
26		*/
27		protected $items;
28
29		/**
30		* Total weight of box
31		* @var int
32		*/
33		protected $weight;
34
35		/**
36		* Remaining width inside box for another item
37		* @var int
38		*/
39		protected $remainingWidth;
40
41		/**
42		* Remaining length inside box for another item
43		* @var int
44		*/
45		protected $remainingLength;
46
47		/**
48		* Remaining depth inside box for another item
49		* @var int
50		*/
51		protected $remainingDepth;
52
53		/**
54		* Remaining weight inside box for another item
55		* @var int
56		*/
57		protected $remainingWeight;
58
59		/**
60		* Used width inside box for packing items
61		* @var int
62		*/
63		protected $usedWidth;
64
65		/**
66		* Used length inside box for packing items
67		* @var int
68		*/
69		protected $usedLength;
70
71		/**
72		* Used depth inside box for packing items
73		* @var int
74		*/
75		protected $usedDepth;
76
77		/**
78		* Get box used
79		* @return Box
80		*/
81	6	public function getBox()
82		{
83	6	return $this->box;
84		}
85
86		/**
87		* Get items packed
88		* @return ItemList
89		*/
90	28	public function getItems()
91		{
92	28	return $this->items;
93		}
94
95		/**
96		* Get packed weight
97		* @return int weight in grams
98		*/
99	7	public function getWeight()
100		{
101
102	7	if (!is_null($this->weight)) {
103	5	return $this->weight;
104		}
105
106	7	$this->weight = $this->box->getEmptyWeight();
107	7	$items = clone $this->items;
108	7	foreach ($items as $item) {
109	7	$this->weight += $item->getWeight();
110	7	}
111	7	return $this->weight;
112		}
113
114		/**
115		* Get remaining width inside box for another item
116		* @return int
117		*/
118	1	public function getRemainingWidth()
119		{
120	1	return $this->remainingWidth;
121		}
122
123		/**
124		* Get remaining length inside box for another item
125		* @return int
126		*/
127	1	public function getRemainingLength()
128		{
129	1	return $this->remainingLength;
130		}
131
132		/**
133		* Get remaining depth inside box for another item
134		* @return int
135		*/
136	1	public function getRemainingDepth()
137		{
138	1	return $this->remainingDepth;
139		}
140
141		/**
142		* Used width inside box for packing items
143		* @return int
144		*/
145	1	public function getUsedWidth()
146		{
147	1	return $this->usedWidth;
148		}
149
150		/**
151		* Used length inside box for packing items
152		* @return int
153		*/
154	1	public function getUsedLength()
155		{
156	1	return $this->usedLength;
157		}
158
159		/**
160		* Used depth inside box for packing items
161		* @return int
162		*/
163	1	public function getUsedDepth()
164		{
165	1	return $this->usedDepth;
166		}
167
168		/**
169		* Get remaining weight inside box for another item
170		* @return int
171		*/
172	1	public function getRemainingWeight()
173		{
174	1	return $this->remainingWeight;
175		}
176
177		/**
178		* Get volume utilisation of the packed box
179		* @return float
180		*/
181	1	public function getVolumeUtilisation()
182		{
183	1	$itemVolume = 0;
184
185		/** @var Item $item */
186	1	foreach (clone $this->items as $item) {
187	1	$itemVolume += $item->getVolume();
188	1	}
189
190	1	return round($itemVolume / $this->box->getInnerVolume() * 100, 1);
191		}
192
193
194		/**
195		* Constructor
196		*
197		* @param Box $box
198		* @param ItemList $itemList
199		* @param int $remainingWidth
200		* @param int $remainingLength
201		* @param int $remainingDepth
202		* @param int $remainingWeight
203		* @param int $usedWidth
204		* @param int $usedLength
205		* @param int $usedDepth
206		*/
207	31	public function __construct(
208		Box $box,
209		ItemList $itemList,
210		$remainingWidth,
211		$remainingLength,
212		$remainingDepth,
213		$remainingWeight,
214		$usedWidth,
215		$usedLength,
216		$usedDepth
217		)
218		{
219	31	$this->box = $box;
220	31	$this->items = $itemList;
221	31	$this->remainingWidth = $remainingWidth;
222	31	$this->remainingLength = $remainingLength;
223	31	$this->remainingDepth = $remainingDepth;
224	31	$this->remainingWeight = $remainingWeight;
225	31	$this->usedWidth = $usedWidth;
226	31	$this->usedLength = $usedLength;
227	31	$this->usedDepth = $usedDepth;
228	31	}
229		}
230

dvdoug / BoxPacker

Push — master ( 349d65...0b9f3a )

PackedBox::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like