PackedBoxListTest::testVolumeUtilisation() - Code Metrics - Inspection of "Match folder structure of v3" - dvdoug/BoxPacker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.x-dev ( 55a3c1...c10cce )

by Doug

created 2018-01-01 15:51 UTC

PackedBoxListTest::testVolumeUtilisation() A

↳ Parent: PackedBoxListTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	9

Duplication

Lines	15
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	15
loc	15
rs	9.4285
c	1
b	0
f	0
cc	1
eloc	9
nc	1
nop	0

<?php
/**
 * Box packing (3D bin packing, knapsack problem)
 * @package BoxPacker
 * @author Doug Wright
 */

namespace DVDoug\BoxPacker;

use DVDoug\BoxPacker\Test\TestBox;
use DVDoug\BoxPacker\Test\TestItem;
use PHPUnit\Framework\TestCase;

class PackedBoxListTest extends TestCase
{
    function testVolumeUtilisation()

    {
        $box = new TestBox('Box', 10, 10, 10, 10, 10, 10, 10, 10);
        $item = new TestItem('Item', 5, 10, 10, 10, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $boxItems = new ItemList();
        $boxItems->insert($item);

        $packedBox = new PackedBox($box, $boxItems, 1, 2, 3, 4, 0, 0, 0);

        $packedBoxList = new PackedBoxList();
        $packedBoxList->insert($packedBox);

        self::assertEquals(50, $packedBoxList->getVolumeUtilisation());
    }

    function testWeightVariance()

    {
        $box = new TestBox('Box', 10, 10, 10, 10, 10, 10, 10, 10);
        $item = new TestItem('Item', 5, 10, 10, 10, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $boxItems = new ItemList();
        $boxItems->insert($item);

        $packedBox = new PackedBox($box, $boxItems, 1, 2, 3, 4, 0, 0, 0);

        $packedBoxList = new PackedBoxList();
        $packedBoxList->insert($packedBox);

        self::assertEquals(0, $packedBoxList->getWeightVariance());
    }
}


1		<?php
2		/**
3		* Box packing (3D bin packing, knapsack problem)
4		* @package BoxPacker
5		* @author Doug Wright
6		*/
7
8		namespace DVDoug\BoxPacker;
9
10		use DVDoug\BoxPacker\Test\TestBox;
11		use DVDoug\BoxPacker\Test\TestItem;
12		use PHPUnit\Framework\TestCase;
13
14		class PackedBoxListTest extends TestCase
15		{
16	View Code Duplication	function testVolumeUtilisation()
		0 ignored issues – show Best Practice introduced 2018-01-01 16:25 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Duplication introduced 2018-01-01 16:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17		{
18		$box = new TestBox('Box', 10, 10, 10, 10, 10, 10, 10, 10);
19		$item = new TestItem('Item', 5, 10, 10, 10, true);
		0 ignored issues – show Documentation introduced 2018-01-01 16:25 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
20
21		$boxItems = new ItemList();
22		$boxItems->insert($item);
23
24		$packedBox = new PackedBox($box, $boxItems, 1, 2, 3, 4, 0, 0, 0);
25
26		$packedBoxList = new PackedBoxList();
27		$packedBoxList->insert($packedBox);
28
29		self::assertEquals(50, $packedBoxList->getVolumeUtilisation());
30		}
31
32	View Code Duplication	function testWeightVariance()
		0 ignored issues – show Best Practice introduced 2018-01-01 16:25 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Duplication introduced 2018-01-01 16:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		{
34		$box = new TestBox('Box', 10, 10, 10, 10, 10, 10, 10, 10);
35		$item = new TestItem('Item', 5, 10, 10, 10, true);
		0 ignored issues – show Documentation introduced 2018-01-01 16:25 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36
37		$boxItems = new ItemList();
38		$boxItems->insert($item);
39
40		$packedBox = new PackedBox($box, $boxItems, 1, 2, 3, 4, 0, 0, 0);
41
42		$packedBoxList = new PackedBoxList();
43		$packedBoxList->insert($packedBox);
44
45		self::assertEquals(0, $packedBoxList->getWeightVariance());
46		}
47		}
48

dvdoug / BoxPacker

Push — 2.x-dev ( 55a3c1...c10cce )

PackedBoxListTest::testVolumeUtilisation() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like