TestItem - Code Metrics - Inspection of "Match folder structure of v3" - dvdoug/BoxPacker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.x-dev ( 55a3c1...c10cce )

by Doug

created 2018-01-01 15:51 UTC

TestItem A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	116
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	8
lcom	0
cbo	0
dl	0
loc	116
rs	10
c	1
b	0
f	0

8 Methods

Rating	Name	Size	Complexity
A	__construct()	11	1
A	getDescription()	4	1
A	getWidth()	4	1
A	getLength()	4	1
A	getDepth()	4	1
A	getWeight()	4	1
A	getVolume()	4	1
A	getKeepFlat()	4	1

<?php
/**
 * Box packing (3D bin packing, knapsack problem)
 * @package BoxPacker
 * @author Doug Wright
 */

namespace DVDoug\BoxPacker\Test;

use DVDoug\BoxPacker\Item;

class TestItem implements Item
{

    /**
     * @var string
     */
    private $description;

    /**
     * @var int
     */
    private $width;

    /**
     * @var int
     */
    private $length;

    /**
     * @var int
     */
    private $depth;

    /**
     * @var int
     */
    private $weight;

    /**
     * @var int
     */
    private $keepFlat;

    /**
     * @var int
     */
    private $volume;

    /**
     * TestItem constructor.
     *
     * @param string $description
     * @param int $width
     * @param int $length
     * @param int $depth
     * @param int $weight
     * @param int $keepFlat
     */
    public function __construct($description, $width, $length, $depth, $weight, $keepFlat)
    {
        $this->description = $description;
        $this->width = $width;
        $this->length = $length;
        $this->depth = $depth;
        $this->weight = $weight;
        $this->keepFlat = $keepFlat;

        $this->volume = $this->width * $this->length * $this->depth;
    }

    /**
     * @return string
     */
    public function getDescription()
    {
        return $this->description;
    }

    /**
     * @return int
     */
    public function getWidth()
    {
        return $this->width;
    }

    /**
     * @return int
     */
    public function getLength()
    {
        return $this->length;
    }

    /**
     * @return int
     */
    public function getDepth()
    {
        return $this->depth;
    }

    /**
     * @return int
     */
    public function getWeight()
    {
        return $this->weight;
    }

    /**
     * @return int
     */
    public function getVolume()
    {
        return $this->volume;
    }

    /**
     * @return int
     */
    public function getKeepFlat()
    {
        return $this->keepFlat;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}




1			<?php
2			/**
3			* Box packing (3D bin packing, knapsack problem)
4			* @package BoxPacker
5			* @author Doug Wright
6			*/
7
8			namespace DVDoug\BoxPacker\Test;
9
10			use DVDoug\BoxPacker\Item;
11
12			class TestItem implements Item
13			{
14
15			/**
16			* @var string
17			*/
18			private $description;
19
20			/**
21			* @var int
22			*/
23			private $width;
24
25			/**
26			* @var int
27			*/
28			private $length;
29
30			/**
31			* @var int
32			*/
33			private $depth;
34
35			/**
36			* @var int
37			*/
38			private $weight;
39
40			/**
41			* @var int
42			*/
43			private $keepFlat;
44
45			/**
46			* @var int
47			*/
48			private $volume;
49
50			/**
51			* TestItem constructor.
52			*
53			* @param string $description
54			* @param int $width
55			* @param int $length
56			* @param int $depth
57			* @param int $weight
58			* @param int $keepFlat
59			*/
60			public function __construct($description, $width, $length, $depth, $weight, $keepFlat)
61			{
62			$this->description = $description;
63			$this->width = $width;
64			$this->length = $length;
65			$this->depth = $depth;
66			$this->weight = $weight;
67			$this->keepFlat = $keepFlat;
68
69			$this->volume = $this->width * $this->length * $this->depth;
70			}
71
72			/**
73			* @return string
74			*/
75			public function getDescription()
76			{
77			return $this->description;
78			}
79
80			/**
81			* @return int
82			*/
83			public function getWidth()
84			{
85			return $this->width;
86			}
87
88			/**
89			* @return int
90			*/
91			public function getLength()
92			{
93			return $this->length;
94			}
95
96			/**
97			* @return int
98			*/
99			public function getDepth()
100			{
101			return $this->depth;
102			}
103
104			/**
105			* @return int
106			*/
107			public function getWeight()
108			{
109			return $this->weight;
110			}
111
112			/**
113			* @return int
114			*/
115			public function getVolume()
116			{
117			return $this->volume;
118			}
119
120			/**
121			* @return int
122			*/
123			public function getKeepFlat()
124			{
125			return $this->keepFlat;
			0 ignored issues – show Bug Best Practice introduced 2018-01-01 16:25 UTC by Report Bug Copy Issue Report The return type of `return $this->keepFlat;` (`integer`) is incompatible with the return type declared by the interface `DVDoug\BoxPacker\Item::getKeepFlat` of type `boolean`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
126			}
127			}
128
129
130

dvdoug / BoxPacker

Push — 2.x-dev ( 55a3c1...c10cce )

TestItem A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Duplication Side-by-Side

Filter issues like