PackerTest - Code Metrics - Inspection of "Match folder structure of v3" - dvdoug/BoxPacker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.x-dev ( 55a3c1...c10cce )

by Doug

created 2018-01-01 15:51 UTC

PackerTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	578
Duplicated Lines	36.33 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	17
Bugs	4	Features	0

Metric	Value
wmc	35
lcom	1
cbo	5
dl	210
loc	578
rs	9
c	17
b	4
f	0

27 Methods

Rating	Name	Duplication	Size	Complexity
A	testPackThreeItemsFitEasilyInSmallerOfTwoBoxes()	23	23	1
A	testPackThreeItemsFitEasilyInLargerOfTwoBoxes()	23	23	1
B	testPackFiveItemsTwoLargeOneSmallBox()	40	40	1
B	testPackFiveItemsTwoLargeOneSmallBoxButThreeAfterRepack()	40	40	1
A	testPackThreeItemsOneDoesntFitInAnyBox()	0	18	1
A	testPackWithoutBox()	0	13	1
A	testIssue1()	0	12	1
A	testIssue3()	0	11	1
A	testIssue6()	0	14	1
A	testIssue9()	10	10	1
A	testIssue11()	11	11	1
A	testIssue13()	0	12	1
A	testIssue14()	0	12	1
A	testIssue47A()	9	9	1
A	testIssue47B()	9	9	1
A	testIssue47C()	9	9	1
A	testIssue47D()	9	9	1
B	testPackerPacksRotatedBoxesInNewRow()	0	33	1
A	testIssue52A()	0	12	1
A	testIssue52B()	0	15	1
A	testIssue52C()	0	21	1
A	testIssue79()	0	16	1
A	testCanSetMaxBoxesToWeightBalance()	0	6	1
A	testWeightRedistributionActivatesUnderLimit()	13	13	1
A	testWeightRedistributionDoesNotActivateOverLimit()	14	14	1
B	testCanPackRepresentativeLargerSamples()	0	67	5
B	getSamples()	0	66	5

How to fix Duplicated Code

<?php
/**
 * Box packing (3D bin packing, knapsack problem)
 * @package BoxPacker
 * @author Doug Wright
 */

namespace DVDoug\BoxPacker;

use DVDoug\BoxPacker\Test\TestBox;
use DVDoug\BoxPacker\Test\TestItem;
use PHPUnit\Framework\TestCase;

class PackerTest extends TestCase
{
    public function testPackThreeItemsFitEasilyInSmallerOfTwoBoxes()

    {

        $box1 = new TestBox('Le petite box', 300, 300, 10, 10, 296, 296, 8, 1000);
        $box2 = new TestBox('Le grande box', 3000, 3000, 100, 100, 2960, 2960, 80, 10000);

        $item1 = new TestItem('Item 1', 250, 250, 2, 200, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item2 = new TestItem('Item 2', 250, 250, 2, 200, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item3 = new TestItem('Item 3', 250, 250, 2, 200, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $packer = new Packer();
        $packer->addBox($box1);
        $packer->addBox($box2);
        $packer->addItem($item1);
        $packer->addItem($item2);
        $packer->addItem($item3);
        $packedBoxes = $packer->pack();

        self::assertEquals(1, $packedBoxes->count());
        self::assertEquals(3, $packedBoxes->top()->getItems()->count());
        self::assertEquals($box1, $packedBoxes->top()->getBox());
        self::assertEquals(610, $packedBoxes->top()->getWeight());
    }

    public function testPackThreeItemsFitEasilyInLargerOfTwoBoxes()

    {

        $box1 = new TestBox('Le petite box', 300, 300, 10, 10, 296, 296, 8, 1000);
        $box2 = new TestBox('Le grande box', 3000, 3000, 100, 100, 2960, 2960, 80, 10000);

        $item1 = new TestItem('Item 1', 2500, 2500, 20, 2000, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item2 = new TestItem('Item 2', 2500, 2500, 20, 2000, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item3 = new TestItem('Item 3', 2500, 2500, 20, 2000, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $packer = new Packer();
        $packer->addBox($box1);
        $packer->addBox($box2);
        $packer->addItem($item1);
        $packer->addItem($item2);
        $packer->addItem($item3);
        $packedBoxes = $packer->pack();

        self::assertEquals(1, $packedBoxes->count());
        self::assertEquals(3, $packedBoxes->top()->getItems()->count());
        self::assertEquals($box2, $packedBoxes->top()->getBox());
        self::assertEquals(6100, $packedBoxes->top()->getWeight());
    }

    public function testPackFiveItemsTwoLargeOneSmallBox()

    {

        $box1 = new TestBox('Le petite box', 600, 600, 10, 10, 596, 596, 8, 1000);
        $box2 = new TestBox('Le grande box', 3000, 3000, 50, 100, 2960, 2960, 40, 10000);

        $item1 = new TestItem('Item 1', 2500, 2500, 20, 500, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item2 = new TestItem('Item 2', 550, 550, 2, 500, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item3 = new TestItem('Item 3', 2500, 2500, 20, 500, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item4 = new TestItem('Item 4', 2500, 2500, 20, 500, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item5 = new TestItem('Item 5', 2500, 2500, 20, 500, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $packer = new Packer();
        $packer->addBox($box1);
        $packer->addBox($box2);
        $packer->addItem($item1);
        $packer->addItem($item2);
        $packer->addItem($item3);
        $packer->addItem($item4);
        $packer->addItem($item5);
        $packedBoxes = $packer->pack();

        self::assertEquals(3, $packedBoxes->count());

        self::assertEquals(2, $packedBoxes->top()->getItems()->count());
        self::assertEquals($box2, $packedBoxes->top()->getBox());
        self::assertEquals(1100, $packedBoxes->top()->getWeight());

        $packedBoxes->extract();

        self::assertEquals(2, $packedBoxes->top()->getItems()->count());
        self::assertEquals($box2, $packedBoxes->top()->getBox());
        self::assertEquals(1100, $packedBoxes->top()->getWeight());

        $packedBoxes->extract();

        self::assertEquals(1, $packedBoxes->top()->getItems()->count());
        self::assertEquals($box1, $packedBoxes->top()->getBox());
        self::assertEquals(510, $packedBoxes->top()->getWeight());
    }

    public function testPackFiveItemsTwoLargeOneSmallBoxButThreeAfterRepack()

    {

        $box1 = new TestBox('Le petite box', 600, 600, 10, 10, 596, 596, 8, 1000);
        $box2 = new TestBox('Le grande box', 3000, 3000, 50, 100, 2960, 2960, 40, 10000);

        $item1 = new TestItem('Item 1', 2500, 2500, 20, 2000, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item2 = new TestItem('Item 2', 550, 550, 2, 200, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item3 = new TestItem('Item 3', 2500, 2500, 20, 2000, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item4 = new TestItem('Item 4', 2500, 2500, 20, 2000, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item5 = new TestItem('Item 5', 2500, 2500, 20, 2000, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $packer = new Packer();
        $packer->addBox($box1);
        $packer->addBox($box2);
        $packer->addItem($item1);
        $packer->addItem($item2);
        $packer->addItem($item3);
        $packer->addItem($item4);
        $packer->addItem($item5);
        $packedBoxes = $packer->pack();

        self::assertEquals(3, $packedBoxes->count());

        self::assertEquals(2, $packedBoxes->top()->getItems()->count());
        self::assertEquals($box2, $packedBoxes->top()->getBox());
        self::assertEquals(4100, $packedBoxes->top()->getWeight());

        $packedBoxes->extract();

        self::assertEquals(2, $packedBoxes->top()->getItems()->count());
        self::assertEquals($box2, $packedBoxes->top()->getBox());
        self::assertEquals(2300, $packedBoxes->top()->getWeight());

        $packedBoxes->extract();

        self::assertEquals(1, $packedBoxes->top()->getItems()->count());
        self::assertEquals($box2, $packedBoxes->top()->getBox());
        self::assertEquals(2100, $packedBoxes->top()->getWeight());
    }

    /**
     * @expectedException \DVDoug\BoxPacker\ItemTooLargeException
     */
    public function testPackThreeItemsOneDoesntFitInAnyBox()
    {

        $box1 = new TestBox('Le petite box', 300, 300, 10, 10, 296, 296, 8, 1000);
        $box2 = new TestBox('Le grande box', 3000, 3000, 100, 100, 2960, 2960, 80, 10000);

        $item1 = new TestItem('Item 1', 2500, 2500, 20, 2000, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item2 = new TestItem('Item 2', 25000, 2500, 20, 2000, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item3 = new TestItem('Item 3', 2500, 2500, 20, 2000, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $packer = new Packer();
        $packer->addBox($box1);
        $packer->addBox($box2);
        $packer->addItem($item1);
        $packer->addItem($item2);
        $packer->addItem($item3);
        $packedBoxes = $packer->pack();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    /**
     * @expectedException \DVDoug\BoxPacker\ItemTooLargeException
     */
    public function testPackWithoutBox()
    {

        $item1 = new TestItem('Item 1', 2500, 2500, 20, 2000, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item2 = new TestItem('Item 2', 25000, 2500, 20, 2000, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item3 = new TestItem('Item 3', 2500, 2500, 20, 2000, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $packer = new Packer();
        $packer->addItem($item1);
        $packer->addItem($item2);
        $packer->addItem($item3);
        $packedBoxes = $packer->pack();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function testIssue1()
    {

        $packer = new Packer();
        $packer->addBox(new TestBox('Le petite box', 292, 336, 60, 10, 292, 336, 60, 9000));
        $packer->addBox(new TestBox('Le grande box', 421, 548, 335, 100, 421, 548, 335, 10000));
        $packer->addItem(new TestItem('Item 1', 226, 200, 40, 440, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('Item 2', 200, 200, 155, 1660, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();

        self::assertEquals(1, $packedBoxes->count());
    }

    public function testIssue3()
    {

        $packer = new Packer();
        $packer->addBox(new TestBox('OW Box 1', 51, 33, 33, 0.6, 51, 33, 33, 0.6));
        $packer->addBox(new TestBox('OW Box 2', 50, 40, 40, 0.95, 50, 40, 40, 0.95));
        $packer->addItem(new TestItem('Product', 28, 19, 9, 0, true), 6);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();

        self::assertEquals(1, $packedBoxes->count());
    }

    public function testIssue6()
    {

        $packer = new Packer();
        $packer->addBox(new TestBox('Package 22', 675, 360, 210, 2, 670, 355, 204, 1000));
        $packer->addBox(new TestBox('Package 2', 330, 130, 102, 2, 335, 135, 107, 1000));
        $packer->addItem(new TestItem('Item 3', 355.6, 335.28, 127, 1.5, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('Item 7', 330.2, 127, 101.6, 1, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('Item 7', 330.2, 127, 101.6, 1, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();

        self::assertEquals(1, $packedBoxes->count());

    }

    public function testIssue9()

    {
        $packer = new Packer();
        $packer->addBox(new TestBox('24x24x24Box', 24, 24, 24, 24, 24, 24, 24, 100));

        $packer->addItem(new TestItem('6x6x6Item', 6, 6, 6, 1, true), 64);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();

        self::assertEquals(1, $packedBoxes->count());
    }

    public function testIssue11()

    {
        $packer = new Packer();
        $packer->addBox(new TestBox('4x4x4Box', 4, 4, 4, 4, 4, 4, 4, 100));

        $packer->addItem(new TestItem('BigItem', 2, 2, 4, 1, true), 2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('SmallItem', 1, 1, 1, 1, true), 32);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();

        self::assertEquals(1, $packedBoxes->count());
    }

    public function testIssue13()
    {
        $packer = new Packer();
        $packer->addBox(new TestBox('Le petite box', 12, 12, 12, 10, 10, 10, 10, 1000));

        $packer->addItem(new TestItem('Item 1', 5, 3, 2, 2, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('Item 2', 5, 3, 2, 2, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('Item 3', 3, 3, 3, 3, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();

        self::assertEquals(1, $packedBoxes->count());
    }

    public function testIssue14()
    {
        $packer = new Packer();
        $packer->addBox(new TestBox('29x1x23Box', 29, 1, 23, 0, 29, 1, 23, 100));
        $packer->addItem(new TestItem('13x1x10Item', 13, 1, 10, 1, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('9x1x6Item', 9, 1, 6, 1, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('9x1x6Item', 9, 1, 6, 1, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('9x1x6Item', 9, 1, 6, 1, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();

        self::assertEquals(1, $packedBoxes->count());
    }

    public function testIssue47A()

    {
        $packer = new Packer();
        $packer->addBox(new TestBox('165x225x25Box', 165, 225, 25, 0, 165, 225, 25, 100));
        $packer->addItem(new TestItem('20x69x20Item', 20, 69, 20, 0, true), 23);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();

        self::assertEquals(1, $packedBoxes->count());
    }

    public function testIssue47B()

    {
        $packer = new Packer();
        $packer->addBox(new TestBox('165x225x25Box', 165, 225, 25, 0, 165, 225, 25, 100));
        $packer->addItem(new TestItem('20x69x20Item', 69, 20, 20, 0, true), 23);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();

        self::assertEquals(1, $packedBoxes->count());
    }

    public function testIssue47C()

    {
        $packer = new Packer();
        $packer->addBox(new TestBox('Box', 11.75, 23.6875, 3, 0, 11.75, 23.6875, 3, 70));
        $packer->addItem(new TestItem('Item', 3.75, 6.5, 3, 0, true), 9);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();

        self::assertEquals(1, $packedBoxes->count());
    }

    public function testIssue47D()

    {
        $packer = new Packer();
        $packer->addBox(new TestBox('Box', 11.75, 23.6875, 3, 0, 11.75, 23.6875, 3, 70));
        $packer->addItem(new TestItem('Item', 6.5, 3.75, 3, 0, true), 9);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();

        self::assertEquals(1, $packedBoxes->count());
    }

    public function testPackerPacksRotatedBoxesInNewRow()
    {
        $packer = new Packer();
        $packer->addItem(new TestItem('30x10x30item', 30, 10, 30, 0, true), 9);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        //Box can hold 7 items in a row and then is completely full, so 9 items won't fit
        $packer->addBox(new TestBox('30x70x30InternalBox', 30, 70, 30, 0, 30, 70, 30, 0, 1000));

        $packedBoxes = $packer->pack();
        self::assertEquals(2, $packedBoxes->count());

        //Box can hold 7 items in a row, plus two more rotated, making 9 items
        // with a 10x10x30 hole in the corner.
        //
        // Overhead view:
        //
        // +--+--++
        // ++++++++
        // ||||||||
        // ++++++++
        //
        $packer = new Packer();
        $packer->addItem(new TestItem('30x10x30item', 30, 10, 30, 0, true), 9);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addBox(new TestBox('40x70x30InternalBox', 40, 70, 30, 0, 40, 70, 30, 0, 1000));

        $packedBoxes = $packer->pack();
        self::assertEquals(1, $packedBoxes->count());

        // Make sure that it doesn't try to fit in a 10th item
        $packer = new Packer();
        $packer->addItem(new TestItem('30x10x30item', 30, 10, 30, 0, true), 10);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addBox(new TestBox('40x70x30InternalBox', 40, 70, 30, 0, 40, 70, 30, 0, 1000));

        $packedBoxes = $packer->pack();
        self::assertEquals(2, $packedBoxes->count());
    }

    public function testIssue52A()
    {
        $packer = new Packer();
        $packer->addBox(new TestBox('Box', 100, 50, 50, 0, 100, 50, 50, 5000));
        $packer->addItem(new TestItem('Item', 15, 13, 8, 407, true), 2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();

        self::assertEquals(1, $packedBoxes->count());
        self::assertEquals(26, $packedBoxes->top()->getUsedWidth());
        self::assertEquals(15, $packedBoxes->top()->getUsedLength());
        self::assertEquals(8, $packedBoxes->top()->getUsedDepth());
    }

    public function testIssue52B()
    {
        $packer = new Packer();
        $packer->addBox(new TestBox('Box',370,375,60,140,364,374,40,3000));
        $packer->addItem(new TestItem('Item 1',220,310,12,679, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('Item 2',210,297,11,648, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('Item 3',210,297,5,187, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('Item 4',148,210,32,880, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();

        self::assertEquals(1, $packedBoxes->count());
        self::assertEquals(310, $packedBoxes->top()->getUsedWidth());
        self::assertEquals(368, $packedBoxes->top()->getUsedLength());
        self::assertEquals(32, $packedBoxes->top()->getUsedDepth());
    }

    public function testIssue52C()
    {
        $packer = new Packer();
        $packer->addBox(new TestBox('Box',230,300,240,160,230,300,240,15000));
        $packer->addItem(new TestItem('Item 1',210,297,4,213, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('Item 2',80,285,70,199, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('Item 3',80,285,70,199, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();

        self::assertEquals(2, $packedBoxes->count());
        $box1 = $packedBoxes->extract();
        $box2 = $packedBoxes->extract();

        self::assertEquals(160, $box1->getUsedWidth());
        self::assertEquals(285, $box1->getUsedLength());
        self::assertEquals(70, $box1->getUsedDepth());

        self::assertEquals(210, $box2->getUsedWidth());
        self::assertEquals(297, $box2->getUsedLength());
        self::assertEquals(4, $box2->getUsedDepth());
    }

    public function testIssue79()
    {
        $packer = new Packer();
        $packer->addBox(new TestBox('Bundle', 75, 15, 15, 0, 75, 15, 15, 30));
        $packer->addItem(new TestItem('Item 1', 14, 12, 2, 2, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('Item 2', 14, 12, 2, 2, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('Item 3', 14, 12, 2, 2, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('Item 4', 14, 12, 2, 2, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->addItem(new TestItem('Item 5', 14, 12, 2, 2, true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();
        $box = $packedBoxes->extract();

        self::assertEquals(60, $box->getUsedWidth());
        self::assertEquals(14, $box->getUsedLength());
        self::assertEquals(2, $box->getUsedDepth());
    }

    public function testCanSetMaxBoxesToWeightBalance()
    {
        $packer = new Packer();
        $packer->setMaxBoxesToBalanceWeight(3);
        self::assertEquals(3, $packer->getMaxBoxesToBalanceWeight());
    }

    public function testWeightRedistributionActivatesUnderLimit()

    {
        $packer = new Packer();
        $packer->addBox(new TestBox('Box', 1, 1, 3, 0, 1, 1, 3, 3));
        $packer->addItem(new TestItem('Item', 1, 1, 1, 1, false), 4);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packedBoxes = $packer->pack();

        $box1 = $packedBoxes->extract();
        $box2 = $packedBoxes->extract();

        self::assertEquals(2, $box1->getItems()->count());
        self::assertEquals(2, $box2->getItems()->count());
    }

    public function testWeightRedistributionDoesNotActivateOverLimit()

    {
        $packer = new Packer();
        $packer->addBox(new TestBox('Box', 1, 1, 3, 0, 1, 1, 3, 3));
        $packer->addItem(new TestItem('Item', 1, 1, 1, 1, false), 4);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $packer->setMaxBoxesToBalanceWeight(1);
        $packedBoxes = $packer->pack();

        $box1 = $packedBoxes->extract();
        $box2 = $packedBoxes->extract();

        self::assertEquals(3, $box1->getItems()->count());
        self::assertEquals(1, $box2->getItems()->count());
    }

    /**
     * @dataProvider getSamples
     * @coversNothing
     */
    public function testCanPackRepresentativeLargerSamples(
        $test,

        $boxes,
        $items,
        $expectedBoxes2D,
        $expectedBoxes3D,
        $expectedWeightVariance2D,
        $expectedWeightVariance3D
    ) {
        $expectedItemCount = 0;

        $packer2D = new Packer();
        $packer3D = new Packer();

        foreach ($boxes as $box) {
            $packer2D->addBox($box);
            $packer3D->addBox($box);
        }
        foreach ($items as $item) {
            $expectedItemCount += $item['qty'];

            $packer2D->addItem(
                new TestItem(
                    $item['name'],
                    $item['width'],
                    $item['length'],
                    $item['depth'],
                    $item['weight'],
                    true
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                ),
                $item['qty']
            );

            $packer3D->addItem(
                new TestItem(
                    $item['name'],
                    $item['width'],
                    $item['length'],
                    $item['depth'],
                    $item['weight'],
                    false
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                ),
                $item['qty']
            );
        }
        $packedBoxes2D = $packer2D->pack();
        $packedBoxes3D = $packer3D->pack();

        $packedItemCount2D = 0;
        foreach (clone $packedBoxes2D as $packedBox) {
            $packedItemCount2D += $packedBox->getItems()->count();
        }

        $packedItemCount3D = 0;
        foreach (clone $packedBoxes3D as $packedBox) {
            $packedItemCount3D += $packedBox->getItems()->count();
        }


        self::assertEquals($expectedBoxes2D, $packedBoxes2D->count());
        self::assertEquals($expectedItemCount, $packedItemCount2D);
        self::assertEquals($expectedWeightVariance2D, (int)$packedBoxes2D->getWeightVariance());

        self::assertEquals($expectedBoxes3D, $packedBoxes3D->count());
        self::assertEquals($expectedItemCount, $packedItemCount3D);
        self::assertEquals($expectedWeightVariance3D, (int)$packedBoxes3D->getWeightVariance());
    }

    public function getSamples()
    {
        $expected = ['2D' => [], '3D' => []];

        $expected2DData = fopen(__DIR__ . '/data/expected.csv', 'r');
        while ($data = fgetcsv($expected2DData)) {
            $expected['2D'][$data[0]] = array('boxes' => $data[1], 'weightVariance' => $data[2]);
            $expected['3D'][$data[0]] = array('boxes' => $data[3], 'weightVariance' => $data[4]);
        }
        fclose($expected2DData);

        $boxes = [];
        $boxData = fopen(__DIR__ . '/data/boxes.csv', 'r');
        while ($data = fgetcsv($boxData)) {
            $boxes[] = new TestBox(
                $data[0],
                $data[1],
                $data[2],
                $data[3],
                $data[4],
                $data[5],
                $data[6],
                $data[7],
                $data[8]
            );
        }
        fclose($boxData);

        $tests = [];
        $itemData = fopen(__DIR__ . '/data/items.csv', 'r');
        while ($data = fgetcsv($itemData)) {

            if (isset($tests[$data[0]])) {
                $tests[$data[0]]['items'][] = array(
                    'qty' => $data[1],
                    'name' => $data[2],
                    'width' => $data[3],
                    'length' => $data[4],
                    'depth' => $data[5],
                    'weight' => $data[6]
                );
            } else {
                $tests[$data[0]] = array(
                    'test' => $data[0],
                    'boxes' => $boxes,
                    'items' => array(
                        array(
                            'qty' => $data[1],
                            'name' => $data[2],
                            'width' => $data[3],
                            'length' => $data[4],
                            'depth' => $data[5],
                            'weight' => $data[6]
                        )
                    ),
                    'expected2D' => $expected['2D'][$data[0]]['boxes'],
                    'expected3D' => $expected['3D'][$data[0]]['boxes'],
                    'weightVariance2D' => $expected['2D'][$data[0]]['weightVariance'],
                    'weightVariance3D' => $expected['3D'][$data[0]]['weightVariance']
                );
            }
        }
        fclose($itemData);

        return $tests;
    }

}


1		<?php
2		/**
3		* Box packing (3D bin packing, knapsack problem)
4		* @package BoxPacker
5		* @author Doug Wright
6		*/
7
8		namespace DVDoug\BoxPacker;
9
10		use DVDoug\BoxPacker\Test\TestBox;
11		use DVDoug\BoxPacker\Test\TestItem;
12		use PHPUnit\Framework\TestCase;
13
14		class PackerTest extends TestCase
15		{
16	View Code Duplication	public function testPackThreeItemsFitEasilyInSmallerOfTwoBoxes()
		0 ignored issues – show Duplication introduced 2018-01-01 16:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17		{
18
19		$box1 = new TestBox('Le petite box', 300, 300, 10, 10, 296, 296, 8, 1000);
20		$box2 = new TestBox('Le grande box', 3000, 3000, 100, 100, 2960, 2960, 80, 10000);
21
22		$item1 = new TestItem('Item 1', 250, 250, 2, 200, true);
		0 ignored issues – show Documentation introduced 2018-01-01 16:25 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
23		$item2 = new TestItem('Item 2', 250, 250, 2, 200, true);
		0 ignored issues – show Documentation introduced 2018-01-01 16:25 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
24		$item3 = new TestItem('Item 3', 250, 250, 2, 200, true);
		0 ignored issues – show Documentation introduced 2018-01-01 16:25 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
25
26		$packer = new Packer();
27		$packer->addBox($box1);
28		$packer->addBox($box2);
29		$packer->addItem($item1);
30		$packer->addItem($item2);
31		$packer->addItem($item3);
32		$packedBoxes = $packer->pack();
33
34		self::assertEquals(1, $packedBoxes->count());
35		self::assertEquals(3, $packedBoxes->top()->getItems()->count());
36		self::assertEquals($box1, $packedBoxes->top()->getBox());

dvdoug / BoxPacker

Push — 2.x-dev ( 55a3c1...c10cce )

PackerTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

27 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like