Issues in Blueprint.php (master) - Issues in master - duxet/laravel-rethinkdb - Measure and Improve Code Quality continuously with Scrutinizer

Issues (48)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Schema/Blueprint.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace duxet\RethinkDB\Schema;

use Illuminate\Database\Connection;
use Illuminate\Database\Schema\Grammars\Grammar;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use r;

class Blueprint extends \Illuminate\Database\Schema\Blueprint
{
    /**
     * Create a new schema blueprint.
     *
     * @param Connection $connection
     * @param string     $table
     */
    public function __construct(Connection $connection, $table)
    {
        $this->connection = $connection;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->table = $table;
    }

    /**
     * Execute the blueprint against the database.
     *
     * @param \Illuminate\Database\Connection              $connection
     * @param \Illuminate\Database\Schema\Grammars\Grammar $grammar
     *
     * @return void
     */
    public function build(Connection $connection, Grammar $grammar)
    {
    }

    /**
     * Indicate that the table needs to be created.
     *
     * @return bool
     */
    public function create()
    {
        $conn = $this->connection->getConnection();
        $db = r\db($this->connection->getDatabaseName());
        $db->tableCreate($this->table)->run($conn);
    }

    /**
     * Indicate that the collection should be dropped.
     *
     * @return bool
     */
    public function drop()
    {
        $conn = $this->connection->getConnection();
        $db = r\db($this->connection->getDatabaseName());
        $db->tableDrop($this->table)->run($conn);
    }

    /**
     * Specify an index for the collection.
     *
     * @param string $column
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param mixed  $options
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return Blueprint
     */
    public function index($columns, $name = NULL, $algorithm = NULL)

    {
        $conn = $this->connection->getConnection();
        $db = r\db($this->connection->getDatabaseName());
        $db->table($this->table)->indexCreate($column)

            ->run($conn);

        return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2
3			namespace duxet\RethinkDB\Schema;
4
5			use Illuminate\Database\Connection;
6			use Illuminate\Database\Schema\Grammars\Grammar;
			0 ignored issues – show Bug introduced 2017-11-11 12:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `duxet\RethinkDB\Schema\Grammar`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
7			use r;
8
9			class Blueprint extends \Illuminate\Database\Schema\Blueprint
10			{
11			/**
12			* Create a new schema blueprint.
13			*
14			* @param Connection $connection
15			* @param string $table
16			*/
17			public function __construct(Connection $connection, $table)
18			{
19			$this->connection = $connection;
			0 ignored issues – show Bug introduced 2015-11-28 11:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `connection` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20			$this->table = $table;
21			}
22
23			/**
24			* Execute the blueprint against the database.
25			*
26			* @param \Illuminate\Database\Connection $connection
27			* @param \Illuminate\Database\Schema\Grammars\Grammar $grammar
28			*
29			* @return void
30			*/
31			public function build(Connection $connection, Grammar $grammar)
32			{
33			}
34
35			/**
36			* Indicate that the table needs to be created.
37			*
38			* @return bool
39			*/
40			public function create()
41			{
42			$conn = $this->connection->getConnection();
43			$db = r\db($this->connection->getDatabaseName());
44			$db->tableCreate($this->table)->run($conn);
45			}
46
47			/**
48			* Indicate that the collection should be dropped.
49			*
50			* @return bool
51			*/
52			public function drop()
53			{
54			$conn = $this->connection->getConnection();
55			$db = r\db($this->connection->getDatabaseName());
56			$db->tableDrop($this->table)->run($conn);
57			}
58
59			/**
60			* Specify an index for the collection.
61			*
62			* @param string $column
			0 ignored issues – show Documentation introduced 2017-11-11 12:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$column`. Did you maybe mean `$columns`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
63			* @param mixed $options
			0 ignored issues – show Bug introduced 2017-11-11 12:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$options`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
64			*
65			* @return Blueprint
66			*/
67			public function index($columns, $name = NULL, $algorithm = NULL)
			0 ignored issues – show Unused Code introduced 2017-11-11 12:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$algorithm` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
68			{
69			$conn = $this->connection->getConnection();
70			$db = r\db($this->connection->getDatabaseName());
71			$db->table($this->table)->indexCreate($column)
			0 ignored issues – show Bug introduced 2017-11-11 12:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$column` does not exist. Did you mean `$columns`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
72			->run($conn);
73
74			return $this;
			0 ignored issues – show Bug Best Practice introduced 2015-11-28 11:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this;` (`duxet\RethinkDB\Schema\Blueprint`) is incompatible with the return type of the parent method `Illuminate\Database\Schema\Blueprint::index` of type `Illuminate\Support\Fluent`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
75			}
76			}
77

GitHub Access Token became invalid

Issues (48)

Security Analysis no request data

src/Schema/Blueprint.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

duxet / laravel-rethinkdb

GitHub Access Token became invalid

Issues (48)

Security Analysis no request data

src/Schema/Blueprint.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like