dukt / videos

src/services/Cache.php

<?php
/**
 * @link      https://dukt.net/videos/
 * @copyright Copyright (c) Dukt
 * @license   https://github.com/dukt/videos/blob/v2/LICENSE.md
 */

namespace dukt\videos\services;

use Craft;
use dukt\videos\Plugin as VideosPlugin;
use yii\base\Component;
use DateInterval;
use craft\helpers\DateTimeHelper;

/**
 * Class Cache service.
 *
 * An instance of the Cache service is globally accessible via [[Plugin::cache `VideosPlugin::$plugin->getCache()`]].
 *
 * @author Dukt <support@dukt.net>
 * @since  2.0
 */
class Cache extends Component
{
    // Public Methods
    // =========================================================================

    /**
     * Get cache.
     *
     * @param $id
     *
     * @return mixed
     */
    public function get(array $id)
    {
        $cacheKey = $this->getCacheKey($id);

        return Craft::$app->getCache()->get($cacheKey);
    }

    /**
     * Set cache.
     *
     * @param      $id
     * @param      $value
     * @param null $expire

Are you sure the doc-type for parameter $expire is correct as it would always require null to be passed?

     * @param null $dependency

Are you sure the doc-type for parameter $dependency is correct as it would always require null to be passed?

     * @param null $enableCache

Are you sure the doc-type for parameter $enableCache is correct as it would always require null to be passed?

     *
     * @return bool|null
     * @throws \Exception
     */
    public function set($id, $value, $expire = null, $dependency = null, $enableCache = null)
    {
        if (null === $enableCache) {

The condition null === $enableCache is always true.

            $enableCache = VideosPlugin::$plugin->getSettings()->cacheDuration;
        }

        if ($enableCache) {
            $cacheKey = $this->getCacheKey($id);

            if (!$expire) {

$expire is of type null, thus it always evaluated to false.

                $duration = VideosPlugin::$plugin->getSettings()->cacheDuration;
                $interval = new DateInterval($duration);
                $expire = DateTimeHelper::intervalToSeconds($interval);
            }

            return Craft::$app->cache->set($cacheKey, $value, $expire, $dependency);
        }

        return null;
    }

    // Private Methods
    // =========================================================================

    /**
     * Return the cache key
     *
     * @param array $request
     *
     * @return string
     */
    private function getCacheKey(array $request): string
    {
        unset($request['CRAFT_CSRF_TOKEN']);

        $hash = md5(serialize($request));

        return 'videos.' . $hash;
    }
}