dukt\videos\services\Tokens

Complexity

Total Complexity

11

Size/Duplication

Total Lines	102
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	saveToken()	0	45	7
A	getToken()	0	14	2
A	deleteTokenById()	0	11	2

<?php
/**
 * @link      https://dukt.net/videos/
 * @copyright Copyright (c) Dukt
 * @license   https://github.com/dukt/videos/blob/v2/LICENSE.md
 */

namespace dukt\videos\services;

use Craft;
use dukt\analytics\errors\InvalidViewException;

The type dukt\analytics\errors\InvalidViewException was not found. Maybe you did not declare it correctly or list all dependencies?

use dukt\videos\models\Token;
use dukt\videos\records\Token as TokenRecord;
use Exception;
use yii\base\Component;

/**
 * Class Tokens service.
 *
 * An instance of the Tokens service is globally accessible via [[Plugin::oauth `VideosPlugin::$plugin->getTokens()`]].
 *
 * @author Dukt <support@dukt.net>
 * @since  2.0
 */
class Tokens extends Component
{
    // Public Methods
    // =========================================================================

    /**
     * Get a token by its gateway handle.
     *
     * @param $gatewayHandle
     * @return Token|null
     */
    public function getToken($gatewayHandle): ?\dukt\videos\models\Token
    {
        $result = TokenRecord::find()
            ->where(['gateway' => $gatewayHandle])
            ->one();

        if (!$result) {
            return null;
        }

        return new Token($result->toArray([
            'id',
            'gateway',
            'accessToken',
        ]));
    }

    /**
     * Saves a token.
     *
     * @param Token $token
     * @param bool $runValidation
     * @return bool
     * @throws InvalidViewException
     */
    public function saveToken(Token $token, bool $runValidation = true): bool
    {
        if ($runValidation && !$token->validate()) {
            Craft::info('Token not saved due to validation error.', __METHOD__);

            return false;
        }

        if ($token->id) {

The expression $token->id of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            $tokenRecord = TokenRecord::find()
                ->where(['id' => $token->id])
                ->one();

            if (!$tokenRecord) {
                throw new InvalidViewException(sprintf('No token exists with the ID \'%s\'', $token->id));
            }

            $isNewToken = false;
        } else {
            $tokenRecord = new TokenRecord();
            $isNewToken = true;
        }

        $tokenRecord->gateway = $token->gateway;

The property gateway does not exist on dukt\videos\records\Token. Since you implemented __set, consider adding a @property annotation.

        $tokenRecord->accessToken = $token->accessToken;

The property accessToken does not exist on dukt\videos\records\Token. Since you implemented __set, consider adding a @property annotation.

        $transaction = Craft::$app->getDb()->beginTransaction();

        try {
            // Is the event giving us the go-ahead?
            $tokenRecord->save(false);

            // Now that we have a view ID, save it on the model
            if ($isNewToken) {
                $token->id = $tokenRecord->id;

The property id does not exist on dukt\videos\records\Token. Since you implemented __get, consider adding a @property annotation.

            }

            $transaction->commit();
        } catch (Exception $exception) {
            $transaction->rollBack();

            throw $exception;
        }

        return true;
    }

    /**
     * Deletes a token.
     *
     * @param int $id
     * @return bool
     * @throws \Throwable
     * @throws \yii\db\StaleObjectException
     */
    public function deleteTokenById(int $id): bool
    {
        $tokenRecord = TokenRecord::findOne($id);

        if (!$tokenRecord instanceof \dukt\videos\records\Token) {
            return true;
        }

        $tokenRecord->delete();

        return true;
    }
}