dukt\twitter\controllers\FieldsController::actionTweetFieldPreview()

Complexity

Conditions	5
Paths	13

Size

Total Lines	32
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function actionTweetFieldPreview(): Response
    {
        $tweetId = Craft::$app->getRequest()->getParam('id');

        try {
            $tweet = Plugin::getInstance()->getApi()->getTweet($tweetId);

It seems like $tweetId can also be of type array; however, parameter $urlOrId of dukt\twitter\services\Api::getTweet() does only seem to accept integer|string, maybe add an additional type check?

            if (!$tweet) {
                throw new InvalidTweetException('No status found with that ID.');
            }

            $html = Craft::$app->getView()->renderTemplate('twitter/_components/tweet', [
                'tweet' => $tweet
            ]);

            return $this->asJson([
                'html' => $html,
            ]);
        } catch (GuzzleException $e) {
            $data = Json::decodeIfJson($e->getResponse()->getBody()->getContents());

The method getResponse() does not exist on GuzzleHttp\Exception\GuzzleException. It seems like you code against a sub-type of GuzzleHttp\Exception\GuzzleException such as GuzzleHttp\Exception\RequestException.

            if (isset($data['errors'][0]['message'])) {
                return $this->asErrorJson($data['errors'][0]['message']);
            }

            Craft::error('Couldn’ load tweet preview: '.$e->getTraceAsString(), __METHOD__);

            return $this->asErrorJson($e->getMessage());
        } catch (InvalidTweetException $e) {
            Craft::error('Couldn’ load tweet preview: '.$e->getTraceAsString(), __METHOD__);

            return $this->asErrorJson($e->getMessage());
        }