Analytics.Utils.responseToDataTable - Code Metrics - Inspection of "Updated `google/apiclient` dependency to `^v2.2.0`" - dukt/analytics - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 29629c...8f4c81 )

by Benjamin

created 2018-09-07 08:46 UTC

Analytics.Utils.responseToDataTable B

↳ Parent: src/web/assets/analytics/src/Analytics/Utils.js

Complexity

Conditions	1
Paths	1

Size

Total Lines	72
Code Lines	47

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	1
eloc	47
nc	1
nop	2
dl	0
loc	72
rs	8.7345
c	2
b	0
f	0

2 Functions

Rating	Name	Duplication	Size	Complexity
A		0	34	1
B		0	25	8

How to fix Long Method

/** global: Analytics */
/** global: google */
/**
 * Utils
 */
Analytics.Utils = {
    responseToDataTable: function(response, localeDefinition) {
        var dataTable = new google.visualization.DataTable();


        // Columns

        $.each(response.cols, function(key, column) {
            var dataTableColumnType;

            switch (column.type) {
                case 'date':
                    dataTableColumnType = 'date';
                    break;
                case 'percent':
                case 'time':
                case 'integer':
                case 'currency':
                case 'float':
                    dataTableColumnType = 'number';
                    break;

                default:
                    dataTableColumnType = 'string';
            }

            dataTable.addColumn({
                type: dataTableColumnType,
                label: column.label,
                id: column.id,
            });
        });


        // Rows

        $.each(response.rows, $.proxy(function(keyRow, row) {

            var dataTableRow = [];

            $.each(response.cols, $.proxy(function(keyColumn, column) {
                switch (column.type) {
                    case 'date':
                        dataTableRow[keyColumn] = Analytics.Utils.formatByType(localeDefinition, column.type, row[keyColumn]);
                        break;

                    case 'float':
                        dataTableRow[keyColumn] = +row[keyColumn];
                        break;

                    case 'integer':
                    case 'currency':
                    case 'percent':
                    case 'time':
                    case 'continent':
                    case 'subContinent':
                        dataTableRow[keyColumn] = {
                            v: Analytics.Utils.formatRawValueByType(localeDefinition, column.type, row[keyColumn]),
                            f: Analytics.Utils.formatByType(localeDefinition, column.type, row[keyColumn])
                        };
                        break;

                    default:
                        dataTableRow[keyColumn] = row[keyColumn];
                }
            }, this));

            dataTable.addRow(dataTableRow);

        }, this));

        return dataTable;
    },

    formatRawValueByType: function(localeDefinition, type, value) {
        switch (type) {
            case 'integer':
            case 'currency':
            case 'percent':
            case 'time':
            case 'float':
                return +value;
                break;


            default:
                return value;
        }
    },

    formatByType: function(localeDefinition, type, value) {
        switch (type) {
            case 'continent':
                return Analytics.Metadata.getContinentByCode(value);
                break;


            case 'subContinent':
                return Analytics.Metadata.getSubContinentByCode(value);
                break;


            case 'currency':
                return Analytics.Utils.formatCurrency(localeDefinition, +value);
                break;


            case 'float':
                return +value;
                break;


            case 'integer':
                return Analytics.Utils.formatInteger(localeDefinition, +value);
                break;


            case 'time':
                return Analytics.Utils.formatDuration(+value);
                break;


            case 'percent':
                return Analytics.Utils.formatPercent(localeDefinition, +value);
                break;


            case 'date':
                $dateString = value;


                if ($dateString.length == 8) {
                    // 20150101

                    $year = eval($dateString.substr(0, 4));

                    $month = eval($dateString.substr(4, 2)) - 1;

                    $day = eval($dateString.substr(6, 2));


                    $date = new Date($year, $month, $day);


                    return $date;
                } else if ($dateString.length == 6) {
                    // 201501

                    $year = eval($dateString.substr(0, 4));

                    $month = eval($dateString.substr(4, 2)) - 1;


                    $date = new Date($year, $month, '01');

                    return $date;
                }
                break;


            default:
                return value;
                break;

        }
    },

    formatCurrency: function(localeDefinition, value) {
        var d3Locale = this.getD3Locale(localeDefinition);
        var formatter = d3Locale.format(Craft.charts.BaseChart.defaults.formats.currencyFormat);


        return formatter(value);
    },

    formatDuration: function(_seconds) {
        var sec_num = parseInt(_seconds, 10); // don't forget the second param
        var hours = Math.floor(sec_num / 3600);
        var minutes = Math.floor((sec_num - (hours * 3600)) / 60);
        var seconds = sec_num - (hours * 3600) - (minutes * 60);

        if (hours < 10) {
            hours = "0" + hours;
        }
        if (minutes < 10) {
            minutes = "0" + minutes;
        }
        if (seconds < 10) {
            seconds = "0" + seconds;
        }
        return hours + ':' + minutes + ':' + seconds;
    },

    formatInteger: function(localeDefinition, value) {
        return this.getD3Locale(localeDefinition).format(",")(value);
    },

    formatPercent: function(localeDefinition, value) {
        return this.getD3Locale(localeDefinition).format(Craft.charts.BaseChart.defaults.formats.percentFormat)(value / 100);

    },

    getD3Locale: function(localeDefinition) {
        return d3.formatLocale(localeDefinition);

    },
};


1			/** global: Analytics */
2			/** global: google */
3			/**
4			* Utils
5			*/
6			Analytics.Utils = {
7			responseToDataTable: function(response, localeDefinition) {
8			var dataTable = new google.visualization.DataTable();
9
10
11			// Columns
12
13			$.each(response.cols, function(key, column) {
14			var dataTableColumnType;
15
16			switch (column.type) {
17			case 'date':
18			dataTableColumnType = 'date';
19			break;
20			case 'percent':
21			case 'time':
22			case 'integer':
23			case 'currency':
24			case 'float':
25			dataTableColumnType = 'number';
26			break;
27
28			default:
29			dataTableColumnType = 'string';
30			}
31
32			dataTable.addColumn({
33			type: dataTableColumnType,
34			label: column.label,
35			id: column.id,
36			});
37			});
38
39
40			// Rows
41
42			$.each(response.rows, $.proxy(function(keyRow, row) {
43
44			var dataTableRow = [];
45
46			$.each(response.cols, $.proxy(function(keyColumn, column) {
47			switch (column.type) {
48			case 'date':
49			dataTableRow[keyColumn] = Analytics.Utils.formatByType(localeDefinition, column.type, row[keyColumn]);
50			break;
51
52			case 'float':
53			dataTableRow[keyColumn] = +row[keyColumn];
54			break;
55
56			case 'integer':
57			case 'currency':
58			case 'percent':
59			case 'time':
60			case 'continent':
61			case 'subContinent':
62			dataTableRow[keyColumn] = {
63			v: Analytics.Utils.formatRawValueByType(localeDefinition, column.type, row[keyColumn]),
64			f: Analytics.Utils.formatByType(localeDefinition, column.type, row[keyColumn])
65			};
66			break;
67
68			default:
69			dataTableRow[keyColumn] = row[keyColumn];
70			}
71			}, this));
72
73			dataTable.addRow(dataTableRow);
74
75			}, this));
76
77			return dataTable;
78			},
79
80			formatRawValueByType: function(localeDefinition, type, value) {
81			switch (type) {
82			case 'integer':
83			case 'currency':
84			case 'percent':
85			case 'time':
86			case 'float':
87			return +value;
88			break;
			0 ignored issues – show Unused Code introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report This break statement is unnecessary and may be removed. Loading history...
89
90			default:
91			return value;
92			}
93			},
94
95			formatByType: function(localeDefinition, type, value) {
96			switch (type) {
97			case 'continent':
98			return Analytics.Metadata.getContinentByCode(value);
99			break;
			0 ignored issues – show Unused Code introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report This break statement is unnecessary and may be removed. Loading history...
100
101			case 'subContinent':
102			return Analytics.Metadata.getSubContinentByCode(value);
103			break;
			0 ignored issues – show Unused Code introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report This break statement is unnecessary and may be removed. Loading history...
104
105			case 'currency':
106			return Analytics.Utils.formatCurrency(localeDefinition, +value);
107			break;
			0 ignored issues – show Unused Code introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report This break statement is unnecessary and may be removed. Loading history...
108
109			case 'float':
110			return +value;
111			break;
			0 ignored issues – show Unused Code introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report This break statement is unnecessary and may be removed. Loading history...
112
113			case 'integer':
114			return Analytics.Utils.formatInteger(localeDefinition, +value);
115			break;
			0 ignored issues – show Unused Code introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report This break statement is unnecessary and may be removed. Loading history...
116
117			case 'time':
118			return Analytics.Utils.formatDuration(+value);
119			break;
			0 ignored issues – show Unused Code introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report This break statement is unnecessary and may be removed. Loading history...
120
121			case 'percent':
122			return Analytics.Utils.formatPercent(localeDefinition, +value);
123			break;
			0 ignored issues – show Unused Code introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report This break statement is unnecessary and may be removed. Loading history...
124
125			case 'date':
126			$dateString = value;
			0 ignored issues – show Bug introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report The variable `$dateString` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.$dateString`. Loading history...
127
128			if ($dateString.length == 8) {
129			// 20150101
130
131			$year = eval($dateString.substr(0, 4));
			0 ignored issues – show Bug introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report The variable `$year` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.$year`. Loading history... Security Performance introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report Calls to `eval` are slow and potentially dangerous, especially on untrusted code. Please consider whether there is another way to achieve your goal. Loading history...
132			$month = eval($dateString.substr(4, 2)) - 1;
			0 ignored issues – show Security Performance introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report Calls to `eval` are slow and potentially dangerous, especially on untrusted code. Please consider whether there is another way to achieve your goal. Loading history... Bug introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report The variable `$month` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.$month`. Loading history...
133			$day = eval($dateString.substr(6, 2));
			0 ignored issues – show Security Performance introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report Calls to `eval` are slow and potentially dangerous, especially on untrusted code. Please consider whether there is another way to achieve your goal. Loading history... Bug introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report The variable `$day` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.$day`. Loading history...
134
135			$date = new Date($year, $month, $day);
			0 ignored issues – show Bug introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report The variable `$date` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.$date`. Loading history...
136
137			return $date;
138			} else if ($dateString.length == 6) {
139			// 201501
140
141			$year = eval($dateString.substr(0, 4));
			0 ignored issues – show Security Performance introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report Calls to `eval` are slow and potentially dangerous, especially on untrusted code. Please consider whether there is another way to achieve your goal. Loading history...
142			$month = eval($dateString.substr(4, 2)) - 1;
			0 ignored issues – show Security Performance introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report Calls to `eval` are slow and potentially dangerous, especially on untrusted code. Please consider whether there is another way to achieve your goal. Loading history...
143
144			$date = new Date($year, $month, '01');
145
146			return $date;
147			}
148			break;
			0 ignored issues – show Best Practice introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
149
150			default:
151			return value;
152			break;
			0 ignored issues – show Unused Code introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report This break statement is unnecessary and may be removed. Loading history...
153			}
154			},
155
156			formatCurrency: function(localeDefinition, value) {
157			var d3Locale = this.getD3Locale(localeDefinition);
158			var formatter = d3Locale.format(Craft.charts.BaseChart.defaults.formats.currencyFormat);
			0 ignored issues – show Bug introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report The variable `Craft` seems to be never declared. If this is a global, consider adding a `/** global: Craft */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
159
160			return formatter(value);
161			},
162
163			formatDuration: function(_seconds) {
164			var sec_num = parseInt(_seconds, 10); // don't forget the second param
165			var hours = Math.floor(sec_num / 3600);
166			var minutes = Math.floor((sec_num - (hours * 3600)) / 60);
167			var seconds = sec_num - (hours * 3600) - (minutes * 60);
168
169			if (hours < 10) {
170			hours = "0" + hours;
171			}
172			if (minutes < 10) {
173			minutes = "0" + minutes;
174			}
175			if (seconds < 10) {
176			seconds = "0" + seconds;
177			}
178			return hours + ':' + minutes + ':' + seconds;
179			},
180
181			formatInteger: function(localeDefinition, value) {
182			return this.getD3Locale(localeDefinition).format(",")(value);
183			},
184
185			formatPercent: function(localeDefinition, value) {
186			return this.getD3Locale(localeDefinition).format(Craft.charts.BaseChart.defaults.formats.percentFormat)(value / 100);
			0 ignored issues – show Bug introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report The variable `Craft` seems to be never declared. If this is a global, consider adding a `/** global: Craft */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
187			},
188
189			getD3Locale: function(localeDefinition) {
190			return d3.formatLocale(localeDefinition);
			0 ignored issues – show Bug introduced 2018-04-26 17:20 UTC by Report Bug Copy Issue Report The variable `d3` seems to be never declared. If this is a global, consider adding a `/** global: d3 */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
191			},
192			};
193

dukt / analytics

Push — develop ( 29629c...8f4c81 )

Analytics.Utils.responseToDataTable B

Complexity

Size

Duplication

Importance

2 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like