ColumnFiltering::initFilters() - Code Metrics - dudapiotr/ZfTable - Measure and Improve Code Quality continuously with Scrutinizer

ColumnFiltering::initFilters() A
last analyzed 2019-10-08 08:28 UTC

↳ Parent: ColumnFiltering

Complexity

Conditions	5
Paths	16

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.3888
c	0
b	0
f	0
cc	5
nc	16
nop	1

<?php
/**
 * ZfTable ( Module for Zend Framework 2)
 *
 * @copyright Copyright (c) 2013 Piotr Duda [email protected]
 * @license   MIT License
 */

namespace ZfTable\Example\TableExample;

use ZfTable\AbstractTable;

class ColumnFiltering extends AbstractTable
{

    protected $config = array(
        'name' => 'Filtering by column',
        'showPagination' => true,
        'showQuickSearch' => false,
        'showItemPerPage' => true,
        'itemCountPerPage' => 10,
        'showColumnFilters' => true,
    );


    /**
     * @var array Definition of headers
     */
    protected $headers = array(
        'idcustomer' => array('title' => 'Id', 'width' => '50') ,
        'name' => array('title' => 'Name' , 'filters' => 'text'),
        'surname' => array('title' => 'Surname' , 'filters' => 'text' ),
        'street' => array('title' => 'Street' , 'filters' => 'text'),
        'city' => array('title' => 'City'),
        'active' => array('title' => 'Active' , 'width' => 100 ,
            'filters' => array( null => 'All' , 1 => 'Active' , 0 => 'Inactive')),
    );

    public function init()
    {

    }

    protected function initFilters($query)
    {
        if ($value = $this->getParamAdapter()->getValueOfFilter('name')) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $query->where("name like '%" . $value . "%' ");
        }
        if ($value = $this->getParamAdapter()->getValueOfFilter('surname')) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $query->where("surname like '%" . $value . "%' ");
        }
        if ($value = $this->getParamAdapter()->getValueOfFilter('street')) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $query->where("street like '%" . $value . "%' ");
        }
        $value = $this->getParamAdapter()->getValueOfFilter('active');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        if ($value != null) {
            $query->where("active = '" . $value . "' ");

        }
    }
}


GitHub Access Token became invalid

ColumnFiltering::initFilters() A
last analyzed 2019-10-08 08:28 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/**
3			* ZfTable ( Module for Zend Framework 2)
4			*
5			* @copyright Copyright (c) 2013 Piotr Duda [email protected]
6			* @license MIT License
7			*/
8
9			namespace ZfTable\Example\TableExample;
10
11			use ZfTable\AbstractTable;
12
13			class ColumnFiltering extends AbstractTable
14			{
15
16			protected $config = array(
17			'name' => 'Filtering by column',
18			'showPagination' => true,
19			'showQuickSearch' => false,
20			'showItemPerPage' => true,
21			'itemCountPerPage' => 10,
22			'showColumnFilters' => true,
23			);
24
25
26			/**
27			* @var array Definition of headers
28			*/
29			protected $headers = array(
30			'idcustomer' => array('title' => 'Id', 'width' => '50') ,
31			'name' => array('title' => 'Name' , 'filters' => 'text'),
32			'surname' => array('title' => 'Surname' , 'filters' => 'text' ),
33			'street' => array('title' => 'Street' , 'filters' => 'text'),
34			'city' => array('title' => 'City'),
35			'active' => array('title' => 'Active' , 'width' => 100 ,
36			'filters' => array( null => 'All' , 1 => 'Active' , 0 => 'Inactive')),
37			);
38
39			public function init()
40			{
41
42			}
43
44			protected function initFilters($query)
45			{
46			if ($value = $this->getParamAdapter()->getValueOfFilter('name')) {
			0 ignored issues – show Bug introduced 2015-11-26 22:15 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `ZfTable\Params\AdapterInterface` as the method `getValueOfFilter()` does only exist in the following implementations of said interface: `ZfTable\Params\AdapterArrayObject`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
47			$query->where("name like '%" . $value . "%' ");
48			}
49			if ($value = $this->getParamAdapter()->getValueOfFilter('surname')) {
			0 ignored issues – show Bug introduced 2015-11-26 22:15 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `ZfTable\Params\AdapterInterface` as the method `getValueOfFilter()` does only exist in the following implementations of said interface: `ZfTable\Params\AdapterArrayObject`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
50			$query->where("surname like '%" . $value . "%' ");
51			}
52			if ($value = $this->getParamAdapter()->getValueOfFilter('street')) {
			0 ignored issues – show Bug introduced 2015-11-26 22:15 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `ZfTable\Params\AdapterInterface` as the method `getValueOfFilter()` does only exist in the following implementations of said interface: `ZfTable\Params\AdapterArrayObject`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
53			$query->where("street like '%" . $value . "%' ");
54			}
55			$value = $this->getParamAdapter()->getValueOfFilter('active');
			0 ignored issues – show Bug introduced 2015-11-26 22:15 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `ZfTable\Params\AdapterInterface` as the method `getValueOfFilter()` does only exist in the following implementations of said interface: `ZfTable\Params\AdapterArrayObject`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
56			if ($value != null) {
57			$query->where("active = '" . $value . "' ");
58
59			}
60			}
61			}
62

dudapiotr / ZfTable

GitHub Access Token became invalid

ColumnFiltering::initFilters() A last analyzed 2019-10-08 08:28 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

ColumnFiltering::initFilters() A
last analyzed 2019-10-08 08:28 UTC