ImportListTable::init() - Code Metrics - dudapiotr/ZfTable - Measure and Improve Code Quality continuously with Scrutinizer

ImportListTable::init() A
last analyzed 2019-10-08 08:28 UTC

↳ Parent: ImportListTable

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	9.568
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php
/**
 * ZfTable ( Module for Zend Framework 2)
 *
 * @copyright Copyright (c) 2013 Piotr Duda [email protected]
 * @license   MIT License
 */


namespace Application\Table;

use ZfTable\AbstractTable;

class ImportListTable extends AbstractTable
{

    protected $config = array(
        'name' => 'Lista importów',
        'showPagination' => true,
        'showQuickSearch' => true,
        'showItemPerPage' => true,
        'itemCountPerPage' => 20,
        'areFilters' => true,
        'rowAction' => 'updateRow'
    );

    /**
     * @var array Definition of headers
     */
    protected $headers = array(
        'category_title' => array('title' => 'Marka', 'filters' => 'text' , 'sortable' => true , 'separatable' => true),
        'created_at'     => array('title' => 'Data importu', 'filters' => 'text', 'editable' => true ),
        'goto-not-voted' => array('title'  => 'Nie ocenione', 'sortable' => false),
        'goto-all'       => array('title'  => 'Wszystkie', 'sortable' => false),
        'report'         => array('title' => 'Report', 'sortable' => false)
    );

    protected function init()
    {
        $this->getRow()->addDecorator('separator', array('defaultColumn' => 'category_title'));
        $this->getRow()->addDecorator('varattr', array('name' => 'data-row' , 'value' => '%s' , 'vars' => array('id')));

        $this->getHeader('category_title')->getCell()->addDecorator('editable', array());

        $this->getHeader('goto-all')->getCell()->addDecorator('template', array(
            'template' => '<a href="/application/index/index/%s/1" target="_blank">Click (%s)</a>',
            'vars' => array('id', 'count-all')
        ));

        $this->getHeader('goto-not-voted')->getCell()->addDecorator('template', array(
            'template' => '<a href="/application/index/index/%s/2" target="_blank">Click (%s)</a>',
            'vars' => array('id' , 'count-not-voted')
        ));

        $this->getHeader('report')->getCell()->addDecorator('template', array(
            'template' => '<a href="/application/index/report/%s" target="_blank">Generate </a>',
            'vars' => array('id')
        ));
    }

    protected function initFilters($query)
    {
        if ($value = $this->getParamAdapter()->getValueOfFilter('zff_category_title')) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $query->where("c.title like '%".$value."%' ");
        }

        if ($value = $this->getParamAdapter()->getValueOfFilter('zff_created_at')) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $query->where("i.created_at like '%".$value."%' ");
        }
    }
}


GitHub Access Token became invalid

ImportListTable::init() A
last analyzed 2019-10-08 08:28 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2			/**
3			* ZfTable ( Module for Zend Framework 2)
4			*
5			* @copyright Copyright (c) 2013 Piotr Duda [email protected]
6			* @license MIT License
7			*/
8
9
10			namespace Application\Table;
11
12			use ZfTable\AbstractTable;
13
14			class ImportListTable extends AbstractTable
15			{
16
17			protected $config = array(
18			'name' => 'Lista importów',
19			'showPagination' => true,
20			'showQuickSearch' => true,
21			'showItemPerPage' => true,
22			'itemCountPerPage' => 20,
23			'areFilters' => true,
24			'rowAction' => 'updateRow'
25			);
26
27			/**
28			* @var array Definition of headers
29			*/
30			protected $headers = array(
31			'category_title' => array('title' => 'Marka', 'filters' => 'text' , 'sortable' => true , 'separatable' => true),
32			'created_at' => array('title' => 'Data importu', 'filters' => 'text', 'editable' => true ),
33			'goto-not-voted' => array('title' => 'Nie ocenione', 'sortable' => false),
34			'goto-all' => array('title' => 'Wszystkie', 'sortable' => false),
35			'report' => array('title' => 'Report', 'sortable' => false)
36			);
37
38			protected function init()
39			{
40			$this->getRow()->addDecorator('separator', array('defaultColumn' => 'category_title'));
41			$this->getRow()->addDecorator('varattr', array('name' => 'data-row' , 'value' => '%s' , 'vars' => array('id')));
42
43			$this->getHeader('category_title')->getCell()->addDecorator('editable', array());
44
45			$this->getHeader('goto-all')->getCell()->addDecorator('template', array(
46			'template' => '<a href="/application/index/index/%s/1" target="_blank">Click (%s)</a>',
47			'vars' => array('id', 'count-all')
48			));
49
50			$this->getHeader('goto-not-voted')->getCell()->addDecorator('template', array(
51			'template' => '<a href="/application/index/index/%s/2" target="_blank">Click (%s)</a>',
52			'vars' => array('id' , 'count-not-voted')
53			));
54
55			$this->getHeader('report')->getCell()->addDecorator('template', array(
56			'template' => '<a href="/application/index/report/%s" target="_blank">Generate </a>',
57			'vars' => array('id')
58			));
59			}
60
61			protected function initFilters($query)
62			{
63			if ($value = $this->getParamAdapter()->getValueOfFilter('zff_category_title')) {
			0 ignored issues – show Bug introduced 2015-11-26 22:15 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `ZfTable\Params\AdapterInterface` as the method `getValueOfFilter()` does only exist in the following implementations of said interface: `ZfTable\Params\AdapterArrayObject`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
64			$query->where("c.title like '%".$value."%' ");
65			}
66
67			if ($value = $this->getParamAdapter()->getValueOfFilter('zff_created_at')) {
			0 ignored issues – show Bug introduced 2015-11-26 22:15 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `ZfTable\Params\AdapterInterface` as the method `getValueOfFilter()` does only exist in the following implementations of said interface: `ZfTable\Params\AdapterArrayObject`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
68			$query->where("i.created_at like '%".$value."%' ");
69			}
70			}
71			}
72

dudapiotr / ZfTable

GitHub Access Token became invalid

ImportListTable::init() A last analyzed 2019-10-08 08:28 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

ImportListTable::init() A
last analyzed 2019-10-08 08:28 UTC