Editable - Code Metrics - dudapiotr/ZfTable - Measure and Improve Code Quality continuously with Scrutinizer

Editable A
last analyzed 2019-10-08 08:28 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

Metric	Value
wmc	5
lcom	0
cbo	4
dl	0
loc	44
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	8	1
A	initFilters()	0	12	4

<?php
/**
 * ZfTable ( Module for Zend Framework 2)
 *
 * @copyright Copyright (c) 2013 Piotr Duda [email protected]
 * @license   MIT License
 */

namespace ZfTable\Example\TableExample;

use ZfTable\AbstractTable;

class Editable extends AbstractTable
{

    protected $config = array(
        'name' => 'Editable table (Db-click on pale yellow space)',
        'showQuickSearch' => false,
        'itemCountPerPage' => 10,
        'showColumnFilters' => true,
        'rowAction' => '/table/updateRow',
    );

    protected $headers = array(
        'idcustomer' => array('title' => 'Id', 'width' => '50'),
        'name' => array('title' => 'Name', 'filters' => 'text'),
        'edit1' => array('title' => 'Edit 1',  'editable' => true),
        'edit2' => array('title' => 'Edit 2'),
        'surname' => array('title' => 'Surname', 'filters' => 'text'),
        'street' => array('title' => 'Street', 'filters' => 'text'),
        'city' => array('title' => 'City'),
        'active' => array('title' => 'Active', 'width' => 100),
    );

    public function init()
    {
        $this->getHeader('edit2')->getCell()->addDecorator('editable');
        $this->getRow()->addDecorator(
            'varattr',
            array('name' => 'data-row' , 'value' => '%s' , 'vars' => array('idcustomer'))
        );
    }

    protected function initFilters($query)
    {
        if ($value = $this->getParamAdapter()->getValueOfFilter('name')) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $query->where("name like '%" . $value . "%' ");
        }
        if ($value = $this->getParamAdapter()->getValueOfFilter('surname')) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $query->where("surname like '%" . $value . "%' ");
        }
        if ($value = $this->getParamAdapter()->getValueOfFilter('street')) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $query->where("street like '%" . $value . "%' ");
        }
    }
}


GitHub Access Token became invalid

Editable A
last analyzed 2019-10-08 08:28 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/**
3			* ZfTable ( Module for Zend Framework 2)
4			*
5			* @copyright Copyright (c) 2013 Piotr Duda [email protected]
6			* @license MIT License
7			*/
8
9			namespace ZfTable\Example\TableExample;
10
11			use ZfTable\AbstractTable;
12
13			class Editable extends AbstractTable
14			{
15
16			protected $config = array(
17			'name' => 'Editable table (Db-click on pale yellow space)',
18			'showQuickSearch' => false,
19			'itemCountPerPage' => 10,
20			'showColumnFilters' => true,
21			'rowAction' => '/table/updateRow',
22			);
23
24			protected $headers = array(
25			'idcustomer' => array('title' => 'Id', 'width' => '50'),
26			'name' => array('title' => 'Name', 'filters' => 'text'),
27			'edit1' => array('title' => 'Edit 1', 'editable' => true),
28			'edit2' => array('title' => 'Edit 2'),
29			'surname' => array('title' => 'Surname', 'filters' => 'text'),
30			'street' => array('title' => 'Street', 'filters' => 'text'),
31			'city' => array('title' => 'City'),
32			'active' => array('title' => 'Active', 'width' => 100),
33			);
34
35			public function init()
36			{
37			$this->getHeader('edit2')->getCell()->addDecorator('editable');
38			$this->getRow()->addDecorator(
39			'varattr',
40			array('name' => 'data-row' , 'value' => '%s' , 'vars' => array('idcustomer'))
41			);
42			}
43
44			protected function initFilters($query)
45			{
46			if ($value = $this->getParamAdapter()->getValueOfFilter('name')) {
			0 ignored issues – show Bug introduced 2015-11-26 22:15 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `ZfTable\Params\AdapterInterface` as the method `getValueOfFilter()` does only exist in the following implementations of said interface: `ZfTable\Params\AdapterArrayObject`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
47			$query->where("name like '%" . $value . "%' ");
48			}
49			if ($value = $this->getParamAdapter()->getValueOfFilter('surname')) {
			0 ignored issues – show Bug introduced 2015-11-26 22:15 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `ZfTable\Params\AdapterInterface` as the method `getValueOfFilter()` does only exist in the following implementations of said interface: `ZfTable\Params\AdapterArrayObject`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
50			$query->where("surname like '%" . $value . "%' ");
51			}
52			if ($value = $this->getParamAdapter()->getValueOfFilter('street')) {
			0 ignored issues – show Bug introduced 2015-11-26 22:15 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `ZfTable\Params\AdapterInterface` as the method `getValueOfFilter()` does only exist in the following implementations of said interface: `ZfTable\Params\AdapterArrayObject`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
53			$query->where("street like '%" . $value . "%' ");
54			}
55			}
56			}
57

dudapiotr / ZfTable

GitHub Access Token became invalid

Editable A last analyzed 2019-10-08 08:28 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

Editable A
last analyzed 2019-10-08 08:28 UTC