Ducks\Component\SplTypes\SplEnumBackedTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	89
Duplicated Lines	0 %

Test Coverage

Coverage

54.55%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__serialize()	0	5	1
A	__debugInfo()	0	9	1
A	__set_state()	0	11	1
A	__unserialize()	0	5	1

<?php

/**
 * Part of SplTypes package.
 *
 * (c) Adrien Loyant <donald_duck@team-df.org>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Ducks\Component\SplTypes;

/**
 * SplEnumBackedTrait expose magic method in order to use an SplEnum class which implements SplBackedEnum.
 *
 * @template T
 *
 * @phpstan-require-extends SplEnum
 * @phpstan-require-implements SplBackedEnum
 *
 * @psalm-api
 */
trait SplEnumBackedTrait
{
    use SplEnumUnitTrait {
        SplEnumUnitTrait::__serialize as private __unitSerialize;
        SplEnumUnitTrait::__unserialize as private __unitUnserialize;
        SplEnumUnitTrait::__set_state as private __unitSetState;
        SplEnumUnitTrait::__debugInfo as private __unitDebugInfo;
    }

    /**
     * Serialize object.
     *
     * @return mixed[]
     *
     * @phpstan-return array<string,mixed>
     *
     * @psalm-suppress LessSpecificImplementedReturnType
     */
    public function __serialize(): array
    {
        $result = $this->__unitSerialize();

        return $result;
    }

    /**
     * Unserialize object.
     *
     * @param mixed[] $data
     *
     * @return void
     *
     * @phpstan-param array<string,mixed> $data
     * @phpstan-return void
     *
     * @psalm-suppress UnsupportedPropertyReferenceUsage
     */
    public function __unserialize(array $data): void
    {
        $this->__unitUnserialize($data);

        $this->value = &$this->__default;

The property value does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Instanciate an exported object.
     *
     * @param mixed[] $properties
     *
     * @return static
     *
     * @phpstan-param array<string,mixed> $properties
     * @phpstan-return static
     *
     * @psalm-suppress UnsafeInstantiation
     */
    #[\ReturnTypeWillChange]
    public static function __set_state(array $properties): SplBackedEnum
    {
        /** @phpstan-var T $value */
        $value = $properties['value'];

        $object = self::__unitSetState($properties);
        $object->value = $value;

Accessing value on the interface Ducks\Component\SplTypes\SplUnitEnum suggest that you code against a concrete implementation. How about adding an instanceof check?

        /** @var static $object */
        return $object;

The expression return $object returns the type Ducks\Component\SplTypes\SplEnumBackedTrait which is incompatible with the type-hinted return Ducks\Component\SplTypes\SplBackedEnum.

    }

    /**
     * Dumping object.
     *
     * @return mixed[]
     *
     * @phpstan-return array<string,mixed>
     *
     * @psalm-suppress LessSpecificImplementedReturnType
     *
     * @codeCoverageIgnore
     */
    public function __debugInfo(): array
    {
        /** @phpstan-var T $value */
        $value = $this->value;

        $result = $this->__unitDebugInfo();
        $result['value'] = $value;

        return $result;
    }
}