TFileSystem::removeFromDir() - Code Metrics - Inspection of "FileSystem trait" - dspbee/pivasic - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d37fab...069828 )

by Igor

created 2016-04-30 19:08 UTC

TFileSystem::removeFromDir() B

↳ Parent: TFileSystem

Complexity

Conditions	8
Paths	13

Size

Total Lines	21
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	21
rs	7.1428
cc	8
eloc	13
nc	13
nop	2

<?php
/**
 * @license MIT
 * @author Igor Sorokin <[email protected]>
 */
namespace Dspbee\Bundle\Common;

/**
 * Class TFileSystem
 * @package Dspbee\Bundle\Common
 */
trait TFileSystem
{
    /**
     * Deleting all subdirectories and files.
     *
     * @param string $dir   Path to the directory
     * @param bool   $self  If true then delete root directory
     */
    private static function removeFromDir($dir, $self = false)
    {
        if (is_dir($dir)) {
            $objects = scandir($dir);
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
            foreach ($objects as $object) {
                if ('.' != $object && '..' != $object) {
                    if ('dir' == filetype($dir . '/' .$object)) {
                        self::removeFromDir($dir . '/' . $object, true);
                    } else {
                        unlink($dir . '/' . $object);
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
                    }
                }
            }
            if ($self) {
                reset($objects);
                if (count(scandir($dir)) == 2) {
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
                    rmdir($dir);
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
                }
            }
        }
    }
}

Push — master ( d37fab...069828 )

TFileSystem::removeFromDir() B

Complexity

Size

Duplication

Importance

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

1			<?php
2			/**
3			* @license MIT
4			* @author Igor Sorokin <[email protected]>
5			*/
6			namespace Dspbee\Bundle\Common;
7
8			/**
9			* Class TFileSystem
10			* @package Dspbee\Bundle\Common
11			*/
12			trait TFileSystem
13			{
14			/**
15			* Deleting all subdirectories and files.
16			*
17			* @param string $dir Path to the directory
18			* @param bool $self If true then delete root directory
19			*/
20			private static function removeFromDir($dir, $self = false)
21			{
22			if (is_dir($dir)) {
23			$objects = scandir($dir);
			0 ignored issues – show Security File Exposure introduced 2016-04-30 19:11 UTC by Report Bug Copy Issue Report `$dir` can contain request data and is used in file inclusion context(s) leading to a potential security vulnerability. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
24			foreach ($objects as $object) {
25			if ('.' != $object && '..' != $object) {
26			if ('dir' == filetype($dir . '/' .$object)) {
27			self::removeFromDir($dir . '/' . $object, true);
28			} else {
29			unlink($dir . '/' . $object);
			0 ignored issues – show Security File Manipulation introduced 2016-04-30 19:11 UTC by Report Bug Copy Issue Report `$dir . '/' . $object` can contain request data and is used in file manipulation context(s) leading to a potential security vulnerability. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
30			}
31			}
32			}
33			if ($self) {
34			reset($objects);
35			if (count(scandir($dir)) == 2) {
			0 ignored issues – show Security File Exposure introduced 2016-04-30 19:11 UTC by Report Bug Copy Issue Report `$dir` can contain request data and is used in file inclusion context(s) leading to a potential security vulnerability. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
36			rmdir($dir);
			0 ignored issues – show Security File Manipulation introduced 2016-04-30 19:11 UTC by Report Bug Copy Issue Report `$dir` can contain request data and is used in file manipulation context(s) leading to a potential security vulnerability. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
37			}
38			}
39			}
40			}
41			}

dspbee / pivasic

Push — master ( d37fab...069828 )

TFileSystem::removeFromDir() B

Complexity

Size

Duplication

Importance

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

Duplication Side-by-Side

Filter issues like