General::parse_request_data() - Code Metrics - Inspection of "add OpenSSL class" - dshovchko/php_EasyPay - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 361424...8a38a3 )

by Dmitry

created 2017-11-24 10:41 UTC

General::parse_request_data() C

↳ Parent: General

Complexity

Conditions	13
Paths	15

Size

Total Lines	61
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
cc	13
eloc	27
c	2
b	0
f	1
nc	15
nop	0
dl	0
loc	61
rs	6.2659

How to fix Long Method Complexity

<?php

/**
 *      General class for all request types
 *
 *      @package php_EasyPay
 *      @version 1.1
 *      @author Dmitry Shovchko <[email protected]>
 *
 */

namespace EasyPay\Provider31\Request;

use EasyPay\Log as Log;
use EasyPay\Exception;
use EasyPay\Key as Key;
use EasyPay\OpenSSL as OpenSSL;

class General
{
    /**
     *      @var string raw request
     */
    protected $raw_request;

    /**
     *      @var string 'DateTime' node
     */
    protected $DateTime;

    /**
     *      @var string 'Sign' node
     */
    protected $Sign;

    /**
     *      @var string 'Operation' type
     */
    protected $Operation;

    /**
     *      @var string 'ServiceId' node
     */
    protected $ServiceId;

    /**
     *      @var array list of possible operations
     */
    protected $operations = array('Check','Payment','Confirm','Cancel');

    /**
     *      General constructor
     *
     *      @param string $raw Raw request data
     */
    public function __construct($raw)
    {
        $this->raw_request = strval($raw);

        $this->parse_request_data();
    }

    /**
     *      Get DateTime
     *
     *      @return string
     */
    public function DateTime()
    {
        return $this->DateTime;
    }

    /**
     *      Get Sign
     *
     *      @return string
     */
    public function Sign()
    {
        return $this->Sign;
    }

    /**
     *      Get Operation type
     *
     *      @return string
     */
    public function Operation()
    {
        return $this->Operation;
    }

    /**
     *      Get ServiceId
     *
     *      @return string
     */
    public function ServiceId()
    {
        return $this->ServiceId;
    }

    /**
     *      Parse xml-request, which was previously "extracted" from the body of the http request
     *
     *      @throws Exception\Structure
     */
    protected function parse_request_data()
    {
        if (empty($this->raw_request))
        {
            throw new Exception\Structure('An empty xml request', -50);
        }

        libxml_use_internal_errors(true);
        $doc = new \DOMDocument();
        if ( ! $doc->loadXML($this->raw_request))
        {
            foreach(libxml_get_errors() as $e){
                Log::instance()->error($e->message);
            }
            throw new Exception\Structure('The wrong XML is received', -51);
        }

        // process <Request> group
        $r = $this->getNodes($doc, 'Request');

        if (count($r) < 1)
        {
            throw new Exception\Structure('The xml-query does not contain any element Request!', -52);
        }

        foreach ($r[0]->childNodes as $child)
        {
            if ($child->nodeName == 'DateTime')
            {
                $this->parse_request_node($child, 'DateTime');
            }
            elseif ($child->nodeName == 'Sign')
            {
                $this->parse_request_node($child, 'Sign');
            }
            elseif (in_array($child->nodeName, $this->operations))
            {
                if ( ! isset($this->Operation))
                {
                    $this->Operation = $child->nodeName;
                }
                else
                {
                    throw new Exception\Structure('There is more than one Operation type element in the xml-query!', -53);
                }
            }
        }

        if ( ! isset($this->Operation))
        {
            throw new Exception\Structure('There is no Operation type element in the xml request!', -55);
        }

        // process <Operation> group
        $r = $this->getNodes($doc, $this->Operation);

        foreach ($r[0]->childNodes as $child)
        {
            if ($child->nodeName == 'ServiceId')
            {
                $this->parse_request_node($child, 'ServiceId');
            }
        }
    }

    /**
     *      Parse node of request
     *
     *      @param \DOMNode $n
     *      @param string $name
     *
     *      @throws Exception\Structure
     */
    protected function parse_request_node($n, $name)
    {
        if ( ! isset($this->$name))
        {
            $this->$name = $n->nodeValue;
        }
        else
        {
            throw new Exception\Structure('There is more than one '.$name.' element in the xml-query!', -56);
        }
    }

    /**
     *      "Rough" validation of the received xml request
     *
     *      @param array $options
     *      @throws Exception\Data
     *      @throws Exception\Structure
     */
    public function validate_request($options)
    {
        $this->validate_element('DateTime');
        $this->validate_element('Sign');
        $this->validate_element('ServiceId');

        // compare received value ServiceId with option ServiceId
        if (intval($options['ServiceId']) != intval($this->ServiceId))
        {
            throw new Exception\Data('This request is not for our ServiceId!', -58);
        }
    }

    /**
     *      Validation of xml-element
     *
     *      @param string $name
     */
    public function validate_element($name)
    {
        if ( ! isset($this->$name))
        {
            throw new Exception\Structure('There is no '.$name.' element in the xml request!', -57);
        }
    }

    /**
     *      Verify signature of request
     *
     *      @param array $options
     */
    public function verify_sign($options)
    {
        if (isset($options['UseSign']) && ($options['UseSign'] === true))
        {
            $this->check_verify_sign_result(
                $result = (new OpenSSL())->verify(
                    str_replace($this->Sign, '', $this->raw_request),
                    pack("H*", $this->Sign),
                    (new OpenSSL())->get_pub_key($this->get_pub_key($options))
                )
            );
        }
    }

    /**
     *      load file with easysoft public key
     *
     *      @param array $options
     *      @throws Exception\Runtime
     *      @return string
     */
    protected function get_pub_key($options)
    {
        if ( ! isset($options['EasySoftPKey']))
        {
            throw new Exception\Runtime('The parameter EasySoftPKey is not set!', -94);
        }

        return (new Key())->get($options['EasySoftPKey'], 'public');
    }

    /**
     *      check result of openssl verify signature
     *
     *      @param integer $result
     *      @throws Exception\Sign
     */
    protected function check_verify_sign_result($result)
    {
        if ($result == -1)
        {
            throw new Exception\Sign('Error verify signature of request!', -96);
        }
        elseif ($result == 0)
        {
            throw new Exception\Sign('Signature of request is incorrect!', -95);
        }
    }

    /**
     *      Selects nodes by name
     *
     *      @param \DOMDocument $dom
     *      @param string $name
     *      @param array $ret
     *
     *      @return array nodes with the name
     */
    protected function getNodes($dom, $name, $ret=array())
    {
        foreach($dom->childNodes as $child)
        {
            if ($child->nodeName == $name)
            {
                array_push($ret, $child);
            }
            else
            {
                if (count($child->childNodes) > 0)
                {
                    $ret = $this->getNodes($child, $name, $ret);
                }
            }
        }

        return $ret;
    }

}


1			<?php
2
3			/**
4			* General class for all request types
5			*
6			* @package php_EasyPay
7			* @version 1.1
8			* @author Dmitry Shovchko <[email protected]>
9			*
10			*/
11
12			namespace EasyPay\Provider31\Request;
13
14			use EasyPay\Log as Log;
15			use EasyPay\Exception;
16			use EasyPay\Key as Key;
17			use EasyPay\OpenSSL as OpenSSL;
18
19			class General
20			{
21			/**
22			* @var string raw request
23			*/
24			protected $raw_request;
25
26			/**
27			* @var string 'DateTime' node
28			*/
29			protected $DateTime;
30
31			/**
32			* @var string 'Sign' node
33			*/
34			protected $Sign;
35
36			/**
37			* @var string 'Operation' type
38			*/
39			protected $Operation;
40
41			/**
42			* @var string 'ServiceId' node
43			*/
44			protected $ServiceId;
45
46			/**
47			* @var array list of possible operations
48			*/
49			protected $operations = array('Check','Payment','Confirm','Cancel');
50
51			/**
52			* General constructor
53			*
54			* @param string $raw Raw request data
55			*/
56			public function __construct($raw)
57			{
58			$this->raw_request = strval($raw);
59
60			$this->parse_request_data();
61			}
62
63			/**
64			* Get DateTime
65			*
66			* @return string
67			*/
68			public function DateTime()
69			{
70			return $this->DateTime;
71			}
72
73			/**
74			* Get Sign
75			*
76			* @return string
77			*/
78			public function Sign()
79			{
80			return $this->Sign;
81			}
82
83			/**
84			* Get Operation type
85			*
86			* @return string
87			*/
88			public function Operation()
89			{
90			return $this->Operation;
91			}
92
93			/**
94			* Get ServiceId
95			*
96			* @return string
97			*/
98			public function ServiceId()
99			{
100			return $this->ServiceId;
101			}
102
103			/**
104			* Parse xml-request, which was previously "extracted" from the body of the http request
105			*
106			* @throws Exception\Structure
107			*/
108			protected function parse_request_data()
109			{
110			if (empty($this->raw_request))
111			{
112			throw new Exception\Structure('An empty xml request', -50);
113			}
114
115			libxml_use_internal_errors(true);
116			$doc = new \DOMDocument();
117			if ( ! $doc->loadXML($this->raw_request))
118			{
119			foreach(libxml_get_errors() as $e){
120			Log::instance()->error($e->message);
121			}
122			throw new Exception\Structure('The wrong XML is received', -51);
123			}
124
125			// process <Request> group
126			$r = $this->getNodes($doc, 'Request');
127
128			if (count($r) < 1)
129			{
130			throw new Exception\Structure('The xml-query does not contain any element Request!', -52);
131			}
132
133			foreach ($r[0]->childNodes as $child)
134			{
135			if ($child->nodeName == 'DateTime')
136			{
137			$this->parse_request_node($child, 'DateTime');
138			}
139			elseif ($child->nodeName == 'Sign')
140			{
141			$this->parse_request_node($child, 'Sign');
142			}
143			elseif (in_array($child->nodeName, $this->operations))
144			{
145			if ( ! isset($this->Operation))
146			{
147			$this->Operation = $child->nodeName;
148			}
149			else
150			{
151			throw new Exception\Structure('There is more than one Operation type element in the xml-query!', -53);
152			}
153			}
154			}
155
156			if ( ! isset($this->Operation))
157			{
158			throw new Exception\Structure('There is no Operation type element in the xml request!', -55);
159			}
160
161			// process <Operation> group
162			$r = $this->getNodes($doc, $this->Operation);
163
164			foreach ($r[0]->childNodes as $child)
165			{
166			if ($child->nodeName == 'ServiceId')
167			{
168			$this->parse_request_node($child, 'ServiceId');
169			}
170			}
171			}
172
173			/**
174			* Parse node of request
175			*
176			* @param \DOMNode $n
177			* @param string $name
178			*
179			* @throws Exception\Structure
180			*/
181			protected function parse_request_node($n, $name)
182			{
183			if ( ! isset($this->$name))
184			{
185			$this->$name = $n->nodeValue;
186			}
187			else
188			{
189			throw new Exception\Structure('There is more than one '.$name.' element in the xml-query!', -56);
190			}
191			}
192
193			/**
194			* "Rough" validation of the received xml request
195			*
196			* @param array $options
197			* @throws Exception\Data
198			* @throws Exception\Structure
199			*/
200			public function validate_request($options)
201			{
202			$this->validate_element('DateTime');
203			$this->validate_element('Sign');
204			$this->validate_element('ServiceId');
205
206			// compare received value ServiceId with option ServiceId
207			if (intval($options['ServiceId']) != intval($this->ServiceId))
208			{
209			throw new Exception\Data('This request is not for our ServiceId!', -58);
210			}
211			}
212
213			/**
214			* Validation of xml-element
215			*
216			* @param string $name
217			*/
218			public function validate_element($name)
219			{
220			if ( ! isset($this->$name))
221			{
222			throw new Exception\Structure('There is no '.$name.' element in the xml request!', -57);
223			}
224			}
225
226			/**
227			* Verify signature of request
228			*
229			* @param array $options
230			*/
231			public function verify_sign($options)
232			{
233			if (isset($options['UseSign']) && ($options['UseSign'] === true))
234			{
235			$this->check_verify_sign_result(
236			$result = (new OpenSSL())->verify(
237			str_replace($this->Sign, '', $this->raw_request),
238			pack("H*", $this->Sign),
239			(new OpenSSL())->get_pub_key($this->get_pub_key($options))
240			)
241			);
242			}
243			}
244
245			/**
246			* load file with easysoft public key
247			*
248			* @param array $options
249			* @throws Exception\Runtime
250			* @return string
251			*/
252			protected function get_pub_key($options)
253			{
254			if ( ! isset($options['EasySoftPKey']))
255			{
256			throw new Exception\Runtime('The parameter EasySoftPKey is not set!', -94);
257			}
258
259			return (new Key())->get($options['EasySoftPKey'], 'public');
260			}
261
262			/**
263			* check result of openssl verify signature
264			*
265			* @param integer $result
266			* @throws Exception\Sign
267			*/
268			protected function check_verify_sign_result($result)
269			{
270			if ($result == -1)
271			{
272			throw new Exception\Sign('Error verify signature of request!', -96);
273			}
274			elseif ($result == 0)
275			{
276			throw new Exception\Sign('Signature of request is incorrect!', -95);
277			}
278			}
279
280			/**
281			* Selects nodes by name
282			*
283			* @param \DOMDocument $dom
284			* @param string $name
285			* @param array $ret
286			*
287			* @return array nodes with the name
288			*/
289			protected function getNodes($dom, $name, $ret=array())
290			{
291			foreach($dom->childNodes as $child)
292			{
293			if ($child->nodeName == $name)
294			{
295			array_push($ret, $child);
296			}
297			else
298			{
299			if (count($child->childNodes) > 0)
300			{
301			$ret = $this->getNodes($child, $name, $ret);
302			}
303			}
304			}
305
306			return $ret;
307			}
308
309			}
310

dshovchko / php_EasyPay

Push — master ( 361424...8a38a3 )

General::parse_request_data() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like