EasyPay\OpenSSL

Complexity

Total Complexity

7

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	verify()	0	3	1
A	__construct()	0	1	1
A	sign()	0	3	1
A	is_key()	0	5	2
A	get_priv_key()	0	6	1
A	get_pub_key()	0	6	1

<?php

namespace EasyPay;

class OpenSSL
{
    public function __construct() {}

    /**
     *      verify signature of xml
     *
     *      @param string $xml
     *      @param string $bin_sign
     *      @param resource $pub_key
     *
     *      @return integer result of checking
     */
    public function verify($xml, $bin_sign, $pub_key)
    {
        return @openssl_verify($xml, $bin_sign, $pub_key);
    }

    /**
     *      generate signature of xml
     *
     *      @param string $xml
     *      @param string $sign
     *      @param resource $priv_key
     *
     *      @return bool result of signing
     */
    public function sign($xml, &$sign, $priv_key)
    {
        return @openssl_sign($xml, $sign, $priv_key);
    }

    /**
     *      get public key
     *
     *      @param mixed $certificate
     *      @return resource
     */
    public function get_pub_key($certificate)
    {
        $pub_key = @openssl_pkey_get_public($certificate);
        $this->is_key($pub_key);

        return $pub_key;
    }

    /**
     *      get private key
     *
     *      @param mixed $certificate
     *      @return resource
     */
    public function get_priv_key($certificate)
    {
        $priv_key = @openssl_pkey_get_private($certificate);
        $this->is_key($priv_key);

It seems like $priv_key can also be of type false; however, parameter $key of EasyPay\OpenSSL::is_key() does only seem to accept resource, maybe add an additional type check?

        return $priv_key;
    }

    /**
     *      check key
     *
     *      @param resource $key
     *      @throws Exception\Runtime
     */
    public function is_key($key)
    {
        if ($key === FALSE)

The condition $key === FALSE is always false.

        {
            throw new Exception\Runtime('Can not extract key from certificate!', -97);
        }
    }

}