Issues in GroupPolicy.php (master) - Issues in master - dsd-meetme/backend - Measure and Improve Code Quality continuously with Scrutinizer

Issues (34)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Policies/GroupPolicy.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace plunner\Policies;

use plunner\Group;
use plunner\PolicyCheckable;

/**
 * Class GroupPolicy
 * @package plunner\Policies
 * @author Claudio Cardinale <[email protected]>
 * @copyright 2015 Claudio Cardinale
 * @version 1.0.0
 */
class GroupPolicy
{
    /**
     * Create a new policy instance.
     *
     * @return void

     */
    public function __construct()
    {
        //
    }

    /**
     * @param PolicyCheckable $policyCheckable
     * @param Group $group
     * @return bool
     */
    public function index(PolicyCheckable $policyCheckable, Group $group)
    {
        return $this->userCheck($policyCheckable, $group);
    }

    /**
     * @param PolicyCheckable $policyCheckable
     * @param Group $group
     * @return bool
     */
    private function userCheck(PolicyCheckable $policyCheckable, Group $group)
    {
        return $policyCheckable->verifyGroup($group);
    }

    /**
     * @param PolicyCheckable $policyCheckable
     * @param Group $group
     * @return bool
     */
    public function store(PolicyCheckable $policyCheckable, Group $group)
    {
        return $this->userCheck($policyCheckable, $group);
    }

    /**
     * @param PolicyCheckable $policyCheckable
     * @param Group $group
     * @return bool
     */
    public function update(PolicyCheckable $policyCheckable, Group $group)
    {
        return $this->userCheck($policyCheckable, $group);
    }

    /**
     * @param PolicyCheckable $policyCheckable
     * @param Group $group
     * @return bool
     */
    public function show(PolicyCheckable $policyCheckable, Group $group)
    {
        $ret = $this->userCheck($policyCheckable, $group);
        return $ret;
    }

    /**
     * @param PolicyCheckable $policyCheckable
     * @param Group $group
     * @return bool
     */
    public function showImage(PolicyCheckable $policyCheckable, Group $group)
    {
        $ret = $this->userCheck($policyCheckable, $group);
        return $ret;
    }

    /**
     * @param PolicyCheckable $policyCheckable
     * @param Group $group
     * @return bool
     */
    public function storeImage(PolicyCheckable $policyCheckable, Group $group)
    {
        $ret = $this->userCheck($policyCheckable, $group);
        return $ret;
    }

    /**
     * @param PolicyCheckable $policyCheckable
     * @param Group $group
     * @return bool
     */
    public function destroy(PolicyCheckable $policyCheckable, Group $group)
    {
        return $this->userCheck($policyCheckable, $group);
    }
}


1		<?php
2
3		namespace plunner\Policies;
4
5		use plunner\Group;
6		use plunner\PolicyCheckable;
7
8		/**
9		* Class GroupPolicy
10		* @package plunner\Policies
11		* @author Claudio Cardinale <[email protected]>
12		* @copyright 2015 Claudio Cardinale
13		* @version 1.0.0
14		*/
15		class GroupPolicy
16		{
17		/**
18		* Create a new policy instance.
19		*
20		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2015-11-24 21:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
21		*/
22	99	public function __construct()
23		{
24		//
25	99	}
26
27		/**
28		* @param PolicyCheckable $policyCheckable
29		* @param Group $group
30		* @return bool
31		*/
32	15	public function index(PolicyCheckable $policyCheckable, Group $group)
33		{
34	15	return $this->userCheck($policyCheckable, $group);
35		}
36
37		/**
38		* @param PolicyCheckable $policyCheckable
39		* @param Group $group
40		* @return bool
41		*/
42	99	private function userCheck(PolicyCheckable $policyCheckable, Group $group)
43		{
44	99	return $policyCheckable->verifyGroup($group);
45		}
46
47		/**
48		* @param PolicyCheckable $policyCheckable
49		* @param Group $group
50		* @return bool
51		*/
52	27	public function store(PolicyCheckable $policyCheckable, Group $group)
53		{
54	27	return $this->userCheck($policyCheckable, $group);
55		}
56
57		/**
58		* @param PolicyCheckable $policyCheckable
59		* @param Group $group
60		* @return bool
61		*/
62	21	public function update(PolicyCheckable $policyCheckable, Group $group)
63		{
64	21	return $this->userCheck($policyCheckable, $group);
65		}
66
67		/**
68		* @param PolicyCheckable $policyCheckable
69		* @param Group $group
70		* @return bool
71		*/
72	39	public function show(PolicyCheckable $policyCheckable, Group $group)
73		{
74	39	$ret = $this->userCheck($policyCheckable, $group);
75	39	return $ret;
76		}
77
78		/**
79		* @param PolicyCheckable $policyCheckable
80		* @param Group $group
81		* @return bool
82		*/
83		public function showImage(PolicyCheckable $policyCheckable, Group $group)
84		{
85		$ret = $this->userCheck($policyCheckable, $group);
86		return $ret;
87		}
88
89		/**
90		* @param PolicyCheckable $policyCheckable
91		* @param Group $group
92		* @return bool
93		*/
94		public function storeImage(PolicyCheckable $policyCheckable, Group $group)
95		{
96		$ret = $this->userCheck($policyCheckable, $group);
97		return $ret;
98		}
99
100		/**
101		* @param PolicyCheckable $policyCheckable
102		* @param Group $group
103		* @return bool
104		*/
105	24	public function destroy(PolicyCheckable $policyCheckable, Group $group)
106		{
107	24	return $this->userCheck($policyCheckable, $group);
108		}
109		}
110

dsd-meetme / backend

Issues (34)

Security Analysis not enabled

app/Policies/GroupPolicy.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like