@@ -79,8 +79,9 @@ |
||
79 | 79 | if ($request->input('remember', false)) { |
80 | 80 | config(['jwt.ttl' => '43200']); //30 days |
81 | 81 | $this->custom = array_merge($this->custom, ['remember' => 'true']); |
82 | - } else |
|
83 | - $this->custom = array_merge($this->custom, ['remember' => 'false']); |
|
82 | + } else { |
|
83 | + $this->custom = array_merge($this->custom, ['remember' => 'false']); |
|
84 | + } |
|
84 | 85 | |
85 | 86 | return $this->postLoginOriginal($request); |
86 | 87 | } |
@@ -31,9 +31,11 @@ |
||
31 | 31 | $group = Group::findOrFail($groupId); |
32 | 32 | $this->authorize($group); |
33 | 33 | $meetings = $group->meetings(); |
34 | - if ($request->query('current')) |
|
35 | - $meetings->where(function ($query) { //parenthesis for conditions ...(C1 OR C2)... |
|
36 | - $query->where('start_time', '=', NULL);//to be planned |
|
34 | + if ($request->query('current')) { |
|
35 | + $meetings->where(function ($query) { //parenthesis for conditions ...(C1 OR C2)... |
|
36 | + $query->where('start_time', '=', NULL); |
|
37 | + } |
|
38 | + //to be planned |
|
37 | 39 | //datetime to consider timezone, don't use mysql NOW() |
38 | 40 | $query->orWhere('start_time', '>=', new \DateTime());//planned |
39 | 41 | }); |
@@ -31,16 +31,19 @@ |
||
31 | 31 | */ |
32 | 32 | $planner = \Auth::user(); |
33 | 33 | $groups = $planner->groupsManaged(); |
34 | - if ($request->query('current')) |
|
35 | - $groups->with(['meetings' => function ($query) { |
|
34 | + if ($request->query('current')) { |
|
35 | + $groups->with(['meetings' => function ($query) { |
|
36 | 36 | $query->where(function ($query) { //parenthesis for conditions ...(C1 OR C2)... |
37 | - $query->where('start_time', '=', NULL);//to be planned |
|
37 | + $query->where('start_time', '=', NULL); |
|
38 | + } |
|
39 | + //to be planned |
|
38 | 40 | //datetime to consider timezone, don't use mysql NOW() |
39 | 41 | $query->orWhere('start_time', '>=', new \DateTime());//planned |
40 | 42 | }); |
41 | 43 | }]); |
42 | - else |
|
43 | - $groups->with('meetings'); |
|
44 | + else { |
|
45 | + $groups->with('meetings'); |
|
46 | + } |
|
44 | 47 | return $groups->get();//both planed and to be planned |
45 | 48 | } |
46 | 49 |
@@ -31,9 +31,11 @@ |
||
31 | 31 | $group = Group::findOrFail($groupId); |
32 | 32 | $this->authorize($group); |
33 | 33 | $meetings = $group->meetings(); |
34 | - if ($request->query('current')) |
|
35 | - $meetings->where(function ($query) { //parenthesis for conditions ...(C1 OR C2)... |
|
36 | - $query->where('start_time', '=', NULL);//to be planned |
|
34 | + if ($request->query('current')) { |
|
35 | + $meetings->where(function ($query) { //parenthesis for conditions ...(C1 OR C2)... |
|
36 | + $query->where('start_time', '=', NULL); |
|
37 | + } |
|
38 | + //to be planned |
|
37 | 39 | //datetime to consider timezone, don't use mysql NOW() |
38 | 40 | $query->orWhere('start_time', '>=', new \DateTime());//planned |
39 | 41 | }); |
@@ -36,8 +36,9 @@ |
||
36 | 36 | $calendar = Calendar::findOrFail($calendarId); |
37 | 37 | $this->authorize($calendar); |
38 | 38 | $timeslots = $calendar->timeslots(); |
39 | - if ($request->query('current')) |
|
40 | - $timeslots->where('time_start', '>=', new \DateTime()); |
|
39 | + if ($request->query('current')) { |
|
40 | + $timeslots->where('time_start', '>=', new \DateTime()); |
|
41 | + } |
|
41 | 42 | return $timeslots->get(); |
42 | 43 | } |
43 | 44 |
@@ -33,8 +33,9 @@ discard block |
||
33 | 33 | $meeting = Meeting::findOrFail($meetingId); |
34 | 34 | $this->authorize($meeting); |
35 | 35 | |
36 | - if ($meeting->group_id == $groupId) |
|
37 | - return $meeting->timeslots; |
|
36 | + if ($meeting->group_id == $groupId) { |
|
37 | + return $meeting->timeslots; |
|
38 | + } |
|
38 | 39 | return Response::json(['error' => 'meeting->group_id <> groupId'], 403); |
39 | 40 | } |
40 | 41 | |
@@ -55,8 +56,9 @@ discard block |
||
55 | 56 | $timeslot = MeetingTimeslot::findOrFail($timeslotId); |
56 | 57 | $this->authorize($timeslot); |
57 | 58 | |
58 | - if ($meeting->group_id == $groupId && $timeslot->meeting_id == $meetingId) |
|
59 | - return $timeslot; |
|
59 | + if ($meeting->group_id == $groupId && $timeslot->meeting_id == $meetingId) { |
|
60 | + return $timeslot; |
|
61 | + } |
|
60 | 62 | return Response::json(['error' => 'meeting->group_id <> groupId || timeslot->meeting_id <> meetingId'], 403); |
61 | 63 | } |
62 | 64 | |
@@ -72,8 +74,9 @@ discard block |
||
72 | 74 | $this->authorize($group); |
73 | 75 | $meeting = Meeting::findOrFail($meetingId); |
74 | 76 | $this->authorize($meeting); |
75 | - if ($meeting->start_time != NULL) |
|
76 | - return Response::json(['error' => 'the meeting is already planned'], 422); |
|
77 | + if ($meeting->start_time != NULL) { |
|
78 | + return Response::json(['error' => 'the meeting is already planned'], 422); |
|
79 | + } |
|
77 | 80 | |
78 | 81 | $input = $request->all(); |
79 | 82 | |
@@ -96,8 +99,9 @@ discard block |
||
96 | 99 | $this->authorize($group); |
97 | 100 | $meeting = Meeting::findOrFail($meetingId); |
98 | 101 | $this->authorize($meeting); |
99 | - if ($meeting->start_time != NULL) |
|
100 | - return Response::json(['error' => 'the meeting is already planned'], 422); |
|
102 | + if ($meeting->start_time != NULL) { |
|
103 | + return Response::json(['error' => 'the meeting is already planned'], 422); |
|
104 | + } |
|
101 | 105 | $timeslot = MeetingTimeslot::findOrFail($timeslotId); |
102 | 106 | $this->authorize($timeslot); |
103 | 107 | |
@@ -124,8 +128,9 @@ discard block |
||
124 | 128 | $this->authorize($group); |
125 | 129 | $meeting = Meeting::findOrFail($meetingId); |
126 | 130 | $this->authorize($meeting); |
127 | - if ($meeting->start_time != NULL) |
|
128 | - return Response::json(['error' => 'the meeting is already planned'], 422); |
|
131 | + if ($meeting->start_time != NULL) { |
|
132 | + return Response::json(['error' => 'the meeting is already planned'], 422); |
|
133 | + } |
|
129 | 134 | $timeslot = MeetingTimeslot::findOrFail($timeslotId); |
130 | 135 | $this->authorize($timeslot); |
131 | 136 |
@@ -37,8 +37,9 @@ |
||
37 | 37 | { |
38 | 38 | $employee = \Auth::user(); |
39 | 39 | $input = $request->only(['name', 'password']); |
40 | - if (isset($input['password'])) |
|
41 | - $input['password'] = bcrypt($input['password']); |
|
40 | + if (isset($input['password'])) { |
|
41 | + $input['password'] = bcrypt($input['password']); |
|
42 | + } |
|
42 | 43 | $employee->update($input); |
43 | 44 | return $employee; |
44 | 45 | } |
@@ -37,8 +37,9 @@ |
||
37 | 37 | { |
38 | 38 | $employee = \Auth::user(); |
39 | 39 | $input = $request->only(['name', 'password']); |
40 | - if (isset($input['password'])) |
|
41 | - $input['password'] = bcrypt($input['password']); |
|
40 | + if (isset($input['password'])) { |
|
41 | + $input['password'] = bcrypt($input['password']); |
|
42 | + } |
|
42 | 43 | $employee->update($input); |
43 | 44 | return $employee; |
44 | 45 | } |
@@ -158,9 +158,9 @@ discard block |
||
158 | 158 | $solver = $this->setData($solver); |
159 | 159 | $solver = $solver->solve(); |
160 | 160 | $this->solver = $solver; |
161 | - }catch(OptimiseException $e) { |
|
161 | + } catch(OptimiseException $e) { |
|
162 | 162 | throw $e; |
163 | - }catch (\Exception $e) { |
|
163 | + } catch (\Exception $e) { |
|
164 | 164 | \Event::fire(new ErrorEvent($this->company, $e->getMessage())); |
165 | 165 | throw new OptimiseException('Optimising error', 0, $e); |
166 | 166 | //TODO catch specif exception |
@@ -204,8 +204,9 @@ discard block |
||
204 | 204 | { |
205 | 205 | //since we consider busy timeslots, we need to get all users |
206 | 206 | $users = $this->company->employees->pluck('id')->toArray(); |
207 | - if(count($users) == 0) |
|
208 | - throw ((new OptimiseException("No users for this company"))->withEmpty(true)); |
|
207 | + if(count($users) == 0) { |
|
208 | + throw ((new OptimiseException("No users for this company"))->withEmpty(true)); |
|
209 | + } |
|
209 | 210 | return $solver->setUsers($users); |
210 | 211 | } |
211 | 212 | |
@@ -220,8 +221,9 @@ discard block |
||
220 | 221 | * @var $meetings \Illuminate\Support\Collection |
221 | 222 | */ |
222 | 223 | $meetings = collect($this->company->getMeetingsTimeSlots($this->startTime, $this->endTime)); |
223 | - if($meetings->count() == 0) |
|
224 | - throw ((new OptimiseException("No meetings for this week"))->withEmpty(true)); |
|
224 | + if($meetings->count() == 0) { |
|
225 | + throw ((new OptimiseException("No meetings for this week"))->withEmpty(true)); |
|
226 | + } |
|
225 | 227 | $timeslots = $meetings->groupBy('id')->map(function ($item) { //convert timeslots |
226 | 228 | return $this->durationConverter($this->timeSlotsConverter($item)); |
227 | 229 | }); |
@@ -311,8 +313,9 @@ discard block |
||
311 | 313 | static private function fillTimeSlots(array $array, $id, \Illuminate\Support\Collection $timeSlots, $fill = '0') |
312 | 314 | { |
313 | 315 | foreach ($timeSlots as $timeSlot) { |
314 | - if (!isset($array[$id])) |
|
315 | - $array[$id] = []; |
|
316 | + if (!isset($array[$id])) { |
|
317 | + $array[$id] = []; |
|
318 | + } |
|
316 | 319 | $array[$id] = self::arrayPadInterval($array[$id], $timeSlot->time_start, $timeSlot->time_end, $fill); |
317 | 320 | } |
318 | 321 | return $array; |
@@ -327,8 +330,9 @@ discard block |
||
327 | 330 | */ |
328 | 331 | static private function arrayPadInterval(array $array, $from, $to, $pad = '0') |
329 | 332 | { |
330 | - for ($i = $from; $i < $to; $i++) |
|
331 | - $array[$i] = $pad; |
|
333 | + for ($i = $from; $i < $to; $i++) { |
|
334 | + $array[$i] = $pad; |
|
335 | + } |
|
332 | 336 | return $array; |
333 | 337 | } |
334 | 338 | |
@@ -341,8 +345,9 @@ discard block |
||
341 | 345 | static private function fillRow(array $array, $id, $until, $fill = '0') |
342 | 346 | { |
343 | 347 | for ($i = 1; $i <= $until; $i++) { |
344 | - if (!isset($array[$id][$i])) |
|
345 | - $array[$id][$i] = $fill; |
|
348 | + if (!isset($array[$id][$i])) { |
|
349 | + $array[$id][$i] = $fill; |
|
350 | + } |
|
346 | 351 | } |
347 | 352 | |
348 | 353 | return $array; |
@@ -359,8 +364,9 @@ discard block |
||
359 | 364 | * @var $users \Illuminate\Support\Collection |
360 | 365 | */ |
361 | 366 | $users = collect($this->company->getEmployeesTimeSlots($this->startTime, $this->endTime)); |
362 | - if($users->count() == 0) |
|
363 | - throw ((new OptimiseException("No users for this company"))->withEmpty(true)); |
|
367 | + if($users->count() == 0) { |
|
368 | + throw ((new OptimiseException("No users for this company"))->withEmpty(true)); |
|
369 | + } |
|
364 | 370 | $timeslots = $users->groupBy('id')->map(function ($item) { //convert timeslots |
365 | 371 | return $this->timeSlotsConverter($item); |
366 | 372 | }); |
@@ -380,8 +386,9 @@ discard block |
||
380 | 386 | * @var $usersMeetings \Illuminate\Support\Collection |
381 | 387 | */ |
382 | 388 | $usersMeetings = collect($this->company->getUsersMeetings($users, $meetings))->groupBy('employee_id'); |
383 | - if($usersMeetings->count() == 0) |
|
384 | - throw ((new OptimiseException("No users for any meeting"))->withEmpty(true)); |
|
389 | + if($usersMeetings->count() == 0) { |
|
390 | + throw ((new OptimiseException("No users for any meeting"))->withEmpty(true)); |
|
391 | + } |
|
385 | 392 | |
386 | 393 | return $solver->setUsersMeetings(self::getUsersMeetingsArray($users, $meetings, $usersMeetings)); |
387 | 394 | } |