dsd-meetme / backend

app/Group.php

Braces +3 added lines, -2 removed lines

@@ -51,8 +51,9 @@
 
     public function getPlannerNameAttribute()
     {
-        if(is_object($this->planner) && $this->planner->exists)
-            return $this->planner->name;
+        if(is_object($this->planner) && $this->planner->exists) {
+                    return $this->planner->name;
+        }
     }
 
     /**

app/Http/Controllers/Companies/Groups/EmployeesController.php

Braces +3 added lines, -2 removed lines

@@ -71,8 +71,9 @@
         $employee = Employee::findOrFail($employeeId);
         $this->authorize($employee);
         $group = Group::findOrFail($groupId);
-        if(!$employee->belongsToGroup($group))
-            return Response::json(['error' => 'employId <> groupId'],404);
+        if(!$employee->belongsToGroup($group)) {
+                    return Response::json(['error' => 'employId <> groupId'],404);
+        }
         $employee->groups()->detach($groupId);
         return $group->employees;
     }

app/Http/Controllers/Companies/Employees/EmployeesController.php

Braces +6 added lines, -4 removed lines

@@ -53,8 +53,9 @@ 
         //
         $company = \Auth::user();
         $input = $request->all();
-        if(isset($input['password']))
-            $input['password'] = bcrypt($input['password']);
+        if(isset($input['password'])) {
+                    $input['password'] = bcrypt($input['password']);
+        }
         $employee = $company->employees()->create($input);
         return $employee;
     }
@@ -86,8 +87,9 @@ 
         $employee = Employee::findOrFail($id);
         $this->authorize($employee);
         $input = $request->all();
-        if(isset($input['password']))
-            $input['password'] = bcrypt($input['password']);
+        if(isset($input['password'])) {
+                    $input['password'] = bcrypt($input['password']);
+        }
         $employee->update($input);
         return $employee;
     }

app/Console/Commands/SyncCaldav/SyncCaldav.php

Braces +14 added lines, -10 removed lines

@@ -53,10 +53,11 @@ 
     {
         //
         $calendarId = $this->argument('calendarId');
-        if(is_numeric($calendarId))
-            $this->makeForeground(Caldav::findOrFail($calendarId));
-        else
-            $this->syncAll();
+        if(is_numeric($calendarId)) {
+                    $this->makeForeground(Caldav::findOrFail($calendarId));
+        } else {
+                    $this->syncAll();
+        }
     }
 
     private function syncAll()
@@ -65,13 +66,15 @@ 
         if($this->option('background')) {
             \Log::debug(self::BACKGROUND_MOD_MEX);
             $this->info(self::BACKGROUND_MOD_MEX);
-            foreach ($calendars as $calendar)
-                $this->makeBackground($calendar);
+            foreach ($calendars as $calendar) {
+                            $this->makeBackground($calendar);
+            }
             \Log::debug(self::BACKGROUND_COMPLETED_MEX);
             $this->info(self::BACKGROUND_COMPLETED_MEX);
-        }else
-            foreach($calendars as $calendar)
+        } else {
+                    foreach($calendars as $calendar)
                 $this->makeForeground($calendar);
+        }
     }
 
     /**
@@ -81,8 +84,9 @@ 
     private function makeBackground(Caldav $calendar)
     {
         $event = $this->schedule->command('sync:caldav '.$calendar->calendar_id)->withoutOverlapping();
-        if($event->isDue($this->laravel))
-             $event->run($this->laravel);
+        if($event->isDue($this->laravel)) {
+                     $event->run($this->laravel);
+        }
     }
 
     /**

app/Http/Controllers/Employees/Calendars/CalendarsController.php

Braces +10 added lines, -7 removed lines

@@ -66,8 +66,9 @@ 
         $employee = \Auth::user();
         $input = $request->all();
         $calendar = $employee->calendars()->create($input);
-        if(isset($input['password']))
-            $input['password'] = \Crypt::encrypt($input['password']);
+        if(isset($input['password'])) {
+                    $input['password'] = \Crypt::encrypt($input['password']);
+        }
         $calendar->caldav()->create($input);
         //TODO test
         //TODO validator
@@ -107,15 +108,17 @@ 
         if($caldav){
             $this->validateCaldav($request);
         }
-        if(isset($input['password']))
-            $input['password'] = \Crypt::encrypt($input['password']);
+        if(isset($input['password'])) {
+                    $input['password'] = \Crypt::encrypt($input['password']);
+        }
         $calendar->update($input);
         //TODO test
         //TODO validator
         //TODO check if caldav exists?
 
-        if($caldav)
-            $caldav->update($input);
+        if($caldav) {
+                    $caldav->update($input);
+        }
         return $calendar;
     }
 
@@ -148,7 +151,7 @@ 
             $caldavClient->connect($request->input('url'), $request->input('username'), $request->input('password'));
             $calendars = $caldavClient->findCalendars();
             return array_keys($calendars);
-        }catch (\it\thecsea\caldav_client_adapter\CaldavException $e)
+        } catch (\it\thecsea\caldav_client_adapter\CaldavException $e)
         {
             return Response::json(['error' => $e->getMessage()],422);
         }

app/Console/Commands/SyncCaldav/Sync.php

Braces +21 added lines, -17 removed lines

@@ -91,11 +91,11 @@ 
         try
         {
             $events = $this->getEvents();
-        }catch (\it\thecsea\caldav_client_adapter\CaldavException $e)
+        } catch (\it\thecsea\caldav_client_adapter\CaldavException $e)
         {
             \Event::fire(new ErrorEvent($this->calendar, $e->getMessage()));
             return ;
-        }catch(\Illuminate\Contracts\Encryption\DecryptException $e){
+        } catch(\Illuminate\Contracts\Encryption\DecryptException $e){
             \Event::fire(new ErrorEvent($this->calendar, $e->getMessage()));
             return ;
         }
@@ -110,10 +110,11 @@ 
 
         //insert new timeslots
         foreach($events as $event){
-            if(!($event = $this->parseEvent($event)))
-                \Event::fire(new ErrorEvent($this->calendar, 'problem during the parsing an event'));
-            else
-                $calendarMain->timeslots()->create($event);
+            if(!($event = $this->parseEvent($event))) {
+                            \Event::fire(new ErrorEvent($this->calendar, 'problem during the parsing an event'));
+            } else {
+                            $calendarMain->timeslots()->create($event);
+            }
         }
         \Event::fire(new OkEvent($this->calendar));
     }
@@ -126,17 +127,20 @@ 
     {
         $pattern = "/^((DTSTART;)|(DTEND;))(.*)\$/m";
         if(preg_match_all($pattern, $event->getData(), $matches)){
-            if(!isset($matches[4]) || count($matches[4]) != 2)
-                return null;
+            if(!isset($matches[4]) || count($matches[4]) != 2) {
+                            return null;
+            }
             $ret = [];
-            if($tmp = $this->parseDate($matches[4][0]))
-                $ret['time_start'] = $tmp;
-            else
-                return null;
-            if($tmp = $this->parseDate($matches[4][1]))
-                $ret['time_end'] = $tmp;
-            else
-                return null;
+            if($tmp = $this->parseDate($matches[4][0])) {
+                            $ret['time_start'] = $tmp;
+            } else {
+                            return null;
+            }
+            if($tmp = $this->parseDate($matches[4][1])) {
+                            $ret['time_end'] = $tmp;
+            } else {
+                            return null;
+            }
             return $ret;
         }
         return null;
@@ -153,7 +157,7 @@ 
             if($matches[1][0] == 'TZID=')
             {
                 return \DateTime::createFromFormat('Ymd\THis', $matches[5][0], new \DateTimeZone($matches[4][0]));
-            }else if($matches[1][0] == 'VALUE=' && $matches[4][0] == 'DATE')
+            } else if($matches[1][0] == 'VALUE=' && $matches[4][0] == 'DATE')
             {
                 return \DateTime::createFromFormat('Ymd\THis', $matches[5][0].'T000000');
             }

app/Console/Commands/Optimise/OptimiseCommand.php

Braces +14 added lines, -10 removed lines

@@ -62,10 +62,11 @@ 
 
         //TODO try...catch with destruct
         $companyId = $this->argument('companyId');
-        if(is_numeric($companyId))
-            $this->makeForeground(Company::findOrFail($companyId));
-        else
-            $this->syncAll();
+        if(is_numeric($companyId)) {
+                    $this->makeForeground(Company::findOrFail($companyId));
+        } else {
+                    $this->syncAll();
+        }
     }
 
     private function syncAll()
@@ -74,13 +75,15 @@ 
         if($this->option('background')) {
             \Log::debug(self::BACKGROUND_MOD_MEX);
             $this->info(self::BACKGROUND_MOD_MEX);
-            foreach ($calendars as $calendar)
-                $this->makeBackground($calendar);
+            foreach ($calendars as $calendar) {
+                            $this->makeBackground($calendar);
+            }
             \Log::debug(self::BACKGROUND_COMPLETED_MEX);
             $this->info(self::BACKGROUND_COMPLETED_MEX);
-        }else
-            foreach($calendars as $calendar)
+        } else {
+                    foreach($calendars as $calendar)
                 $this->makeForeground($calendar);
+        }
     }
 
     /**
@@ -90,8 +93,9 @@ 
     private function makeBackground(Company $company)
     {
         $event = $this->schedule->command('optimise:meetings '.$company->id)->withoutOverlapping();
-        if($event->isDue($this->laravel))
-            $event->run($this->laravel);
+        if($event->isDue($this->laravel)) {
+                    $event->run($this->laravel);
+        }
     }
 
     /**

app/Console/Commands/Optimise/Optimise.php

Braces +12 added lines, -9 removed lines

@@ -156,7 +156,7 @@ 
             $solver = $this->setData($solver);
             $solver = $solver->solve();
             $this->solver = $solver;
-        }catch(\Exception $e)
+        } catch(\Exception $e)
         {
             \Event::fire(new ErrorEvent($this->company, $e->getMessage()));
             throw new OptimiseException('Optimising error', 0, $e);
@@ -180,7 +180,7 @@ 
         try {
             $this->saveMeetings($this->solver);
             $this->saveEmployeesMeetings($this->solver);
-        }catch(\Exception $e)
+        } catch(\Exception $e)
         {
             \Event::fire(new ErrorEvent($this->company, $e->getMessage()));
             throw new OptimiseException('Optimising error', 0, $e);
@@ -327,7 +327,7 @@ 
             foreach($meetings as $meeting){
                 if($usersMeetingsTmp->contains('meeting_id', $meeting)){
                     $ret[$user][$meeting] = 1;
-                }else{
+                } else{
                     $ret[$user][$meeting] = 0;
                 }
             }
@@ -373,8 +373,9 @@ 
     static private function fillTimeSlots(array $array, $id, \Illuminate\Support\Collection $timeSlots, $fill = '0')
     {
         foreach($timeSlots as $timeSlot) {
-            if(!isset($array[$id]))
-                $array[$id] = [];
+            if(!isset($array[$id])) {
+                            $array[$id] = [];
+            }
             $array[$id] = self::arrayPadInterval($array[$id], $timeSlot->time_start, $timeSlot->time_end, $fill);
         }
         return $array;
@@ -389,8 +390,9 @@ 
     static private function fillRow(array $array, $id, $until, $fill = '0')
     {
         for($i = 1; $i <= $until; $i++){
-            if(!isset($array[$id][$i]))
-                $array[$id][$i] = $fill;
+            if(!isset($array[$id][$i])) {
+                            $array[$id][$i] = $fill;
+            }
         }
 
         return $array;
@@ -405,8 +407,9 @@ 
      */
     static private function arrayPadInterval(array $array, $from, $to, $pad = '0')
     {
-        for($i = $from; $i<$to; $i++)
-            $array[$i] = $pad;
+        for($i = $from; $i<$to; $i++) {
+                    $array[$i] = $pad;
+        }
         return $array;
     }
 

app/Console/Commands/Optimise/Solver.php

Braces +60 added lines, -40 removed lines

@@ -112,8 +112,9 @@ 
      */
     static private function checkGlpsol()
     {
-        if(!(`which glpsol`))
-            throw new OptimiseException('glpsol is not installed');
+        if(!(`which glpsol`)) {
+                    throw new OptimiseException('glpsol is not installed');
+        }
     }
 
     /**
@@ -193,8 +194,9 @@ 
      */
     public function setTimeSlots($timeSlots)
     {
-        if(!is_int($timeSlots) || $timeSlots <=0)
-            throw new OptimiseException('$timeSlots is not integer or it is not >0');
+        if(!is_int($timeSlots) || $timeSlots <=0) {
+                    throw new OptimiseException('$timeSlots is not integer or it is not >0');
+        }
 
         $this->timeSlots = $timeSlots;
         return $this;
@@ -215,8 +217,9 @@ 
      */
     public function setMaxTimeSlots($maxTimeSlots)
     {
-        if(!is_int($maxTimeSlots) || $maxTimeSlots <=0)
-            throw new OptimiseException('$maxTimeSlots is not integer or it is not >0');
+        if(!is_int($maxTimeSlots) || $maxTimeSlots <=0) {
+                    throw new OptimiseException('$maxTimeSlots is not integer or it is not >0');
+        }
 
         $this->maxTimeSlots = $maxTimeSlots;
         return $this;
@@ -238,12 +241,14 @@ 
     public function setMeetingsAvailability($meetingsAvailability)
     {
         $meetings = array_keys($meetingsAvailability);
-        if(array_diff($meetings, $this->meetings))
-            throw new OptimiseException('meetings different from meetings set');
+        if(array_diff($meetings, $this->meetings)) {
+                    throw new OptimiseException('meetings different from meetings set');
+        }
         foreach($meetingsAvailability as $key=>$meetingsAvailabilityS) {
             $timeSlots = array_keys($meetingsAvailabilityS);
-            if(count($timeSlots) != $this->timeSlots)
-                throw new OptimiseException('timeSlots different from timeSlots set');
+            if(count($timeSlots) != $this->timeSlots) {
+                            throw new OptimiseException('timeSlots different from timeSlots set');
+            }
             $meetingsAvailability[$key] = self::arrayPad($meetingsAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0);
         }
 
@@ -273,8 +278,9 @@ 
         }
         foreach($meetingsDuration as $duration) {
             $duration = (int) $duration; //TODO fix this (fix for optimise)
-            if(!is_int($duration) || $duration <=0)
-                throw new OptimiseException('duration is not integer or it is not >0');
+            if(!is_int($duration) || $duration <=0) {
+                            throw new OptimiseException('duration is not integer or it is not >0');
+            }
         }
 
         $this->meetingsDuration = $meetingsDuration;
@@ -297,12 +303,14 @@ 
     public function setUsersAvailability($usersAvailability)
     {
         $users = array_keys($usersAvailability);
-        if(array_diff($users, $this->users))
-            throw new OptimiseException('users different from users set');
+        if(array_diff($users, $this->users)) {
+                    throw new OptimiseException('users different from users set');
+        }
         foreach($usersAvailability as $key=>$usersAvailabilityS) {
             $timeSlots = array_keys($usersAvailabilityS);
-            if(count($timeSlots) != $this->timeSlots)
-                throw new OptimiseException('timeSlots different from timeSlots set');
+            if(count($timeSlots) != $this->timeSlots) {
+                            throw new OptimiseException('timeSlots different from timeSlots set');
+            }
 
             $usersAvailability[$key] = self::arrayPad($usersAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0);
         }
@@ -327,12 +335,14 @@ 
     public function setUsersMeetings($usersMeetings)
     {
         $users = array_keys($usersMeetings);
-        if(array_diff($users, $this->users))
-            throw new OptimiseException('users different from users set');
+        if(array_diff($users, $this->users)) {
+                    throw new OptimiseException('users different from users set');
+        }
         foreach($usersMeetings as $usersMeetingsS) {
             $meetings = array_keys($usersMeetingsS);
-            if(array_diff($meetings, $this->meetings))
-                throw new OptimiseException('meetings different from meetings set');
+            if(array_diff($meetings, $this->meetings)) {
+                            throw new OptimiseException('meetings different from meetings set');
+            }
         }
 
         $this->usersMeetings = $usersMeetings;
@@ -430,8 +440,9 @@ 
     {
         $f = function ($fp, $data){
             foreach ($data as $key=>$field) {
-                foreach ($field as $key2=>$field2)
-                    fputcsv($fp, [$key, $key2, $field2]);
+                foreach ($field as $key2=>$field2) {
+                                    fputcsv($fp, [$key, $key2, $field2]);
+                }
             }
         };
 
@@ -448,8 +459,9 @@ 
     static private function writeCSV($file, $data, $heading, \Closure $writer)
     {
         $fp = @fopen($file, 'w');
-        if(!$fp)
-            throw new OptimiseException('problem during creation of a file');
+        if(!$fp) {
+                    throw new OptimiseException('problem during creation of a file');
+        }
 
         fputcsv($fp, $heading);
 
@@ -469,8 +481,9 @@ 
         $this->writeData();
         $this->writeModelFile();
         $event = $this->schedule->exec('glpsol --math '.$this->path->getModelPath())->sendOutputTo($this->path->getOutputPath())->after(function () { }); //this just to execute in foreground
-        if($event->isDue($this->laravel))
-            $event->run($this->laravel);
+        if($event->isDue($this->laravel)) {
+                    $event->run($this->laravel);
+        }
         //TODO catch glpsol errors
         return $this;
     }
@@ -483,8 +496,9 @@ 
         $strReplaceS = array('{USERS_PATH}', '{MEETINGS_PATH}', '{USER_AVAILABILITY_PATH}', '{MEETINGS_AVAILABILITY_PATH}', '{USER_MEETINGS_PATH}', '{MEETINGS_DURATION_PATH}', '{TIME_SLOTS}', '{MAX_TIME_SLOTS}', '{X_OUT_PATH}', '{Y_OUT_PATH}');
         $strReplaceR = array($this->path->getUsersPath(), $this->path->getMeetingsPath(), $this->path->getUsersAvailabilityPath(), $this->path->getMeetingsAvailabilityPath(), $this->path->getUsersMeetingsPath(), $this->path->getMeetingsDurationPath(), $this->timeSlots, $this->maxTimeSlots, $this->path->getXPath(), $this->path->getYPath());
         $f = @fopen($this->path->getModelPath(), "w");
-        if(!$f)
-            throw new OptimiseException('problem during creation of a file');
+        if(!$f) {
+                    throw new OptimiseException('problem during creation of a file');
+        }
         fwrite($f, str_replace($strReplaceS, $strReplaceR, file_get_contents(__DIR__ . "/model.stub")));
         fclose($f);
     }
@@ -513,8 +527,9 @@ 
      */
     public function getOutput()
     {
-        if(!($data = file_get_contents($this->path->getOutputPath())))
-            throw new OptimiseException('problems during reading the file');
+        if(!($data = file_get_contents($this->path->getOutputPath()))) {
+                    throw new OptimiseException('problems during reading the file');
+        }
         return $data;
     }
 
@@ -525,12 +540,14 @@ 
      */
     static private function readCSVFile($file)
     {
-        if(!file_exists($file) || !filesize($file))
-            throw new OptimiseException('no results file');
+        if(!file_exists($file) || !filesize($file)) {
+                    throw new OptimiseException('no results file');
+        }
 
         $handle = @fopen($file,"r");
-        if(!$handle)
-            throw new OptimiseException('problems during reading the file');
+        if(!$handle) {
+                    throw new OptimiseException('problems during reading the file');
+        }
 
         $ret = [];
         fgetcsv($handle); //skip head
@@ -577,9 +594,10 @@ 
      */
     private function checkArrayProprieties($proprieties)
     {
-        foreach($proprieties as $propriety)
-            if(count($this->$propriety)==0)
+        foreach($proprieties as $propriety) {
+                    if(count($this->$propriety)==0)
                 throw new OptimiseException($propriety.' is not set correctly');
+        }
     }
 
     /**
@@ -588,9 +606,10 @@ 
      */
     private function checkIntProprieties($proprieties)
     {
-        foreach($proprieties as $propriety)
-            if(!is_int($this->$propriety) || $this->$propriety <= 0)
+        foreach($proprieties as $propriety) {
+                    if(!is_int($this->$propriety) || $this->$propriety <= 0)
                 throw new OptimiseException($propriety.' is not set correctly');
+        }
     }
 
     /**
@@ -602,8 +621,9 @@ 
     static private function arrayPad(array $array, $len, $pad)
     {
         $len = $len - count($array);
-        for($i = 0; $i<$len; $i++)
-            $array[] = $pad;
+        for($i = 0; $i<$len; $i++) {
+                    $array[] = $pad;
+        }
         return $array;
     }
 }
\ No newline at end of file