@@ -37,8 +37,9 @@ |
||
| 37 | 37 | { |
| 38 | 38 | $employee = \Auth::user(); |
| 39 | 39 | $input = $request->only(['name', 'password']); |
| 40 | - if (isset($input['password'])) |
|
| 41 | - $input['password'] = bcrypt($input['password']); |
|
| 40 | + if (isset($input['password'])) { |
|
| 41 | + $input['password'] = bcrypt($input['password']); |
|
| 42 | + } |
|
| 42 | 43 | $employee->update($input); |
| 43 | 44 | return $employee; |
| 44 | 45 | } |
@@ -10,8 +10,8 @@ discard block |
||
| 10 | 10 | { |
| 11 | 11 | public function __construct() |
| 12 | 12 | { |
| 13 | - config(['auth.model' => \plunner\Employee::class]); |
|
| 14 | - config(['jwt.user' => \plunner\Employee::class]); |
|
| 13 | + config([ 'auth.model' => \plunner\Employee::class ]); |
|
| 14 | + config([ 'jwt.user' => \plunner\Employee::class ]); |
|
| 15 | 15 | $this->middleware('jwt.authandrefresh:mode-en'); |
| 16 | 16 | } |
| 17 | 17 | |
@@ -36,10 +36,10 @@ discard block |
||
| 36 | 36 | public function update(EmployeeRequest $request) |
| 37 | 37 | { |
| 38 | 38 | $employee = \Auth::user(); |
| 39 | - $input = $request->only(['name', 'password']); |
|
| 39 | + $input = $request->only([ 'name', 'password' ]); |
|
| 40 | 40 | //TODO authorize??? |
| 41 | - if (isset($input['password'])) |
|
| 42 | - $input['password'] = bcrypt($input['password']); |
|
| 41 | + if (isset($input[ 'password' ])) |
|
| 42 | + $input[ 'password' ] = bcrypt($input[ 'password' ]); |
|
| 43 | 43 | $employee->update($input); |
| 44 | 44 | return $employee; |
| 45 | 45 | } |
@@ -36,7 +36,7 @@ |
||
| 36 | 36 | * @param Exception $previous |
| 37 | 37 | * @param bool $empty |
| 38 | 38 | */ |
| 39 | - public function __construct($message = "", $code = 0, Exception $previous = null, $empty = false) |
|
| 39 | + public function __construct($message = "", $code = 0, Exception $previous = null, $empty = false) |
|
| 40 | 40 | { |
| 41 | 41 | parent::__construct($message, $code, $previous); |
| 42 | 42 | $this->empty = $empty; |
@@ -90,10 +90,11 @@ discard block |
||
| 90 | 90 | |
| 91 | 91 | //insert new timeslots |
| 92 | 92 | foreach ($events as $event) { |
| 93 | - if (!($event = $this->parseEvent($event))) |
|
| 94 | - \Event::fire(new ErrorEvent($this->calendar, 'problem during the parsing an event')); |
|
| 95 | - else |
|
| 96 | - $calendarMain->timeslots()->create($event); |
|
| 93 | + if (!($event = $this->parseEvent($event))) { |
|
| 94 | + \Event::fire(new ErrorEvent($this->calendar, 'problem during the parsing an event')); |
|
| 95 | + } else { |
|
| 96 | + $calendarMain->timeslots()->create($event); |
|
| 97 | + } |
|
| 97 | 98 | } |
| 98 | 99 | \Event::fire(new OkEvent($this->calendar)); |
| 99 | 100 | } |
@@ -110,8 +111,9 @@ discard block |
||
| 110 | 111 | $caldavClient = new SimpleCaldavAdapter(); |
| 111 | 112 | $caldavClient->connect($this->calendar->url, $this->calendar->username, \Crypt::decrypt($this->calendar->password)); |
| 112 | 113 | $calendars = $caldavClient->findCalendars(); |
| 113 | - if(!isset($calendars[$this->calendar->calendar_name])) |
|
| 114 | - throw new CaldavException("calendar inserted doesn't exist"); |
|
| 114 | + if(!isset($calendars[$this->calendar->calendar_name])) { |
|
| 115 | + throw new CaldavException("calendar inserted doesn't exist"); |
|
| 116 | + } |
|
| 115 | 117 | $caldavClient->setCalendar($calendars[$this->calendar->calendar_name]);//TODO error if the calendar name is wrong |
| 116 | 118 | /** |
| 117 | 119 | * 26 hours before to avoid tiemezone problems and dst problems |
@@ -128,17 +130,20 @@ discard block |
||
| 128 | 130 | { |
| 129 | 131 | $pattern = "/^((DTSTART;)|(DTEND;))(.*)\$/m"; |
| 130 | 132 | if (preg_match_all($pattern, $event->getData(), $matches)) { |
| 131 | - if (!isset($matches[4]) || count($matches[4]) != 2) |
|
| 132 | - return null; |
|
| 133 | + if (!isset($matches[4]) || count($matches[4]) != 2) { |
|
| 134 | + return null; |
|
| 135 | + } |
|
| 133 | 136 | $ret = []; |
| 134 | - if ($tmp = $this->parseDate($matches[4][0])) |
|
| 135 | - $ret['time_start'] = $tmp; |
|
| 136 | - else |
|
| 137 | - return null; |
|
| 138 | - if ($tmp = $this->parseDate($matches[4][1])) |
|
| 139 | - $ret['time_end'] = $tmp; |
|
| 140 | - else |
|
| 141 | - return null; |
|
| 137 | + if ($tmp = $this->parseDate($matches[4][0])) { |
|
| 138 | + $ret['time_start'] = $tmp; |
|
| 139 | + } else { |
|
| 140 | + return null; |
|
| 141 | + } |
|
| 142 | + if ($tmp = $this->parseDate($matches[4][1])) { |
|
| 143 | + $ret['time_end'] = $tmp; |
|
| 144 | + } else { |
|
| 145 | + return null; |
|
| 146 | + } |
|
| 142 | 147 | return $ret; |
| 143 | 148 | } |
| 144 | 149 | return null; |
@@ -110,9 +110,9 @@ discard block |
||
| 110 | 110 | $caldavClient = new SimpleCaldavAdapter(); |
| 111 | 111 | $caldavClient->connect($this->calendar->url, $this->calendar->username, \Crypt::decrypt($this->calendar->password)); |
| 112 | 112 | $calendars = $caldavClient->findCalendars(); |
| 113 | - if(!isset($calendars[$this->calendar->calendar_name])) |
|
| 113 | + if (!isset($calendars[ $this->calendar->calendar_name ])) |
|
| 114 | 114 | throw new CaldavException("calendar inserted doesn't exist"); |
| 115 | - $caldavClient->setCalendar($calendars[$this->calendar->calendar_name]); |
|
| 115 | + $caldavClient->setCalendar($calendars[ $this->calendar->calendar_name ]); |
|
| 116 | 116 | /** |
| 117 | 117 | * 26 hours before to avoid tiemezone problems and dst problems |
| 118 | 118 | * 30 days after |
@@ -128,15 +128,15 @@ discard block |
||
| 128 | 128 | { |
| 129 | 129 | $pattern = "/^((DTSTART;)|(DTEND;))(.*)\$/m"; |
| 130 | 130 | if (preg_match_all($pattern, $event->getData(), $matches)) { |
| 131 | - if (!isset($matches[4]) || count($matches[4]) != 2) |
|
| 131 | + if (!isset($matches[ 4 ]) || count($matches[ 4 ]) != 2) |
|
| 132 | 132 | return null; |
| 133 | - $ret = []; |
|
| 134 | - if ($tmp = $this->parseDate($matches[4][0])) |
|
| 135 | - $ret['time_start'] = $tmp; |
|
| 133 | + $ret = [ ]; |
|
| 134 | + if ($tmp = $this->parseDate($matches[ 4 ][ 0 ])) |
|
| 135 | + $ret[ 'time_start' ] = $tmp; |
|
| 136 | 136 | else |
| 137 | 137 | return null; |
| 138 | - if ($tmp = $this->parseDate($matches[4][1])) |
|
| 139 | - $ret['time_end'] = $tmp; |
|
| 138 | + if ($tmp = $this->parseDate($matches[ 4 ][ 1 ])) |
|
| 139 | + $ret[ 'time_end' ] = $tmp; |
|
| 140 | 140 | else |
| 141 | 141 | return null; |
| 142 | 142 | return $ret; |
@@ -152,10 +152,10 @@ discard block |
||
| 152 | 152 | { |
| 153 | 153 | $pattern = "/^((TZID=)|(VALUE=))(.*):(.*)\$/m"; |
| 154 | 154 | if (preg_match_all($pattern, $date, $matches)) { |
| 155 | - if ($matches[1][0] == 'TZID=') { |
|
| 156 | - return \DateTime::createFromFormat('Ymd\THis', $matches[5][0], new \DateTimeZone($matches[4][0])); |
|
| 157 | - } else if ($matches[1][0] == 'VALUE=' && $matches[4][0] == 'DATE') { |
|
| 158 | - return \DateTime::createFromFormat('Ymd\THis', $matches[5][0] . 'T000000'); |
|
| 155 | + if ($matches[ 1 ][ 0 ] == 'TZID=') { |
|
| 156 | + return \DateTime::createFromFormat('Ymd\THis', $matches[ 5 ][ 0 ], new \DateTimeZone($matches[ 4 ][ 0 ])); |
|
| 157 | + } else if ($matches[ 1 ][ 0 ] == 'VALUE=' && $matches[ 4 ][ 0 ] == 'DATE') { |
|
| 158 | + return \DateTime::createFromFormat('Ymd\THis', $matches[ 5 ][ 0 ].'T000000'); |
|
| 159 | 159 | } |
| 160 | 160 | } |
| 161 | 161 | return null; |
@@ -70,17 +70,17 @@ discard block |
||
| 70 | 70 | */ |
| 71 | 71 | private function makeForeground(Company $company) |
| 72 | 72 | { |
| 73 | - $this->info('Optimisation company ' . $company->id . ' started'); |
|
| 73 | + $this->info('Optimisation company '.$company->id.' started'); |
|
| 74 | 74 | try { |
| 75 | 75 | (new Optimise($company, $this->schedule, $this->laravel))->optimise()->save(); |
| 76 | - $this->info('Optimisation ' . $company->id . ' completed'); |
|
| 77 | - }catch(OptimiseException $e) { |
|
| 76 | + $this->info('Optimisation '.$company->id.' completed'); |
|
| 77 | + } catch (OptimiseException $e) { |
|
| 78 | 78 | if ($e->isEmpty()) { |
| 79 | - $mex = 'Company ' . $company->id . ' doesn\'t have sufficient data'; |
|
| 79 | + $mex = 'Company '.$company->id.' doesn\'t have sufficient data'; |
|
| 80 | 80 | $this->warn($mex); |
| 81 | 81 | \Log::info($mex); |
| 82 | 82 | } else { |
| 83 | - $mex = 'Error during optimisation of company ' . $company->id . ': ' . $e->getMessage(); |
|
| 83 | + $mex = 'Error during optimisation of company '.$company->id.': '.$e->getMessage(); |
|
| 84 | 84 | $this->error($mex); |
| 85 | 85 | //TODO log cause, but don't send it to the user |
| 86 | 86 | //\Log::error($mex); //already logged in listener |
@@ -109,7 +109,7 @@ discard block |
||
| 109 | 109 | */ |
| 110 | 110 | private function makeBackground(Company $company) |
| 111 | 111 | { |
| 112 | - $event = $this->schedule->command('optimise:meetings ' . $company->id)->withoutOverlapping(); |
|
| 112 | + $event = $this->schedule->command('optimise:meetings '.$company->id)->withoutOverlapping(); |
|
| 113 | 113 | if ($event->isDue($this->laravel)) |
| 114 | 114 | $event->run($this->laravel); |
| 115 | 115 | } |
@@ -58,10 +58,11 @@ discard block |
||
| 58 | 58 | //TODO insert a timeout |
| 59 | 59 | //TODO try...catch with destruct |
| 60 | 60 | $companyId = $this->argument('companyId'); |
| 61 | - if (is_numeric($companyId)) |
|
| 62 | - $this->makeForeground(Company::findOrFail($companyId)); |
|
| 63 | - else |
|
| 64 | - $this->syncAll(); |
|
| 61 | + if (is_numeric($companyId)) { |
|
| 62 | + $this->makeForeground(Company::findOrFail($companyId)); |
|
| 63 | + } else { |
|
| 64 | + $this->syncAll(); |
|
| 65 | + } |
|
| 65 | 66 | } |
| 66 | 67 | |
| 67 | 68 | /** |
@@ -74,7 +75,7 @@ discard block |
||
| 74 | 75 | try { |
| 75 | 76 | (new Optimise($company, $this->schedule, $this->laravel))->optimise()->save(); |
| 76 | 77 | $this->info('Optimisation ' . $company->id . ' completed'); |
| 77 | - }catch(OptimiseException $e) { |
|
| 78 | + } catch(OptimiseException $e) { |
|
| 78 | 79 | if ($e->isEmpty()) { |
| 79 | 80 | $mex = 'Company ' . $company->id . ' doesn\'t have sufficient data'; |
| 80 | 81 | $this->warn($mex); |
@@ -94,13 +95,15 @@ discard block |
||
| 94 | 95 | if ($this->option('background')) { |
| 95 | 96 | \Log::debug(self::BACKGROUND_MOD_MEX); |
| 96 | 97 | $this->info(self::BACKGROUND_MOD_MEX); |
| 97 | - foreach ($companies as $company) |
|
| 98 | - $this->makeBackground($company); |
|
| 98 | + foreach ($companies as $company) { |
|
| 99 | + $this->makeBackground($company); |
|
| 100 | + } |
|
| 99 | 101 | \Log::debug(self::BACKGROUND_COMPLETED_MEX); |
| 100 | 102 | $this->info(self::BACKGROUND_COMPLETED_MEX); |
| 101 | - } else |
|
| 102 | - foreach ($companies as $company) |
|
| 103 | + } else { |
|
| 104 | + foreach ($companies as $company) |
|
| 103 | 105 | $this->makeForeground($company); |
| 106 | + } |
|
| 104 | 107 | } |
| 105 | 108 | |
| 106 | 109 | /** |
@@ -110,7 +113,8 @@ discard block |
||
| 110 | 113 | private function makeBackground(Company $company) |
| 111 | 114 | { |
| 112 | 115 | $event = $this->schedule->command('optimise:meetings ' . $company->id)->withoutOverlapping(); |
| 113 | - if ($event->isDue($this->laravel)) |
|
| 114 | - $event->run($this->laravel); |
|
| 116 | + if ($event->isDue($this->laravel)) { |
|
| 117 | + $event->run($this->laravel); |
|
| 118 | + } |
|
| 115 | 119 | } |
| 116 | 120 | } |
@@ -26,7 +26,7 @@ |
||
| 26 | 26 | { |
| 27 | 27 | // |
| 28 | 28 | $calendar = $event->getCalendar(); |
| 29 | - \Log::info('caldav (calendar id = ' . $calendar->calendar_id . ') correctly synchronized'); |
|
| 29 | + \Log::info('caldav (calendar id = '.$calendar->calendar_id.') correctly synchronized'); |
|
| 30 | 30 | //$calendar = $event->getCalendar()->fresh(); |
| 31 | 31 | $calendar->sync_errors = ''; |
| 32 | 32 | $calendar->save(); |
@@ -25,7 +25,7 @@ discard block |
||
| 25 | 25 | public function handle(ErrorEvent $event) |
| 26 | 26 | { |
| 27 | 27 | // |
| 28 | - \Log::error('problems during optimise (company id = ' . $event->getCompany()->id . '): ' . $event->getError()); |
|
| 28 | + \Log::error('problems during optimise (company id = '.$event->getCompany()->id.'): '.$event->getError()); |
|
| 29 | 29 | $company = $event->getCompany(); |
| 30 | 30 | //$company = $event->getCompany()->fresh(); |
| 31 | 31 | self::sendEmail($company->email, $event->getError()); |
@@ -37,7 +37,7 @@ discard block |
||
| 37 | 37 | */ |
| 38 | 38 | static private function sendEmail($email, $error) |
| 39 | 39 | { |
| 40 | - \Mail::queue('emails.optimise.error', ['error' => $error], function ($message) use ($email) { |
|
| 40 | + \Mail::queue('emails.optimise.error', [ 'error' => $error ], function($message) use ($email) { |
|
| 41 | 41 | $message->from(config('mail.from.address'), config('mail.from.name')); |
| 42 | 42 | $message->to($email)->subject('Problems during optimisation'); |
| 43 | 43 | }); |
@@ -26,19 +26,19 @@ |
||
| 26 | 26 | * |
| 27 | 27 | * @var array |
| 28 | 28 | */ |
| 29 | - protected $fillable = ['time_start', 'time_end']; |
|
| 29 | + protected $fillable = [ 'time_start', 'time_end' ]; |
|
| 30 | 30 | |
| 31 | 31 | /** |
| 32 | 32 | * The attributes excluded from the model's JSON form. |
| 33 | 33 | * |
| 34 | 34 | * @var array |
| 35 | 35 | */ |
| 36 | - protected $hidden = ['pivot', 'calendar']; |
|
| 36 | + protected $hidden = [ 'pivot', 'calendar' ]; |
|
| 37 | 37 | |
| 38 | 38 | /** |
| 39 | 39 | * @var array |
| 40 | 40 | */ |
| 41 | - protected $touches = ['calendar']; |
|
| 41 | + protected $touches = [ 'calendar' ]; |
|
| 42 | 42 | |
| 43 | 43 | /** |
| 44 | 44 | * @return \Illuminate\Database\Eloquent\Relations\BelongsTo |
@@ -34,12 +34,12 @@ |
||
| 34 | 34 | \JWTFactory::setTTL(43200); |
| 35 | 35 | //config(['jwt.ttl' =>'43200']); //30 days |
| 36 | 36 | } |
| 37 | - }catch(JWTException $e) |
|
| 37 | + } catch (JWTException $e) |
|
| 38 | 38 | {} |
| 39 | 39 | |
| 40 | 40 | //this to add the remember me mode field in the new token, but we have the custom check that is an useless |
| 41 | 41 | //overhead |
| 42 | - $custom = $custom . ';remember-' . $remember == 'true' ? 'true' : 'false'; |
|
| 42 | + $custom = $custom.';remember-'.$remember == 'true' ? 'true' : 'false'; |
|
| 43 | 43 | return parent::handle($request, $next, $custom); |
| 44 | 44 | } |
| 45 | 45 | |
@@ -34,7 +34,7 @@ |
||
| 34 | 34 | \JWTFactory::setTTL(43200); |
| 35 | 35 | //config(['jwt.ttl' =>'43200']); //30 days |
| 36 | 36 | } |
| 37 | - }catch(JWTException $e) |
|
| 37 | + } catch(JWTException $e) |
|
| 38 | 38 | {} |
| 39 | 39 | |
| 40 | 40 | //this to add the remember me mode field in the new token, but we have the custom check that is an useless |
@@ -47,12 +47,12 @@ |
||
| 47 | 47 | |
| 48 | 48 | private static function withFilter() |
| 49 | 49 | { |
| 50 | - return ['groups' => function ($query) { |
|
| 50 | + return [ 'groups' => function($query) { |
|
| 51 | 51 | $query->select('id', 'company_id'); |
| 52 | - }, 'groups.meetings' => function ($query) { |
|
| 52 | + }, 'groups.meetings' => function($query) { |
|
| 53 | 53 | $query->select('id', 'group_id', 'start_time'); |
| 54 | - }, 'groups.meetings.employees' => function ($query) { |
|
| 54 | + }, 'groups.meetings.employees' => function($query) { |
|
| 55 | 55 | $query->select('id'); |
| 56 | - }]; |
|
| 56 | + } ]; |
|
| 57 | 57 | } |
| 58 | 58 | } |
@@ -39,10 +39,11 @@ |
||
| 39 | 39 | { |
| 40 | 40 | // |
| 41 | 41 | $companyId = $this->argument('companyId'); |
| 42 | - if (is_numeric($companyId)) |
|
| 43 | - print_r(Company::with(self::withFilter())->findOrFail($companyId)->toArray()); |
|
| 44 | - else |
|
| 45 | - print_r(Company::with(self::withFilter())->select('id')->get()->toArray()); |
|
| 42 | + if (is_numeric($companyId)) { |
|
| 43 | + print_r(Company::with(self::withFilter())->findOrFail($companyId)->toArray()); |
|
| 44 | + } else { |
|
| 45 | + print_r(Company::with(self::withFilter())->select('id')->get()->toArray()); |
|
| 46 | + } |
|
| 46 | 47 | } |
| 47 | 48 | |
| 48 | 49 | private static function withFilter() |