dsd-meetme / backend

app/Calendar.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
      *
      * @var array
      */
-    protected $fillable = ['name', 'enabled'];
+    protected $fillable = [ 'name', 'enabled' ];
 
     /**
      * @return \Illuminate\Database\Eloquent\Relations\BelongsTo

app/Http/routes.php

Spacing +28 added lines, -28 removed lines

@@ -18,36 +18,36 @@ 
 /**
  * Companies
  */
-Route::group(['namespace' => 'Companies', 'prefix' => 'companies'], function() {
+Route::group([ 'namespace' => 'Companies', 'prefix' => 'companies' ], function() {
 
     //\Auth
 
-    Route::group(['namespace' => 'Auth'], function() {
-        Route::group(['prefix' => 'auth'], function () {
+    Route::group([ 'namespace' => 'Auth' ], function() {
+        Route::group([ 'prefix' => 'auth' ], function() {
             // Authentication routes...
-            Route::post('login', ['as' => 'companies.auth.login','uses'=>'AuthController@postLogin']);
+            Route::post('login', [ 'as' => 'companies.auth.login', 'uses'=>'AuthController@postLogin' ]);
 
             // Registration routes...
-            Route::post('register', ['as' => 'companies.auth.register', 'uses'=>'AuthController@postRegister']);
+            Route::post('register', [ 'as' => 'companies.auth.register', 'uses'=>'AuthController@postRegister' ]);
 
         });
 
-        Route::group(['prefix' => 'password'], function () {
+        Route::group([ 'prefix' => 'password' ], function() {
             // Password reset link request routes...
-            Route::post('email', ['as' => 'companies.auth.email', 'uses'=>'PasswordController@postEmail']);
+            Route::post('email', [ 'as' => 'companies.auth.email', 'uses'=>'PasswordController@postEmail' ]);
 
             // Password reset routes...
-            Route::post('reset', ['as' => 'companies.auth.reset', 'uses'=>'PasswordController@postReset']);
+            Route::post('reset', [ 'as' => 'companies.auth.reset', 'uses'=>'PasswordController@postReset' ]);
         });
     });
 
-    Route::group(['namespace' => 'Employees'], function() {
-        Route::resource('employees', 'EmployeesController', ['except' => ['create', 'edit']]);
+    Route::group([ 'namespace' => 'Employees' ], function() {
+        Route::resource('employees', 'EmployeesController', [ 'except' => [ 'create', 'edit' ] ]);
     });
 
-    Route::group(['namespace' => 'Groups'], function() {
-        Route::resource('groups', 'GroupsController', ['except' => ['create', 'edit']]);
-        Route::resource('groups.employees', 'EmployeesController', ['only' => ['store', 'index', 'destroy']]);
+    Route::group([ 'namespace' => 'Groups' ], function() {
+        Route::resource('groups', 'GroupsController', [ 'except' => [ 'create', 'edit' ] ]);
+        Route::resource('groups.employees', 'EmployeesController', [ 'only' => [ 'store', 'index', 'destroy' ] ]);
     });
 });
 
@@ -55,39 +55,39 @@ 
 /**
  * Employees
  */
-Route::group(['namespace' => 'Employees', 'prefix' => 'employees'], function() {
+Route::group([ 'namespace' => 'Employees', 'prefix' => 'employees' ], function() {
 
     //\Auth
-    Route::group(['namespace' => 'Auth'], function() {
-        Route::group(['prefix' => 'auth'], function () {
+    Route::group([ 'namespace' => 'Auth' ], function() {
+        Route::group([ 'prefix' => 'auth' ], function() {
             // Authentication routes...
-            Route::post('login', ['as' => 'companies.auth.login', 'uses'=>'AuthController@postLogin']);
+            Route::post('login', [ 'as' => 'companies.auth.login', 'uses'=>'AuthController@postLogin' ]);
 
             // Registration routes...
             //Route::post('register', ['as' => 'companies.auth.register', 'uses'=>'AuthController@postRegister']); //the registration is managed by the company
 
         });
 
-        Route::group(['prefix' => 'password'], function () {
+        Route::group([ 'prefix' => 'password' ], function() {
             // Password reset link request routes...
-            Route::post('email', ['as' => 'companies.auth.email', 'uses'=>'PasswordController@postEmail']);
+            Route::post('email', [ 'as' => 'companies.auth.email', 'uses'=>'PasswordController@postEmail' ]);
 
             // Password reset routes...
-            Route::post('reset', ['as' => 'companies.auth.reset', 'uses'=>'PasswordController@postReset']);
+            Route::post('reset', [ 'as' => 'companies.auth.reset', 'uses'=>'PasswordController@postReset' ]);
         });
     });
 
-    Route::group(['namespace' => 'Calendars'], function() {
-        Route::resource('calendars', 'CalendarsController', ['except' => ['create', 'edit']]);
-        Route::post('calendars/caldav', ['as' => 'employees.calendars.caldav','uses'=>'CalendarsController@storeCaldav']);
-        Route::post('calendars/calendars', ['as' => 'employees.calendars.calendars','uses'=>'CalendarsController@getCalendars']); //TODO it's correct post? or not
+    Route::group([ 'namespace' => 'Calendars' ], function() {
+        Route::resource('calendars', 'CalendarsController', [ 'except' => [ 'create', 'edit' ] ]);
+        Route::post('calendars/caldav', [ 'as' => 'employees.calendars.caldav', 'uses'=>'CalendarsController@storeCaldav' ]);
+        Route::post('calendars/calendars', [ 'as' => 'employees.calendars.calendars', 'uses'=>'CalendarsController@getCalendars' ]); //TODO it's correct post? or not
     });
 
-    Route::group(['namespace' => 'Planners', 'prefix' => 'planners'], function() {
-        Route::resource('groups', 'GroupsController', ['only' => ['index', 'show']]);
+    Route::group([ 'namespace' => 'Planners', 'prefix' => 'planners' ], function() {
+        Route::resource('groups', 'GroupsController', [ 'only' => [ 'index', 'show' ] ]);
     });
 
-    Route::group(['namespace' => 'Groups'], function() {
-        Route::resource('groups', 'GroupsController', ['only' => ['index', 'show']]);
+    Route::group([ 'namespace' => 'Groups' ], function() {
+        Route::resource('groups', 'GroupsController', [ 'only' => [ 'index', 'show' ] ]);
     });
 });
\ No newline at end of file

app/MeetingTimeslot.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
      *
      * @var array
      */
-    protected $fillable = ['time_start', 'time_end'];
+    protected $fillable = [ 'time_start', 'time_end' ];
 
     public function employees()
     {

app/Http/Controllers/Employees/Calendars/CalendarsController.php

Spacing +11 added lines, -11 removed lines

@@ -17,8 +17,8 @@ 
      */
     public function __construct()
     {
-        config(['auth.model' => \plunner\Employee::class]);
-        config(['jwt.user' => \plunner\Employee::class]);
+        config([ 'auth.model' => \plunner\Employee::class ]);
+        config([ 'jwt.user' => \plunner\Employee::class ]);
         $this->middleware('jwt.authandrefresh:mode-en');
     }
 
@@ -66,8 +66,8 @@ 
         $employee = \Auth::user();
         $input = $request->all();
         $calendar = $employee->calendars()->create($input);
-        if(isset($input['password']))
-            $input['password'] = \Crypt::encrypt($input['password']);
+        if (isset($input[ 'password' ]))
+            $input[ 'password' ] = \Crypt::encrypt($input[ 'password' ]);
         $calendar->caldav()->create($input);
         //TODO test
         //TODO validator
@@ -104,17 +104,17 @@ 
         $this->authorize($calendar);
         $input = $request->all();
         $caldav = $calendar->caldav;
-        if($caldav){
+        if ($caldav) {
             $this->validateCaldav($request);
         }
-        if(isset($input['password']))
-            $input['password'] = \Crypt::encrypt($input['password']);
+        if (isset($input[ 'password' ]))
+            $input[ 'password' ] = \Crypt::encrypt($input[ 'password' ]);
         $calendar->update($input);
         //TODO test
         //TODO validator
         //TODO check if caldav exists?
 
-        if($caldav)
+        if ($caldav)
             $caldav->update($input);
         return $calendar;
     }
@@ -148,9 +148,9 @@ 
             $caldavClient->connect($request->input('url'), $request->input('username'), $request->input('password'));
             $calendars = $caldavClient->findCalendars();
             return array_keys($calendars);
-        }catch (\it\thecsea\caldav_client_adapter\CaldavException $e)
+        } catch (\it\thecsea\caldav_client_adapter\CaldavException $e)
         {
-            return Response::json(['error' => $e->getMessage()],422);
+            return Response::json([ 'error' => $e->getMessage() ], 422);
         }
     }
 
@@ -162,7 +162,7 @@ 
         $this->validate($request, [
             'url' => 'required|max:255',
             'username' => 'required|max:255',
-            'password' => ((\Route::current()->getName() == 'companies.calendars.caldav')?'required':''),
+            'password' => ((\Route::current()->getName() == 'companies.calendars.caldav') ? 'required' : ''),
             'calendar_name' => 'required|max:255',
         ]);
     }

Braces +10 added lines, -7 removed lines

@@ -66,8 +66,9 @@ 
         $employee = \Auth::user();
         $input = $request->all();
         $calendar = $employee->calendars()->create($input);
-        if(isset($input['password']))
-            $input['password'] = \Crypt::encrypt($input['password']);
+        if(isset($input['password'])) {
+                    $input['password'] = \Crypt::encrypt($input['password']);
+        }
         $calendar->caldav()->create($input);
         //TODO test
         //TODO validator
@@ -107,15 +108,17 @@ 
         if($caldav){
             $this->validateCaldav($request);
         }
-        if(isset($input['password']))
-            $input['password'] = \Crypt::encrypt($input['password']);
+        if(isset($input['password'])) {
+                    $input['password'] = \Crypt::encrypt($input['password']);
+        }
         $calendar->update($input);
         //TODO test
         //TODO validator
         //TODO check if caldav exists?
 
-        if($caldav)
-            $caldav->update($input);
+        if($caldav) {
+                    $caldav->update($input);
+        }
         return $calendar;
     }
 
@@ -148,7 +151,7 @@ 
             $caldavClient->connect($request->input('url'), $request->input('username'), $request->input('password'));
             $calendars = $caldavClient->findCalendars();
             return array_keys($calendars);
-        }catch (\it\thecsea\caldav_client_adapter\CaldavException $e)
+        } catch (\it\thecsea\caldav_client_adapter\CaldavException $e)
         {
             return Response::json(['error' => $e->getMessage()],422);
         }

app/Meeting.php

Spacing +2 added lines, -2 removed lines

@@ -46,14 +46,14 @@
      *
      * @var array
      */
-    protected $fillable = ['title', 'description', 'duration'];
+    protected $fillable = [ 'title', 'description', 'duration' ];
 
     /**
      * The attributes excluded from the model's JSON form.
      *
      * @var array
      */
-    protected $hidden = ['pivot'];
+    protected $hidden = [ 'pivot' ];
 
 
     /**

app/Listeners/Caldav/OkListener.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace plunner\Listeners;
 
 use plunner\Events\CaldavErrorEvent;
-use Illuminate\Queue\InteractsWithQueue;
-use Illuminate\Contracts\Queue\ShouldQueue;
 
 class CaldavErrorListener
 {

app/Events/Caldav/OkEvent.php

Spacing +1 added lines, -1 removed lines

@@ -39,6 +39,6 @@
      */
     public function broadcastOn()
     {
-        return [];
+        return [ ];
     }
 }

app/Console/Commands/Optimise/Optimise.php

Doc Comments +6 added lines, -5 removed lines

@@ -303,10 +303,10 @@ 
     }
 
     /**
-     * @param array $users
-     * @param array $meetings
+     * @param string[] $users
+     * @param string[] $meetings
      * @param \Illuminate\Support\Collection $usersMeetings
-     * @return array
+     * @return \string[]
      */
     static private function getUsersMeetingsArray($users, $meetings, \Illuminate\Support\Collection $usersMeetings)
     {
@@ -338,8 +338,9 @@ 
 
     /**
      * @param \Illuminate\Support\Collection $timeSlots
-     * @param bool|true $free if true the array is filled with 1 for timeslots values else with 0 for timeslots values
-     * @return array
+     * @param boolean $free if true the array is filled with 1 for timeslots values else with 0 for timeslots values
+     * @param integer $timeslotsN
+     * @return \string[]
      */
     static private function getAvailabilityArray(\Illuminate\Support\Collection $timeSlots, $timeslotsN, $free=true)
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -9,8 +9,8 @@
 namespace plunner\Console\Commands\Optimise;
 
 use Illuminate\Console\Scheduling\Schedule;
-use plunner\company;
 use plunner\Events\Optimise\ErrorEvent;
+use plunner\company;
 
 /**
  * Class Optimise

Indentation +8 added lines, -8 removed lines

@@ -1,10 +1,10 @@ 
 <?php
 /**
- * Created by PhpStorm.
- * User: claudio
- * Date: 12/12/15
- * Time: 15.41
- */
+     * Created by PhpStorm.
+     * User: claudio
+     * Date: 12/12/15
+     * Time: 15.41
+     */
 
 namespace plunner\Console\Commands\Optimise;
 
@@ -45,8 +45,8 @@ 
     private $company;
 
     /**
-    * @var Schedule laravel schedule object needed to perform command in background
-    */
+     * @var Schedule laravel schedule object needed to perform command in background
+     */
     private $schedule;
 
     /**
@@ -413,7 +413,7 @@ 
         $diff = explode(':',$diff->format('%R:%d:%h:%i:%s'));
         $diff = $diff[1]*86400 + $diff[2]*3600 + $diff[3]*60 + $diff[4];
         //if($diff[0] != '-' && $diff != 0)
-          //  throw new OptimiseException('timeslot time <= startTime');
+            //  throw new OptimiseException('timeslot time <= startTime');
         //TODO fix check
         //TODO check if diff makes sense
         //TODO check upper limit

Spacing +33 added lines, -33 removed lines

@@ -85,7 +85,7 @@ 
     {
         $this->startTime = clone $startTime;
         $this->endTime = clone $this->startTime;
-        $this->endTime->add(new \DateInterval('PT'.(($this->max_time_slots+$this->time_slots)*self::TIME_SLOT_DURATION).'S'));
+        $this->endTime->add(new \DateInterval('PT'.(($this->max_time_slots + $this->time_slots) * self::TIME_SLOT_DURATION).'S'));
     }
 
     /**
@@ -169,7 +169,7 @@ 
      */
     public function save()
     {
-        if(!($this->solver instanceof Solver)) {
+        if (!($this->solver instanceof Solver)) {
             \Event::fire(new ErrorEvent($this->company, 'solver is not an instace of Solver'));
             return;
         }
@@ -186,8 +186,8 @@ 
     private function saveMeetings(Solver $solver)
     {
         $meetings = $solver->getYResults();
-        foreach($meetings as $id=>$meeting){
-            $meetingO = \plunner\Meeting::findOrFail($id);//TODO catch error
+        foreach ($meetings as $id=>$meeting) {
+            $meetingO = \plunner\Meeting::findOrFail($id); //TODO catch error
             $meetingO->start_time = $this->toDateTime(array_search('1', $meeting));
             $meetingO->save();
         }
@@ -199,11 +199,11 @@ 
     private function saveEmployeesMeetings(Solver $solver)
     {
         $employeesMeetings = $solver->getXResults();
-        foreach($employeesMeetings as $eId =>$employeeMeetings)
+        foreach ($employeesMeetings as $eId =>$employeeMeetings)
         {
             $employee = \plunner\Employee::findOrFail($eId);
             $employeeMeetings = collect($employeeMeetings);
-            $employeeMeetings = $employeeMeetings->filter(function ($item) {
+            $employeeMeetings = $employeeMeetings->filter(function($item) {
                 return $item == 1;
             });
             $employee->meetings()->attach($employeeMeetings->keys()->toArray());
@@ -264,7 +264,7 @@ 
                 return $this->timeSlotsConverter($item);
             });
         return $solver->setMeetings($timeslots->keys()->toArray())
-            ->setMeetingsDuration($meetings->pluck('duration','id')->toArray())
+            ->setMeetingsDuration($meetings->pluck('duration', 'id')->toArray())
             ->setMeetingsAvailability(self::getAvailabilityArray($timeslots, $this->time_slots));
     }
 
@@ -310,15 +310,15 @@ 
      */
     static private function getUsersMeetingsArray($users, $meetings, \Illuminate\Support\Collection $usersMeetings)
     {
-        $ret = [];
-        foreach($users as $user)
+        $ret = [ ];
+        foreach ($users as $user)
         {
             $usersMeetingsTmp = $usersMeetings->get($user);
-            foreach($meetings as $meeting){
-                if($usersMeetingsTmp->contains('meeting_id', $meeting)){
-                    $ret[$user][$meeting] = 1;
-                }else{
-                    $ret[$user][$meeting] = 0;
+            foreach ($meetings as $meeting) {
+                if ($usersMeetingsTmp->contains('meeting_id', $meeting)) {
+                    $ret[ $user ][ $meeting ] = 1;
+                } else {
+                    $ret[ $user ][ $meeting ] = 0;
                 }
             }
         }
@@ -328,7 +328,7 @@ 
 
     private function timeSlotsConverter($item)
     {
-        return $item->each(function($item2){
+        return $item->each(function($item2) {
             $item2->time_start = $this->toTimeSlot($item2->time_start);
             $item2->time_end = $this->toTimeSlot($item2->time_end);
             return $item2;
@@ -341,13 +341,13 @@ 
      * @param bool|true $free if true the array is filled with 1 for timeslots values else with 0 for timeslots values
      * @return array
      */
-    static private function getAvailabilityArray(\Illuminate\Support\Collection $timeSlots, $timeslotsN, $free=true)
+    static private function getAvailabilityArray(\Illuminate\Support\Collection $timeSlots, $timeslotsN, $free = true)
     {
-        $ret = [];
-        foreach($timeSlots as $id=>$timeSlots2)
+        $ret = [ ];
+        foreach ($timeSlots as $id=>$timeSlots2)
         {
-            $ret = self::fillTimeSlots($ret, $id, $timeSlots2, $free?'1':'0');
-            $ret = self::fillRow($ret, $id, $timeslotsN, $free?'0':'1');
+            $ret = self::fillTimeSlots($ret, $id, $timeSlots2, $free ? '1' : '0');
+            $ret = self::fillRow($ret, $id, $timeslotsN, $free ? '0' : '1');
         }
 
         return $ret;
@@ -362,10 +362,10 @@ 
      */
     static private function fillTimeSlots(array $array, $id, \Illuminate\Support\Collection $timeSlots, $fill = '0')
     {
-        foreach($timeSlots as $timeSlot) {
-            if(!isset($array[$id]))
-                $array[$id] = [];
-            $array[$id] = self::arrayPadInterval($array[$id], $timeSlot->time_start, $timeSlot->time_end, $fill);
+        foreach ($timeSlots as $timeSlot) {
+            if (!isset($array[ $id ]))
+                $array[ $id ] = [ ];
+            $array[ $id ] = self::arrayPadInterval($array[ $id ], $timeSlot->time_start, $timeSlot->time_end, $fill);
         }
         return $array;
     }
@@ -378,9 +378,9 @@ 
      */
     static private function fillRow(array $array, $id, $until, $fill = '0')
     {
-        for($i = 1; $i <= $until; $i++){
-            if(!isset($array[$id][$i]))
-                $array[$id][$i] = $fill;
+        for ($i = 1; $i <= $until; $i++) {
+            if (!isset($array[ $id ][ $i ]))
+                $array[ $id ][ $i ] = $fill;
         }
 
         return $array;
@@ -395,8 +395,8 @@ 
      */
     static private function arrayPadInterval(array $array, $from, $to, $pad = '0')
     {
-        for($i = $from; $i<$to; $i++)
-            $array[$i] = $pad;
+        for ($i = $from; $i < $to; $i++)
+            $array[ $i ] = $pad;
         return $array;
     }
 
@@ -410,14 +410,14 @@ 
     {
         $dateTime = new \DateTime($time);
         $diff = $dateTime->diff($this->startTime);
-        $diff = explode(':',$diff->format('%R:%d:%h:%i:%s'));
-        $diff = $diff[1]*86400 + $diff[2]*3600 + $diff[3]*60 + $diff[4];
+        $diff = explode(':', $diff->format('%R:%d:%h:%i:%s'));
+        $diff = $diff[ 1 ] * 86400 + $diff[ 2 ] * 3600 + $diff[ 3 ] * 60 + $diff[ 4 ];
         //if($diff[0] != '-' && $diff != 0)
           //  throw new OptimiseException('timeslot time <= startTime');
         //TODO fix check
         //TODO check if diff makes sense
         //TODO check upper limit
-        return (int)(round($diff/self::TIME_SLOT_DURATION)+1); //TODO can round cause overlaps?
+        return (int) (round($diff / self::TIME_SLOT_DURATION) + 1); //TODO can round cause overlaps?
     }
 
     /**
@@ -427,6 +427,6 @@ 
     private function toDateTime($timeslot)
     {
         $ret = clone $this->startTime;
-        return $ret->add(new \DateInterval('PT'.(($timeslot-1)*self::TIME_SLOT_DURATION).'S'));
+        return $ret->add(new \DateInterval('PT'.(($timeslot - 1) * self::TIME_SLOT_DURATION).'S'));
     }
 }
\ No newline at end of file

Braces +10 added lines, -7 removed lines

@@ -317,7 +317,7 @@ 
             foreach($meetings as $meeting){
                 if($usersMeetingsTmp->contains('meeting_id', $meeting)){
                     $ret[$user][$meeting] = 1;
-                }else{
+                } else{
                     $ret[$user][$meeting] = 0;
                 }
             }
@@ -363,8 +363,9 @@ 
     static private function fillTimeSlots(array $array, $id, \Illuminate\Support\Collection $timeSlots, $fill = '0')
     {
         foreach($timeSlots as $timeSlot) {
-            if(!isset($array[$id]))
-                $array[$id] = [];
+            if(!isset($array[$id])) {
+                            $array[$id] = [];
+            }
             $array[$id] = self::arrayPadInterval($array[$id], $timeSlot->time_start, $timeSlot->time_end, $fill);
         }
         return $array;
@@ -379,8 +380,9 @@ 
     static private function fillRow(array $array, $id, $until, $fill = '0')
     {
         for($i = 1; $i <= $until; $i++){
-            if(!isset($array[$id][$i]))
-                $array[$id][$i] = $fill;
+            if(!isset($array[$id][$i])) {
+                            $array[$id][$i] = $fill;
+            }
         }
 
         return $array;
@@ -395,8 +397,9 @@ 
      */
     static private function arrayPadInterval(array $array, $from, $to, $pad = '0')
     {
-        for($i = $from; $i<$to; $i++)
-            $array[$i] = $pad;
+        for($i = $from; $i<$to; $i++) {
+                    $array[$i] = $pad;
+        }
         return $array;
     }
 

app/Console/Commands/Optimise/Solver.php

Doc Comments +15 added lines, -13 removed lines

@@ -119,7 +119,7 @@ 
 
     /**
      * remove a no empty dir
-     * @param $dir
+     * @param string $dir
      * @return bool
      */
     private static function delTree($dir) {
@@ -173,7 +173,7 @@ 
     }
 
     /**
-     * @return \string[]
+     * @return string[]
      */
     public function getUsers()
     {
@@ -191,7 +191,7 @@ 
     }
 
     /**
-     * @return \string[]
+     * @return string[]
      */
     public function getMeetings()
     {
@@ -253,7 +253,7 @@ 
     }
 
     /**
-     * @return \string[]
+     * @return string[]
      */
     public function getMeetingsAvailability()
     {
@@ -282,7 +282,7 @@ 
     }
 
     /**
-     * @return \string[]
+     * @return string[]
      */
     public function getMeetingsDuration()
     {
@@ -312,7 +312,7 @@ 
     }
 
     /**
-     * @return \string[]
+     * @return string[]
      */
     public function getUsersAvailability()
     {
@@ -342,7 +342,7 @@ 
     }
 
     /**
-     * @return \string[]
+     * @return string[]
      */
     public function getUsersMeetings()
     {
@@ -419,7 +419,7 @@ 
 
     /**
      * @param string $file
-     * @param array $data
+     * @param string[] $data
      * @throws OptimiseException
      */
     static private function writeCSVArrayNoKey($file, $data)
@@ -435,7 +435,7 @@ 
 
     /**
      * @param string $file
-     * @param array $data
+     * @param string[] $data
      * @param string $name
      * @throws OptimiseException
      */
@@ -452,7 +452,7 @@ 
 
     /**
      * @param string $file
-     * @param array $data
+     * @param string[] $data
      * @param string $name
      * @throws OptimiseException
      */
@@ -471,7 +471,7 @@ 
     /**
      * @param string $file
      * @param array $data
-     * @param array $heading
+     * @param string[] $heading
      * @param \Closure $writer
      * @throws OptimiseException
      */
@@ -682,7 +682,7 @@ 
     }
 
     /**
-     * @param $proprieties
+     * @param string[] $proprieties
      * @throws OptimiseException
      */
     private function checkArrayProprieties($proprieties)
@@ -693,7 +693,7 @@ 
     }
 
     /**
-     * @param $proprieties
+     * @param string[] $proprieties
      * @throws OptimiseException
      */
     private function checkIntProprieties($proprieties)
@@ -707,6 +707,8 @@ 
      * implementation of arraypad that doesn't change original keys<br/>
      * <strong>CAUTION: Only positive $len</strong>
      * @param array $array
+     * @param integer $len
+     * @param integer $pad
      * @return array
      */
     static private function arrayPad(array $array, $len, $pad)

Spacing +51 added lines, -51 removed lines

@@ -113,7 +113,7 @@ 
      */
     static private function checkGlpsol()
     {
-        if(!(`which glpsol`))
+        if (!(`which glpsol`))
             throw new OptimiseException('glpsol is not installed');
     }
 
@@ -123,7 +123,7 @@ 
      * @return bool
      */
     private static function delTree($dir) {
-        $files = array_diff(scandir($dir), array('.','..'));
+        $files = array_diff(scandir($dir), array('.', '..'));
         foreach ($files as $file) {
             (is_dir("$dir/$file")) ? delTree("$dir/$file") : unlink("$dir/$file");
         }
@@ -138,11 +138,11 @@ 
     {
         $this->path = tempnam(sys_get_temp_dir(), 'OPT'); //TODO check the return in case of errors this return false on failure
         unlink($this->path); //remove file to create a dir
-        if(file_exists($this->path))
+        if (file_exists($this->path))
             throw new OptimiseException('problem during creation of tmp dir (the directory already exists)');
-        if(!@mkdir($this->path))
-            throw new OptimiseException('problem during creation of tmp dir (mkdir problem)');;
-        if(! is_dir($this->path))
+        if (!@mkdir($this->path))
+            throw new OptimiseException('problem during creation of tmp dir (mkdir problem)'); ;
+        if (!is_dir($this->path))
             throw new OptimiseException('problem during creation of tmp dir (it is not possible to create directory)');
     }
 
@@ -223,7 +223,7 @@ 
      */
     public function setTimeSlots($timeSlots)
     {
-        if(!is_int($timeSlots) || $timeSlots <=0)
+        if (!is_int($timeSlots) || $timeSlots <= 0)
             throw new OptimiseException('$timeSlots is not integer or it is not >0');
 
         $this->timeSlots = $timeSlots;
@@ -245,7 +245,7 @@ 
      */
     public function setMaxTimeSlots($maxTimeSlots)
     {
-        if(!is_int($maxTimeSlots) || $maxTimeSlots <=0)
+        if (!is_int($maxTimeSlots) || $maxTimeSlots <= 0)
             throw new OptimiseException('$maxTimeSlots is not integer or it is not >0');
 
         $this->maxTimeSlots = $maxTimeSlots;
@@ -268,13 +268,13 @@ 
     public function setMeetingsAvailability($meetingsAvailability)
     {
         $meetings = array_keys($meetingsAvailability);
-        if(array_diff($meetings, $this->meetings))
+        if (array_diff($meetings, $this->meetings))
             throw new OptimiseException('meetings different from meetings set');
-        foreach($meetingsAvailability as $key=>$meetingsAvailabilityS) {
+        foreach ($meetingsAvailability as $key=>$meetingsAvailabilityS) {
             $timeSlots = array_keys($meetingsAvailabilityS);
-            if(count($timeSlots) != $this->timeSlots)
+            if (count($timeSlots) != $this->timeSlots)
                 throw new OptimiseException('timeSlots different from timeSlots set');
-            $meetingsAvailability[$key] = self::arrayPad($meetingsAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0);
+            $meetingsAvailability[ $key ] = self::arrayPad($meetingsAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0);
         }
 
         $this->meetingsAvailability = $meetingsAvailability;
@@ -297,13 +297,13 @@ 
     public function setMeetingsDuration($meetingsDuration)
     {
         $meetings = array_keys($meetingsDuration);
-        if(array_diff($meetings, $this->meetings)) {
+        if (array_diff($meetings, $this->meetings)) {
             print "";
             throw new OptimiseException('meetings different from meetings set');
         }
-        foreach($meetingsDuration as $duration) {
+        foreach ($meetingsDuration as $duration) {
             $duration = (int) $duration; //TODO fix this (fix for optimise)
-            if(!is_int($duration) || $duration <=0)
+            if (!is_int($duration) || $duration <= 0)
                 throw new OptimiseException('duration is not integer or it is not >0');
         }
 
@@ -327,14 +327,14 @@ 
     public function setUsersAvailability($usersAvailability)
     {
         $users = array_keys($usersAvailability);
-        if(array_diff($users, $this->users))
+        if (array_diff($users, $this->users))
             throw new OptimiseException('users different from users set');
-        foreach($usersAvailability as $key=>$usersAvailabilityS) {
+        foreach ($usersAvailability as $key=>$usersAvailabilityS) {
             $timeSlots = array_keys($usersAvailabilityS);
-            if(count($timeSlots) != $this->timeSlots)
+            if (count($timeSlots) != $this->timeSlots)
                 throw new OptimiseException('timeSlots different from timeSlots set');
 
-            $usersAvailability[$key] = self::arrayPad($usersAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0);
+            $usersAvailability[ $key ] = self::arrayPad($usersAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0);
         }
 
         $this->usersAvailability = $usersAvailability;
@@ -357,11 +357,11 @@ 
     public function setUsersMeetings($usersMeetings)
     {
         $users = array_keys($usersMeetings);
-        if(array_diff($users, $this->users))
+        if (array_diff($users, $this->users))
             throw new OptimiseException('users different from users set');
-        foreach($usersMeetings as $usersMeetingsS) {
+        foreach ($usersMeetings as $usersMeetingsS) {
             $meetings = array_keys($usersMeetingsS);
-            if(array_diff($meetings, $this->meetings))
+            if (array_diff($meetings, $this->meetings))
                 throw new OptimiseException('meetings different from meetings set');
         }
 
@@ -424,13 +424,13 @@ 
      */
     static private function writeCSVArrayNoKey($file, $data)
     {
-        $f = function ($fp, $data){
+        $f = function($fp, $data) {
             foreach ($data as $field) {
-                fputcsv($fp, [$field]);
+                fputcsv($fp, [ $field ]);
             }
         };
 
-        self::writeCSV($file, $data, ['i'], $f);
+        self::writeCSV($file, $data, [ 'i' ], $f);
     }
 
     /**
@@ -441,13 +441,13 @@ 
      */
     static private function writeCSVArray($file, $data, $name)
     {
-        $f = function ($fp, $data){
+        $f = function($fp, $data) {
             foreach ($data as $key=>$field) {
-                fputcsv($fp, [$key, $field]);
+                fputcsv($fp, [ $key, $field ]);
             }
         };
 
-        self::writeCSV($file, $data, ['i', $name], $f);
+        self::writeCSV($file, $data, [ 'i', $name ], $f);
     }
 
     /**
@@ -458,14 +458,14 @@ 
      */
     static private function writeCSVMatrix($file, $data, $name)
     {
-        $f = function ($fp, $data){
+        $f = function($fp, $data) {
             foreach ($data as $key=>$field) {
                 foreach ($field as $key2=>$field2)
-                    fputcsv($fp, [$key, $key2, $field2]);
+                    fputcsv($fp, [ $key, $key2, $field2 ]);
             }
         };
 
-        self::writeCSV($file, $data, ['i', 'j', $name], $f);
+        self::writeCSV($file, $data, [ 'i', 'j', $name ], $f);
     }
 
     /**
@@ -478,7 +478,7 @@ 
     static private function writeCSV($file, $data, $heading, \Closure $writer)
     {
         $fp = @fopen($file, 'w');
-        if(!$fp)
+        if (!$fp)
             throw new OptimiseException('problem during creation of a file');
 
         fputcsv($fp, $heading);
@@ -498,8 +498,8 @@ 
     {
         $this->writeData();
         $this->writeModelFile();
-        $event = $this->schedule->exec('glpsol --math '.$this->getModelPath())->sendOutputTo($this->getOutputPath())->after(function () { }); //this just to execute in foreground
-        if($event->isDue($this->laravel))
+        $event = $this->schedule->exec('glpsol --math '.$this->getModelPath())->sendOutputTo($this->getOutputPath())->after(function() { }); //this just to execute in foreground
+        if ($event->isDue($this->laravel))
             $event->run($this->laravel);
         //TODO catch glpsol errors
         return $this;
@@ -513,9 +513,9 @@ 
         $strReplaceS = array('{USERS_PATH}', '{MEETINGS_PATH}', '{USER_AVAILABILITY_PATH}', '{MEETINGS_AVAILABILITY_PATH}', '{USER_MEETINGS_PATH}', '{MEETINGS_DURATION_PATH}', '{TIME_SLOTS}', '{MAX_TIME_SLOTS}', '{X_OUT_PATH}', '{Y_OUT_PATH}');
         $strReplaceR = array($this->getUsersPath(), $this->getMeetingsPath(), $this->getUsersAvailabilityPath(), $this->getMeetingsAvailabilityPath(), $this->getUsersMeetingsPath(), $this->getMeetingsDurationPath(), $this->timeSlots, $this->maxTimeSlots, $this->getXPath(), $this->getYPath());
         $f = @fopen($this->getModelPath(), "w");
-        if(!$f)
+        if (!$f)
             throw new OptimiseException('problem during creation of a file');
-        fwrite($f, str_replace($strReplaceS, $strReplaceR, file_get_contents(__DIR__ . "/model.stub")));
+        fwrite($f, str_replace($strReplaceS, $strReplaceR, file_get_contents(__DIR__."/model.stub")));
         fclose($f);
     }
 
@@ -543,7 +543,7 @@ 
      */
     public function getOutput()
     {
-        if(!($data = file_get_contents($this->getOutputPath())))
+        if (!($data = file_get_contents($this->getOutputPath())))
             throw new OptimiseException('problems during reading the file');
         return $data;
     }
@@ -555,22 +555,22 @@ 
      */
     static private function readCSVFile($file)
     {
-        if(!file_exists($file) || !filesize($file))
+        if (!file_exists($file) || !filesize($file))
             throw new OptimiseException('no results file');
 
-        $handle = @fopen($file,"r");
-        if(!$handle)
+        $handle = @fopen($file, "r");
+        if (!$handle)
             throw new OptimiseException('problems during reading the file');
 
-        $ret = [];
+        $ret = [ ];
         fgetcsv($handle); //skip head
         while (($data = fgetcsv($handle)) !== FALSE) {
-            if(count($data) != 3) {
+            if (count($data) != 3) {
                 fclose($handle);
                 throw new OptimiseException('problems during parsing the file');
             }
 
-            $ret[$data[0]][$data[1]] = $data[2];
+            $ret[ $data[ 0 ] ][ $data[ 1 ] ] = $data[ 2 ];
         }
 
         fclose($handle);
@@ -677,8 +677,8 @@ 
      */
     private function checkData()
     {
-        $this->checkArrayProprieties(['users', 'meetings', 'meetingsAvailability', 'meetingsDuration', 'usersAvailability', 'usersMeetings']);
-        $this->checkIntProprieties(['timeSlots', 'maxTimeSlots']);
+        $this->checkArrayProprieties([ 'users', 'meetings', 'meetingsAvailability', 'meetingsDuration', 'usersAvailability', 'usersMeetings' ]);
+        $this->checkIntProprieties([ 'timeSlots', 'maxTimeSlots' ]);
     }
 
     /**
@@ -687,8 +687,8 @@ 
      */
     private function checkArrayProprieties($proprieties)
     {
-        foreach($proprieties as $propriety)
-            if(count($this->$propriety)==0)
+        foreach ($proprieties as $propriety)
+            if (count($this->$propriety) == 0)
                 throw new OptimiseException($propriety.' is not set correctly');
     }
 
@@ -698,8 +698,8 @@ 
      */
     private function checkIntProprieties($proprieties)
     {
-        foreach($proprieties as $propriety)
-            if(!is_int($this->$propriety) || $this->$propriety <= 0)
+        foreach ($proprieties as $propriety)
+            if (!is_int($this->$propriety) || $this->$propriety <= 0)
                 throw new OptimiseException($propriety.' is not set correctly');
     }
 
@@ -712,8 +712,8 @@ 
     static private function arrayPad(array $array, $len, $pad)
     {
         $len = $len - count($array);
-        for($i = 0; $i<$len; $i++)
-            $array[] = $pad;
+        for ($i = 0; $i < $len; $i++)
+            $array[ ] = $pad;
         return $array;
     }
 }
\ No newline at end of file

Braces +73 added lines, -48 removed lines

@@ -104,8 +104,9 @@ 
      */
     function __destruct()
     {
-        if ($this->path && is_dir($this->path) && !self::delTree($this->path))
-            throw new OptimiseException('problems during removing of path directory');
+        if ($this->path && is_dir($this->path) && !self::delTree($this->path)) {
+                    throw new OptimiseException('problems during removing of path directory');
+        }
     }
 
     /**
@@ -113,8 +114,9 @@ 
      */
     static private function checkGlpsol()
     {
-        if(!(`which glpsol`))
-            throw new OptimiseException('glpsol is not installed');
+        if(!(`which glpsol`)) {
+                    throw new OptimiseException('glpsol is not installed');
+        }
     }
 
     /**
@@ -138,12 +140,16 @@ 
     {
         $this->path = tempnam(sys_get_temp_dir(), 'OPT'); //TODO check the return in case of errors this return false on failure
         unlink($this->path); //remove file to create a dir
-        if(file_exists($this->path))
-            throw new OptimiseException('problem during creation of tmp dir (the directory already exists)');
-        if(!@mkdir($this->path))
-            throw new OptimiseException('problem during creation of tmp dir (mkdir problem)');;
-        if(! is_dir($this->path))
-            throw new OptimiseException('problem during creation of tmp dir (it is not possible to create directory)');
+        if(file_exists($this->path)) {
+                    throw new OptimiseException('problem during creation of tmp dir (the directory already exists)');
+        }
+        if(!@mkdir($this->path)) {
+                    throw new OptimiseException('problem during creation of tmp dir (mkdir problem)');
+        }
+        ;
+        if(! is_dir($this->path)) {
+                    throw new OptimiseException('problem during creation of tmp dir (it is not possible to create directory)');
+        }
     }
 
     /**
@@ -223,8 +229,9 @@ 
      */
     public function setTimeSlots($timeSlots)
     {
-        if(!is_int($timeSlots) || $timeSlots <=0)
-            throw new OptimiseException('$timeSlots is not integer or it is not >0');
+        if(!is_int($timeSlots) || $timeSlots <=0) {
+                    throw new OptimiseException('$timeSlots is not integer or it is not >0');
+        }
 
         $this->timeSlots = $timeSlots;
         return $this;
@@ -245,8 +252,9 @@ 
      */
     public function setMaxTimeSlots($maxTimeSlots)
     {
-        if(!is_int($maxTimeSlots) || $maxTimeSlots <=0)
-            throw new OptimiseException('$maxTimeSlots is not integer or it is not >0');
+        if(!is_int($maxTimeSlots) || $maxTimeSlots <=0) {
+                    throw new OptimiseException('$maxTimeSlots is not integer or it is not >0');
+        }
 
         $this->maxTimeSlots = $maxTimeSlots;
         return $this;
@@ -268,12 +276,14 @@ 
     public function setMeetingsAvailability($meetingsAvailability)
     {
         $meetings = array_keys($meetingsAvailability);
-        if(array_diff($meetings, $this->meetings))
-            throw new OptimiseException('meetings different from meetings set');
+        if(array_diff($meetings, $this->meetings)) {
+                    throw new OptimiseException('meetings different from meetings set');
+        }
         foreach($meetingsAvailability as $key=>$meetingsAvailabilityS) {
             $timeSlots = array_keys($meetingsAvailabilityS);
-            if(count($timeSlots) != $this->timeSlots)
-                throw new OptimiseException('timeSlots different from timeSlots set');
+            if(count($timeSlots) != $this->timeSlots) {
+                            throw new OptimiseException('timeSlots different from timeSlots set');
+            }
             $meetingsAvailability[$key] = self::arrayPad($meetingsAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0);
         }
 
@@ -303,8 +313,9 @@ 
         }
         foreach($meetingsDuration as $duration) {
             $duration = (int) $duration; //TODO fix this (fix for optimise)
-            if(!is_int($duration) || $duration <=0)
-                throw new OptimiseException('duration is not integer or it is not >0');
+            if(!is_int($duration) || $duration <=0) {
+                            throw new OptimiseException('duration is not integer or it is not >0');
+            }
         }
 
         $this->meetingsDuration = $meetingsDuration;
@@ -327,12 +338,14 @@ 
     public function setUsersAvailability($usersAvailability)
     {
         $users = array_keys($usersAvailability);
-        if(array_diff($users, $this->users))
-            throw new OptimiseException('users different from users set');
+        if(array_diff($users, $this->users)) {
+                    throw new OptimiseException('users different from users set');
+        }
         foreach($usersAvailability as $key=>$usersAvailabilityS) {
             $timeSlots = array_keys($usersAvailabilityS);
-            if(count($timeSlots) != $this->timeSlots)
-                throw new OptimiseException('timeSlots different from timeSlots set');
+            if(count($timeSlots) != $this->timeSlots) {
+                            throw new OptimiseException('timeSlots different from timeSlots set');
+            }
 
             $usersAvailability[$key] = self::arrayPad($usersAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0);
         }
@@ -357,12 +370,14 @@ 
     public function setUsersMeetings($usersMeetings)
     {
         $users = array_keys($usersMeetings);
-        if(array_diff($users, $this->users))
-            throw new OptimiseException('users different from users set');
+        if(array_diff($users, $this->users)) {
+                    throw new OptimiseException('users different from users set');
+        }
         foreach($usersMeetings as $usersMeetingsS) {
             $meetings = array_keys($usersMeetingsS);
-            if(array_diff($meetings, $this->meetings))
-                throw new OptimiseException('meetings different from meetings set');
+            if(array_diff($meetings, $this->meetings)) {
+                            throw new OptimiseException('meetings different from meetings set');
+            }
         }
 
         $this->usersMeetings = $usersMeetings;
@@ -460,8 +475,9 @@ 
     {
         $f = function ($fp, $data){
             foreach ($data as $key=>$field) {
-                foreach ($field as $key2=>$field2)
-                    fputcsv($fp, [$key, $key2, $field2]);
+                foreach ($field as $key2=>$field2) {
+                                    fputcsv($fp, [$key, $key2, $field2]);
+                }
             }
         };
 
@@ -478,8 +494,9 @@ 
     static private function writeCSV($file, $data, $heading, \Closure $writer)
     {
         $fp = @fopen($file, 'w');
-        if(!$fp)
-            throw new OptimiseException('problem during creation of a file');
+        if(!$fp) {
+                    throw new OptimiseException('problem during creation of a file');
+        }
 
         fputcsv($fp, $heading);
 
@@ -499,8 +516,9 @@ 
         $this->writeData();
         $this->writeModelFile();
         $event = $this->schedule->exec('glpsol --math '.$this->getModelPath())->sendOutputTo($this->getOutputPath())->after(function () { }); //this just to execute in foreground
-        if($event->isDue($this->laravel))
-            $event->run($this->laravel);
+        if($event->isDue($this->laravel)) {
+                    $event->run($this->laravel);
+        }
         //TODO catch glpsol errors
         return $this;
     }
@@ -513,8 +531,9 @@ 
         $strReplaceS = array('{USERS_PATH}', '{MEETINGS_PATH}', '{USER_AVAILABILITY_PATH}', '{MEETINGS_AVAILABILITY_PATH}', '{USER_MEETINGS_PATH}', '{MEETINGS_DURATION_PATH}', '{TIME_SLOTS}', '{MAX_TIME_SLOTS}', '{X_OUT_PATH}', '{Y_OUT_PATH}');
         $strReplaceR = array($this->getUsersPath(), $this->getMeetingsPath(), $this->getUsersAvailabilityPath(), $this->getMeetingsAvailabilityPath(), $this->getUsersMeetingsPath(), $this->getMeetingsDurationPath(), $this->timeSlots, $this->maxTimeSlots, $this->getXPath(), $this->getYPath());
         $f = @fopen($this->getModelPath(), "w");
-        if(!$f)
-            throw new OptimiseException('problem during creation of a file');
+        if(!$f) {
+                    throw new OptimiseException('problem during creation of a file');
+        }
         fwrite($f, str_replace($strReplaceS, $strReplaceR, file_get_contents(__DIR__ . "/model.stub")));
         fclose($f);
     }
@@ -543,8 +562,9 @@ 
      */
     public function getOutput()
     {
-        if(!($data = file_get_contents($this->getOutputPath())))
-            throw new OptimiseException('problems during reading the file');
+        if(!($data = file_get_contents($this->getOutputPath()))) {
+                    throw new OptimiseException('problems during reading the file');
+        }
         return $data;
     }
 
@@ -555,12 +575,14 @@ 
      */
     static private function readCSVFile($file)
     {
-        if(!file_exists($file) || !filesize($file))
-            throw new OptimiseException('no results file');
+        if(!file_exists($file) || !filesize($file)) {
+                    throw new OptimiseException('no results file');
+        }
 
         $handle = @fopen($file,"r");
-        if(!$handle)
-            throw new OptimiseException('problems during reading the file');
+        if(!$handle) {
+                    throw new OptimiseException('problems during reading the file');
+        }
 
         $ret = [];
         fgetcsv($handle); //skip head
@@ -687,9 +709,10 @@ 
      */
     private function checkArrayProprieties($proprieties)
     {
-        foreach($proprieties as $propriety)
-            if(count($this->$propriety)==0)
+        foreach($proprieties as $propriety) {
+                    if(count($this->$propriety)==0)
                 throw new OptimiseException($propriety.' is not set correctly');
+        }
     }
 
     /**
@@ -698,9 +721,10 @@ 
      */
     private function checkIntProprieties($proprieties)
     {
-        foreach($proprieties as $propriety)
-            if(!is_int($this->$propriety) || $this->$propriety <= 0)
+        foreach($proprieties as $propriety) {
+                    if(!is_int($this->$propriety) || $this->$propriety <= 0)
                 throw new OptimiseException($propriety.' is not set correctly');
+        }
     }
 
     /**
@@ -712,8 +736,9 @@ 
     static private function arrayPad(array $array, $len, $pad)
     {
         $len = $len - count($array);
-        for($i = 0; $i<$len; $i++)
-            $array[] = $pad;
+        for($i = 0; $i<$len; $i++) {
+                    $array[] = $pad;
+        }
         return $array;
     }
 }
\ No newline at end of file

Indentation +2 added lines, -2 removed lines

@@ -32,8 +32,8 @@
     protected $description = 'Optimise meetings';
 
     /**
-    * @var Schedule laravel schedule object needed to perform command in background
-    */
+     * @var Schedule laravel schedule object needed to perform command in background
+     */
     private $schedule;
 
     /**