@@ -70,17 +70,17 @@ discard block |
||
70 | 70 | */ |
71 | 71 | private function makeForeground(Company $company) |
72 | 72 | { |
73 | - $this->info('Optimisation company ' . $company->id . ' started'); |
|
73 | + $this->info('Optimisation company '.$company->id.' started'); |
|
74 | 74 | try { |
75 | 75 | (new Optimise($company, $this->schedule, $this->laravel))->optimise()->save(); |
76 | - $this->info('Optimisation ' . $company->id . ' completed'); |
|
77 | - }catch(OptimiseException $e) { |
|
76 | + $this->info('Optimisation '.$company->id.' completed'); |
|
77 | + } catch (OptimiseException $e) { |
|
78 | 78 | if ($e->isEmpty()) { |
79 | - $mex = 'Company ' . $company->id . ' doesn\'t have sufficient data'; |
|
79 | + $mex = 'Company '.$company->id.' doesn\'t have sufficient data'; |
|
80 | 80 | $this->warn($mex); |
81 | 81 | \Log::info($mex); |
82 | 82 | } else { |
83 | - $mex = 'Error during optimisation of company ' . $company->id . ': ' . $e->getMessage(); |
|
83 | + $mex = 'Error during optimisation of company '.$company->id.': '.$e->getMessage(); |
|
84 | 84 | $this->error($mex); |
85 | 85 | //TODO log cause, but don't send it to the user |
86 | 86 | //\Log::error($mex); //already logged in listener |
@@ -109,7 +109,7 @@ discard block |
||
109 | 109 | */ |
110 | 110 | private function makeBackground(Company $company) |
111 | 111 | { |
112 | - $event = $this->schedule->command('optimise:meetings ' . $company->id)->withoutOverlapping(); |
|
112 | + $event = $this->schedule->command('optimise:meetings '.$company->id)->withoutOverlapping(); |
|
113 | 113 | if ($event->isDue($this->laravel)) |
114 | 114 | $event->run($this->laravel); |
115 | 115 | } |
@@ -110,9 +110,9 @@ discard block |
||
110 | 110 | $caldavClient = new SimpleCaldavAdapter(); |
111 | 111 | $caldavClient->connect($this->calendar->url, $this->calendar->username, \Crypt::decrypt($this->calendar->password)); |
112 | 112 | $calendars = $caldavClient->findCalendars(); |
113 | - if(!isset($calendars[$this->calendar->calendar_name])) |
|
113 | + if (!isset($calendars[ $this->calendar->calendar_name ])) |
|
114 | 114 | throw new CaldavException("calendar inserted doesn't exist"); |
115 | - $caldavClient->setCalendar($calendars[$this->calendar->calendar_name]); |
|
115 | + $caldavClient->setCalendar($calendars[ $this->calendar->calendar_name ]); |
|
116 | 116 | /** |
117 | 117 | * 26 hours before to avoid tiemezone problems and dst problems |
118 | 118 | * 30 days after |
@@ -128,15 +128,15 @@ discard block |
||
128 | 128 | { |
129 | 129 | $pattern = "/^((DTSTART;)|(DTEND;))(.*)\$/m"; |
130 | 130 | if (preg_match_all($pattern, $event->getData(), $matches)) { |
131 | - if (!isset($matches[4]) || count($matches[4]) != 2) |
|
131 | + if (!isset($matches[ 4 ]) || count($matches[ 4 ]) != 2) |
|
132 | 132 | return null; |
133 | - $ret = []; |
|
134 | - if ($tmp = $this->parseDate($matches[4][0])) |
|
135 | - $ret['time_start'] = $tmp; |
|
133 | + $ret = [ ]; |
|
134 | + if ($tmp = $this->parseDate($matches[ 4 ][ 0 ])) |
|
135 | + $ret[ 'time_start' ] = $tmp; |
|
136 | 136 | else |
137 | 137 | return null; |
138 | - if ($tmp = $this->parseDate($matches[4][1])) |
|
139 | - $ret['time_end'] = $tmp; |
|
138 | + if ($tmp = $this->parseDate($matches[ 4 ][ 1 ])) |
|
139 | + $ret[ 'time_end' ] = $tmp; |
|
140 | 140 | else |
141 | 141 | return null; |
142 | 142 | return $ret; |
@@ -152,10 +152,10 @@ discard block |
||
152 | 152 | { |
153 | 153 | $pattern = "/^((TZID=)|(VALUE=))(.*):(.*)\$/m"; |
154 | 154 | if (preg_match_all($pattern, $date, $matches)) { |
155 | - if ($matches[1][0] == 'TZID=') { |
|
156 | - return \DateTime::createFromFormat('Ymd\THis', $matches[5][0], new \DateTimeZone($matches[4][0])); |
|
157 | - } else if ($matches[1][0] == 'VALUE=' && $matches[4][0] == 'DATE') { |
|
158 | - return \DateTime::createFromFormat('Ymd\THis', $matches[5][0] . 'T000000'); |
|
155 | + if ($matches[ 1 ][ 0 ] == 'TZID=') { |
|
156 | + return \DateTime::createFromFormat('Ymd\THis', $matches[ 5 ][ 0 ], new \DateTimeZone($matches[ 4 ][ 0 ])); |
|
157 | + } else if ($matches[ 1 ][ 0 ] == 'VALUE=' && $matches[ 4 ][ 0 ] == 'DATE') { |
|
158 | + return \DateTime::createFromFormat('Ymd\THis', $matches[ 5 ][ 0 ].'T000000'); |
|
159 | 159 | } |
160 | 160 | } |
161 | 161 | return null; |
@@ -26,7 +26,7 @@ |
||
26 | 26 | { |
27 | 27 | // |
28 | 28 | $calendar = $event->getCalendar(); |
29 | - \Log::info('caldav (calendar id = ' . $calendar->calendar_id . ') correctly synchronized'); |
|
29 | + \Log::info('caldav (calendar id = '.$calendar->calendar_id.') correctly synchronized'); |
|
30 | 30 | //$calendar = $event->getCalendar()->fresh(); |
31 | 31 | $calendar->sync_errors = ''; |
32 | 32 | $calendar->save(); |
@@ -25,7 +25,7 @@ discard block |
||
25 | 25 | public function handle(ErrorEvent $event) |
26 | 26 | { |
27 | 27 | // |
28 | - \Log::error('problems during optimise (company id = ' . $event->getCompany()->id . '): ' . $event->getError()); |
|
28 | + \Log::error('problems during optimise (company id = '.$event->getCompany()->id.'): '.$event->getError()); |
|
29 | 29 | $company = $event->getCompany(); |
30 | 30 | //$company = $event->getCompany()->fresh(); |
31 | 31 | self::sendEmail($company->email, $event->getError()); |
@@ -37,7 +37,7 @@ discard block |
||
37 | 37 | */ |
38 | 38 | static private function sendEmail($email, $error) |
39 | 39 | { |
40 | - \Mail::queue('emails.optimise.error', ['error' => $error], function ($message) use ($email) { |
|
40 | + \Mail::queue('emails.optimise.error', [ 'error' => $error ], function($message) use ($email) { |
|
41 | 41 | $message->from(config('mail.from.address'), config('mail.from.name')); |
42 | 42 | $message->to($email)->subject('Problems during optimisation'); |
43 | 43 | }); |
@@ -25,14 +25,14 @@ discard block |
||
25 | 25 | public function handle(OkEvent $event) |
26 | 26 | { |
27 | 27 | // |
28 | - \Log::info('Meeting correctly optimised (company id = ' . $event->getCompany()->id . ')'); |
|
28 | + \Log::info('Meeting correctly optimised (company id = '.$event->getCompany()->id.')'); |
|
29 | 29 | $company = $event->getCompany()->fresh(); |
30 | 30 | //send email to company |
31 | 31 | self::sendCompanyEmail($company->email); |
32 | 32 | //send emails to employees |
33 | - $employees = $company->employees()->with(['meetings'=>function($query){ |
|
33 | + $employees = $company->employees()->with([ 'meetings'=>function($query) { |
|
34 | 34 | $query->where('start_time', '>=', new \DateTime()); |
35 | - }])->get(); |
|
35 | + } ])->get(); |
|
36 | 36 | foreach ($employees as $employee) |
37 | 37 | self::sendEmployeeEmail($employee->email, $employee->meetings); |
38 | 38 | } |
@@ -42,7 +42,7 @@ discard block |
||
42 | 42 | */ |
43 | 43 | static private function sendCompanyEmail($email) |
44 | 44 | { |
45 | - \Mail::queue('emails.optimise.ok.company', [], function ($message) use ($email) { |
|
45 | + \Mail::queue('emails.optimise.ok.company', [ ], function($message) use ($email) { |
|
46 | 46 | $message->from(config('mail.from.address'), config('mail.from.name')); |
47 | 47 | $message->to($email)->subject('Meetings optimised'); |
48 | 48 | }); |
@@ -54,7 +54,7 @@ discard block |
||
54 | 54 | */ |
55 | 55 | static private function sendEmployeeEmail($email, $meetings) |
56 | 56 | { |
57 | - \Mail::queue('emails.optimise.ok.employee', ['meetings' => $meetings], function ($message) use ($email) { |
|
57 | + \Mail::queue('emails.optimise.ok.employee', [ 'meetings' => $meetings ], function($message) use ($email) { |
|
58 | 58 | $message->from(config('mail.from.address'), config('mail.from.name')); |
59 | 59 | $message->to($email)->subject('Meetings of next week'); |
60 | 60 | }); |
@@ -26,19 +26,19 @@ |
||
26 | 26 | * |
27 | 27 | * @var array |
28 | 28 | */ |
29 | - protected $fillable = ['time_start', 'time_end']; |
|
29 | + protected $fillable = [ 'time_start', 'time_end' ]; |
|
30 | 30 | |
31 | 31 | /** |
32 | 32 | * The attributes excluded from the model's JSON form. |
33 | 33 | * |
34 | 34 | * @var array |
35 | 35 | */ |
36 | - protected $hidden = ['pivot', 'calendar']; |
|
36 | + protected $hidden = [ 'pivot', 'calendar' ]; |
|
37 | 37 | |
38 | 38 | /** |
39 | 39 | * @var array |
40 | 40 | */ |
41 | - protected $touches = ['calendar']; |
|
41 | + protected $touches = [ 'calendar' ]; |
|
42 | 42 | |
43 | 43 | /** |
44 | 44 | * @return \Illuminate\Database\Eloquent\Relations\BelongsTo |
@@ -34,12 +34,12 @@ |
||
34 | 34 | \JWTFactory::setTTL(43200); |
35 | 35 | //config(['jwt.ttl' =>'43200']); //30 days |
36 | 36 | } |
37 | - }catch(JWTException $e) |
|
37 | + } catch (JWTException $e) |
|
38 | 38 | {} |
39 | 39 | |
40 | 40 | //this to add the remember me mode field in the new token, but we have the custom check that is an useless |
41 | 41 | //overhead |
42 | - $custom = $custom . ';remember-' . $remember == 'true' ? 'true' : 'false'; |
|
42 | + $custom = $custom.';remember-'.$remember == 'true' ? 'true' : 'false'; |
|
43 | 43 | return parent::handle($request, $next, $custom); |
44 | 44 | } |
45 | 45 |
@@ -241,10 +241,10 @@ discard block |
||
241 | 241 | if (array_diff($meetings, $this->meetings)) |
242 | 242 | throw new OptimiseException('meetings different from meetings set'); |
243 | 243 | foreach ($meetingsAvailability as $key => $meetingsAvailabilityS) { |
244 | - $timeSlots = array_keys($meetingsAvailabilityS);//TODO this is useless, we can use directly $usersAvailabilityS |
|
244 | + $timeSlots = array_keys($meetingsAvailabilityS); //TODO this is useless, we can use directly $usersAvailabilityS |
|
245 | 245 | if (count($timeSlots) != $this->timeSlots) |
246 | 246 | throw new OptimiseException('timeSlots different from timeSlots set'); |
247 | - $meetingsAvailability[$key] = self::arrayPad($meetingsAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0); |
|
247 | + $meetingsAvailability[ $key ] = self::arrayPad($meetingsAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0); |
|
248 | 248 | } |
249 | 249 | |
250 | 250 | $this->meetingsAvailability = $meetingsAvailability; |
@@ -261,7 +261,7 @@ discard block |
||
261 | 261 | { |
262 | 262 | $len = $len - count($array); |
263 | 263 | for ($i = 0; $i < $len; $i++) |
264 | - $array[] = $pad; |
|
264 | + $array[ ] = $pad; |
|
265 | 265 | return $array; |
266 | 266 | } |
267 | 267 | |
@@ -286,7 +286,7 @@ discard block |
||
286 | 286 | throw new OptimiseException('meetings different from meetings set'); |
287 | 287 | } |
288 | 288 | foreach ($meetingsDuration as $duration) { |
289 | - $duration = (int)$duration; //TODO fix this (fix for optimise) |
|
289 | + $duration = (int) $duration; //TODO fix this (fix for optimise) |
|
290 | 290 | if (!is_int($duration) || $duration <= 0) |
291 | 291 | throw new OptimiseException('duration is not integer or it is not >0'); |
292 | 292 | } |
@@ -314,11 +314,11 @@ discard block |
||
314 | 314 | if (array_diff($users, $this->users)) |
315 | 315 | throw new OptimiseException('users different from users set'); |
316 | 316 | foreach ($usersAvailability as $key => $usersAvailabilityS) { |
317 | - $timeSlots = array_keys($usersAvailabilityS);//TODO this is useless, we can use directly $usersAvailabilityS |
|
317 | + $timeSlots = array_keys($usersAvailabilityS); //TODO this is useless, we can use directly $usersAvailabilityS |
|
318 | 318 | if (count($timeSlots) != $this->timeSlots) |
319 | 319 | throw new OptimiseException('timeSlots different from timeSlots set'); |
320 | 320 | |
321 | - $usersAvailability[$key] = self::arrayPad($usersAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0); |
|
321 | + $usersAvailability[ $key ] = self::arrayPad($usersAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0); |
|
322 | 322 | } |
323 | 323 | |
324 | 324 | $this->usersAvailability = $usersAvailability; |
@@ -361,7 +361,7 @@ discard block |
||
361 | 361 | { |
362 | 362 | $this->writeData(); |
363 | 363 | $this->writeModelFile(); |
364 | - $event = $this->schedule->exec('glpsol --math ' . $this->path->getModelPath())->sendOutputTo($this->path->getOutputPath())->after(function () { |
|
364 | + $event = $this->schedule->exec('glpsol --math '.$this->path->getModelPath())->sendOutputTo($this->path->getOutputPath())->after(function() { |
|
365 | 365 | }); //this just to execute in foreground |
366 | 366 | if ($event->isDue($this->laravel)) |
367 | 367 | $event->run($this->laravel); |
@@ -388,8 +388,8 @@ discard block |
||
388 | 388 | */ |
389 | 389 | private function checkData() |
390 | 390 | { |
391 | - $this->checkArrayProprieties(['users', 'meetings', 'meetingsAvailability', 'meetingsDuration', 'usersAvailability', 'usersMeetings']); |
|
392 | - $this->checkIntProprieties(['timeSlots', 'maxTimeSlots']); |
|
391 | + $this->checkArrayProprieties([ 'users', 'meetings', 'meetingsAvailability', 'meetingsDuration', 'usersAvailability', 'usersMeetings' ]); |
|
392 | + $this->checkIntProprieties([ 'timeSlots', 'maxTimeSlots' ]); |
|
393 | 393 | } |
394 | 394 | |
395 | 395 | /** |
@@ -400,7 +400,7 @@ discard block |
||
400 | 400 | { |
401 | 401 | foreach ($proprieties as $propriety) |
402 | 402 | if (count($this->$propriety) == 0) |
403 | - throw new OptimiseException($propriety . ' property is not set correctly'); |
|
403 | + throw new OptimiseException($propriety.' property is not set correctly'); |
|
404 | 404 | } |
405 | 405 | |
406 | 406 | /** |
@@ -411,7 +411,7 @@ discard block |
||
411 | 411 | { |
412 | 412 | foreach ($proprieties as $propriety) |
413 | 413 | if (!is_int($this->$propriety) || $this->$propriety <= 0) |
414 | - throw new OptimiseException($propriety . ' property is not set correctly'); |
|
414 | + throw new OptimiseException($propriety.' property is not set correctly'); |
|
415 | 415 | } |
416 | 416 | |
417 | 417 | /** |
@@ -429,13 +429,13 @@ discard block |
||
429 | 429 | */ |
430 | 430 | static private function writeCSVArrayNoKey($file, $data) |
431 | 431 | { |
432 | - $f = function ($fp, $data) { |
|
432 | + $f = function($fp, $data) { |
|
433 | 433 | foreach ($data as $field) { |
434 | - fputcsv($fp, [$field]); |
|
434 | + fputcsv($fp, [ $field ]); |
|
435 | 435 | } |
436 | 436 | }; |
437 | 437 | |
438 | - self::writeCSV($file, $data, ['i'], $f); |
|
438 | + self::writeCSV($file, $data, [ 'i' ], $f); |
|
439 | 439 | } |
440 | 440 | |
441 | 441 | /** |
@@ -484,13 +484,13 @@ discard block |
||
484 | 484 | */ |
485 | 485 | static private function writeCSVArray($file, $data, $name) |
486 | 486 | { |
487 | - $f = function ($fp, $data) { |
|
487 | + $f = function($fp, $data) { |
|
488 | 488 | foreach ($data as $key => $field) { |
489 | - fputcsv($fp, [$key, $field]); |
|
489 | + fputcsv($fp, [ $key, $field ]); |
|
490 | 490 | } |
491 | 491 | }; |
492 | 492 | |
493 | - self::writeCSV($file, $data, ['i', $name], $f); |
|
493 | + self::writeCSV($file, $data, [ 'i', $name ], $f); |
|
494 | 494 | } |
495 | 495 | |
496 | 496 | /** |
@@ -509,14 +509,14 @@ discard block |
||
509 | 509 | */ |
510 | 510 | static private function writeCSVMatrix($file, $data, $name) |
511 | 511 | { |
512 | - $f = function ($fp, $data) { |
|
512 | + $f = function($fp, $data) { |
|
513 | 513 | foreach ($data as $key => $field) { |
514 | 514 | foreach ($field as $key2 => $field2) |
515 | - fputcsv($fp, [$key, $key2, $field2]); |
|
515 | + fputcsv($fp, [ $key, $key2, $field2 ]); |
|
516 | 516 | } |
517 | 517 | }; |
518 | 518 | |
519 | - self::writeCSV($file, $data, ['i', 'j', $name], $f); |
|
519 | + self::writeCSV($file, $data, [ 'i', 'j', $name ], $f); |
|
520 | 520 | } |
521 | 521 | |
522 | 522 | /** |
@@ -545,7 +545,7 @@ discard block |
||
545 | 545 | $f = @fopen($this->path->getModelPath(), "w"); |
546 | 546 | if (!$f) |
547 | 547 | throw new OptimiseException('problem during creation of a file'); |
548 | - fwrite($f, str_replace($strReplaceS, $strReplaceR, file_get_contents(__DIR__ . "/model.stub"))); |
|
548 | + fwrite($f, str_replace($strReplaceS, $strReplaceR, file_get_contents(__DIR__."/model.stub"))); |
|
549 | 549 | fclose($f); |
550 | 550 | } |
551 | 551 | |
@@ -572,7 +572,7 @@ discard block |
||
572 | 572 | if (!$handle) |
573 | 573 | throw new OptimiseException('problems during reading the file'); |
574 | 574 | |
575 | - $ret = []; |
|
575 | + $ret = [ ]; |
|
576 | 576 | fgetcsv($handle); //skip head |
577 | 577 | while (($data = fgetcsv($handle)) !== FALSE) { |
578 | 578 | if (count($data) != 3) { |
@@ -580,7 +580,7 @@ discard block |
||
580 | 580 | throw new OptimiseException('problems during parsing the file'); |
581 | 581 | } |
582 | 582 | |
583 | - $ret[$data[0]][$data[1]] = $data[2]; |
|
583 | + $ret[ $data[ 0 ] ][ $data[ 1 ] ] = $data[ 2 ]; |
|
584 | 584 | } |
585 | 585 | |
586 | 586 | fclose($handle); |