plunner\Http\Controllers\Employees\Calendars\CalendarsController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	132
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

69.05%

Importance

Changes	8
Bugs	3	Features	1

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	index()	0	9	1
A	store()	0	8	1
A	storeCaldav()	0	13	1
A	show()	0	7	1
A	destroy()	0	8	1
A	getCalendars()	0	14	2
A	update()	0	12	1

<?php

namespace plunner\Http\Controllers\Employees\Calendars;

use Illuminate\Support\Facades\Response;
use Illuminate\Http\Request; //TODO fix this
use it\thecsea\caldav_client_adapter\simple_caldav_client\SimpleCaldavAdapter;
use plunner\Calendar;
use plunner\Http\Controllers\Controller;
use plunner\Http\Requests\Employees\CalendarRequest;


class CalendarsController extends Controller
{
    /**
     * ExampleController constructor.
     */
    public function __construct()
    {
        config(['auth.model' => \plunner\Employee::class]);
        config(['jwt.user' => \plunner\Employee::class]);
        $this->middleware('jwt.authandrefresh:mode-en');
    }


    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        //
        /**
         * @var $employee Employee
         */
        $employee = \Auth::user();
        return $employee->calendars;
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  CalendarRequest  $request
     * @return \Illuminate\Http\Response
     */
    public function store(CalendarRequest $request)
    {
        //
        $employee = \Auth::user();
        $input = $request->all();
        $calendar = $employee->calendars()->create($input);
        return $calendar;
    }

    /**
     * Store a newly created resource in storage with caldav.
     *
     * @param  CalendarRequest  $request
     * @return \Illuminate\Http\Response
     */
    public function storeCaldav(CalendarRequest $request)
    {
        //
        $employee = \Auth::user();
        $input = $request->all();
        $calendar = $employee->calendars()->create($input);
        $calendar->caldav()->create($input);
        //TODO test
        //TODO validator
        //TODO return caldav info
        //TODO supprot function to create simple calendar
        return $calendar;
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        //
        $calendar = Calendar::with('caldav')->findOrFail($id);
        $this->authorize($calendar);
        return $calendar;
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  CalendarRequest  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(CalendarRequest $request, $id)
    {
        //
        $calendar = Calendar::findOrFail($id);
        $this->authorize($calendar);
        $input = $request->all();

$input is not used, you could remove the assignment.

        $calendar->update($request->only('name', 'enabled'));
        //TODO test
        //TODO validator
        $calendar->caldav()->update($request->only('url','username', 'password', 'calendar_name'));
        return $calendar;
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        //
        $calendar = Calendar::findOrFail($id);
        $this->authorize($calendar);
        $calendar->delete();
        return $calendar;
    }

    /**
     * Return a list of calendars name of a specif caldav calendar
     * @param Request $request
     * @return \Illuminate\Http\Response
     */
    public function getCalendars(Request $request)
    {
        //TODO VALIDATE
        //TODO test this
        try {
            $caldavClient = new SimpleCaldavAdapter();
            $caldavClient->connect($request->input('url'), $request->input('username'), $request->input('password'));

It seems like $request->input('url') targeting Illuminate\Http\Request::input() can also be of type array; however, it\thecsea\caldav_client_adapter\simple_caldav_client\SimpleCaldavAdapter::connect() does only seem to accept string, maybe add an additional type check?

It seems like $request->input('username') targeting Illuminate\Http\Request::input() can also be of type array; however, it\thecsea\caldav_client_adapter\simple_caldav_client\SimpleCaldavAdapter::connect() does only seem to accept string, maybe add an additional type check?

It seems like $request->input('password') targeting Illuminate\Http\Request::input() can also be of type array; however, it\thecsea\caldav_client_adapter\simple_caldav_client\SimpleCaldavAdapter::connect() does only seem to accept string, maybe add an additional type check?

            $calendars = $caldavClient->findCalendars();
            return array_keys($calendars);

The return type of return array_keys($calendars); (integer[]) is incompatible with the return type documented by plunner\Http\Controllers\Employees\Calendars\CalendarsController::getCalendars of type Illuminate\Http\Response.

        }catch (\it\thecsea\caldav_client_adapter\CaldavException $e)
        {
            return Response::json(['error' => $e->getMessage()],422);
        }
    }
}