plunner\Http\Controllers\Employees\GroupsController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	127
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__create()	0	4	1
A	index()	0	4	1
A	create()	0	4	1
A	store()	0	15	2
A	show()	0	4	1
A	edit()	0	4	1
A	update()	0	22	2
A	validateGroupUpdates()	0	7	1
A	respondOK()	0	4	1
A	destroy()	0	4	1

<?php

namespace plunner\Http\Controllers\Employees;

use Illuminate\Http\Request;

use plunner\Group;
use plunner\Employee;
use plunner\Http\Requests;
use plunner\Http\Controllers\Controller;

class GroupsController extends Controller
{
    private $responder;

    public function __create(ReponseCreator $responder)
    {
        $this->responder = $responder;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        //
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $this->validateGroupUpdates($request);
        $input = $request->all();

        $g = Group::create([
            'name' => $input['group_name'],
            'description' => isset($input['description']) ? $input['description'] : ''
        ]);
        $employees = Employee::whereIn('name', $input['employees'])->get();

The method whereIn does not exist on object<plunner\Employee>? Since you implemented __callStatic, maybe consider adding a @method annotation.

        $g->addEmployees($employees);

        return $this->respondOK();
    }

    /**
     * Display the specified resource.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)

The parameter $id is not used and could be removed.

    {
        $this->validateGroupUpdates($request);
        $input = $request->all();

        $employees = Employee::whereIn('name', $input['employees'])->get();

The method whereIn does not exist on object<plunner\Employee>? Since you implemented __callStatic, maybe consider adding a @method annotation.

        try {
            $group = Group::findOrFail($input['group_name']);

The method findOrFail does not exist on object<plunner\Group>? Since you implemented __callStatic, maybe consider adding a @method annotation.

        } catch (ModelNotFoundException $e) {

The class plunner\Http\Controllers\Employees\ModelNotFoundException does not exist. Did you forget a USE statement, or did you not list all dependencies?

            return $this->responder->respond(
                [
                    'message' => 'Group not found',
                    'group_name' => $input['group_name']
                ],
                404
            );
        }
        $group->addEmployees($employees);

        return $this->respondOK();
    }

    private function validateGroupUpdates($request)
    {
        $this->validate($request, [
            'group_name' => 'required|max:255',
            'employees' => 'required|array',
        ]);
    }

    private function respondOK()
    {
        return $this->responder->respond([], 200);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

The parameter $id is not used and could be removed.

    {
        //
    }
}