plunner\Http\Controllers\Employees\Planners\MeetingsController

Complexity

Total Complexity

15

Size/Duplication

Total Lines	158
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

61.97%

Importance

Changes	11
Bugs	4	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	index()	0	14	2
A	show()	0	10	1
A	store()	0	8	1
A	storeImage()	0	11	1
A	putImg()	0	4	1
A	showImage()	0	12	2
A	getImg()	0	7	2
A	update()	0	13	3
A	destroy()	0	9	1

<?php

namespace plunner\Http\Controllers\Employees\Planners;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Response;
use plunner\Group;
use plunner\Http\Controllers\Controller;
use plunner\Http\Requests;
use plunner\Http\Requests\Employees\Meeting\MeetingRequest;
use plunner\Meeting;

class MeetingsController extends Controller
{
    public function __construct()
    {
        config(['auth.model' => \plunner\Planner::class]);
        config(['jwt.user' => \plunner\Planner::class]);
        $this->middleware('jwt.authandrefresh:mode-en');
    }

    /**
     * Display a listing of the resource.
     * ?current=1 -> to exclude old planed meetings
     *
     * @param int $groupId
     * @param Request $request needed for get query to get only current planed meetings (to be planned are all retrieved)
     * @return mixed
     */
    public function index($groupId, Request $request)
    {
        $group = Group::findOrFail($groupId);
        $this->authorize($group);
        $meetings = $group->meetings();
        if ($request->query('current'))
            $meetings->where(function ($query) { //parenthesis for conditions ...(C1 OR C2)...
                $query->where('start_time', '=', NULL);//to be planned
                //datetime to consider timezone, don't use mysql NOW()
                $query->orWhere('start_time', '>=', new \DateTime());//planned
            });

        return $meetings->get();
    }

    /**
     * Display the specified resource.
     *
     * @param int $groupId
     * @param int $meetingId
     * @return mixed
     */
    public function show($groupId, $meetingId)
    {
        $group = Group::findOrFail($groupId);
        $this->authorize($group);
        //Meeting::where('group_id', $groupId)->findOrFail($meetingId);
        //it is good but expensive and useless for the user experience
        $meeting = Meeting::findOrFail($meetingId);
        $this->authorize($meeting);
        return $meeting;
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param MeetingRequest $request
     * @param int $groupId
     * @return static
     */
    public function store(MeetingRequest $request, $groupId)
    {
        $group = Group::findOrFail($groupId);
        $this->authorize($group);
        $input = $request->all();
        $meeting = $group->meetings()->create($input);
        return $meeting;
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param Requests\Request $request
     * @param int $groupId
     * @param int $meetingId
     * @return static
     */
    public function storeImage(Requests\Request $request, $groupId, $meetingId)
    {
        $this->validate($request, ['data' => 'required|image']);
        $group = Group::findOrFail($groupId);
        $this->authorize($group);
        $meeting = Group::findOrFail($meetingId);
        $this->authorize($meeting);
        $file = $request->file('data');
        self::putImg($file, $meeting);
        return $meeting;
    }

    private static function putImg($file, Meeting $meeting)
    {
        \Storage::put('meetings/' . $meeting->id, \File::get($file));

The method put() does not seem to exist on object<Illuminate\Contracts\Filesystem\Factory>.

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param int $groupId
     * @param int $meetingId
     * @return static
     */
    public function showImage($groupId, $meetingId)
    {
        $group = Group::findOrFail($groupId);
        $this->authorize($group);
        $meeting = Group::findOrFail($meetingId);
        $this->authorize($meeting);
        $ret = self::getImg($meeting);
        if ($ret === false)
            return \Response::json(['error' => 'The file is not uploaded'], 404);

The return type of return \Response::json(array('error' => 'The file is not uploaded'), 404); (Illuminate\Http\JsonResponse) is incompatible with the return type documented by plunner\Http\Controllers\Employees\Planners\MeetingsController::showImage of type plunner\Http\Controllers\Employees\Planners\MeetingsController.

        return (new Response($ret, 200))

The call to Response::__construct() has too many arguments starting with $ret.

The method header() does not seem to exist on object<Illuminate\Support\Facades\Response>.

            ->header('Content-Type', 'image/jpeg');
    }

    private static function getImg(Meeting $meeting)
    {
        $name = 'meetings/' . $meeting->id;
        if (!\Storage::exists($name))

The method exists() does not seem to exist on object<Illuminate\Contracts\Filesystem\Factory>.

            return false;
        return \Storage::get($name);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param MeetingRequest $request
     * @param int $meetingId
     * @param int $groupId
     * @return mixed
     */
    public function update(MeetingRequest $request, $groupId, $meetingId)
    {
        $group = Group::findOrFail($groupId);
        $this->authorize($group);
        $meeting = Meeting::findOrFail($meetingId);
        $this->authorize($meeting);
        $input = $request->all();
        //the planner cannot modify the duration of a planed meeting
        if ($meeting->start_time != NULL && $meeting->duration != $input['duration'])
            return Response::json(['error' => 'the meeting is already planned, you cannot change the duration'], 422);
        $meeting->update($input);
        return $meeting;
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param int $groupId
     * @param int $meetingId
     * @return mixed
     */
    public function destroy($groupId, $meetingId)
    {
        $group = Group::findOrFail($groupId);
        $this->authorize($group);
        $meeting = Meeting::findOrFail($meetingId);
        $this->authorize($meeting);
        $meeting->delete();
        return $meeting;
    }
}