dsd-meetme / backend

app/Console/Commands/Optimise/OptimiseException.php

Indentation +16 added lines, -16 removed lines

@@ -1,21 +1,21 @@
 <?php
 /**
- * Created by PhpStorm.
- * User: Claudio Cardinale <cardi@thecsea.it>
- * Date: 07/12/15
- * Time: 21.24
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version 2
- * of the License, or (at your option) any later version.
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
- */
+     * Created by PhpStorm.
+     * User: Claudio Cardinale <cardi@thecsea.it>
+     * Date: 07/12/15
+     * Time: 21.24
+     * This program is free software; you can redistribute it and/or
+     * modify it under the terms of the GNU General Public License
+     * as published by the Free Software Foundation; either version 2
+     * of the License, or (at your option) any later version.
+     * This program is distributed in the hope that it will be useful,
+     * but WITHOUT ANY WARRANTY; without even the implied warranty of
+     * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+     * GNU General Public License for more details.
+     * You should have received a copy of the GNU General Public License
+     * along with this program; if not, write to the Free Software
+     * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+     */
 
 namespace plunner\Console\Commands\Optimise;
 

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
      * @param Exception $previous
      * @param bool $empty
      */
-    public function __construct($message =  "", $code = 0, Exception $previous = null, $empty = false)
+    public function __construct($message = "", $code = 0, Exception $previous = null, $empty = false)
     {
         parent::__construct($message, $code, $previous);
         $this->empty = $empty;

app/Events/Optimise/OkEvent.php

Spacing +1 added lines, -1 removed lines

@@ -39,6 +39,6 @@
      */
     public function broadcastOn()
     {
-        return [];
+        return [ ];
     }
 }

app/Events/Optimise/ErrorEvent.php

Spacing +1 added lines, -1 removed lines

@@ -39,6 +39,6 @@
      */
     public function broadcastOn()
     {
-        return [];
+        return [ ];
     }
 }

app/Console/Commands/Optimise/Path.php

Indentation +16 added lines, -16 removed lines

@@ -1,21 +1,21 @@
 <?php
 /**
- * Created by PhpStorm.
- * User: Claudio Cardinale <cardi@thecsea.it>
- * Date: 18/12/15
- * Time: 15.20
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version 2
- * of the License, or (at your option) any later version.
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
- */
+     * Created by PhpStorm.
+     * User: Claudio Cardinale <cardi@thecsea.it>
+     * Date: 18/12/15
+     * Time: 15.20
+     * This program is free software; you can redistribute it and/or
+     * modify it under the terms of the GNU General Public License
+     * as published by the Free Software Foundation; either version 2
+     * of the License, or (at your option) any later version.
+     * This program is distributed in the hope that it will be useful,
+     * but WITHOUT ANY WARRANTY; without even the implied warranty of
+     * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+     * GNU General Public License for more details.
+     * You should have received a copy of the GNU General Public License
+     * along with this program; if not, write to the Free Software
+     * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+     */
 
 namespace plunner\Console\Commands\Optimise;
 

Spacing +11 added lines, -11 removed lines

@@ -53,7 +53,7 @@ 
         if (file_exists($path->getPath()))
             throw new OptimiseException('problem during creation of tmp dir (the directory already exists)');
         if (!@mkdir($path->getPath()))
-            throw new OptimiseException('problem during creation of tmp dir (mkdir problem)');;
+            throw new OptimiseException('problem during creation of tmp dir (mkdir problem)'); ;
         if (!is_dir($path->getPath()))
             throw new OptimiseException('problem during creation of tmp dir (it is not possible to create directory)');
         return $path;
@@ -104,7 +104,7 @@ 
      */
     public function getModelPath()
     {
-        return $this->path . '/model.mod';
+        return $this->path.'/model.mod';
     }
 
     /**
@@ -112,7 +112,7 @@ 
      */
     public function getUsersPath()
     {
-        return $this->path . '/Users.csv';
+        return $this->path.'/Users.csv';
     }
 
     /**
@@ -120,7 +120,7 @@ 
      */
     public function getMeetingsPath()
     {
-        return $this->path . '/Meeting.csv';
+        return $this->path.'/Meeting.csv';
     }
 
     /**
@@ -128,7 +128,7 @@ 
      */
     public function getMeetingsDurationPath()
     {
-        return $this->path . '/MeetingsDuration.csv';
+        return $this->path.'/MeetingsDuration.csv';
     }
 
     /**
@@ -136,7 +136,7 @@ 
      */
     public function getMeetingsAvailabilityPath()
     {
-        return $this->path . '/MeetingsAvailability.csv';
+        return $this->path.'/MeetingsAvailability.csv';
     }
 
     /**
@@ -144,7 +144,7 @@ 
      */
     public function getUsersAvailabilityPath()
     {
-        return $this->path . '/UsersAvailability.csv';
+        return $this->path.'/UsersAvailability.csv';
     }
 
     /**
@@ -152,7 +152,7 @@ 
      */
     public function getUsersMeetingsPath()
     {
-        return $this->path . '/UsersMeetings.csv';
+        return $this->path.'/UsersMeetings.csv';
     }
 
     /**
@@ -160,7 +160,7 @@ 
      */
     public function getXPath()
     {
-        return $this->path . '/x.csv';
+        return $this->path.'/x.csv';
     }
 
     /**
@@ -168,7 +168,7 @@ 
      */
     public function getYPath()
     {
-        return $this->path . '/y.csv';
+        return $this->path.'/y.csv';
     }
 
     /**
@@ -176,6 +176,6 @@ 
      */
     public function getOutputPath()
     {
-        return $this->path . '/out.txt';
+        return $this->path.'/out.txt';
     }
 }
\ No newline at end of file

Braces +13 added lines, -8 removed lines

@@ -50,12 +50,16 @@ 
     {
         $path = new Path(tempnam(sys_get_temp_dir(), 'OPT')); //TODO check the return in case of errors this return false on failure
         unlink($path->getPath()); //remove file to create a dir
-        if (file_exists($path->getPath()))
-            throw new OptimiseException('problem during creation of tmp dir (the directory already exists)');
-        if (!@mkdir($path->getPath()))
-            throw new OptimiseException('problem during creation of tmp dir (mkdir problem)');;
-        if (!is_dir($path->getPath()))
-            throw new OptimiseException('problem during creation of tmp dir (it is not possible to create directory)');
+        if (file_exists($path->getPath())) {
+                    throw new OptimiseException('problem during creation of tmp dir (the directory already exists)');
+        }
+        if (!@mkdir($path->getPath())) {
+                    throw new OptimiseException('problem during creation of tmp dir (mkdir problem)');
+        }
+        ;
+        if (!is_dir($path->getPath())) {
+                    throw new OptimiseException('problem during creation of tmp dir (it is not possible to create directory)');
+        }
         return $path;
     }
 
@@ -80,8 +84,9 @@ 
      */
     public function __destruct()
     {
-        if ($this->path && is_dir($this->path) && !self::delTree($this->path))
-            throw new OptimiseException('problems during removing of path directory');
+        if ($this->path && is_dir($this->path) && !self::delTree($this->path)) {
+                    throw new OptimiseException('problems during removing of path directory');
+        }
     }
 
     /**

app/Http/Middleware/GetUserAndRefresh.php

Indentation +16 added lines, -16 removed lines

@@ -1,21 +1,21 @@
 <?php
 /**
- * Created by PhpStorm.
- * User: Claudio Cardinale <cardi@thecsea.it>
- * Date: 24/12/15
- * Time: 22.53
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version 2
- * of the License, or (at your option) any later version.
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
- */
+     * Created by PhpStorm.
+     * User: Claudio Cardinale <cardi@thecsea.it>
+     * Date: 24/12/15
+     * Time: 22.53
+     * This program is free software; you can redistribute it and/or
+     * modify it under the terms of the GNU General Public License
+     * as published by the Free Software Foundation; either version 2
+     * of the License, or (at your option) any later version.
+     * This program is distributed in the hope that it will be useful,
+     * but WITHOUT ANY WARRANTY; without even the implied warranty of
+     * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+     * GNU General Public License for more details.
+     * You should have received a copy of the GNU General Public License
+     * along with this program; if not, write to the Free Software
+     * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+     */
 
 namespace plunner\Http\Middleware;
 

Spacing +2 added lines, -2 removed lines

@@ -34,12 +34,12 @@
                 \JWTFactory::setTTL(43200);
                 //config(['jwt.ttl' =>'43200']); //30 days
             }
-        }catch(JWTException $e)
+        } catch (JWTException $e)
         {}
 
         //this to add the remember me mode field in the new token, but we have the custom check that is an useless
         //overhead
-        $custom = $custom . ';remember-' . $remember == 'true' ? 'true' : 'false';
+        $custom = $custom.';remember-'.$remember == 'true' ? 'true' : 'false';
         return parent::handle($request, $next, $custom);
     }
 

Braces +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
                 \JWTFactory::setTTL(43200);
                 //config(['jwt.ttl' =>'43200']); //30 days
             }
-        }catch(JWTException $e)
+        } catch(JWTException $e)
         {}
 
         //this to add the remember me mode field in the new token, but we have the custom check that is an useless

app/MeetingTimeslot.php

Spacing +2 added lines, -2 removed lines

@@ -32,14 +32,14 @@
      *
      * @var array
      */
-    protected $fillable = ['time_start', 'time_end'];
+    protected $fillable = [ 'time_start', 'time_end' ];
 
     /**
      * The attributes excluded from the model's JSON form.
      *
      * @var array
      */
-    protected $hidden = ['pivot', 'meeting'];
+    protected $hidden = [ 'pivot', 'meeting' ];
 
     /**
      * @return \Illuminate\Database\Eloquent\Relations\BelongsTo

app/Http/Controllers/Employees/Calendars/TimeslotsController.php

Spacing +2 added lines, -2 removed lines

@@ -21,8 +21,8 @@
      */
     public function __construct()
     {
-        config(['auth.model' => \plunner\Employee::class]);
-        config(['jwt.user' => \plunner\Employee::class]);
+        config([ 'auth.model' => \plunner\Employee::class ]);
+        config([ 'jwt.user' => \plunner\Employee::class ]);
         $this->middleware('jwt.authandrefresh:mode-en');
     }
 

Braces +3 added lines, -2 removed lines

@@ -36,8 +36,9 @@
         $calendar = Calendar::findOrFail($calendarId);
         $this->authorize($calendar);
         $timeslots = $calendar->timeslots();
-        if ($request->query('current'))
-            $timeslots->where('time_start', '>=', new \DateTime());
+        if ($request->query('current')) {
+                    $timeslots->where('time_start', '>=', new \DateTime());
+        }
         return $timeslots->get();
     }
 

app/Http/Controllers/Employees/Planners/MeetingTimeslotsController.php

Unused Use Statements -2 removed lines

@@ -2,11 +2,9 @@
 
 namespace plunner\Http\Controllers\Employees\Planners;
 
-use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Response;
 use plunner\Group;
 use plunner\Http\Controllers\Controller;
-use plunner\Http\Requests;
 use plunner\Http\Requests\Employees\Meeting\MeetingTimeslotRequest;
 use plunner\Meeting;
 use plunner\MeetingTimeslot;

Spacing +10 added lines, -10 removed lines

@@ -16,8 +16,8 @@ 
 {
     public function __construct()
     {
-        config(['auth.model' => \plunner\Planner::class]);
-        config(['jwt.user' => \plunner\Planner::class]);
+        config([ 'auth.model' => \plunner\Planner::class ]);
+        config([ 'jwt.user' => \plunner\Planner::class ]);
         $this->middleware('jwt.authandrefresh:mode-en');
     }
 
@@ -35,7 +35,7 @@ 
 
         if ($meeting->group_id == $groupId)
             return $meeting->timeslots;
-        return Response::json(['error' => 'meeting->group_id <> groupId'], 403);
+        return Response::json([ 'error' => 'meeting->group_id <> groupId' ], 403);
     }
 
     /**
@@ -57,7 +57,7 @@ 
 
         if ($meeting->group_id == $groupId && $timeslot->meeting_id == $meetingId)
             return $timeslot;
-        return Response::json(['error' => 'meeting->group_id <> groupId || timeslot->meeting_id <> meetingId'], 403);
+        return Response::json([ 'error' => 'meeting->group_id <> groupId || timeslot->meeting_id <> meetingId' ], 403);
     }
 
     /**
@@ -73,7 +73,7 @@ 
         $meeting = Meeting::findOrFail($meetingId);
         $this->authorize($meeting);
         if ($meeting->start_time != NULL)
-            return Response::json(['error' => 'the meeting is already planned'], 422);
+            return Response::json([ 'error' => 'the meeting is already planned' ], 422);
 
         $input = $request->all();
 
@@ -81,7 +81,7 @@ 
             $timeslot = $meeting->timeslots()->create($input);
             return $timeslot;
         }
-        return Response::json(['error' => 'meeting->group_id <> groupId'], 403);
+        return Response::json([ 'error' => 'meeting->group_id <> groupId' ], 403);
     }
 
     /**
@@ -97,7 +97,7 @@ 
         $meeting = Meeting::findOrFail($meetingId);
         $this->authorize($meeting);
         if ($meeting->start_time != NULL)
-            return Response::json(['error' => 'the meeting is already planned'], 422);
+            return Response::json([ 'error' => 'the meeting is already planned' ], 422);
         $timeslot = MeetingTimeslot::findOrFail($timeslotId);
         $this->authorize($timeslot);
 
@@ -107,7 +107,7 @@ 
             $timeslot->update($input);
             return $timeslot;
         }
-        return Response::json(['error' => 'meeting->group_id <> groupId || timeslot->meeting_id <> meetingId'], 403);
+        return Response::json([ 'error' => 'meeting->group_id <> groupId || timeslot->meeting_id <> meetingId' ], 403);
     }
 
     /**
@@ -125,7 +125,7 @@ 
         $meeting = Meeting::findOrFail($meetingId);
         $this->authorize($meeting);
         if ($meeting->start_time != NULL)
-            return Response::json(['error' => 'the meeting is already planned'], 422);
+            return Response::json([ 'error' => 'the meeting is already planned' ], 422);
         $timeslot = MeetingTimeslot::findOrFail($timeslotId);
         $this->authorize($timeslot);
 
@@ -133,6 +133,6 @@ 
             $timeslot->delete();
             return $timeslot;
         }
-        return Response::json(['error' => 'meeting->group_id <> groupId || timeslot->meeting_id <> meetingId'], 403);
+        return Response::json([ 'error' => 'meeting->group_id <> groupId || timeslot->meeting_id <> meetingId' ], 403);
     }
 }

Braces +15 added lines, -10 removed lines

@@ -33,8 +33,9 @@ 
         $meeting = Meeting::findOrFail($meetingId);
         $this->authorize($meeting);
 
-        if ($meeting->group_id == $groupId)
-            return $meeting->timeslots;
+        if ($meeting->group_id == $groupId) {
+                    return $meeting->timeslots;
+        }
         return Response::json(['error' => 'meeting->group_id <> groupId'], 403);
     }
 
@@ -55,8 +56,9 @@ 
         $timeslot = MeetingTimeslot::findOrFail($timeslotId);
         $this->authorize($timeslot);
 
-        if ($meeting->group_id == $groupId && $timeslot->meeting_id == $meetingId)
-            return $timeslot;
+        if ($meeting->group_id == $groupId && $timeslot->meeting_id == $meetingId) {
+                    return $timeslot;
+        }
         return Response::json(['error' => 'meeting->group_id <> groupId || timeslot->meeting_id <> meetingId'], 403);
     }
 
@@ -72,8 +74,9 @@ 
         $this->authorize($group);
         $meeting = Meeting::findOrFail($meetingId);
         $this->authorize($meeting);
-        if ($meeting->start_time != NULL)
-            return Response::json(['error' => 'the meeting is already planned'], 422);
+        if ($meeting->start_time != NULL) {
+                    return Response::json(['error' => 'the meeting is already planned'], 422);
+        }
 
         $input = $request->all();
 
@@ -96,8 +99,9 @@ 
         $this->authorize($group);
         $meeting = Meeting::findOrFail($meetingId);
         $this->authorize($meeting);
-        if ($meeting->start_time != NULL)
-            return Response::json(['error' => 'the meeting is already planned'], 422);
+        if ($meeting->start_time != NULL) {
+                    return Response::json(['error' => 'the meeting is already planned'], 422);
+        }
         $timeslot = MeetingTimeslot::findOrFail($timeslotId);
         $this->authorize($timeslot);
 
@@ -124,8 +128,9 @@ 
         $this->authorize($group);
         $meeting = Meeting::findOrFail($meetingId);
         $this->authorize($meeting);
-        if ($meeting->start_time != NULL)
-            return Response::json(['error' => 'the meeting is already planned'], 422);
+        if ($meeting->start_time != NULL) {
+                    return Response::json(['error' => 'the meeting is already planned'], 422);
+        }
         $timeslot = MeetingTimeslot::findOrFail($timeslotId);
         $this->authorize($timeslot);
 

app/Console/Commands/Optimise/Solver.php

Doc Comments +9 added lines, -7 removed lines

@@ -143,7 +143,7 @@ 
     }
 
     /**
-     * @return \string[]
+     * @return string[]
      */
     public function getUsers()
     {
@@ -255,6 +255,8 @@ 
      * implementation of arraypad that doesn't change original keys<br/>
      * <strong>CAUTION: Only positive $len</strong>
      * @param array $array
+     * @param integer $len
+     * @param integer $pad
      * @return array
      */
     static private function arrayPad(array $array, $len, $pad)
@@ -393,7 +395,7 @@ 
     }
 
     /**
-     * @param $proprieties
+     * @param string[] $proprieties
      * @throws OptimiseException
      */
     private function checkArrayProprieties($proprieties)
@@ -404,7 +406,7 @@ 
     }
 
     /**
-     * @param $proprieties
+     * @param string[] $proprieties
      * @throws OptimiseException
      */
     private function checkIntProprieties($proprieties)
@@ -424,7 +426,7 @@ 
 
     /**
      * @param string $file
-     * @param array $data
+     * @param string[] $data
      * @throws OptimiseException
      */
     static private function writeCSVArrayNoKey($file, $data)
@@ -441,7 +443,7 @@ 
     /**
      * @param string $file
      * @param array $data
-     * @param array $heading
+     * @param string[] $heading
      * @param \Closure $writer
      * @throws OptimiseException
      */
@@ -478,7 +480,7 @@ 
 
     /**
      * @param string $file
-     * @param array $data
+     * @param string[] $data
      * @param string $name
      * @throws OptimiseException
      */
@@ -503,7 +505,7 @@ 
 
     /**
      * @param string $file
-     * @param array $data
+     * @param string[] $data
      * @param string $name
      * @throws OptimiseException
      */

Indentation +16 added lines, -16 removed lines

@@ -1,21 +1,21 @@
 <?php
 /**
- * Created by PhpStorm.
- * User: Claudio Cardinale <cardi@thecsea.it>
- * Date: 07/12/15
- * Time: 21.18
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version 2
- * of the License, or (at your option) any later version.
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
- */
+     * Created by PhpStorm.
+     * User: Claudio Cardinale <cardi@thecsea.it>
+     * Date: 07/12/15
+     * Time: 21.18
+     * This program is free software; you can redistribute it and/or
+     * modify it under the terms of the GNU General Public License
+     * as published by the Free Software Foundation; either version 2
+     * of the License, or (at your option) any later version.
+     * This program is distributed in the hope that it will be useful,
+     * but WITHOUT ANY WARRANTY; without even the implied warranty of
+     * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+     * GNU General Public License for more details.
+     * You should have received a copy of the GNU General Public License
+     * along with this program; if not, write to the Free Software
+     * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+     */
 
 namespace plunner\Console\Commands\Optimise;
 

Braces +60 added lines, -40 removed lines

@@ -104,8 +104,9 @@ 
      */
     static private function checkGlpsol()
     {
-        if (!(`which glpsol`))
-            throw new OptimiseException('glpsol is not installed');
+        if (!(`which glpsol`)) {
+                    throw new OptimiseException('glpsol is not installed');
+        }
     }
 
     /**
@@ -193,8 +194,9 @@ 
      */
     public function setTimeSlots($timeSlots)
     {
-        if (!is_int($timeSlots) || $timeSlots <= 0)
-            throw new OptimiseException('$timeSlots is not integer or it is not >0');
+        if (!is_int($timeSlots) || $timeSlots <= 0) {
+                    throw new OptimiseException('$timeSlots is not integer or it is not >0');
+        }
 
         $this->timeSlots = $timeSlots;
         return $this;
@@ -215,8 +217,9 @@ 
      */
     public function setMaxTimeSlots($maxTimeSlots)
     {
-        if (!is_int($maxTimeSlots) || $maxTimeSlots <= 0)
-            throw new OptimiseException('$maxTimeSlots is not integer or it is not >0');
+        if (!is_int($maxTimeSlots) || $maxTimeSlots <= 0) {
+                    throw new OptimiseException('$maxTimeSlots is not integer or it is not >0');
+        }
 
         $this->maxTimeSlots = $maxTimeSlots;
         return $this;
@@ -238,12 +241,14 @@ 
     public function setMeetingsAvailability($meetingsAvailability)
     {
         $meetings = array_keys($meetingsAvailability);
-        if (array_diff($meetings, $this->meetings))
-            throw new OptimiseException('meetings different from meetings set');
+        if (array_diff($meetings, $this->meetings)) {
+                    throw new OptimiseException('meetings different from meetings set');
+        }
         foreach ($meetingsAvailability as $key => $meetingsAvailabilityS) {
             $timeSlots = array_keys($meetingsAvailabilityS);
-            if (count($timeSlots) != $this->timeSlots)
-                throw new OptimiseException('timeSlots different from timeSlots set');
+            if (count($timeSlots) != $this->timeSlots) {
+                            throw new OptimiseException('timeSlots different from timeSlots set');
+            }
             $meetingsAvailability[$key] = self::arrayPad($meetingsAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0);
         }
 
@@ -260,8 +265,9 @@ 
     static private function arrayPad(array $array, $len, $pad)
     {
         $len = $len - count($array);
-        for ($i = 0; $i < $len; $i++)
-            $array[] = $pad;
+        for ($i = 0; $i < $len; $i++) {
+                    $array[] = $pad;
+        }
         return $array;
     }
 
@@ -287,8 +293,9 @@ 
         }
         foreach ($meetingsDuration as $duration) {
             $duration = (int)$duration; //TODO fix this (fix for optimise)
-            if (!is_int($duration) || $duration <= 0)
-                throw new OptimiseException('duration is not integer or it is not >0');
+            if (!is_int($duration) || $duration <= 0) {
+                            throw new OptimiseException('duration is not integer or it is not >0');
+            }
         }
 
         $this->meetingsDuration = $meetingsDuration;
@@ -311,12 +318,14 @@ 
     public function setUsersAvailability($usersAvailability)
     {
         $users = array_keys($usersAvailability);
-        if (array_diff($users, $this->users))
-            throw new OptimiseException('users different from users set');
+        if (array_diff($users, $this->users)) {
+                    throw new OptimiseException('users different from users set');
+        }
         foreach ($usersAvailability as $key => $usersAvailabilityS) {
             $timeSlots = array_keys($usersAvailabilityS);
-            if (count($timeSlots) != $this->timeSlots)
-                throw new OptimiseException('timeSlots different from timeSlots set');
+            if (count($timeSlots) != $this->timeSlots) {
+                            throw new OptimiseException('timeSlots different from timeSlots set');
+            }
 
             $usersAvailability[$key] = self::arrayPad($usersAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0);
         }
@@ -341,12 +350,14 @@ 
     public function setUsersMeetings($usersMeetings)
     {
         $users = array_keys($usersMeetings);
-        if (array_diff($users, $this->users))
-            throw new OptimiseException('users different from users set');
+        if (array_diff($users, $this->users)) {
+                    throw new OptimiseException('users different from users set');
+        }
         foreach ($usersMeetings as $usersMeetingsS) {
             $meetings = array_keys($usersMeetingsS);
-            if (array_diff($meetings, $this->meetings))
-                throw new OptimiseException('meetings different from meetings set');
+            if (array_diff($meetings, $this->meetings)) {
+                            throw new OptimiseException('meetings different from meetings set');
+            }
         }
 
         $this->usersMeetings = $usersMeetings;
@@ -363,8 +374,9 @@ 
         $this->writeModelFile();
         $event = $this->schedule->exec('glpsol --math ' . $this->path->getModelPath())->sendOutputTo($this->path->getOutputPath())->after(function () {
         }); //this just to execute in foreground
-        if ($event->isDue($this->laravel))
-            $event->run($this->laravel);
+        if ($event->isDue($this->laravel)) {
+                    $event->run($this->laravel);
+        }
         //TODO catch glpsol errors
         return $this;
     }
@@ -398,9 +410,10 @@ 
      */
     private function checkArrayProprieties($proprieties)
     {
-        foreach ($proprieties as $propriety)
-            if (count($this->$propriety) == 0)
+        foreach ($proprieties as $propriety) {
+                    if (count($this->$propriety) == 0)
                 throw new OptimiseException($propriety . ' is not set correctly');
+        }
     }
 
     /**
@@ -409,9 +422,10 @@ 
      */
     private function checkIntProprieties($proprieties)
     {
-        foreach ($proprieties as $propriety)
-            if (!is_int($this->$propriety) || $this->$propriety <= 0)
+        foreach ($proprieties as $propriety) {
+                    if (!is_int($this->$propriety) || $this->$propriety <= 0)
                 throw new OptimiseException($propriety . ' is not set correctly');
+        }
     }
 
     /**
@@ -448,8 +462,9 @@ 
     static private function writeCSV($file, $data, $heading, \Closure $writer)
     {
         $fp = @fopen($file, 'w');
-        if (!$fp)
-            throw new OptimiseException('problem during creation of a file');
+        if (!$fp) {
+                    throw new OptimiseException('problem during creation of a file');
+        }
 
         fputcsv($fp, $heading);
 
@@ -511,8 +526,9 @@ 
     {
         $f = function ($fp, $data) {
             foreach ($data as $key => $field) {
-                foreach ($field as $key2 => $field2)
-                    fputcsv($fp, [$key, $key2, $field2]);
+                foreach ($field as $key2 => $field2) {
+                                    fputcsv($fp, [$key, $key2, $field2]);
+                }
             }
         };
 
@@ -543,8 +559,9 @@ 
         $strReplaceS = array('{USERS_PATH}', '{MEETINGS_PATH}', '{USER_AVAILABILITY_PATH}', '{MEETINGS_AVAILABILITY_PATH}', '{USER_MEETINGS_PATH}', '{MEETINGS_DURATION_PATH}', '{TIME_SLOTS}', '{MAX_TIME_SLOTS}', '{X_OUT_PATH}', '{Y_OUT_PATH}');
         $strReplaceR = array($this->path->getUsersPath(), $this->path->getMeetingsPath(), $this->path->getUsersAvailabilityPath(), $this->path->getMeetingsAvailabilityPath(), $this->path->getUsersMeetingsPath(), $this->path->getMeetingsDurationPath(), $this->timeSlots, $this->maxTimeSlots, $this->path->getXPath(), $this->path->getYPath());
         $f = @fopen($this->path->getModelPath(), "w");
-        if (!$f)
-            throw new OptimiseException('problem during creation of a file');
+        if (!$f) {
+                    throw new OptimiseException('problem during creation of a file');
+        }
         fwrite($f, str_replace($strReplaceS, $strReplaceR, file_get_contents(__DIR__ . "/model.stub")));
         fclose($f);
     }
@@ -565,12 +582,14 @@ 
      */
     static private function readCSVFile($file)
     {
-        if (!file_exists($file) || !filesize($file))
-            throw new OptimiseException('no results file');
+        if (!file_exists($file) || !filesize($file)) {
+                    throw new OptimiseException('no results file');
+        }
 
         $handle = @fopen($file, "r");
-        if (!$handle)
-            throw new OptimiseException('problems during reading the file');
+        if (!$handle) {
+                    throw new OptimiseException('problems during reading the file');
+        }
 
         $ret = [];
         fgetcsv($handle); //skip head
@@ -603,8 +622,9 @@ 
      */
     public function getOutput()
     {
-        if (!($data = file_get_contents($this->path->getOutputPath())))
-            throw new OptimiseException('problems during reading the file');
+        if (!($data = file_get_contents($this->path->getOutputPath()))) {
+                    throw new OptimiseException('problems during reading the file');
+        }
         return $data;
     }
 }
\ No newline at end of file

Spacing +23 added lines, -23 removed lines

@@ -241,10 +241,10 @@ 
         if (array_diff($meetings, $this->meetings))
             throw new OptimiseException('meetings different from meetings set');
         foreach ($meetingsAvailability as $key => $meetingsAvailabilityS) {
-            $timeSlots = array_keys($meetingsAvailabilityS);//TODO this is useless, we can use directly $usersAvailabilityS
+            $timeSlots = array_keys($meetingsAvailabilityS); //TODO this is useless, we can use directly $usersAvailabilityS
             if (count($timeSlots) != $this->timeSlots)
                 throw new OptimiseException('timeSlots different from timeSlots set');
-            $meetingsAvailability[$key] = self::arrayPad($meetingsAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0);
+            $meetingsAvailability[ $key ] = self::arrayPad($meetingsAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0);
         }
 
         $this->meetingsAvailability = $meetingsAvailability;
@@ -261,7 +261,7 @@ 
     {
         $len = $len - count($array);
         for ($i = 0; $i < $len; $i++)
-            $array[] = $pad;
+            $array[ ] = $pad;
         return $array;
     }
 
@@ -286,7 +286,7 @@ 
             throw new OptimiseException('meetings different from meetings set');
         }
         foreach ($meetingsDuration as $duration) {
-            $duration = (int)$duration; //TODO fix this (fix for optimise)
+            $duration = (int) $duration; //TODO fix this (fix for optimise)
             if (!is_int($duration) || $duration <= 0)
                 throw new OptimiseException('duration is not integer or it is not >0');
         }
@@ -314,11 +314,11 @@ 
         if (array_diff($users, $this->users))
             throw new OptimiseException('users different from users set');
         foreach ($usersAvailability as $key => $usersAvailabilityS) {
-            $timeSlots = array_keys($usersAvailabilityS);//TODO this is useless, we can use directly $usersAvailabilityS
+            $timeSlots = array_keys($usersAvailabilityS); //TODO this is useless, we can use directly $usersAvailabilityS
             if (count($timeSlots) != $this->timeSlots)
                 throw new OptimiseException('timeSlots different from timeSlots set');
 
-            $usersAvailability[$key] = self::arrayPad($usersAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0);
+            $usersAvailability[ $key ] = self::arrayPad($usersAvailabilityS, $this->timeSlots + $this->maxTimeSlots, 0);
         }
 
         $this->usersAvailability = $usersAvailability;
@@ -361,7 +361,7 @@ 
     {
         $this->writeData();
         $this->writeModelFile();
-        $event = $this->schedule->exec('glpsol --math ' . $this->path->getModelPath())->sendOutputTo($this->path->getOutputPath())->after(function () {
+        $event = $this->schedule->exec('glpsol --math '.$this->path->getModelPath())->sendOutputTo($this->path->getOutputPath())->after(function() {
         }); //this just to execute in foreground
         if ($event->isDue($this->laravel))
             $event->run($this->laravel);
@@ -388,8 +388,8 @@ 
      */
     private function checkData()
     {
-        $this->checkArrayProprieties(['users', 'meetings', 'meetingsAvailability', 'meetingsDuration', 'usersAvailability', 'usersMeetings']);
-        $this->checkIntProprieties(['timeSlots', 'maxTimeSlots']);
+        $this->checkArrayProprieties([ 'users', 'meetings', 'meetingsAvailability', 'meetingsDuration', 'usersAvailability', 'usersMeetings' ]);
+        $this->checkIntProprieties([ 'timeSlots', 'maxTimeSlots' ]);
     }
 
     /**
@@ -400,7 +400,7 @@ 
     {
         foreach ($proprieties as $propriety)
             if (count($this->$propriety) == 0)
-                throw new OptimiseException($propriety . ' property is not set correctly');
+                throw new OptimiseException($propriety.' property is not set correctly');
     }
 
     /**
@@ -411,7 +411,7 @@ 
     {
         foreach ($proprieties as $propriety)
             if (!is_int($this->$propriety) || $this->$propriety <= 0)
-                throw new OptimiseException($propriety . ' property is not set correctly');
+                throw new OptimiseException($propriety.' property is not set correctly');
     }
 
     /**
@@ -429,13 +429,13 @@ 
      */
     static private function writeCSVArrayNoKey($file, $data)
     {
-        $f = function ($fp, $data) {
+        $f = function($fp, $data) {
             foreach ($data as $field) {
-                fputcsv($fp, [$field]);
+                fputcsv($fp, [ $field ]);
             }
         };
 
-        self::writeCSV($file, $data, ['i'], $f);
+        self::writeCSV($file, $data, [ 'i' ], $f);
     }
 
     /**
@@ -484,13 +484,13 @@ 
      */
     static private function writeCSVArray($file, $data, $name)
     {
-        $f = function ($fp, $data) {
+        $f = function($fp, $data) {
             foreach ($data as $key => $field) {
-                fputcsv($fp, [$key, $field]);
+                fputcsv($fp, [ $key, $field ]);
             }
         };
 
-        self::writeCSV($file, $data, ['i', $name], $f);
+        self::writeCSV($file, $data, [ 'i', $name ], $f);
     }
 
     /**
@@ -509,14 +509,14 @@ 
      */
     static private function writeCSVMatrix($file, $data, $name)
     {
-        $f = function ($fp, $data) {
+        $f = function($fp, $data) {
             foreach ($data as $key => $field) {
                 foreach ($field as $key2 => $field2)
-                    fputcsv($fp, [$key, $key2, $field2]);
+                    fputcsv($fp, [ $key, $key2, $field2 ]);
             }
         };
 
-        self::writeCSV($file, $data, ['i', 'j', $name], $f);
+        self::writeCSV($file, $data, [ 'i', 'j', $name ], $f);
     }
 
     /**
@@ -545,7 +545,7 @@ 
         $f = @fopen($this->path->getModelPath(), "w");
         if (!$f)
             throw new OptimiseException('problem during creation of a file');
-        fwrite($f, str_replace($strReplaceS, $strReplaceR, file_get_contents(__DIR__ . "/model.stub")));
+        fwrite($f, str_replace($strReplaceS, $strReplaceR, file_get_contents(__DIR__."/model.stub")));
         fclose($f);
     }
 
@@ -572,7 +572,7 @@ 
         if (!$handle)
             throw new OptimiseException('problems during reading the file');
 
-        $ret = [];
+        $ret = [ ];
         fgetcsv($handle); //skip head
         while (($data = fgetcsv($handle)) !== FALSE) {
             if (count($data) != 3) {
@@ -580,7 +580,7 @@ 
                 throw new OptimiseException('problems during parsing the file');
             }
 
-            $ret[$data[0]][$data[1]] = $data[2];
+            $ret[ $data[ 0 ] ][ $data[ 1 ] ] = $data[ 2 ];
         }
 
         fclose($handle);