Complex classes like Optimise often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Optimise, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
23 | class Optimise |
||
24 | { |
||
25 | |||
26 | private $max_time_slots; |
||
27 | private $time_slots; |
||
28 | |||
29 | //TODO timezone |
||
30 | /** |
||
31 | * @var \DateTime |
||
32 | */ |
||
33 | private $startTime; |
||
34 | /** |
||
35 | * @var \DateTime |
||
36 | */ |
||
37 | private $endTime; |
||
38 | |||
39 | /** |
||
40 | * @var Company |
||
41 | */ |
||
42 | private $company; |
||
43 | |||
44 | /** |
||
45 | * @var Schedule laravel schedule object needed to perform command in background |
||
46 | */ |
||
47 | private $schedule; |
||
48 | |||
49 | /** |
||
50 | * @var \Illuminate\Contracts\Foundation\Application; |
||
51 | */ |
||
52 | private $laravel; |
||
53 | |||
54 | /** |
||
55 | * @var Solver |
||
56 | */ |
||
57 | private $solver = null; |
||
58 | |||
59 | //TODO clone |
||
60 | //TODO to_string |
||
61 | |||
62 | /** |
||
63 | * Optimise constructor. |
||
64 | * @param company $company |
||
65 | * @param Schedule $schedule |
||
66 | * @param \Illuminate\Contracts\Foundation\Application $laravel |
||
67 | */ |
||
68 | 12 | public function __construct(company $company, Schedule $schedule, \Illuminate\Contracts\Foundation\Application $laravel) |
|
69 | { |
||
70 | 12 | $this->company = $company; |
|
|
|||
71 | 12 | $this->schedule = $schedule; |
|
72 | 12 | $this->laravel = $laravel; |
|
73 | 12 | $this->max_time_slots = config('app.timeslots.max'); |
|
74 | 12 | $this->time_slots = config('app.timeslots.number'); |
|
75 | |||
76 | |||
77 | 12 | $this->setStartTime((new \DateTime())->modify('next monday')); |
|
78 | 12 | } |
|
79 | |||
80 | |||
81 | /** |
||
82 | * @param \DateTime $startTime |
||
83 | */ |
||
84 | 12 | public function setStartTime(\DateTime $startTime) |
|
85 | { |
||
86 | 12 | $this->startTime = clone $startTime; |
|
87 | 12 | $this->endTime = clone $this->startTime; |
|
88 | 12 | $this->endTime->add(new \DateInterval('PT' . (($this->max_time_slots + $this->time_slots) * |
|
89 | 12 | config('app.timeslots.duration')) . 'S')); |
|
90 | 12 | } |
|
91 | |||
92 | /** |
||
93 | * @return int |
||
94 | */ |
||
95 | 2 | public function getMaxTimeSlots() |
|
99 | |||
100 | /** |
||
101 | * @param int $max_time_slots |
||
102 | */ |
||
103 | 3 | public function setMaxTimeSlots($max_time_slots) |
|
107 | |||
108 | /** |
||
109 | * @return int |
||
110 | */ |
||
111 | 3 | public function getTimeSlots() |
|
115 | |||
116 | /** |
||
117 | * @param int $time_slots |
||
118 | */ |
||
119 | 3 | public function setTimeSlots($time_slots) |
|
120 | { |
||
121 | 3 | $this->time_slots = $time_slots; |
|
122 | 3 | } |
|
123 | |||
124 | |||
125 | /** |
||
126 | * @return Company |
||
127 | */ |
||
128 | public function getCompany() |
||
129 | { |
||
130 | return $this->company; |
||
131 | } |
||
132 | |||
133 | /** |
||
134 | * @param Company $company |
||
135 | */ |
||
136 | public function setCompany($company) |
||
137 | { |
||
138 | $this->company = $company; |
||
139 | } |
||
140 | |||
141 | /** |
||
142 | * @return Solver |
||
143 | */ |
||
144 | 5 | public function getSolver() |
|
148 | |||
149 | |||
150 | /** |
||
151 | * @return Optimise |
||
152 | * @throws OptimiseException |
||
153 | */ |
||
154 | 12 | public function optimise() |
|
173 | |||
174 | /** |
||
175 | * @param Solver $solver |
||
176 | * @return Solver |
||
177 | * @throws OptimiseException |
||
178 | */ |
||
179 | 12 | private function setData(Solver $solver) |
|
180 | { |
||
181 | 12 | $solver = $this->setTimeSlotsSolver($solver); |
|
182 | 12 | $solver = $this->setUsers($solver); |
|
183 | 9 | $solver = $this->setAllMeetingsInfo($solver); |
|
184 | 6 | $solver = $this->setUserAvailability($solver); |
|
185 | 6 | $solver = $this->setUsersMeetings($solver); |
|
186 | 6 | return $solver; |
|
187 | } |
||
188 | |||
189 | //TODO fix php doc with exceptions |
||
190 | |||
191 | /** |
||
192 | * @param Solver $solver |
||
193 | * @return Solver |
||
194 | * @throws OptimiseException |
||
195 | */ |
||
196 | 12 | private function setTimeSlotsSolver(Solver $solver) |
|
200 | |||
201 | /** |
||
202 | * @param Solver $solver |
||
203 | * @return Solver |
||
204 | * @throws OptimiseException |
||
205 | */ |
||
206 | 12 | private function setUsers(Solver $solver) |
|
214 | |||
215 | /** |
||
216 | * @param Solver $solver |
||
217 | * @return Solver |
||
218 | * @throws OptimiseException |
||
219 | */ |
||
220 | 9 | private function setAllMeetingsInfo(Solver $solver) |
|
221 | { |
||
222 | /** |
||
223 | * @var $meetings \Illuminate\Support\Collection |
||
224 | */ |
||
225 | 9 | $meetings = collect($this->company->getMeetingsTimeSlots($this->startTime, $this->endTime)); |
|
226 | 9 | if($meetings->count() == 0) |
|
227 | 7 | throw ((new OptimiseException("No meetings for this week"))->withEmpty(true)); |
|
228 | $timeslots = $meetings->groupBy('id')->map(function ($item) { //convert timeslots |
||
229 | 6 | return $this->durationConverter($this->timeSlotsConverter($item)); |
|
230 | 6 | }); |
|
231 | 6 | return $solver->setMeetings($timeslots->keys()->toArray()) |
|
232 | 6 | ->setMeetingsDuration($meetings->pluck('duration', 'id')->toArray()) |
|
233 | 6 | ->setMeetingsAvailability(self::getAvailabilityArray($timeslots, $this->time_slots, $solver->getMeetings())); |
|
234 | } |
||
235 | |||
236 | |||
237 | /** |
||
238 | * @param mixed $item |
||
239 | * @return mixed |
||
240 | */ |
||
241 | 6 | private function durationConverter($item) |
|
249 | |||
250 | /** |
||
251 | * @param int $duration |
||
252 | * @return int |
||
253 | */ |
||
254 | 6 | static private function convertDuration($duration) |
|
258 | |||
259 | /** |
||
260 | * @param mixed $item |
||
261 | * @return mixed |
||
262 | */ |
||
263 | 6 | private function timeSlotsConverter($item) |
|
264 | { |
||
265 | return $item->each(function ($item2) { |
||
266 | 6 | $item2->time_start = $this->toTimeSlot($item2->time_start); |
|
267 | 6 | $item2->time_end = $this->toTimeSlot($item2->time_end); |
|
268 | 6 | return $item2; |
|
269 | //TODO try catch |
||
270 | 6 | }); |
|
271 | } |
||
272 | |||
273 | /** |
||
274 | * @param mixed $time |
||
275 | * @return int |
||
276 | * @throws OptimiseException |
||
277 | */ |
||
278 | 6 | private function toTimeSlot($time) |
|
279 | { |
||
280 | 6 | $dateTime = new \DateTime($time); |
|
281 | 6 | $diff = $dateTime->diff($this->startTime); |
|
282 | 6 | $diff = explode(':', $diff->format('%R:%d:%h:%i:%s')); |
|
283 | 6 | $diff = $diff[1] * 86400 + $diff[2] * 3600 + $diff[3] * 60 + $diff[4]; |
|
284 | //if($diff[0] != '-' && $diff != 0) |
||
285 | // throw new OptimiseException('timeslot time <= startTime'); |
||
286 | //TODO fix check |
||
287 | //TODO check if diff makes sense |
||
288 | //TODO check upper limit |
||
289 | 6 | return (int)(round($diff / config('app.timeslots.duration')) + 1); //TODO can round cause overlaps? |
|
290 | } |
||
291 | |||
292 | /** |
||
293 | * @param \Illuminate\Support\Collection $timeSlots |
||
294 | * @param bool|true $free if true the array is filled with 1 for timeslots values else with 0 for timeslots values |
||
295 | * @return array |
||
296 | */ |
||
297 | 6 | static private function getAvailabilityArray(\Illuminate\Support\Collection $timeSlots, $timeslotsN, $ids, $free = true) |
|
298 | { |
||
299 | 6 | $ret = []; |
|
300 | 6 | foreach ($ids as $id) { |
|
301 | 6 | if(isset($timeSlots[$id])) |
|
302 | 6 | $ret = self::fillTimeSlots($ret, $id, $timeSlots[$id], $free ? '1' : '0'); |
|
303 | 6 | $ret = self::fillRow($ret, $id, $timeslotsN, $free ? '0' : '1'); |
|
304 | 4 | } |
|
305 | |||
306 | 6 | return $ret; |
|
307 | } |
||
308 | |||
309 | /** |
||
310 | * @param array $array |
||
311 | * @param int $id |
||
312 | * @param \Illuminate\Support\Collection $timeSlots |
||
313 | * @param string $fill |
||
314 | * @return array |
||
315 | */ |
||
316 | 6 | static private function fillTimeSlots(array $array, $id, \Illuminate\Support\Collection $timeSlots, $fill = '0') |
|
317 | { |
||
318 | 6 | foreach ($timeSlots as $timeSlot) { |
|
319 | 6 | if (!isset($array[$id])) |
|
320 | 6 | $array[$id] = []; |
|
321 | 6 | $array[$id] = self::arrayPadInterval($array[$id], $timeSlot->time_start, $timeSlot->time_end, $fill); |
|
322 | 4 | } |
|
323 | 6 | return $array; |
|
324 | } |
||
325 | |||
326 | /** |
||
327 | * @param array $array |
||
328 | * @param int $from |
||
329 | * @param int $to |
||
330 | * @param string $pad |
||
331 | * @return array |
||
332 | */ |
||
333 | 6 | static private function arrayPadInterval(array $array, $from, $to, $pad = '0') |
|
334 | { |
||
335 | 6 | for ($i = $from; $i < $to; $i++) |
|
336 | 6 | $array[$i] = $pad; |
|
337 | 6 | return $array; |
|
338 | } |
||
339 | |||
340 | /** |
||
341 | * @param array $array |
||
342 | * @param int $id |
||
343 | * @param string $fill |
||
344 | * @return array |
||
345 | */ |
||
346 | 6 | static private function fillRow(array $array, $id, $until, $fill = '0') |
|
347 | { |
||
348 | 6 | for ($i = 1; $i <= $until; $i++) { |
|
349 | 6 | if (!isset($array[$id][$i])) |
|
350 | 6 | $array[$id][$i] = $fill; |
|
351 | 4 | } |
|
352 | |||
353 | 6 | return $array; |
|
354 | } |
||
355 | |||
356 | /** |
||
357 | * @param Solver $solver |
||
358 | * @return Solver |
||
359 | * @throws OptimiseException |
||
360 | */ |
||
361 | 6 | private function setUserAvailability(Solver $solver) |
|
362 | { |
||
363 | /** |
||
364 | * @var $users \Illuminate\Support\Collection |
||
365 | */ |
||
366 | 6 | $users = collect($this->company->getEmployeesTimeSlots($this->startTime, $this->endTime)); |
|
367 | //if($users->count() == 0) |
||
368 | // throw ((new OptimiseException("No users for this company"))->withEmpty(true)); |
||
369 | $timeslots = $users->groupBy('id')->map(function ($item) { //convert timeslots |
||
370 | 6 | return $this->timeSlotsConverter($item); |
|
371 | 6 | }); |
|
372 | 6 | return $solver->setUsersAvailability(self::getAvailabilityArray($timeslots, $this->time_slots, $solver->getUsers(), |
|
373 | 6 | false)); |
|
374 | } |
||
375 | |||
376 | /** |
||
377 | * @param Solver $solver |
||
378 | * @return Solver |
||
379 | * @throws OptimiseException |
||
380 | */ |
||
381 | 6 | private function setUsersMeetings(Solver $solver) |
|
394 | |||
395 | /** |
||
396 | * @param array $users |
||
397 | * @param array $meetings |
||
398 | * @param \Illuminate\Support\Collection $usersMeetings |
||
399 | * @return array |
||
400 | */ |
||
401 | 6 | static private function getUsersMeetingsArray($users, $meetings, \Illuminate\Support\Collection $usersMeetings) |
|
417 | |||
418 | /** |
||
419 | * @return Optimise |
||
420 | * @throws OptimiseException |
||
421 | */ |
||
422 | 6 | public function save() |
|
423 | { |
||
424 | 6 | if (!($this->solver instanceof Solver)) { |
|
425 | \Event::fire(new ErrorEvent($this->company, 'solver is not an instace of Solver')); |
||
426 | throw new OptimiseException('solver is not an instance of Solver'); |
||
445 | |||
446 | /** |
||
447 | * @param Solver $solver |
||
448 | */ |
||
449 | 6 | private function saveMeetings(Solver $solver) |
|
458 | |||
459 | /** |
||
460 | * @param int $timeslot |
||
461 | * @return \DateTime |
||
462 | */ |
||
463 | 6 | private function toDateTime($timeslot) |
|
471 | |||
472 | /** |
||
473 | * @param Solver $solver |
||
474 | */ |
||
475 | 6 | private function saveEmployeesMeetings(Solver $solver) |
|
487 | } |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..