Completed
Push — master ( 5a3752...2e0b19 )
by claudio
33:21
created
app/Http/Controllers/Companies/Groups/EmployeesController.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -19,8 +19,8 @@  discard block
 block discarded – undo
19 19
 {
20 20
     public function __construct()
21 21
     {
22
-        config(['auth.model' => \plunner\Company::class]);
23
-        config(['jwt.user' => \plunner\Company::class]);
22
+        config([ 'auth.model' => \plunner\Company::class ]);
23
+        config([ 'jwt.user' => \plunner\Company::class ]);
24 24
         $this->middleware('jwt.authandrefresh:mode-cn');
25 25
     }
26 26
 
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
         //
52 52
         $group = Group::findOrFail($groupId);
53 53
         $this->authorize($group);
54
-        $id = $request->all()['id'];
54
+        $id = $request->all()[ 'id' ];
55 55
         $group->employees()->attach($id);
56 56
         return $group->employees;
57 57
     }
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
         $this->authorize($employee);
71 71
         $group = Group::findOrFail($groupId);
72 72
         if (!$employee->belongsToGroup($group))
73
-            return Response::json(['error' => 'employId <> groupId'], 404);
73
+            return Response::json([ 'error' => 'employId <> groupId' ], 404);
74 74
         $employee->groups()->detach($groupId);
75 75
         return $group->employees;
76 76
     }
Please login to merge, or discard this patch.
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,8 +69,9 @@
 block discarded – undo
69 69
         $employee = Employee::findOrFail($employeeId);
70 70
         $this->authorize($employee);
71 71
         $group = Group::findOrFail($groupId);
72
-        if (!$employee->belongsToGroup($group))
73
-            return Response::json(['error' => 'employId <> groupId'], 404);
72
+        if (!$employee->belongsToGroup($group)) {
73
+                    return Response::json(['error' => 'employId <> groupId'], 404);
74
+        }
74 75
         $employee->groups()->detach($groupId);
75 76
         return $group->employees;
76 77
     }
Please login to merge, or discard this patch.
app/Http/Controllers/Employees/Auth/AuthController.php 2 patches
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,8 +79,9 @@
 block discarded – undo
79 79
         if ($request->input('remember', false)) {
80 80
             config(['jwt.ttl' => '43200']); //30 days
81 81
             $this->custom = array_merge($this->custom, ['remember' => 'true']);
82
-        } else
83
-            $this->custom = array_merge($this->custom, ['remember' => 'false']);
82
+        } else {
83
+                    $this->custom = array_merge($this->custom, ['remember' => 'false']);
84
+        }
84 85
 
85 86
         return $this->postLoginOriginal($request);
86 87
     }
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -42,13 +42,13 @@  discard block
 block discarded – undo
42 42
      * en = employee normal
43 43
      * @var array
44 44
      */
45
-    protected $custom = ['mode' => 'en'];
45
+    protected $custom = [ 'mode' => 'en' ];
46 46
 
47 47
     /**
48 48
      * unique identifiers of the user
49 49
      * @var array
50 50
      */
51
-    protected $username = ['company_id', 'email'];
51
+    protected $username = [ 'company_id', 'email' ];
52 52
 
53 53
     /**
54 54
      * @var company
@@ -61,13 +61,13 @@  discard block
 block discarded – undo
61 61
      */
62 62
     public function __construct()
63 63
     {
64
-        config(['auth.model' => \plunner\Employee::class]);
65
-        config(['jwt.user' => \plunner\Employee::class]);
64
+        config([ 'auth.model' => \plunner\Employee::class ]);
65
+        config([ 'jwt.user' => \plunner\Employee::class ]);
66 66
     }
67 67
 
68 68
     public function postRegister(Request $request)
69 69
     {
70
-        $this->validate($request, ['company' => 'required|exists:companies,name']);
70
+        $this->validate($request, [ 'company' => 'required|exists:companies,name' ]);
71 71
         $this->company = Company::whereName($request->input('company'))->firstOrFail();
72 72
         return $this->postRegisterOriginal($request);
73 73
     }
@@ -75,17 +75,17 @@  discard block
 block discarded – undo
75 75
     public function postLogin(Request $request)
76 76
     {
77 77
         //get company ID and impiled it in the request
78
-        $this->validate($request, ['company' => 'required|exists:companies,name']);
78
+        $this->validate($request, [ 'company' => 'required|exists:companies,name' ]);
79 79
         $this->company = Company::whereName($request->input('company'))->firstOrFail();
80
-        $request->merge(['company_id' => $this->company->id]);
80
+        $request->merge([ 'company_id' => $this->company->id ]);
81 81
 
82 82
         //remember me
83
-        $this->validate($request, ['remember' => 'required|boolean']);
83
+        $this->validate($request, [ 'remember' => 'required|boolean' ]);
84 84
         if ($request->input('remember', false)) {
85
-            config(['jwt.ttl' => '43200']); //30 days
86
-            $this->custom = array_merge($this->custom, ['remember' => 'true']);
85
+            config([ 'jwt.ttl' => '43200' ]); //30 days
86
+            $this->custom = array_merge($this->custom, [ 'remember' => 'true' ]);
87 87
         } else
88
-            $this->custom = array_merge($this->custom, ['remember' => 'false']);
88
+            $this->custom = array_merge($this->custom, [ 'remember' => 'false' ]);
89 89
 
90 90
         return $this->postLoginOriginal($request);
91 91
     }
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
     {
101 101
         return Validator::make($data, [
102 102
             'name' => 'required|min:1|max:255',
103
-            'email' => 'required|email|max:255|unique:employees,email,NULL,id,company_id,' . $this->company->id,
103
+            'email' => 'required|email|max:255|unique:employees,email,NULL,id,company_id,'.$this->company->id,
104 104
             'password' => 'required|confirmed|min:6',
105 105
         ]);
106 106
     }
@@ -114,9 +114,9 @@  discard block
 block discarded – undo
114 114
     protected function create(array $data)
115 115
     {
116 116
         return $this->company->save(new employee([
117
-            'name' => $data['name'],
118
-            'email' => $data['email'],
119
-            'password' => bcrypt($data['password']),
117
+            'name' => $data[ 'name' ],
118
+            'email' => $data[ 'email' ],
119
+            'password' => bcrypt($data[ 'password' ]),
120 120
         ]));
121 121
     }
122 122
 }
Please login to merge, or discard this patch.
app/Http/Controllers/Employees/Auth/PasswordController.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -36,12 +36,12 @@  discard block
 block discarded – undo
36 36
      * en = employee normal
37 37
      * @var array
38 38
      */
39
-    protected $custom = ['mode' => 'en'];
39
+    protected $custom = [ 'mode' => 'en' ];
40 40
 
41 41
     /**
42 42
      * @var array
43 43
      */
44
-    protected $username = ['email', 'company_id'];
44
+    protected $username = [ 'email', 'company_id' ];
45 45
 
46 46
     /**
47 47
      * @var company
@@ -54,24 +54,24 @@  discard block
 block discarded – undo
54 54
      */
55 55
     public function __construct()
56 56
     {
57
-        config(['auth.model' => \plunner\Employee::class]);
58
-        config(['jwt.user' => \plunner\Employee::class]);
59
-        config(['auth.password.table' => 'password_resets_employees', 'auth.password.email' => 'emails.employees.password']);
57
+        config([ 'auth.model' => \plunner\Employee::class ]);
58
+        config([ 'jwt.user' => \plunner\Employee::class ]);
59
+        config([ 'auth.password.table' => 'password_resets_employees', 'auth.password.email' => 'emails.employees.password' ]);
60 60
     }
61 61
 
62 62
     public function postEmail(Request $request)
63 63
     {
64
-        $this->validate($request, ['company' => 'required|exists:companies,name']);
64
+        $this->validate($request, [ 'company' => 'required|exists:companies,name' ]);
65 65
         $this->company = Company::whereName($request->input('company'))->firstOrFail();
66
-        $request->merge(['company_id' => $this->company->id]);
66
+        $request->merge([ 'company_id' => $this->company->id ]);
67 67
         return $this->postEmailOriginal($request);
68 68
     }
69 69
 
70 70
     public function postReset(Request $request)
71 71
     {
72
-        $this->validate($request, ['company' => 'required|exists:companies,name']);
72
+        $this->validate($request, [ 'company' => 'required|exists:companies,name' ]);
73 73
         $this->company = Company::whereName($request->input('company'))->firstOrFail();
74
-        $request->merge(['company_id' => $this->company->id]);
74
+        $request->merge([ 'company_id' => $this->company->id ]);
75 75
         return $this->postResetOriginal($request);
76 76
     }
77 77
 
Please login to merge, or discard this patch.
app/Http/Controllers/Employees/Calendars/CalendarsController.php 3 patches
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@  discard block
 block discarded – undo
16 16
 {
17 17
     public function __construct()
18 18
     {
19
-        config(['auth.model' => \plunner\Employee::class]);
20
-        config(['jwt.user' => \plunner\Employee::class]);
19
+        config([ 'auth.model' => \plunner\Employee::class ]);
20
+        config([ 'jwt.user' => \plunner\Employee::class ]);
21 21
         $this->middleware('jwt.authandrefresh:mode-en');
22 22
     }
23 23
 
@@ -66,8 +66,8 @@  discard block
 block discarded – undo
66 66
         $employee = \Auth::user();
67 67
         $input = $request->all();
68 68
         $calendar = $employee->calendars()->create($input);
69
-        if (isset($input['password']))
70
-            $input['password'] = \Crypt::encrypt($input['password']);
69
+        if (isset($input[ 'password' ]))
70
+            $input[ 'password' ] = \Crypt::encrypt($input[ 'password' ]);
71 71
         $calendar->caldav()->create($input);
72 72
         //TODO test
73 73
         //TODO validator
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
         $this->validate($request, [
85 85
             'url' => 'required|max:255',
86 86
             'username' => 'required|max:255',
87
-            'password' => ((\Route::current()->getName() == 'employees.calendars.caldav') ? '' : 'sometimes|') . 'required',
87
+            'password' => ((\Route::current()->getName() == 'employees.calendars.caldav') ? '' : 'sometimes|').'required',
88 88
             'calendar_name' => 'required|max:255',
89 89
         ]);
90 90
     }
@@ -120,8 +120,8 @@  discard block
 block discarded – undo
120 120
         if ($caldav) {
121 121
             $this->validateCaldav($request);
122 122
         }
123
-        if (isset($input['password']))
124
-            $input['password'] = \Crypt::encrypt($input['password']);
123
+        if (isset($input[ 'password' ]))
124
+            $input[ 'password' ] = \Crypt::encrypt($input[ 'password' ]);
125 125
         $calendar->update($input);
126 126
         //TODO test
127 127
         //TODO validator
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
             $calendars = $caldavClient->findCalendars();
163 163
             return array_keys($calendars);
164 164
         } catch (\it\thecsea\caldav_client_adapter\CaldavException $e) {
165
-            return Response::json(['error' => $e->getMessage()], 422);
165
+            return Response::json([ 'error' => $e->getMessage() ], 422);
166 166
         }
167 167
     }
168 168
 }
Please login to merge, or discard this patch.
Braces   +9 added lines, -6 removed lines patch added patch discarded remove patch
@@ -66,8 +66,9 @@  discard block
 block discarded – undo
66 66
         $employee = \Auth::user();
67 67
         $input = $request->all();
68 68
         $calendar = $employee->calendars()->create($input);
69
-        if (isset($input['password']))
70
-            $input['password'] = \Crypt::encrypt($input['password']);
69
+        if (isset($input['password'])) {
70
+                    $input['password'] = \Crypt::encrypt($input['password']);
71
+        }
71 72
         $calendar->caldav()->create($input);
72 73
         //TODO test
73 74
         //TODO validator
@@ -120,15 +121,17 @@  discard block
 block discarded – undo
120 121
         if ($caldav) {
121 122
             $this->validateCaldav($request);
122 123
         }
123
-        if (isset($input['password']))
124
-            $input['password'] = \Crypt::encrypt($input['password']);
124
+        if (isset($input['password'])) {
125
+                    $input['password'] = \Crypt::encrypt($input['password']);
126
+        }
125 127
         $calendar->update($input);
126 128
         //TODO test
127 129
         //TODO validator
128 130
         //TODO check if caldav exists?
129 131
 
130
-        if ($caldav)
131
-            $caldav->update($input);
132
+        if ($caldav) {
133
+                    $caldav->update($input);
134
+        }
132 135
         return $calendar;
133 136
     }
134 137
 
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
     }
72 72
 
73 73
     /**
74
-     * @param Request $request
74
+     * @param CalendarRequest $request
75 75
      */
76 76
     private function validateCaldav(Request $request)
77 77
     {
Please login to merge, or discard this patch.
app/Http/Controllers/Employees/Groups/GroupsController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -11,8 +11,8 @@  discard block
 block discarded – undo
11 11
 {
12 12
     public function __construct()
13 13
     {
14
-        config(['auth.model' => \plunner\Employee::class]);
15
-        config(['jwt.user' => \plunner\Employee::class]);
14
+        config([ 'auth.model' => \plunner\Employee::class ]);
15
+        config([ 'jwt.user' => \plunner\Employee::class ]);
16 16
         $this->middleware('jwt.authandrefresh:mode-en');
17 17
     }
18 18
 
@@ -24,9 +24,9 @@  discard block
 block discarded – undo
24 24
     public function index()
25 25
     {
26 26
         $employee = \Auth::user();
27
-        return $employee->groups()->with(['meetings' => function ($query) {
27
+        return $employee->groups()->with([ 'meetings' => function($query) {
28 28
             $query->where('start_time', '=', NULL);
29
-        }])->get();
29
+        } ])->get();
30 30
         //TODO get only current meetings via a query
31 31
     }
32 32
 
Please login to merge, or discard this patch.
app/Http/Kernel.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,6 +30,6 @@
 block discarded – undo
30 30
         'auth' => \plunner\Http\Middleware\Authenticate::class,
31 31
         'auth.basic' => \Illuminate\Auth\Middleware\AuthenticateWithBasicAuth::class,
32 32
         'guest' => \plunner\Http\Middleware\RedirectIfAuthenticated::class,
33
-        'jwt.authandrefresh' => \plunner\Http\Middleware\GetUserAndRefresh::class,//'Tymon\JWTAuth\Middleware\GetUserAndRefresh',
33
+        'jwt.authandrefresh' => \plunner\Http\Middleware\GetUserAndRefresh::class, //'Tymon\JWTAuth\Middleware\GetUserAndRefresh',
34 34
     ];
35 35
 }
Please login to merge, or discard this patch.
app/Http/Requests/Companies/Company/CompanyRequest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
     public function rules()
25 25
     {
26 26
         return [
27
-            'name' => 'sometimes|required|min:1|max:255|unique:companies,name,' . $this->user()->id,
27
+            'name' => 'sometimes|required|min:1|max:255|unique:companies,name,'.$this->user()->id,
28 28
             'password' => 'sometimes|required|confirmed|min:6',
29 29
         ];
30 30
     }
Please login to merge, or discard this patch.
app/Http/Requests/Companies/Employees/EmployeeRequest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,8 +32,8 @@
 block discarded – undo
32 32
     {
33 33
         return [
34 34
             'name' => 'required|min:1|max:255',
35
-            'email' => 'required|email|max:255|unique:employees,email,' . $this->route('employees') . ',id,company_id,' . $this->user()->id,
36
-            'password' => ((\Route::current()->getName() == 'companies.employees.store') ? '' : 'sometimes|') . 'required|confirmed|min:6',
35
+            'email' => 'required|email|max:255|unique:employees,email,'.$this->route('employees').',id,company_id,'.$this->user()->id,
36
+            'password' => ((\Route::current()->getName() == 'companies.employees.store') ? '' : 'sometimes|').'required|confirmed|min:6',
37 37
         ];
38 38
     }
39 39
 }
Please login to merge, or discard this patch.
app/Http/Requests/Companies/Groups/EmployeeRequest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
     public function rules()
32 32
     {
33 33
         return [
34
-            'id' => 'required|array|exists:employees,id,company_id,' . $this->user()->id,
34
+            'id' => 'required|array|exists:employees,id,company_id,'.$this->user()->id,
35 35
         ];
36 36
     }
37 37
 }
Please login to merge, or discard this patch.