MeetingsList::handle() - Code Metrics - dsd-meetme/backend - Measure and Improve Code Quality continuously with Scrutinizer

MeetingsList::handle() A
last analyzed 2016-07-08 20:23 UTC

↳ Parent: MeetingsList

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	9
ccs	0
cts	6
cp	0
rs	9.6666
cc	2
eloc	6
nc	2
nop	0
crap	6

<?php

namespace plunner\Console\Commands;

use Illuminate\Console\Command;
use plunner\Company;

class MeetingsList extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'meetings:list {companyId?}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'List of all meetings of a company that must be taken';

    /**
     * Create a new command instance.
     *
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        //
        $companyId = $this->argument('companyId');
        if (is_numeric($companyId))
            print_r(Company::with(self::withFilter())->findOrFail($companyId)->toArray());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        else
            print_r(Company::with(self::withFilter())->select('id')->get()->toArray());
    }

    private static function withFilter()
    {
        return ['groups' => function ($query) {
            $query->select('id', 'company_id');
        }, 'groups.meetings' => function ($query) {
            $query->select('id', 'group_id', 'start_time');
        }, 'groups.meetings.employees' => function ($query) {
            $query->select('id');
        }];
    }
}


1		<?php
2
3		namespace plunner\Console\Commands;
4
5		use Illuminate\Console\Command;
6		use plunner\Company;
7
8		class MeetingsList extends Command
9		{
10		/**
11		* The name and signature of the console command.
12		*
13		* @var string
14		*/
15		protected $signature = 'meetings:list {companyId?}';
16
17		/**
18		* The console command description.
19		*
20		* @var string
21		*/
22		protected $description = 'List of all meetings of a company that must be taken';
23
24		/**
25		* Create a new command instance.
26		*
27		*/
28	15	public function __construct()
29		{
30	15	parent::__construct();
31	15	}
32
33		/**
34		* Execute the console command.
35		*
36		* @return mixed
37		*/
38		public function handle()
39		{
40		//
41		$companyId = $this->argument('companyId');
42		if (is_numeric($companyId))
43		print_r(Company::with(self::withFilter())->findOrFail($companyId)->toArray());
		0 ignored issues – show Bug introduced 2016-01-10 16:21 UTC by Report Bug Copy Issue Report The method `toArray` does only exist in `Illuminate\Database\Eloq...Database\Eloquent\Model`, but not in `Illuminate\Database\Eloquent\Builder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
44		else
45		print_r(Company::with(self::withFilter())->select('id')->get()->toArray());
46		}
47
48		private static function withFilter()
49		{
50		return ['groups' => function ($query) {
51		$query->select('id', 'company_id');
52		}, 'groups.meetings' => function ($query) {
53		$query->select('id', 'group_id', 'start_time');
54		}, 'groups.meetings.employees' => function ($query) {
55		$query->select('id');
56		}];
57		}
58		}
59

dsd-meetme / backend

MeetingsList::handle() A last analyzed 2016-07-08 20:23 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

MeetingsList::handle() A
last analyzed 2016-07-08 20:23 UTC