Total Lines | 79 |
Code Lines | 39 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
53 | public function orderInWhichTheEventsHaveBeenRaisedIsPreserved() : void |
||
54 | { |
||
55 | $event1 = new class implements DomainEvent { |
||
56 | public function getName() : string |
||
57 | { |
||
58 | return 'first'; |
||
59 | } |
||
60 | }; |
||
61 | $event2 = new class implements DomainEvent { |
||
62 | public function getName() : string |
||
63 | { |
||
64 | return 'second'; |
||
65 | } |
||
66 | }; |
||
67 | $event3 = new class implements DomainEvent { |
||
68 | public function getName() : string |
||
69 | { |
||
70 | return 'third'; |
||
71 | } |
||
72 | }; |
||
73 | |||
74 | $entity1 = new class implements EventAware{ |
||
75 | use OrderedEventRegistry; |
||
76 | |||
77 | public function trigger(DomainEvent $event) : void |
||
78 | { |
||
79 | $this->triggeredA($event); |
||
80 | } |
||
81 | }; |
||
82 | |||
83 | $entity2 = new class implements EventAware { |
||
84 | use OrderedEventRegistry; |
||
85 | |||
86 | public function trigger(DomainEvent $event) : void |
||
87 | { |
||
88 | $this->triggeredA($event); |
||
89 | } |
||
90 | }; |
||
91 | |||
92 | $entity1->trigger($event1); |
||
93 | $entity2->trigger($event2); |
||
94 | $entity1->trigger($event3); |
||
95 | |||
96 | $uow = $this->createMock(UnitOfWork::class); |
||
97 | |||
98 | $uow->expects(self::once()) |
||
99 | ->method('getScheduledEntityInsertions') |
||
100 | ->willReturn([$entity1]); |
||
101 | |||
102 | $uow->expects(self::once()) |
||
103 | ->method('getScheduledEntityUpdates') |
||
104 | ->willReturn([$entity2]); |
||
105 | |||
106 | $uow->expects(self::once()) |
||
107 | ->method('getScheduledEntityDeletions') |
||
108 | ->willReturn([]); |
||
109 | |||
110 | $em = $this->createMock(EntityManagerInterface::class); |
||
111 | |||
112 | $em->expects(self::once())->method('getUnitOfWork')->willReturn($uow); |
||
113 | |||
114 | $eventArgs = $this->createMock(OnFlushEventArgs::class); |
||
115 | $eventArgs->expects(self::once())->method('getEntityManager')->willReturn($em); |
||
116 | |||
117 | $this->eventDispatcher->/** @scrutinizer ignore-call */expects(self::exactly(3)) |
||
118 | ->method('dispatch') |
||
119 | ->withConsecutive( |
||
120 | ['first', new SymfonyEvent($event1)], |
||
121 | ['second', new SymfonyEvent($event2)], |
||
122 | ['third', new SymfonyEvent($event3)] |
||
123 | ); |
||
124 | |||
125 | self::assertEquals(3, Counter::getNext()); |
||
126 | |||
127 | $this->recorder->onFlush($eventArgs); |
||
128 | |||
129 | self::assertEquals(0, Counter::getNext()); |
||
130 | |||
131 | $this->doctrineDispatcher->postFlush(); |
||
132 | } |
||
134 |